libis-workflow 2.1.4 → 2.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 584b8e1d60eca39c3f050334e697a01c9385466ee97e135e2f424f6b80e49b99
-  data.tar.gz: 7c105c4a9685e0c12acf6ddeb6bd876e702b4b6638f50c43c593e3b74f5af492
+  metadata.gz: 27ae10e41a3a147effde1d6c4778236dc1d4e6671684d8e9b08d5b1684e01a7a
+  data.tar.gz: 1e21e8addccd4e08fcb795b9bfb64ff6e64e2489b9c8749ac79c3f65d475a315
 SHA512:
-  metadata.gz: 90995692a972340ef2363ccf4b74c16a8bea56b19ae8ee2ee9e9efa011e4f1b65613070d0c2186946d8f82b61a00ece8ad2a65219fa1e7e129a2bec2ddb3b4ec
-  data.tar.gz: 967aaff3c1178c2913bc8e97a82e2bbd4a94759dcac5812999adda01d3d6b4af9a20bb51c4276490818cb097326a244a773476fc91e6bf97f6f17134c1d41c60
+  metadata.gz: e36b676594edeba060efdc8cdabf325684c93b3c8d669188e6d4c2fe710e9fdf8c6c83c28b4fe3f1710362f799f0d3cf738410fe014f5258af68a739ea343f9d
+  data.tar.gz: 4c15558469b3790923aeacb1bea1da6b08bfc3b6b0c2fa871430c79f5189e05578db4d98ff4c648be3d31d39d8899bfbc6675bd3db2fc7f068a8d4f1b3462022

data/README.md

@@ -258,7 +258,7 @@ perform on each work item:
 
     class MyTask < ::Libis::Workflow::Task
 
-      def process_item(item)
+      def process(item)
         if do_something(item)
           info "Did something"
         else
@@ -274,7 +274,7 @@ perform on each work item:
     end
 ```
 
-As seen above, the task should define a method called process_item that takes one argument. The argument will be a 
+As seen above, the task should define a method called process that takes one argument. The argument will be a 
 reference to the work item that it needs to perform an action on. The task has several option to progress after 
 performing its actions:
 * return. This is considered a normal and successful operation result. After a successful return the item's status will 
@@ -297,7 +297,7 @@ help of workflow input parameters and run options.
 
 #### Performing an action on the work item and all child items recursively
 
-With the 'recursive' parameter set to true, your task's process_item method will be called for the work item and then 
+With the 'recursive' parameter set to true, your task's process method will be called for the work item and then 
 once for each child and each child's children recursively.
 
 Note: you should not make both parent and child tasks recursive as this will cause the subitems to be processed 
@@ -318,7 +318,7 @@ parameter 'retry_interval', which is 30 by default.
 
 ### Pre- and postprocessing
 
-The default implementation of 'process' is to call 'pre_process' and then call 'process_item' on each child item, 
+The default implementation of running a task is to call 'pre_process' and then call 'process' for each child item, 
 followed by calling 'post_process'. The methods 'pre_process' and 'post_process' are no-operation methods by default, 
 but can be overwritten if needed.
 

data/lib/libis/workflow/task.rb

@@ -97,8 +97,8 @@ module Libis
 
       rescue Exception => e
         set_status item, :FAILED
-        fatal_error "Exception occured: #{e.message}", item
-        debug e.backtrace.join("\n")
+        fatal_error "Aborting ingest because of error: %s @ %s\n%s", item, e.message, e.backtrace.first, e.backtrace.map{|t| ' -- ' + t}.join("\n")
+        raise Libis::WorkflowAbort, "#{e.message} @ #{e.backtrace.first}"
 
       ensure
         item.save!
@@ -209,7 +209,7 @@ module Libis
             break if parameter(:abort_recursion_on_failure)
 
           rescue Libis::WorkflowAbort => e
-            fatal_error 'Fatal error processing subitem (%d/%d): %s', item, i + 1, items.size, e.message
+            fatal_error 'Fatal error processing subitem (%d/%d): %s @ %s\n%s', item, i + 1, items.size, e.message, e.backtrace.first, e.backtrace.map{|t| ' -- ' + t}.join("\n")
             item.set_status(namepath, :FAILED)
             break
 
@@ -240,6 +240,16 @@ module Libis
       def substatus_check(status_count, item, task_or_item)
         item_status = :DONE
 
+        if (not_started = status_count[:NOT_STARTED]) > 0
+          error "%d sub#{task_or_item}(s) not started", item, not_started
+          item_status = :FAILED
+        end
+
+        if (started = status_count[:STARTED]) > 0
+          error "%d sub#{task_or_item}(s) started but not done", item, started
+          item_status = :FAILED
+        end
+
         if (waiting = status_count[:ASYNC_WAIT]) > 0
           info "waiting for %d sub#{task_or_item}(s) in async process", item, waiting
           item_status = :ASYNC_WAIT

data/lib/libis/workflow/version.rb

@@ -1,5 +1,5 @@
 module Libis
   module Workflow
-    VERSION = '2.1.4' unless const_defined? :VERSION # the guard is against a redefinition warning that happens on Travis
+    VERSION = '2.1.6' unless const_defined? :VERSION # the guard is against a redefinition warning that happens on Travis
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: libis-workflow
 version: !ruby/object:Gem::Version
-  version: 2.1.4
+  version: 2.1.6
 platform: ruby
 authors:
 - Kris Dekeyser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-24 00:00:00.000000000 Z
+date: 2023-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -163,8 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: LIBIS Workflow framework.