lib-tl1-huawei 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e35fe42f5b11d5bdb4bf4e96b1b6255937e3e30c8a6d8aad054f4bd3d5af648
-  data.tar.gz: 8375e47ed4d6090ecf2f98c912ce88e87cf865ed8a0ad93face865aa9086c168
+  metadata.gz: fa419db9b636262d5c1508225bfc2964dba1048640badd89617cfaf1d391cf83
+  data.tar.gz: 59b962716fe07cdbac297b0445270735dbe4e4a26d18fe2fb707338b97cc53da
 SHA512:
-  metadata.gz: 0646ece3ee2007d1e21066543782a0c4ddf826b80df76e6d4ee297a00e3692d02fc09045dfcaee582ab0a8f0f319e2cd6498d78d820576fefefb04901395f40c
-  data.tar.gz: f8c668c1706b9cda0f3320d447ea19ea411ab58d3d37e3d389de851d019f2b1b4a52e399a3d18ae2a58eb4f0632814c6fbc3a7d30305ab8c623a16b5f0bc8bc9
+  metadata.gz: 8db89037f1ef25ad794a573dfac262d6141869102d2ac419029ae1016328d059f502df49ea478bb0cce56e5683f80b69aa0b1878e259deea3da6f9b23e78c504
+  data.tar.gz: '09972d8cb1b8b53aaf874e25e32d69aef2c63ff30d211e0de715e16f04692eddf8b969038cb156fc18389ccdfefc4c24ffa89af51587f09343244ef4ed49fff6'

data/.rubocop.yml

@@ -0,0 +1,30 @@
+AllCops:
+  TargetRubyVersion: 3.4
+  NewCops: enable
+  SuggestExtensions: false
+  Exclude:
+    - 'tmp/**/*'
+    - 'vendor/**/*'
+
+# Named TL1 fields are part of the public command API; positional arguments keep
+# the default limit.
+Metrics/ParameterLists:
+  CountKeywordArgs: false
+
+# Protocol field maps and expected response data are declarative collections.
+Metrics/MethodLength:
+  CountAsOne: ['array', 'hash', 'heredoc']
+
+# Example groups collect independent tests; individual examples remain checked.
+Metrics/BlockLength:
+  AllowedMethods: ['describe']
+
+# GB (general block) and CC (completion code) are public lib-tl1 keywords.
+Naming/MethodParameterName:
+  AllowedNames: ['cc', 'gb']
+
+# Response is a public OpenStruct subclass with dynamic, mutable TL1 columns.
+# Replacing it with a fixed Struct or Hash would change the record API.
+Style/OpenStructUse:
+  Exclude:
+    - 'lib/lib/tl1/huawei/message/response.rb'

data/.ruby-version

@@ -1 +1 @@
-ruby-3.0.2
+3.4

data/Gemfile

@@ -8,5 +8,4 @@ gemspec
 gem 'rake', '~> 13.0'
 
 gem 'rspec', '~> 3.0'
-gem 'rubocop', group: 'development'
-
+gem 'rubocop', '~> 1.91.0', group: 'development'

data/README.md

@@ -1,47 +1,214 @@
-# Lib::Tl1::Huawei
+# Lib::TL1::Huawei
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/lib/tl1/huawei`. To experiment with that code, run `bin/console` for an interactive prompt.
+A Ruby library for building commands and parsing TL1 NBI responses from Huawei iManager U2000.
+It extends `lib-tl1`, using its fields and TL1 frame parser to read Huawei metadata
+and tables. It provides a subset of queries for devices, GPON/ONT, GEM, profiles,
+optical parameters, statistics, IP/WAN, VLAN and VoIP, as well as session commands.
 
-TODO: Delete this and the text above, and describe your gem
+The library does not establish TCP/TLS connections, send commands, maintain sessions
+or assemble multipart responses. These are the responsibility of the application using the gem.
 
 ## Installation
 
-Add this line to your application's Gemfile:
+Ruby `>= 3.4.0` is required. Older Ruby versions are no longer supported.
+Add the following to your application's `Gemfile`:
 
-```ruby
+```gemfile
 gem 'lib-tl1-huawei'
 ```
 
-And then execute:
+Then run `bundle install`. The gem depends on `lib-tl1 ~> 0.1.2`
+and `ostruct >= 0.1.0, < 1.0`; Bundler installs them automatically.
+The entry point is `require 'lib/tl1/huawei'`, and the namespace is `Lib::TL1::Huawei`.
 
-    $ bundle install
+## Building a command
 
-Or install it yourself as:
+This example builds an `LST-ONTDETAIL` command to query details for ONT 3 on
+port 2, slot 8, frame 0 of device 1. `CTAG` is a request identifier that lets the
+application match a response to its command. Set it with `message.ctag` before
+calling `to_s` to produce the TL1 command string.
 
-    $ gem install lib-tl1-huawei
+```ruby
+require 'lib/tl1/huawei'
+
+message = Lib::TL1::Huawei::Message::LstOntDetail.new(
+  did: 1, frame_number: 0, slot_number: 8, port_number: 2, ont_id: 3
+)
+message.ctag = 101
+puts message.to_s
+# LST-ONTDETAIL::DID=1,FN=0,SN=8,PN=2,ONTID=3:101::;
+```
 
-## Usage
+`DID` is the device identifier in U2000. `DEV` means the device name by default,
+but the `DevMean`/`DEVMEAN` setting can change its meaning to the IP address.
+Choose `did:` or `dev:` according to the NBI configuration and the command's requirements.
+The library does not read this configuration or validate the address against a device.
+
+| Ruby argument | TL1 field | Meaning |
+| --- | --- | --- |
+| `frame_number:` | `FN` | OLT frame/shelf number |
+| `slot_number:` | `SN` | Slot number |
+| `port_number:` | `PN` | Port number |
+| `ont_id:` | `ONTID` | ONT identifier on the port |
+| `ont_name:` | `NAME` | ONT name, together with `DID` or `DEV` |
+| `ont_alias:` | `ALIAS` | Alternative ONT addressing by alias |
+
+For `LstOntDetail`, choose the ONT coordinates, a name with a device, or an alias alone;
+do not combine all addressing variants. Available arguments depend on the constructor.
+For example, `LstOnt` uses `onu_name:` for `NAME` and supports `ont_sn:` (`ONTSN`)
+and `ont_pwd:` (`PWD`); `LstOntDbaProf` also maps `ont_pwd:` to `PWD`.
+`LstGponAutoFind` sends `LST-GPONONTAUTOFIND` and accepts a serial number or an OLT location.
+`LstGponNniPort` is a separate query for NNI ports with optional `SHOWOPTION`.
+For example, `LstGponNniPort` supports `show_option: [:PSTAT]`;
+the allowed `SHOWOPTION` fields differ between commands.
+
+## Reading responses and errors
+
+Run the following examples from the repository directory, for example with `bundle exec ruby`.
+The files in `spec/fixtures/huawei` are synthetic: they contain no subscriber data and
+are not device session recordings. Fixtures and tests are not packaged in the installed gem.
 
-TODO: Write usage instructions here
+```ruby
+require 'lib/tl1/huawei'
+
+raw = File.binread('spec/fixtures/huawei/one_record.tl1')
+output = Lib::TL1::Huawei::Message::Output.parse(raw, encoding: 'UTF-8')
+puts output.ont_id             # 1
+puts output.first.name         # Office west
+puts output.first.rx_power     # --
+puts output.to_h[:blktotal]     # 1
+```
 
-## Development
+`Output.parse` accepts one complete response. `response` is an array of
+`Response` records based on `OpenStruct`; `first`, `each`, `map`, `[]` and `size` provide
+collection operations. Column names are converted to lowercase, and records also support
+snake_case names: `ontid` and `ont_id` read the same field.
+Record getters are delegated directly from `Output` only when
+`blktotal == 1` and `response.size == 1`. Use the collection for empty results or results
+with multiple records; `respond_to?` follows the same delegation rule.
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+`blktag` is the packet number, `blkcount` is the number of records in that packet, and
+`blktotal` is the total number of records, not packets. `to_h` returns the header,
+`en`, `endesc`, counters, title and an array of hashes in `:response`. Field values remain
+strings without unit conversion; `--` remains `--`, and an empty table cell remains an empty string.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+```ruby
+require 'lib/tl1/huawei'
+
+begin
+  raw = File.binread('spec/fixtures/huawei/error.tl1')
+  Lib::TL1::Huawei::Message::Output.parse(raw, encoding: 'UTF-8')
+rescue Lib::TL1::Huawei::StandardError => error
+  puts "#{error.error_number}: #{error.message}"
+  # 123: Example device error.
+end
+```
+
+A nonzero `EN` identifies a Huawei error; `ENDESC` supplies its description.
+Do not compare the description with a literal success message. Frame syntax errors can also
+come from the `lib-tl1` parser and may raise exceptions other than `Lib::TL1::Huawei::StandardError`.
 
-## Contributing
+## Encoding and API compatibility
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/lib-tl1-huawei. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/[USERNAME]/lib-tl1-huawei/blob/master/CODE_OF_CONDUCT.md).
+The default `encoding: nil` preserves the bytes and encoding of the input `String`.
+For `File.binread`, this means `ASCII-8BIT`, without guessing the server's encoding.
+An explicit `encoding: 'UTF-8'`, `'GBK'` or `'ISO-8859-1'` interprets a copy of the input
+bytes in the specified encoding and decodes it to UTF-8. Match it to the U2000 `CharSet`
+configuration. Invalid data raises an exception; the parser does not replace characters.
+Repeated reads and `to_h` do not change the source data or the encoding of record values.
+`to_h` no longer forces conversion from ISO-8859-1.
 
-## License
+`reverse` returns a reversed copy of the collection without changing its order.
+The broken delegator with the misspelled name `revers` has been removed; replace calls to it
+with `reverse`. `LstDev#dev_type` reflects the constructor argument, and `show_option`
+and the retained alias `showoption` return the same list of options.
 
-The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
+`LstOntEthVlanSwitchPair` sends `LST-ONTETHVLANSWTICHPAIR`, with the intentional
+spelling `SWTICHPAIR`. It replaces the previously sent
+`LST-ONTETHVLANSWITCHPAIR`. The `ont_port_type:` argument is serialized in uppercase
+(the default `:eth` produces `ETH`); `nil` omits the field, and the getter preserves the supplied argument.
 
-## Code of Conduct
+Tests use synthetic fixtures and do not establish compatibility with a live U2000 system.
+The library implements a subset of U2000 commands and addressing variants; the class list is in
+the [message loader](lib/lib/tl1/huawei/message.rb), and the maintained signatures are in
+the [RBS signatures](sig/lib/tl1/), whose file layout mirrors `lib/lib/tl1/`.
 
-Everyone interacting in the Lib::Tl1::Huawei project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/lib-tl1-huawei/blob/master/CODE_OF_CONDUCT.md).
+## Development
+
+Select a supported Ruby environment with RVM; `.ruby-version` specifies `3.4`,
+and `.ruby-gemset` specifies `lib-tl1-huawei`. Use this gemset name when selecting another
+supported Ruby version as well, for example `rvm use 4.0.2@lib-tl1-huawei --create`.
+Install dependencies, including the `development` group, in the selected gemset and
+run the local checks:
 
-## NBI U2000 Port
-9819
+```sh
+bundle check
+bundle install
+bundle exec rake
+```
 
+`bundle install` is only needed when `bundle check` reports missing dependencies.
+The default Rake task runs RuboCop followed by RSpec. Use `bundle exec rake rubocop`
+for lint only or `bundle exec rake spec` for tests only.
+RuboCop settings live in `.rubocop.yml`, without an offense baseline.
+The configuration preserves named TL1 parameters and the `gb`/`cc` protocol keywords,
+counts multiline data literals as one expression for method length, and excludes
+declarative RSpec `describe` groups from block length checks. Individual examples
+and helpers retain the default limits. `Response` alone is exempt from
+`Style/OpenStructUse` to preserve its public dynamic, mutable record API; all
+other checks still apply to it. Fix new offenses in code instead of generating
+exclusions; any rule adjustment needs an explicit design or compatibility reason.
+The tests do not connect to U2000; they also execute the Ruby examples in this README.
+CI runs RuboCop on Ruby 3.4 and tests on Ruby 3.4 and 4.0 for pull requests,
+pushes to `master` and `v*` tags. Both checks must pass before release tag preparation.
+
+## Publishing
+
+When a push to `master` changes `Lib::TL1::Huawei::VERSION` in
+`lib/lib/tl1/huawei/version.rb`, the workflow runs the tests and creates a matching
+`v<VERSION>` tag (for example, `v0.1.9`). It compares the versions before and after
+the entire push, including pushes containing multiple commits. Unchanged versions,
+initial branch creation and existing tags do not trigger an automatic release.
+Existing tags are never moved.
+
+Only a newly created tag enables the build and publication using
+[RubyGems Trusted Publishing](https://guides.rubygems.org/trusted-publishing/).
+Tags created by the workflow use `GITHUB_TOKEN`, which
+[does not trigger another push workflow](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow).
+The dependent publishing job therefore runs in the same workflow after tag creation,
+without a personal access token. A new `v*` tag pushed manually also runs the tests
+and publishes, provided its name matches the version at the tagged commit.
+Deleting or updating an existing tag does not publish a gem.
+
+The workflow exchanges a GitHub Actions OIDC token for short-lived RubyGems credentials
+through the official
+[`configure-rubygems-credentials` action](https://github.com/rubygems/configure-rubygems-credentials).
+Only the publishing job has `id-token: write`; it uses the `release` environment.
+The tag preparation job has `contents: write`; repository rules must allow
+`GITHUB_TOKEN` to create `v*` tags.
+
+Before the first publication through this workflow, create the GitHub environment `release`
+and register a trusted publisher for `lib-tl1-huawei` on RubyGems.org with these values:
+
+| Setting | Value |
+| --- | --- |
+| Repository owner | `pwojcieszonek` |
+| Repository name | `lib-tl1-huawei` |
+| Workflow filename | `main.yml` |
+| Environment | `release` |
+
+The workflow filename is the basename of `.github/workflows/main.yml`.
+The RubyGems and GitHub environment names must match. No `RUBYGEMS_AUTH_TOKEN` secret
+is required by this workflow.
+If the `release` environment restricts deployment branches or tags, allow both
+`master` (automatic tags) and `v*` tags (manual tag pushes). Required environment
+reviewers, if configured, still need to approve publication.
+
+Set a new, unpublished version in `lib/lib/tl1/huawei/version.rb` before pushing a release
+to `master`; RubyGems rejects attempts to publish an existing version again.
+If publication fails after automatic tag creation, use GitHub Actions' **Re-run failed jobs**
+to retry publication with the existing tag output. Re-running all jobs finds the
+existing tag and skips the automatic release.
+Local tests and `gem build lib-tl1-huawei.gemspec` do not publish the gem.
+
+This project is available under the [MIT license](LICENSE.txt).

data/Rakefile

@@ -1,8 +1,13 @@
 # frozen_string_literal: true
 
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task default: :spec
+desc 'Run RuboCop'
+task :rubocop do
+  ruby '-S', 'rubocop'
+end
+
+task default: %i[rubocop spec]

data/lib/lib/tl1/huawei/message/exception.rb

@@ -1,15 +1,16 @@
+# frozen_string_literal: true
+
 module Lib
   module TL1
     module Huawei
-      class StandardError < StandardError
-
+      # Reports the Huawei EN error number alongside its ENDESC description.
+      class StandardError < ::StandardError
         attr_reader :error_number
 
-        def initialize(msg = nil, en=nil)
-          super(msg)
-          @error_number = en
+        def initialize(message = nil, error_number = nil)
+          super(message)
+          @error_number = error_number
         end
-
       end
     end
   end

data/lib/lib/tl1/huawei/message/input.rb

@@ -6,8 +6,8 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Serializes Huawei command parameters on top of the TL1 frame builder.
         class Input < Lib::TL1::Message::Input
-
           def initialize(command: nil, tid: nil, aid: nil, ctag: nil, gb: nil, payload: nil)
             command = self.class.name.split('::').last.sub(/(.)([A-Z])/, '\1-\2').upcase if command.nil?
             super
@@ -15,14 +15,17 @@ module Lib
 
           private
 
+          def set_attributes(**attributes)
+            attributes.each { |name, value| instance_variable_set("@#{name}", value) }
+          end
+
           def __show_option(*show_option)
             show_option.empty? ? nil : show_option.map { |option| option.to_s.delete('_') }.join(' ')
           end
 
           def hash_to_string(**hash)
-            hash.reject { |k, v| v.nil? }.map { |k, v| "#{k.to_s.delete('_').upcase}=#{v.to_s}" }.join(',')
+            hash.compact.map { |key, value| "#{key.to_s.delete('_').upcase}=#{value}" }.join(',')
           end
-
         end
       end
     end

data/lib/lib/tl1/huawei/message/login.rb

@@ -1,9 +1,12 @@
-require_relative "input"
+# frozen_string_literal: true
+
+require_relative 'input'
 
 module Lib
   module TL1
     module Huawei
       module Message
+        # Builds a LOGIN command from the NBI username and password.
         class Login < Lib::TL1::Huawei::Message::Input
           attr_reader :password, :username
 
@@ -12,9 +15,8 @@ module Lib
             @password = password
             super(payload: "UN=#{username},PWD=#{password}")
           end
-
         end
       end
     end
   end
-end
+end

data/lib/lib/tl1/huawei/message/logout.rb

@@ -6,9 +6,10 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Builds a LOGOUT command to end an NBI session.
         class Logout < Lib::TL1::Huawei::Message::Input
           def initialize
-            super
+            super(command: 'LOGOUT')
           end
         end
       end

data/lib/lib/tl1/huawei/message/lst_bms_version.rb

@@ -6,8 +6,8 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries the NBI management system version.
         class LstBmsVersion < Lib::TL1::Huawei::Message::Input
-
         end
       end
     end

data/lib/lib/tl1/huawei/message/lst_board.rb

@@ -6,8 +6,8 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries boards by device, frame, slot, and board type.
         class LstBoard < Lib::TL1::Huawei::Message::Input
-
           attr_reader :dev, :did, :onu_locate_info, :frame_number, :slot_number, :board_type, :show_option
 
           def initialize(
@@ -19,13 +19,9 @@ module Lib
             board_type: nil,
             show_option: nil
           )
-            @dev = dev
-            @did = did
-            @frame_number = frame_number
-            @onu_locate_info = onu_locate_info
-            @slot_number = slot_number
-            @board_type = board_type
-            @show_option = show_option
+            set_attributes(
+              dev:, did:, frame_number:, onu_locate_info:, slot_number:, board_type:, show_option:
+            )
 
             super(
               aid: hash_to_string(
@@ -39,10 +35,8 @@ module Lib
               payload: __show_option(*show_option)
             )
           end
-
         end
       end
     end
   end
 end
-

data/lib/lib/tl1/huawei/message/lst_dev.rb

@@ -6,9 +6,11 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries devices and optionally selects returned device attributes.
         class LstDev < Lib::TL1::Huawei::Message::Input
+          attr_reader :did, :dev, :dev_ip, :dev_type, :dev_ver, :onu_locate_info, :show_option, :user_id
 
-          attr_reader :did, :dev, :dev_ip, :dev_type, :dev_ver, :onu_locate_info, :showoption, :user_id
+          alias showoption show_option
 
           def initialize(
             did: nil,
@@ -20,15 +22,9 @@ module Lib
             show_option: [],
             user_id: nil
           )
-
-            @did = did
-            @dev = dev
-            @dev_ip = dev_ip
-            @dt = dev_type
-            @dev_ver = dev_ver
-            @onu_locate_info = onu_locate_info
-            @show_option = show_option
-            @user_id = user_id
+            set_attributes(
+              did:, dev:, dev_ip:, dev_type:, dev_ver:, onu_locate_info:, show_option:, user_id:
+            )
 
             super(
               aid: hash_to_string(
@@ -44,10 +40,9 @@ module Lib
                 user_id: user_id
               )
             )
-
           end
         end
       end
     end
   end
-end
+end

data/lib/lib/tl1/huawei/message/lst_emf_sys_info.rb

@@ -1,12 +1,15 @@
-require_relative "input"
+# frozen_string_literal: true
+
+require_relative 'input'
 
 module Lib
   module TL1
     module Huawei
       module Message
+        # Queries management system information.
         class LstEmfSysInfo < Lib::TL1::Huawei::Message::Input
           def initialize
-            super
+            super(command: 'LST-EMFSYSINFO')
           end
         end
       end

data/lib/lib/tl1/huawei/message/lst_frame.rb

@@ -6,24 +6,21 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries frames belonging to a device.
         class LstFrame < Lib::TL1::Huawei::Message::Input
-
           attr_reader :dev, :did, :frame_number, :show_option
 
           def initialize(dev: nil, did: nil, frame_number: nil, show_option: nil)
-            @dev = dev
-            @did = did
-            @frame_number = frame_number
-            @show_option = show_option
+            set_attributes(
+              dev:, did:, frame_number:, show_option:
+            )
             super(
               aid: hash_to_string(dev: dev, did: did, fn: frame_number),
               payload: __show_option(*show_option)
             )
           end
-
         end
       end
     end
   end
 end
-

data/lib/lib/tl1/huawei/message/lst_gem_connection.rb

@@ -5,22 +5,19 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries GEM connections by ONT, GEM port, and VLAN.
         class LstGemConnection < Lib::TL1::Huawei::Message::Input
-          attr_reader :did, :dev, :frame_number, :slot_number, :port_number, :ont_id, :gem_port_id, :vlan_id, :show_option
+          attr_reader :did, :dev, :frame_number, :slot_number, :port_number, :ont_id, :gem_port_id, :vlan_id,
+                      :show_option
 
           def initialize(
             did: nil, dev: nil, frame_number: nil, slot_number: nil, port_number: nil,
             ont_id: nil, gem_port_id: nil, vlan_id: nil, show_option: []
           )
-            @did = did
-            @dev = dev
-            @frame_number = frame_number
-            @slot_number = slot_number
-            @port_number = port_number
-            @ont_id = ont_id
-            @gem_port_id = gem_port_id
-            @vlan_id = vlan_id
-            @show_option = show_option
+            set_attributes(
+              did:, dev:, frame_number:, slot_number:, port_number:, ont_id:, gem_port_id:, vlan_id:,
+              show_option:
+            )
             super(
               aid: hash_to_string(
                 did: did, dev: dev, fn: frame_number, sn: slot_number, pn: port_number,

data/lib/lib/tl1/huawei/message/lst_gem_port.rb

@@ -5,6 +5,7 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries GEM ports belonging to an ONT.
         class LstGemPort < Lib::TL1::Huawei::Message::Input
           attr_reader :did, :dev, :frame_number, :slot_number, :port_number, :ont_id, :gem_port_id, :show_option
 
@@ -12,14 +13,9 @@ module Lib
             did: nil, dev: nil, frame_number: nil, slot_number: nil, port_number: nil,
             ont_id: nil, gem_port_id: nil, show_option: []
           )
-            @did = did
-            @dev = dev
-            @frame_number = frame_number
-            @slot_number = slot_number
-            @port_number = port_number
-            @ont_id = ont_id
-            @gem_port_id = gem_port_id
-            @show_option = show_option
+            set_attributes(
+              did:, dev:, frame_number:, slot_number:, port_number:, ont_id:, gem_port_id:, show_option:
+            )
             super(
               aid: hash_to_string(
                 did: did, dev: dev, fn: frame_number, sn: slot_number,

data/lib/lib/tl1/huawei/message/lst_gpon_auto_find.rb

@@ -6,18 +6,16 @@ module Lib
   module TL1
     module Huawei
       module Message
-        class LstGponNniPort < Lib::TL1::Huawei::Message::Input
-
+        # Queries automatically discovered ONTs by serial number or GPON port.
+        class LstGponAutoFind < Lib::TL1::Huawei::Message::Input
           attr_reader :did, :dev, :frame_number, :slot_number, :port_number, :ont_sn
 
           def initialize(did: nil, dev: nil, frame_number: nil, slot_number: nil, port_number: nil, ont_sn: nil)
-            @did = did
-            @dev = dev
-            @frame_number = frame_number
-            @slot_number = slot_number
-            @port_number = port_number
-            @ont_sn = ont_sn
+            set_attributes(
+              did:, dev:, frame_number:, slot_number:, port_number:, ont_sn:
+            )
             super(
+              command: 'LST-GPONONTAUTOFIND',
               aid: hash_to_string(
                 did: did, dev: dev, fn: frame_number, sn: slot_number, pn: port_number, ont_sn: ont_sn
               )

data/lib/lib/tl1/huawei/message/lst_gpon_ddm_info.rb

@@ -6,15 +6,14 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries digital diagnostic monitoring values for a GPON port.
         class LstGponDdmInfo < Lib::TL1::Huawei::Message::Input
           attr_reader :did, :dev, :frame_number, :slot_number, :port_number
 
           def initialize(did: nil, dev: nil, frame_number: nil, slot_number: nil, port_number: nil)
-            @did = did
-            @dev = dev
-            @frame_number = frame_number
-            @slot_number = slot_number
-            @port_number = port_number
+            set_attributes(
+              did:, dev:, frame_number:, slot_number:, port_number:
+            )
             super(
               aid: hash_to_string(
                 did: did, dev: dev, fn: frame_number, sn: slot_number, pn: port_number

data/lib/lib/tl1/huawei/message/lst_gpon_line_profile.rb

@@ -6,6 +6,7 @@ module Lib
   module TL1
     module Huawei
       module Message
+        # Queries GPON line profiles, with device and profile selectors in the payload.
         class LstGponLineProfile < Lib::TL1::Huawei::Message::Input
           attr_reader :did, :dev, :prof_id