liaison 0.0.2 → 0.0.3

data/ChangeLog

@@ -1,4 +1,26 @@
-2011-09-20   Mike Burns   <mburns@thoughtbot.com>
+2011-10-20  Mike Burns  <mburns@thoughtbot.com>
+
+	* presenter.rb, presenter_spec.rc: Don't name the struct so that we can
+	avoid redefining a constant.
+
+2011-09-21  Mike Burns  <mburns@thoughtbot.com>
+
+	* ChangeLog, NEWS: Retroactively update the docs based on git history.
+	* README.md:
+	Link to the raw NEWS, ChangeLog, and Ruby docs at the top of the docs.
+	Mention the raw license in the contact section.
+	Demand that pull requests update the ChangeLog and NEWS.
+	Mention the GNU ChangeLog format.
+
+2011-09-21  Matt Gillooly  <matt@mattgillooly.com>
+
+	* README.md: Fix the 'tutorial' misspelling.
+
+2011-09-21  Dan Croak  <dcroak@thoughtbot.com>
+
+	* README.md: The validator class is passed, not an instance.
+
+2011-09-20  Mike Burns  <mburns@thoughtbot.com>
 
 	* presenter.rb, presenter_spec.rb:
 	Include the Enumerable module to the Presenter class, with a test.
@@ -7,3 +29,17 @@
 	Add an overview NEWS file and a more detailed ChangeLog file.
 
 	* version.rb: Bump version to 0.0.2.
+
+2011-09-10  Mike Burns  <mburns@thoughtbot.com>
+
+	* presenter.rb (model_name):
+	Use a struct as the model namer for ActiveModel::Name.
+
+	* README.md: Add a quick start guide.
+
+	* presenter.rb (model_name, persisted?):
+	Explain why these exist but are undocumented.
+	(with_params, each):
+	Be more explicit in the documentation about how to use these and what the
+	classes are.
+	(instance_validations): Make this protected.

data/NEWS

@@ -1,4 +1,11 @@
+New in 0.0.3:
+
+* Take care of a warning based on using a struct for the model_name.
+
 New in 0.0.2:
 
+* The #instance_validations method, part of the plumbing to make the
+  validations work transparently with Rails, is protected. This would be of no
+  use to you anyway, ideally.
 * The Presenter class now includes the Enumerable class. This means you can
   use #map, #reject, #sort, and so on, on the Presenter data object.

data/README.md

@@ -3,6 +3,8 @@ Liaison
 
 A Rails presenter class.
 
+Experienced devs will be interested in the [NEWS](https://raw.github.com/mike-burns/liaison/master/NEWS), [ChangeLog](https://raw.github.com/mike-burns/liaison/master/ChangeLog), and [reference documentation](http://rubydoc.info/gems/liaison/0.0.2/frames).
+
 How to Use Liaison
 ------------------
 
@@ -22,7 +24,7 @@ The business logic classes (`SignUp` in the below example) live under `app/model
 
 Validator classes (`SignUpValidator` in the below example) live under `lib` and must either descend from `ActiveModel::Validator` or implement the same interface (`.kind`, `#kind`, `#validate` that takes a record, and a constructor that takes a hash of options). They are also unit tested like normal and can likely get away with just requiring `rspec` instead of `spec_helper`. Sadly, in order to hook into the `ActiveModel::Validations` framework, you must pass the validator class itself instead of an object (`SignUpValidator` vs `SignUpValidator.new`).
 
-Turorial and Thought Process
+Tutorial and Thought Process
 ----------------------------
 
 A major idea of [the presenter pattern](http://blog.jayfields.com/2007/03/rails-presenter-pattern.html) is to break off the business logic from the view object, letting the view logic be a dumb instance that knows how to get, set, and validate values. The business logic can then query the presenter object for the values as needed.
@@ -82,7 +84,7 @@ Now you need to know how to use a `Presenter` object, so this is what the contro
       def presenter
         Presenter.new('sign_up',
                       :fields => [:email, :password, :account_name],
-                      :validator => SignUpValidator.new)
+                      :validator => SignUpValidator)
       end
     end
 
@@ -128,6 +130,6 @@ When writing your unit tests it'll be handy to have a mock presenter around, whi
 Contact
 -------
 
-Copyright 2011 [Mike Burns](http://mike-burns.com/).
+Copyright 2011 [Mike Burns](http://mike-burns.com/). Distributed under [the three-clause BSD license](https://raw.github.com/mike-burns/liaison/master/LICENSE).
 
-Please [open a pull request on Github](https://github.com/mike-burns/liaison/pulls) as needed.
+Please [open a pull request on Github](https://github.com/mike-burns/liaison/pulls) as needed. Be sure to update the ChangeLog and, if needed, the NEWS. We follow [the GNU ChangeLog format](http://www.gnu.org/prep/standards/html_node/Change-Logs.html).

data/lib/liaison/presenter.rb

@@ -27,7 +27,7 @@ class Presenter
 
   # This only exists for ActiveModel::Naming
   def self.model_name # :nodoc:
-    model_namer = Struct.new("ModelNamer", :name).new(@@model_name)
+    model_namer = Struct.new(:name).new(@@model_name)
     ActiveModel::Name.new(model_namer)
   end
 

data/lib/liaison/version.rb

@@ -1,3 +1,3 @@
 module Liaison
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/presenter_spec.rb

@@ -15,6 +15,11 @@ describe Presenter do
     subject.to_key.should be_nil
     subject.to_param.should be_nil
   end
+
+  it "does not mind having a bunch of them" do
+    Presenter.new("another_model_name").class.model_name
+    # The result is that this should have no warning in the test output
+  end
 end
 
 describe Presenter, 'validations' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: liaison
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - Mike Burns
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-20 00:00:00 Z
+date: 2011-10-20 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activemodel