lhs 7.2.3 → 7.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 472c0308bceb0d57beb2999ddf90b98881ee9b2c
-  data.tar.gz: 3b100b77107bafa8eec978370e98ece0b0103dc5
+  metadata.gz: b2d99ceddb2ae5693268943054615f83012e7915
+  data.tar.gz: 237d0864cfd642b7ea652646c9694e11db6df6bc
 SHA512:
-  metadata.gz: 00d83acc6b319b7e5d7b32a27eb58674f135f7afba5e9cdfde405b3e7b4f5555456583b3bae6f5cf7bc7e7cf25c27407f0e9c919a46e31984946ed2db84c60c7
-  data.tar.gz: c54dcd9cb6a0dbc785166b6ab3185a985767142232ff20e0cb5459ff56eb2aab3394729445d93a6b453d2f0430c1d040bf150e7fd6e95f62b867180f76c8a8c4
+  metadata.gz: 90e6b45e7b29f894773ff861bcd5ceae5cb28d4d223e099b360da9e729e6ef27746abb5f8c97d9ed679378f2ae58a97a6a953c14082f6addb00c82f2981831c4
+  data.tar.gz: 6f1404569a787ef49efbc533a2e61a43eef55315387d9d32c6351d844fdde9f90a3f6556fed649558129db06dc292908dabc03a45eaa002bb2d3dd0f81806a96

data/lib/lhs/concerns/item/save.rb

@@ -15,30 +15,35 @@ class LHS::Item < LHS::Proxy
     def save!(options = {})
       options = options.present? ? options.dup : {}
       data = _data._raw.dup
-      if href.present?
-        url = href
-      else
-        endpoint = endpoint_for_persistance(data, options)
-        url = url_for_persistance(endpoint, data, options)
-        endpoint.remove_interpolated_params!(data)
-        endpoint.remove_interpolated_params!(options.fetch(:params, {}))
-        options.merge!(endpoint.options.merge(options)) if endpoint.options
-      end
+      url = url_for_persistance!(options, data)
+      create_and_merge_data!(
+        apply_default_creation_options(options, url, data)
+      )
+    rescue LHC::Error => e
+      self.errors = LHS::Errors.new(e.response)
+      raise e
+    end
+
+    private
 
+    def apply_default_creation_options(options, url, data)
       options = options.merge(method: :post, url: url, body: data.to_json)
       options[:headers] ||= {}
       options[:headers].merge!('Content-Type' => 'application/json')
+      options
+    end
 
-      data = record_for_persistance.request(options)
-      _data.merge_raw!(data)
+    def create_and_merge_data!(options)
+      direct_response_data = record_for_persistance.request(options)
+      _data.merge_raw!(direct_response_data)
+      response_headers = direct_response_data._request.response.headers
+      if response_headers && response_headers['Location']
+        location_data = record_for_persistance.request(options.merge(url: response_headers['Location'], method: :get, body: nil))
+        _data.merge_raw!(location_data)
+      end
       true
-    rescue LHC::Error => e
-      self.errors = LHS::Errors.new(e.response)
-      raise e
     end
 
-    private
-
     def endpoint_for_persistance(data, options)
       record_for_persistance
         .find_endpoint(merge_data_with_options(data, options))
@@ -56,10 +61,16 @@ class LHS::Item < LHS::Proxy
       _data.class
     end
 
-    def url_for_persistance(endpoint, data, options)
+    def url_for_persistance!(options, data)
+      return href if href.present?
+      endpoint = endpoint_for_persistance(data, options)
       endpoint.compile(
         merge_data_with_options(data, options)
-      )
+      ).tap do
+        endpoint.remove_interpolated_params!(data)
+        endpoint.remove_interpolated_params!(options.fetch(:params, {}))
+        options.merge!(endpoint.options.merge(options)) if endpoint.options
+      end
     end
   end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "7.2.3"
+  VERSION = "7.2.4"
 end

data/spec/record/create_spec.rb

@@ -131,5 +131,28 @@ describe LHS::Record do
         end
       end
     end
+
+    context 'location header' do
+      before(:each) do
+        class ContactPerson < LHS::Record
+          endpoint 'http://datastore/contact_persons'
+        end
+      end
+
+      let(:location)   { 'http://datastore/contact_persons/1' }
+      let(:created_at) { '2017-12-21' }
+      let(:name)       { 'Sebastian' }
+
+      it 'Loads the data from the "Location" header after creation' do
+        stub_request(:post, "http://datastore/contact_persons")
+          .to_return(status: 204, headers: { Location: location })
+        stub_request(:get, "http://datastore/contact_persons/1")
+          .to_return(body: { href: location, name: name, created_at: created_at }.to_json)
+        contact_person = ContactPerson.create!(name: name)
+        expect(contact_person.href).to eq location
+        expect(contact_person.created_at).to eq Date.parse(created_at)
+        expect(contact_person.name).to eq name
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 7.2.3
+  version: 7.2.4
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors