lhs 7.0.0 → 7.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aa6cec36b44adf1e4a4ec191be5ddadeade8df99
-  data.tar.gz: 504a4cbb77242734dc54a9545d8871325ff1467b
+  metadata.gz: 2e11e78d3dd76e163a20dd38f8873322ff71ff81
+  data.tar.gz: 763cb822c37ca6e938cfd8f9a7f7014a1f47dc7f
 SHA512:
-  metadata.gz: 2980127f21442628806801f96bf5cae65b7fd426a45639b739831e2f9cf06480c2f2fb0d4317b5d7604e6f68703d2306113371ca360be92bcc5ddc497301d90c
-  data.tar.gz: f61ba980791188f4bed6dd59c3f67c9334f77871fa60e5e97c3bba4b2142346ee3b8d799293ec348405cb85b4af8a53353943b932293da5b910512da14a0562f
+  metadata.gz: 970ba3f98020e099502f5dcf768d0efc0e40bb147be2f334cd5429dbec35543fd0b6157459f45a7c293e7ecd08a2ffae951e06aba758eabae61d15baf2fe220a
+  data.tar.gz: 00d4680483a466f6ae84487c3ed1d6c014e493ee2c120f47cef1a35c4a1e8ad5a5ea6c2d0f58a741715db146ee14d141771ef0688234e9395ac2fd88f12bd283

data/lib/lhs/concerns/item/save.rb

@@ -14,15 +14,15 @@ class LHS::Item < LHS::Proxy
     end
 
     def save!(options = {})
-      options ||= {}
-      record = _data.class
+      options = options.present? ? options.dup : {}
       data = _data._raw.dup
       if href.present?
         url = href
       else
-        endpoint = record.find_endpoint(data)
-        url = endpoint.compile(data)
+        endpoint = endpoint_for_persistance(data, options)
+        url = url_for_persistance(endpoint, data, options)
         endpoint.remove_interpolated_params!(data)
+        endpoint.remove_interpolated_params!(options.fetch(:params, {}))
         options.merge!(endpoint.options.merge(options)) if endpoint.options
       end
 
@@ -30,9 +30,34 @@ class LHS::Item < LHS::Proxy
       options[:headers] ||= {}
       options[:headers].merge!('Content-Type' => 'application/json')
 
-      data = record.request(options)
+      data = record_for_persistance.request(options)
       _data.merge_raw!(data)
       true
     end
+
+    private
+
+    def endpoint_for_persistance(data, options)
+      record_for_persistance
+        .find_endpoint(merge_data_with_options(data, options))
+    end
+
+    def merge_data_with_options(data, options)
+      if options && options[:params]
+        data.merge(options[:params])
+      else
+        data
+      end
+    end
+
+    def record_for_persistance
+      _data.class
+    end
+
+    def url_for_persistance(endpoint, data, options)
+      endpoint.compile(
+        merge_data_with_options(data, options)
+      )
+    end
   end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "7.0.0"
+  VERSION = "7.0.1"
 end

data/spec/record/save_spec.rb

@@ -14,14 +14,24 @@ describe LHS::Record do
       let(:campaign_id) { 12345 }
       let(:object) { { recommended: true } }
       let(:item) { Feedback.new(object.merge(campaign_id: campaign_id)) }
-
-      it 'removes params used to compute url from send data' do
-        datastore_request = stub_request(:post, "#{datastore}/content-ads/#{campaign_id}/feedbacks")
+      let!(:request) do
+        stub_request(:post, "#{datastore}/content-ads/#{campaign_id}/feedbacks")
           .with(body: object.to_json)
           .to_return(status: 200, body: object.to_json)
+      end
 
+      it 'removes params used to compute url from send data' do
         item.save!
-        expect(datastore_request).to have_been_made.once
+        expect(request).to have_been_made.once
+      end
+
+      context 'item without data' do
+        let(:item) { Feedback.new(object) }
+
+        it 'takes params to find endpoint also from the options' do
+          item.save!(params: { campaign_id: campaign_id })
+          expect(request).to have_been_made.once
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 7.0.0
+  version: 7.0.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-16 00:00:00.000000000 Z
+date: 2016-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc