lhs 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5457dca94fecc849496d18aaff5a9caa087608f8
-  data.tar.gz: c1854bf19ecd17ab7383cda4ee2cc482e068fecc
+  metadata.gz: 25c2f31fa82157c1d9a3b6afebaf02f5d71b926a
+  data.tar.gz: d464725b1cc5882bc182d460532fe26b6add315d
 SHA512:
-  metadata.gz: ceabba06f22f3337a24ef9410b7f2cd17b072c4c86ba3d4e8e8f01991d98f51eaa10448d77021baf5bb3055fe5226127ab8d6ccebe1da993b43c68a5e0691cfd
-  data.tar.gz: 861a4ff34ea47ed94c33e3b247ad75a25119f74a9a430b307a4b8f3bd05459cfb29fd280d00d4be986c86b3ea7a3062bb378f3a58390f8b5a8712c0cc10d4d05
+  metadata.gz: d3cce7225ad9cbd4e615e35af9362096c760dfb9603ed24ed4c207ecbaba98c7620f5efd02c5d41a5446d6ddc1d1b3d0d7048a10984a56aeb08650e9f2108250
+  data.tar.gz: 58446953d05a44c0d8e3af2d5c2be56725f22440aa6bf6d21731522bd4bbd849469e1964af675a8ff324dd880405e562e2f3fe347a652b44e44f4ce1f7f8604b

data/.rubocop.yml

@@ -5,3 +5,9 @@ inherit_from:
 
 Lint/IneffectiveAccessModifier:
   Enabled: false
+
+RSpec/DescribedClass:
+  Enabled: false
+
+RSpec/AnyInstance:
+  Enabled: false

data/lib/lhs/record.rb

@@ -14,6 +14,8 @@ class LHS::Record
   include Request
   include Where
 
+  delegate :_proxy, to: :_data
+
   def initialize(data = nil)
     data = LHS::Data.new({}, nil, self.class) unless data
     data = LHS::Data.new(data, nil, self.class) unless data.is_a?(LHS::Data)
@@ -40,11 +42,10 @@ class LHS::Record
   protected
 
   def method_missing(name, *args, &block)
-    _data.send(name, *args, &block)
+    _data._proxy.send(name, *args, &block)
   end
 
   def respond_to_missing?(name, include_all = false)
-    (_data.root_item? && _data._root._record_class.instance_methods.include?(name)) ||
-      _data._proxy.respond_to?(name, include_all)
+    _data.respond_to_missing?(name, include_all)
   end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "3.0.3"
+  VERSION = "3.0.4"
 end

data/spec/collection/delegate_spec.rb

@@ -6,7 +6,7 @@ describe LHS::Collection do
   }
 
   let(:collection){
-    described_class.new(LHS::Data.new(data))
+    LHS::Collection.new(LHS::Data.new(data))
   }
 
   context 'delegates methods to raw' do

data/spec/collection/enumerable_spec.rb

@@ -6,7 +6,7 @@ describe LHS::Collection do
   }
 
   let(:collection){
-    described_class.new(LHS::Data.new(data))
+    LHS::Collection.new(LHS::Data.new(data))
   }
 
   context 'enumerable' do

data/spec/collection/respond_to_spec.rb

@@ -6,7 +6,7 @@ describe LHS::Collection do
   }
 
   let(:collection){
-    described_class.new(LHS::Data.new(data))
+    LHS::Data.new(LHS::Data.new(data))
   }
 
   context '#respond_to?' do

data/spec/data/collection_spec.rb

@@ -6,14 +6,14 @@ describe LHS::Data do
   end
 
   let(:data) do
-    described_class.new(json)
+    LHS::Data.new(json)
   end
 
   context 'collections' do
     it 'forwards calls to the collection' do
       expect(data.count).to be_kind_of Fixnum
-      expect(data[0]).to be_kind_of described_class
-      expect(data.sample).to be_kind_of described_class
+      expect(data[0]).to be_kind_of LHS::Data
+      expect(data.sample).to be_kind_of LHS::Data
     end
 
     it 'provides a total method to get the number of total records' do
@@ -23,7 +23,7 @@ describe LHS::Data do
 
   context 'collections from arrays' do
     let(:data) do
-      described_class.new([1, 2, 3, 4])
+      LHS::Data.new([1, 2, 3, 4])
     end
 
     it 'uses collection as proxy for arrays' do

data/spec/data/item_spec.rb

@@ -13,7 +13,7 @@ describe LHS::Data do
   end
 
   let(:data) do
-    described_class.new(json, nil, Record)
+    LHS::Data.new(json, nil, Record)
   end
 
   let(:item) do

data/spec/data/merge_spec.rb

@@ -9,16 +9,11 @@ describe LHS::Data do
   end
 
   let(:data) do
-    described_class.new({
-                          href: 'http://www.local.ch/v2/stuff'
-                        }, nil, Record)
+    LHS::Data.new({ href: 'http://www.local.ch/v2/stuff' }, nil, Record)
   end
 
   let(:loaded_data) do
-    described_class.new({
-                          href: 'http://www.local.ch/v2/stuff',
-                          id: '123123123'
-                        }, nil, Record)
+    LHS::Data.new({ href: 'http://www.local.ch/v2/stuff', id: '123123123' }, nil, Record)
   end
 
   context 'merging' do

data/spec/data/raw_spec.rb

@@ -10,7 +10,7 @@ describe LHS::Data do
   end
 
   let(:data_from_raw) do
-    described_class.new(
+    LHS::Data.new(
       href: 'http://www.local.ch/v2/stuff',
       id: '123123123'
     )
@@ -18,8 +18,8 @@ describe LHS::Data do
 
   let(:data_from_item) do
     raw = { href: 'http://www.local.ch/v2/stuff' }
-    item = LHS::Item.new(described_class.new(raw))
-    described_class.new(item)
+    item = LHS::Item.new(LHS::Data.new(raw))
+    LHS::Data.new(item)
   end
 
   context 'raw' do

data/spec/data/respond_to_spec.rb

@@ -9,14 +9,14 @@ describe LHS::Data do
 
   context '#respond_to?' do
     it 'it is true for mappings that are defined' do
-      data = described_class.new({ 'campaign' => { 'id' => 123 } }, nil, Record)
+      data = LHS::Data.new({ 'campaign' => { 'id' => 123 } }, nil, Record)
 
       expect(data.respond_to?(:test_mapping?)).to be(true)
     end
 
     # proxy for this example is LHC::Collection which implements total
     it 'it is true for calls forwarded to proxy' do
-      data = described_class.new({ 'items' => [{ 'campaign' => { 'id' => 123 } }] }, nil, Record)
+      data = LHS::Data.new({ 'items' => [{ 'campaign' => { 'id' => 123 } }] }, nil, Record)
 
       expect(data.respond_to?(:total)).to be(true)
     end

data/spec/data/root_spec.rb

@@ -11,12 +11,12 @@ describe LHS::Data do
 
   context 'root' do
     it 'is navigateable from nested data' do
-      root = described_class.new({ 'items' => [{ 'campaign' => { 'id' => 123 } }] }, nil, Record)
+      root = LHS::Data.new({ 'items' => [{ 'campaign' => { 'id' => 123 } }] }, nil, Record)
       child = root.first
       leafe = child.campaign
       expect(leafe._root).to eq root
-      expect(leafe._parent).to be_kind_of described_class
-      expect(leafe._parent._parent).to be_kind_of described_class
+      expect(leafe._parent).to be_kind_of LHS::Data
+      expect(leafe._parent._parent).to be_kind_of LHS::Data
       expect(leafe._parent._parent).to eq root
     end
   end

data/spec/data/select_spec.rb

@@ -6,7 +6,7 @@ describe LHS::Data do
   end
 
   let(:data) do
-    described_class.new(raw)
+    LHS::Data.new(raw)
   end
 
   context 'select' do

data/spec/data/to_json_spec.rb

@@ -13,7 +13,7 @@ describe LHS::Data do
   end
 
   let(:collection) do
-    described_class.new(json, nil, Record)
+    LHS::Data.new(json, nil, Record)
   end
 
   let(:item) do

data/spec/endpoint/for_url_spec.rb

@@ -12,13 +12,13 @@ describe LHS::Endpoint do
 
     it 'provides the endpoint for a given url' do
       expect(
-        described_class.for_url('http://local.ch/v2/entries/123/content-ads/456/feedbacks').url
+        LHS::Endpoint.for_url('http://local.ch/v2/entries/123/content-ads/456/feedbacks').url
       ).to eq ':datastore/entries/:entry_id/content-ads/:campaign_id/feedbacks'
       expect(
-        described_class.for_url('http://local.ch/123/feedbacks').url
+        LHS::Endpoint.for_url('http://local.ch/123/feedbacks').url
       ).to eq ':datastore/:campaign_id/feedbacks'
       expect(
-        described_class.for_url('http://local.ch/feedbacks').url
+        LHS::Endpoint.for_url('http://local.ch/feedbacks').url
       ).to eq ':datastore/feedbacks'
     end
   end

data/spec/item/respond_to_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Item do
   let(:item){
-    described_class.new(id: 1234)
+    LHS::Item.new(id: 1234)
   }
 
   context '#respond_to?' do

data/spec/item/update_spec.rb

@@ -46,7 +46,7 @@ describe LHS::Item do
         .to_return(status: 400, body: item._raw.merge(likes: 'Banana').to_json)
       item.update(name: 'Andrea')
       expect(item.name).to eq 'Andrea'
-      expect(item.likes).to_not eq 'Banana'
+      expect(item.likes).not_to eq 'Banana'
     end
   end
 

data/spec/record/all_spec.rb

@@ -21,7 +21,7 @@ describe LHS::Collection do
         .to_return(status: 200, body: { items: (201..300).to_a, total: 300, limit: 100, offset: 201 }.to_json)
       all = Record.all
       expect(all).to be_kind_of Record
-      expect(all._proxy).to be_kind_of described_class
+      expect(all._data._proxy).to be_kind_of LHS::Collection
       expect(all.count).to eq 300
       expect(all.last).to eq 300
     end
@@ -35,7 +35,7 @@ describe LHS::Collection do
         .to_return(status: 200, body: { items: (201..300).to_a, total: 300, offset: 201 }.to_json)
       all = Record.all
       expect(all).to be_kind_of Record
-      expect(all._proxy).to be_kind_of described_class
+      expect(all._proxy).to be_kind_of LHS::Collection
       expect(all.count).to eq 300
       expect(all.last).to eq 300
     end
@@ -45,7 +45,7 @@ describe LHS::Collection do
         .to_return(status: 200, body: { items: [], total: 300, offset: 0 }.to_json)
       all = Record.all
       expect(all).to be_kind_of Record
-      expect(all._proxy).to be_kind_of described_class
+      expect(all._proxy).to be_kind_of LHS::Collection
       expect(all.count).to eq 0
     end
   end

data/spec/record/find_in_batches_spec.rb

@@ -36,7 +36,7 @@ describe LHS::Collection do
       Record.find_in_batches do |records|
         count += records.count
         expect(records).to be_kind_of Record
-        expect(records._proxy).to be_kind_of described_class
+        expect(records._proxy).to be_kind_of LHS::Collection
       end
       expect(count).to eq total
     end
@@ -51,7 +51,7 @@ describe LHS::Collection do
       Record.find_in_batches(batch_size: 230) do |records|
         count += records.count
         expect(records).to be_kind_of Record
-        expect(records._proxy).to be_kind_of described_class
+        expect(records._proxy).to be_kind_of LHS::Collection
       end
       expect(count).to eq total
     end

data/spec/record/select_spec.rb

@@ -0,0 +1,15 @@
+require 'rails_helper'
+
+describe LHS::Record do
+  let(:record) do
+    LHS::Record.new(LHS::Data.new(['cat', 'dog']))
+  end
+
+  context 'select' do
+    it 'works with select' do
+      expect(
+        record.select { |x| x }.join
+      ).to eq 'catdog'
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-15 00:00:00.000000000 Z
+date: 2016-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -258,6 +258,7 @@ files:
 - spec/record/model_name_spec.rb
 - spec/record/new_spec.rb
 - spec/record/request_spec.rb
+- spec/record/select_spec.rb
 - spec/record/to_json_spec.rb
 - spec/record/where_spec.rb
 - spec/spec_helper.rb
@@ -376,6 +377,7 @@ test_files:
 - spec/record/model_name_spec.rb
 - spec/record/new_spec.rb
 - spec/record/request_spec.rb
+- spec/record/select_spec.rb
 - spec/record/to_json_spec.rb
 - spec/record/where_spec.rb
 - spec/spec_helper.rb