lhs 3.0.2 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: de4e937aec263ff69d6e9a3ba6325c644c4cd9fe
-  data.tar.gz: f9b26639ef17eed08e07d9015892aa5cb86810dd
+  metadata.gz: 5457dca94fecc849496d18aaff5a9caa087608f8
+  data.tar.gz: c1854bf19ecd17ab7383cda4ee2cc482e068fecc
 SHA512:
-  metadata.gz: 08b0a1aef783001857844d13927dccf03a6e5dabbb5d7804cb74a35776903d750760b6c7c89a60b488742c2d63cce9bbef3fe9fe9e1494d12ddf92be9b4595b6
-  data.tar.gz: 8a08538eab98ca16604e3c14d8fc44f144f42be8ece4a0c0537189459437d23565b15068ffddb8b89ec959bac86a5838c9258f7fd44b6b1a25851686031090cb
+  metadata.gz: ceabba06f22f3337a24ef9410b7f2cd17b072c4c86ba3d4e8e8f01991d98f51eaa10448d77021baf5bb3055fe5226127ab8d6ccebe1da993b43c68a5e0691cfd
+  data.tar.gz: 861a4ff34ea47ed94c33e3b247ad75a25119f74a9a430b307a4b8f3bd05459cfb29fd280d00d4be986c86b3ea7a3062bb378f3a58390f8b5a8712c0cc10d4d05

data/lib/lhs/concerns/item/validation.rb

@@ -9,7 +9,8 @@ class LHS::Item < LHS::Proxy
       self.errors = nil
       fail 'No validation endpoint found!' unless validation_endpoint
       record = LHS::Record.for_url(validation_endpoint.url)
-      params = validation_endpoint.options.fetch(:params, {}).merge(persist: false)
+      validation_params = validation_endpoint.options[:validates] == true ? { persist: false } : { validation_endpoint.options[:validates] => false }
+      params = validation_endpoint.options.fetch(:params, {}).merge(validation_params)
       begin
         record.request(
           url: validation_endpoint.url,

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "3.0.2"
+  VERSION = "3.0.3"
 end

data/spec/item/validation_spec.rb

@@ -3,83 +3,109 @@ require 'rails_helper'
 describe LHS::Item do
   let(:datastore) { 'http://local.ch' }
 
-  before(:each) do
-    LHC.config.placeholder('datastore', datastore)
-    class User < LHS::Record
-      endpoint ':datastore/v2/users', validates: true
-    end
-    mock_validation
-  end
+  let(:validation_parameter) { 'persist' }
 
   let(:mock_validation) do
     successful_validation
   end
 
   let(:successful_validation) do
-    stub_request(:post, "#{datastore}/v2/users?persist=false").to_return(body: '{}')
+    stub_request(:post, "#{datastore}/v2/users?#{validation_parameter}=false").to_return(body: '{}')
   end
 
-  let(:failing_validation) do
-    stub_request(:post, "#{datastore}/v2/users?persist=false")
-      .to_return(status: 400,
-                 body: {
-                   field_errors: [{ code: "UNSUPPORTED_PROPERTY_VALUE", "path" => ["email"] }]
-                 }.to_json
-                )
+  before(:each) do
+    mock_validation
   end
 
-  context 'valid data' do
+  context 'custom validation parameter' do
+    let(:validation_parameter) { 'publish' }
+
     let(:user) do
       User.build(email: 'steve@local.ch')
     end
 
-    it 'validates' do
-      expect(user.valid?).to eq true
+    before(:each) do
+      LHC.config.placeholder('datastore', datastore)
+      class User < LHS::Record
+        endpoint ':datastore/v2/users', validates: 'publish'
+      end
     end
 
-    it 'turns to be invalid if validating on changed, invalid data' do
+    it 'validates' do
       expect(user.valid?).to eq true
-      user.email = 'not a valid email'
-      failing_validation
-      expect(user.valid?).to eq false
-      expect(user.errors[:email]).to be
     end
   end
 
-  context 'invalid data' do
-    let(:user) do
-      User.build(email: 'im not an email address')
+  context 'default parameter' do
+    before(:each) do
+      LHC.config.placeholder('datastore', datastore)
+      class User < LHS::Record
+        endpoint ':datastore/v2/users', validates: true
+      end
     end
 
-    let(:mock_validation) do
-      failing_validation
+    let(:failing_validation) do
+      stub_request(:post, "#{datastore}/v2/users?persist=false")
+        .to_return(status: 400,
+                   body: {
+                     field_errors: [{ code: "UNSUPPORTED_PROPERTY_VALUE", "path" => ["email"] }]
+                   }.to_json
+                  )
     end
 
-    it 'does not validate and provides error messages' do
-      expect(user.valid?).to eq false
-      expect(user.errors[:email]).to be
-    end
+    context 'valid data' do
+      let(:user) do
+        User.build(email: 'steve@local.ch')
+      end
 
-    it 'resets errors when revalidating' do
-      expect(user.valid?).to eq false
-      user.email = 'steve@local.ch'
-      successful_validation
-      expect(user.valid?).to eq true
-      expect(user.errors).to be_nil
+      it 'validates' do
+        expect(user.valid?).to eq true
+      end
+
+      it 'turns to be invalid if validating on changed, invalid data' do
+        expect(user.valid?).to eq true
+        user.email = 'not a valid email'
+        failing_validation
+        expect(user.valid?).to eq false
+        expect(user.errors[:email]).to be
+      end
     end
-  end
 
-  context 'endpoint does not support validations' do
-    before(:each) do
-      class Favorite < LHS::Record
-        endpoint ':datastore/v2/favorites'
+    context 'invalid data' do
+      let(:user) do
+        User.build(email: 'im not an email address')
+      end
+
+      let(:mock_validation) do
+        failing_validation
+      end
+
+      it 'does not validate and provides error messages' do
+        expect(user.valid?).to eq false
+        expect(user.errors[:email]).to be
+      end
+
+      it 'resets errors when revalidating' do
+        expect(user.valid?).to eq false
+        user.email = 'steve@local.ch'
+        successful_validation
+        expect(user.valid?).to eq true
+        expect(user.errors).to be_nil
       end
     end
 
-    it 'fails when trying to use an endpoint for validations that does not support it' do
-      expect(lambda {
-        Favorite.build.valid?
-      }).to raise_error('Endpoint does not support validations!')
+    context 'endpoint does not support validations' do
+      before(:each) do
+        class Favorite < LHS::Record
+          endpoint ':datastore/v2/favorites'
+        end
+      end
+
+      it 'fails when trying to use an endpoint for validations that does not support it' do
+        expect(lambda do
+          Favorite.build.valid?
+        end).to raise_error('Endpoint does not support validations!')
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors