lhs 19.8.2 → 20.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e57e3afbbffbdd6fdbcc8b64a947daae97b5faa5975ae8fe29b6b77d87b0d47
-  data.tar.gz: 5d8363f9dcbd226f60428e6344967ef2369639fd36544b7a6d9112d5058b8d31
+  metadata.gz: 6222738010dc108833f001419f0fe23f97c1fbe6bb3211347724455bd6d1fab6
+  data.tar.gz: ec1856d1a8ce39396dedf8251058f59604f3e84111a2dffea05a7b0d97b07cab
 SHA512:
-  metadata.gz: 4f7ae19794cade9f046731c0c6cc948a87b8a04bada44e14c52853600b78c47f6ecfb53bc2bedbb16918cb0cf2788e3ac780873ebbeebbad544eb504494464aa
-  data.tar.gz: b8092ac44ed946248fa686e95873ce841cd1b38dbebbc41f7547037840b56e8c8c5d168c1866382e9f6e6eb51c181e43f407febe9d5ff1b476b1df3a063f326e
+  metadata.gz: 22dde92abf63322ceab6d51962462c5dac3a34c12c46438a761fdce584066e50c1202babbc31762326cd96d073edd7d83aa8b8a231948a3d404adb93ea8a8ea2
+  data.tar.gz: eaafb72d93e036a0e8af226877fea17d5489e722bbd0d403946bc4828e3429f2a37cf85dc46818116fe751fb937dc3c1851e4cc9ac55f0d7fbbb0482611abe38

data/README.md

@@ -119,6 +119,7 @@ record.review # "Lunch was great
             * [Record setters](#record-setters)
             * [Record getters](#record-getters)
          * [Include linked resources (hyperlinks and hypermedia)](#include-linked-resources-hyperlinks-and-hypermedia)
+            * [Generate links from parameters](#generate-links-from-parameters)
             * [Ensure the whole linked collection is included: includes_all](#ensure-the-whole-linked-collection-is-included-includes_all)
             * [Include the first linked page or single item is included: include](#include-the-first-linked-page-or-single-item-is-included-include)
             * [Include various levels of linked data](#include-various-levels-of-linked-data)
@@ -136,8 +137,11 @@ record.review # "Lunch was great
          * [Disable request cycle cache](#disable-request-cycle-cache)
       * [Option Blocks](#option-blocks)
       * [Request tracing](#request-tracing)
+      * [Extended Rollbar Logging](#extended-rollbar-logging)
       * [Testing with LHS](#testing-with-lhs)
-         * [Test helper for request cycle cache](#test-helper-for-request-cycle-cache)
+         * [Test helper](#test-helper)
+            * [Stub](#stub)
+               * [Stub All](#stub-all)
          * [Test query chains](#test-query-chains)
             * [By explicitly resolving the chain: fetch](#by-explicitly-resolving-the-chain-fetch)
             * [Without resolving the chain: where_values_hash](#without-resolving-the-chain-where_values_hash)
@@ -1627,6 +1631,15 @@ POST https://service.example.com/records/1z-5r1fkaj { body: "{ 'name': 'Starbuck
 
 -> See [record validation](#record-validation) for how to handle validation errors when updating records.
 
+You can also pass explicit request options to `update`, by passing two explicit hashes:
+
+```ruby
+# app/controllers/some_controller.rb
+
+record.update({ recommended: true }, { method: 'put' })
+
+```
+
 ##### partial_update
 
 `partial_update` updates just the provided parameters.
@@ -1658,6 +1671,15 @@ POST https://service.example.com/records/1z-5r1fkaj { body: "{ 'name': 'Starbuck
 
 -> See [record validation](#record-validation) for how to handle validation errors when updating records.
 
+You can also pass explicit request options to `partial_update`, by passing two explicit hashes:
+
+```ruby
+# app/controllers/some_controller.rb
+
+record.partial_update({ recommended: true }, { method: 'put' })
+
+```
+
 #### Endpoint url parameter injection during record creation/change
 
 LHS injects parameters provided to `create`, `update`, `partial_update`, `save` etc. into an endpoint's URL when matching:
@@ -2020,6 +2042,21 @@ With `includes` or `includes_all` (to enforce fetching all remote objects for pa
 
 Including linked resources/records is heavily influenced by [https://guides.rubyonrails.org/active_record_querying.html](https://guides.rubyonrails.org/active_record_querying.html#eager-loading-associations) and you should read it to understand this feature in all it's glory.
 
+#### Generate links from parameters
+
+Sometimes you need to generate full hrefs/urls for records but you just have parameters that describe that record, like the ID.
+
+For those usecases you can use `href_for(params)`:
+
+```ruby
+# app/controllers/some_controller.rb
+
+Presence.create(place: { href: Place.href_for(123) })
+```
+```
+POST '/presences' { place: { href: "http://datastore/places/123" } }
+```
+
 #### Ensure the whole linked collection is included: includes_all
 
 In case endpoints are paginated and you are certain that you'll need all objects of a set and not only the first page/batch, use `includes_all`.
@@ -2428,6 +2465,26 @@ code.places
 }
 ```
 
+## Extended Rollbar Logging
+
+In order to log all requests/responses prior to an exception reported by Rollbar in addition to the exception itself, use the `LHS::ExtendedRollbar` interceptor in combination with the rollbar processor/handler:
+
+```ruby
+# config/initializers/lhc.rb
+
+LHC.configure do |config|
+  config.interceptors = [LHS::ExtendedRollbar]
+end
+```
+
+```ruby
+# config/initializers/rollbar.rb
+
+Rollbar.configure do |config|
+  config.before_process << LHS::Interceptors::ExtendedRollbar::Handler.init
+end
+```
+
 ## Testing with LHS
 
 **Best practice in regards of testing applications using LHS, is to let LHS fetch your records, actually perform HTTP requests and [WebMock](https://github.com/bblimke/webmock) to stub/mock those http requests/responses.**
@@ -2465,17 +2522,44 @@ it 'displays contracts' do
 end
 ```
 
-### Test helper for request cycle cache
+### Test helper
 
-In order to not run into caching issues during your tests, when (request cycle cache)[#request-cycle-cache] is enabled, simply require the following helper in your tests:
+In order to load LHS test helpers into your tests, add the following to your spec helper:
 
 ```ruby
 # spec/spec_helper.rb
 
-require 'lhs/test/request_cycle_cache_helper'
+require 'lhs/rspec'
 ```
 
-This will initialize a MemoryStore cache for LHC::Caching interceptor and resets the cache before every test.
+This e.g. will prevent running into caching issues during your tests, when (request cycle cache)[#request-cycle-cache] is enabled.
+It will initialize a MemoryStore cache for LHC::Caching interceptor and resets the cache before every test.
+
+#### Stub
+
+LHS offers stub helpers that simplify stubbing https request to your apis.
+
+##### Stub All
+
+`LHS.stub.all(url, items, additional_options)`
+
+```ruby
+# your_spec.rb
+
+before do
+  LHS.stub.all(
+    'https://records',
+    200.times.map{ |index| { name: "Item #{index}" } },
+    headers: {
+      'Authorization' => 'Bearer 123'
+    }
+  )
+end
+```
+```
+GET https://records?limit=100
+GET https://records?limit=100&offset=100
+```
 
 ### Test query chains
 

data/lhs.gemspec

@@ -28,9 +28,11 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'capybara'
   s.add_development_dependency 'json', '>=  1.8.2'
+  s.add_development_dependency 'local_uri'
   s.add_development_dependency 'pry'
   s.add_development_dependency 'pry-byebug'
   s.add_development_dependency 'rails', '>= 4.2.11'
+  s.add_development_dependency 'rollbar'
   s.add_development_dependency 'rspec-rails', '>= 3.7.0'
   s.add_development_dependency 'rubocop', '~> 0.57.1'
   s.add_development_dependency 'rubocop-rspec', '~> 1.26.0'

data/lib/lhs.rb

@@ -15,10 +15,28 @@ module LHS
     'lhs/config'
   autoload :Data,
     'lhs/data'
+  autoload :ExtendedRollbar,
+    'lhs/interceptors/extended_rollbar/interceptor'
   autoload :Endpoint,
     'lhs/endpoint'
   autoload :Inspect,
     'lhs/concerns/inspect'
+  module Interceptors
+    module RequestCycleCache
+      autoload :ThreadRegistry,
+        'lhs/interceptors/request_cycle_cache/thread_registry'
+      autoload :Interceptor,
+        'lhs/interceptors/request_cycle_cache/interceptor'
+    end
+    module ExtendedRollbar
+      autoload :ThreadRegistry,
+        'lhs/interceptors/extended_rollbar/thread_registry'
+      autoload :Interceptor,
+        'lhs/interceptors/extended_rollbar/interceptor'
+      autoload :Handler,
+        'lhs/interceptors/extended_rollbar/handler'
+    end
+  end
   autoload :IsHref,
     'lhs/concerns/is_href'
   autoload :Item,

data/lib/lhs/concerns/option_blocks.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'active_support'
+require 'active_support/per_thread_registry'
 
 module LHS
   module OptionBlocks
@@ -8,7 +9,7 @@ module LHS
 
     class CurrentOptionBlock
       # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
-      # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v5.
+      # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v4.
       extend ActiveSupport::PerThreadRegistry
       attr_accessor :options
     end

data/lib/lhs/concerns/record/href_for.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'active_support'
+
+class LHS::Record
+
+  module HrefFor
+    extend ActiveSupport::Concern
+
+    module ClassMethods
+      def href_for(args = nil)
+        return unless [Integer, String].include?(args.class)
+        params = { id: args }
+        find_endpoint(params).compile(params)
+      end
+      alias url_for href_for
+    end
+  end
+end

data/lib/lhs/concerns/record/request.rb

@@ -509,16 +509,16 @@ class LHS::Record
         options
       end
 
-      # Injects options into request, that enable the LHS::Record::RequestCycleCache::Interceptor
+      # Injects options into request, that enable the request cycle cache interceptor
       def inject_request_cycle_cache!(options)
         return unless LHS.config.request_cycle_cache_enabled
         interceptors = options[:interceptors] || LHC.config.interceptors
         if interceptors.include?(LHC::Caching)
-          # Ensure LHS::RequestCycleCache interceptor is prepend
-          interceptors = interceptors.unshift(LHS::Record::RequestCycleCache::Interceptor)
+          # Ensure interceptor is prepend
+          interceptors = interceptors.unshift(LHS::Interceptors::RequestCycleCache::Interceptor)
           options[:interceptors] = interceptors
         else
-          warn("[WARNING] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured (see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor)!")
+          warn("[WARNING] Can't enable request cycle cache as LHC::Caching interceptor is not enabled/configured (see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor)!")
         end
       end
 

data/lib/lhs/interceptors/extended_rollbar/handler.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module LHS
+  module Interceptors
+    module ExtendedRollbar
+      class Handler
+
+        def self.init
+          proc do |options|
+            # as handlers cant influence what actually is reported to rollbar
+            # this just makes sure that Rollbar is already loaded when this class is loaded,
+            # so that we can extend rollbar loging
+          end
+        end
+
+        module ExtendedLogging
+          def log(level, *args)
+            args[2] = {} if args[2].nil?
+            args[2][:lhs] = LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log.map do |entry|
+              {
+                request: entry[:request].options,
+                response: {
+                  code: entry[:response].code,
+                  body: entry[:response].body
+                }
+              }
+            end.to_json
+            super
+          end
+        end
+
+        module ::Rollbar
+          class Notifier
+            prepend LHS::Interceptors::ExtendedRollbar::Handler::ExtendedLogging
+          end
+        end
+      end
+    end
+  end
+end

data/lib/lhs/interceptors/extended_rollbar/interceptor.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'active_support'
+
+module LHS
+  module Interceptors
+    module ExtendedRollbar
+      extend ActiveSupport::Concern
+
+      class Interceptor < LHC::Interceptor
+        def after_response
+          return unless LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log
+          LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log.push(request: request, response: response)
+        end
+      end
+    end
+  end
+
+  const_set('ExtendedRollbar', LHS::Interceptors::ExtendedRollbar::Interceptor)
+end

data/lib/lhs/interceptors/extended_rollbar/thread_registry.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'active_support'
+require 'active_support/per_thread_registry'
+
+module LHS
+  module Interceptors
+    module ExtendedRollbar
+      extend ActiveSupport::Concern
+
+      class ThreadRegistry
+        # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
+        # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v4.
+        extend ActiveSupport::PerThreadRegistry
+        attr_accessor :log
+      end
+    end
+  end
+end

data/lib/lhs/interceptors/request_cycle_cache/interceptor.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'active_support'
+
+module LHS
+  module Interceptors
+    module RequestCycleCache
+      extend ActiveSupport::Concern
+
+      class Interceptor < LHC::Interceptor
+
+        VERSION = 1
+        CACHED_METHODS = [:get].freeze
+
+        def before_request
+          request.options = {
+            cache: {
+              expires_in: 5.minutes,
+              race_condition_ttl: 5.seconds,
+              key: cache_key_for(request),
+              methods: CACHED_METHODS,
+              use: LHS.config.request_cycle_cache
+            }
+          }.merge(request.options)
+        end
+
+        private
+
+        def cache_key_for(request)
+          [
+            "LHS_REQUEST_CYCLE_CACHE(v#{VERSION})",
+            request.method.upcase,
+            [request.url, request.params.presence].compact.join('?'),
+            "REQUEST=#{LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id}",
+            "HEADERS=#{request.headers.hash}"
+          ].join(' ')
+        end
+      end
+    end
+  end
+end

data/lib/lhs/interceptors/request_cycle_cache/thread_registry.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'active_support'
+require 'active_support/per_thread_registry'
+
+module LHS
+  module Interceptors
+    module RequestCycleCache
+      extend ActiveSupport::Concern
+      class ThreadRegistry
+        # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
+        # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v4.
+        extend ActiveSupport::PerThreadRegistry
+        attr_accessor :request_id
+      end
+    end
+  end
+end

data/lib/lhs/railtie.rb

@@ -8,6 +8,7 @@ module LHS
         def initialize
           prepare_lhs_request_cycle_cache
           reset_option_blocks
+          reset_extended_rollbar_request_logs
           super
         end
 
@@ -15,12 +16,18 @@ module LHS
 
         def prepare_lhs_request_cycle_cache
           return unless LHS.config.request_cycle_cache_enabled
-          LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id = [Time.now.to_f, request.object_id].join('#')
+          LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id = [Time.now.to_f, request.object_id].join('#')
         end
 
         def reset_option_blocks
           LHS::OptionBlocks::CurrentOptionBlock.options = nil
         end
+
+        def reset_extended_rollbar_request_logs
+          return unless defined?(::Rollbar)
+          return unless LHC.config.interceptors.include?(LHS::Interceptors::ExtendedRollbar::Interceptor)
+          LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log = []
+        end
       end
     end
   end

data/lib/lhs/record.rb

@@ -23,6 +23,8 @@ class LHS::Record
     'lhs/concerns/record/find_by'
   autoload :First,
     'lhs/concerns/record/first'
+  autoload :HrefFor,
+    'lhs/concerns/record/href_for'
   autoload :Last,
     'lhs/concerns/record/last'
   autoload :Mapping,
@@ -46,13 +48,6 @@ class LHS::Record
   autoload :AttributeAssignment,
     'lhs/concerns/record/attribute_assignment'
 
-  module RequestCycleCache
-    autoload :RequestCycleThreadRegistry,
-      'lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry'
-    autoload :Interceptor,
-      'lhs/concerns/record/request_cycle_cache/interceptor'
-  end
-
   include Batch
   include Chainable
   include Configuration
@@ -64,6 +59,7 @@ class LHS::Record
   include Find
   include FindBy
   include First
+  include HrefFor
   include LHS::IsHref
   include Last
   include LHS::Inspect
@@ -74,7 +70,6 @@ class LHS::Record
   include Provider
   include Request
   include Relations
-  include RequestCycleCache
   include Scope
   include Tracing
   include AttributeAssignment

data/lib/lhs/rspec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'lhs'
+require 'lhs/test/stub'
+
+RSpec.configure do |config|
+  config.before(:each) do
+    LHS.config.request_cycle_cache.clear
+  end
+
+  config.before(:all) do
+
+    module LHS
+      def self.stub
+        LHS::Test::Stub
+      end
+    end
+  end
+end

data/lib/lhs/test/stub.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require 'local_uri'
+require 'webmock'
+module LHS
+  module Test
+    class Stub
+      extend WebMock::API
+      DEFAULT_LIMIT = LHS::Pagination::Base::DEFAULT_LIMIT
+
+      def self.all(url, items, options = {})
+        items.each_slice(DEFAULT_LIMIT).with_index do |(*batch), index|
+          uri = LocalUri::URI.new(url)
+          uri.query.merge!(limit: DEFAULT_LIMIT)
+          uri.query.merge!(offset: DEFAULT_LIMIT * index) unless index.zero?
+          stub_request(:get, uri.to_s)
+            .with(options)
+            .to_return(
+              body: {
+                items: batch,
+                offset: index * DEFAULT_LIMIT,
+                total: items.length
+              }.to_json
+            )
+        end
+      end
+    end
+  end
+end

data/lib/lhs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LHS
-  VERSION = '19.8.2'
+  VERSION = '20.1.2'
 end

data/spec/dummy/app/controllers/extended_rollbar_controller.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+class ExtendedRollbarController < ApplicationController
+
+  def extended_rollbar
+    Record.where(color: 'blue').fetch
+    Record.where(color: 'red').fetch
+    raise "Let's see if rollbar logs information about what kind of requests where made around here!"
+  end
+end

data/spec/dummy/config/initializers/rollbar.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+if defined?(Rollbar)
+  Rollbar.configure do |config|
+    config.access_token = '12345'
+    config.enabled = true
+    config.before_process << LHS::Interceptors::ExtendedRollbar::Handler.init
+  end
+end

data/spec/dummy/config/routes.rb

@@ -16,4 +16,7 @@ Rails.application.routes.draw do
   # Option Blocks
   get 'option_blocks/first' => 'option_blocks#first'
   get 'option_blocks/second' => 'option_blocks#second'
+
+  # Extended Rollbar
+  get 'extended_rollbar' => 'extended_rollbar#extended_rollbar'
 end

data/spec/extended_rollbar_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe 'Extended Rollbar', type: :request do
+  let!(:records_request_1) do
+    stub_request(:get, "http://datastore/v2/records?color=blue").to_return(body: ['blue'].to_json)
+  end
+
+  let!(:records_request_2) do
+    stub_request(:get, "http://datastore/v2/records?color=red").to_return(body: ['red'].to_json)
+  end
+
+  let!(:rollbar_request) do
+    stub_request(:post, "https://api.rollbar.com/api/1/item/")
+      .with do |request|
+        json = JSON.parse request.body
+        message = "Let's see if rollbar logs information about what kind of requests where made around here!"
+        extra = {
+          lhs: [
+            {
+              request: {
+                params: { color: 'blue' },
+                url: 'http://datastore/v2/records',
+                headers: {
+                  'Content-Type' => 'application/json; charset=utf-8',
+                  'Accept' => 'application/json,application/vnd.api+json',
+                  'Accept-Charset' => 'utf-8'
+                }
+              },
+              response: { code: 200, body: '["blue"]' }
+            }, {
+              request: {
+                params: { color: 'red' },
+                url: 'http://datastore/v2/records',
+                headers: {
+                  'Content-Type' => 'application/json; charset=utf-8',
+                  'Accept' => 'application/json,application/vnd.api+json',
+                  'Accept-Charset' => 'utf-8'
+                }
+              },
+              response: { code: 200, body: '["red"]' }
+            }
+          ].to_json
+        }
+        json['access_token'] == '12345' &&
+          json['data']['level'] == 'error' &&
+          json['data']['body']['trace']['exception']['message'] == message &&
+          json['data']['body']['trace']['extra'].to_json == extra.to_json
+      end
+      .to_return(status: 200)
+  end
+
+  before do
+    LHC.configure do |config|
+      config.interceptors = [LHS::ExtendedRollbar]
+    end
+  end
+
+  it 'extends default rollbar logging by adding information about the requests made during a request/response cycle',
+  dummy_models: true, extended_rollbar: true do
+    get '/extended_rollbar'
+    expect(records_request_1).to have_been_requested
+    expect(records_request_2).to have_been_requested
+    expect(rollbar_request).to have_been_requested
+  end
+end

data/spec/rails_helper.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 ENV["RAILS_ENV"] ||= 'test'
+ENV['DUMMYAPP_PATH'] = "spec/dummy"
 
+require 'rails/rollbar_runner'
 require 'spec_helper'
 require File.expand_path("../dummy/config/environment", __FILE__)
 require 'rspec/rails'

data/spec/record/href_for_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe LHS::Record do
+  before do
+    class Record < LHS::Record
+      endpoint 'http://datastore/records/'
+      endpoint 'http://datastore/records/{id}'
+    end
+  end
+
+  context 'href_for' do
+
+    it 'injects variables and returns href' do
+      expect(Record.href_for(1)).to eq 'http://datastore/records/1'
+      expect(Record.href_for('vmasd241')).to eq 'http://datastore/records/vmasd241'
+    end
+
+    it 'also works with url_for (alias)' do
+      expect(Record.url_for(1)).to eq 'http://datastore/records/1'
+      expect(Record.url_for('vmasd241')).to eq 'http://datastore/records/vmasd241'
+    end
+  end
+end

data/spec/request_cycle_cache_spec.rb

@@ -37,7 +37,7 @@ describe 'Request Cycle Cache', type: :request do
     expect(lambda do
       get '/request_cycle_cache/no_caching_interceptor'
     end).to output(
-      %r{\[WARNING\] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
+      %r{\[WARNING\] Can't enable request cycle cache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
     ).to_stderr
     expect(request).to have_been_made.times(2)
   end
@@ -52,11 +52,11 @@ describe 'Request Cycle Cache', type: :request do
   it 'sets different uniq request ids as base for request cycle caching for different requests',
   dummy_models: true, request_cycle_cache: true do
     get '/request_cycle_cache/simple'
-    first_request_id = LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id
+    first_request_id = LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id
     second_request_id = nil
     thread = Thread.new do
       get '/request_cycle_cache/simple'
-      second_request_id = LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id
+      second_request_id = LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id
     end
     thread.join
     expect(first_request_id).not_to be_nil
@@ -70,7 +70,7 @@ describe 'Request Cycle Cache', type: :request do
       expect(lambda do
         get '/request_cycle_cache/no_caching_interceptor'
       end).not_to output(
-        %r{\[WARNING\] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
+        %r{\[WARNING\] Can't enable request cycle cache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
       ).to_stderr
       expect(request).to have_been_made.times(2)
     end

data/spec/stubs/all_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+require 'lhs/rspec'
+
+describe LHS do
+
+  before do
+    class Record < LHS::Record
+      endpoint 'https://records'
+    end
+
+    LHS.stub.all(
+      'https://records',
+      200.times.map { |index| { name: "Item #{index}" } },
+      headers: {
+        'Authorization' => 'Bearer 123'
+      }
+    )
+  end
+
+  it 'stubs all requests' do
+    records = Record.options(headers: { 'Authorization' => 'Bearer 123' }).all.fetch
+    expect(records.count).to eq 200
+    expect(records.length).to eq 200
+    expect(records.first.name).to eq 'Item 0'
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 19.8.2
+  version: 20.1.2
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-25 00:00:00.000000000 Z
+date: 2019-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.8.2
+- !ruby/object:Gem::Dependency
+  name: local_uri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -122,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.11
+- !ruby/object:Gem::Dependency
+  name: rollbar
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -252,6 +280,7 @@ files:
 - lib/lhs/concerns/record/find.rb
 - lib/lhs/concerns/record/find_by.rb
 - lib/lhs/concerns/record/first.rb
+- lib/lhs/concerns/record/href_for.rb
 - lib/lhs/concerns/record/last.rb
 - lib/lhs/concerns/record/mapping.rb
 - lib/lhs/concerns/record/merge.rb
@@ -260,13 +289,16 @@ files:
 - lib/lhs/concerns/record/provider.rb
 - lib/lhs/concerns/record/relations.rb
 - lib/lhs/concerns/record/request.rb
-- lib/lhs/concerns/record/request_cycle_cache/interceptor.rb
-- lib/lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry.rb
 - lib/lhs/concerns/record/scope.rb
 - lib/lhs/concerns/record/tracing.rb
 - lib/lhs/config.rb
 - lib/lhs/data.rb
 - lib/lhs/endpoint.rb
+- lib/lhs/interceptors/extended_rollbar/handler.rb
+- lib/lhs/interceptors/extended_rollbar/interceptor.rb
+- lib/lhs/interceptors/extended_rollbar/thread_registry.rb
+- lib/lhs/interceptors/request_cycle_cache/interceptor.rb
+- lib/lhs/interceptors/request_cycle_cache/thread_registry.rb
 - lib/lhs/item.rb
 - lib/lhs/pagination/base.rb
 - lib/lhs/pagination/link.rb
@@ -282,7 +314,8 @@ files:
 - lib/lhs/proxy.rb
 - lib/lhs/railtie.rb
 - lib/lhs/record.rb
-- lib/lhs/test/request_cycle_cache_helper.rb
+- lib/lhs/rspec.rb
+- lib/lhs/test/stub.rb
 - lib/lhs/unprocessable.rb
 - lib/lhs/version.rb
 - script/ci/build.sh
@@ -321,6 +354,7 @@ files:
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/concerns/.keep
 - spec/dummy/app/controllers/error_handling_with_chains_controller.rb
+- spec/dummy/app/controllers/extended_rollbar_controller.rb
 - spec/dummy/app/controllers/option_blocks_controller.rb
 - spec/dummy/app/controllers/request_cycle_cache_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
@@ -349,6 +383,7 @@ files:
 - spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/rollbar.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/locales/en.yml
@@ -361,6 +396,7 @@ files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
+- spec/extended_rollbar_spec.rb
 - spec/item/access_errors_spec.rb
 - spec/item/accessors_spec.rb
 - spec/item/add_error_spec.rb
@@ -427,6 +463,7 @@ files:
 - spec/record/handle_includes_errors_spec.rb
 - spec/record/has_many_spec.rb
 - spec/record/has_one_spec.rb
+- spec/record/href_for_spec.rb
 - spec/record/ignore_errors_spec.rb
 - spec/record/immutable_chains_spec.rb
 - spec/record/includes_all_spec.rb
@@ -465,6 +502,7 @@ files:
 - spec/request_cycle_cache_spec.rb
 - spec/require_lhs_spec.rb
 - spec/spec_helper.rb
+- spec/stubs/all_spec.rb
 - spec/support/fixtures/json/feedback.json
 - spec/support/fixtures/json/feedbacks.json
 - spec/support/fixtures/json/localina_content_ad.json
@@ -492,8 +530,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - Ruby >= 2.3.0
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: 'REST services accelerator: Rails gem providing an easy, active-record-like
@@ -533,6 +570,7 @@ test_files:
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/concerns/.keep
 - spec/dummy/app/controllers/error_handling_with_chains_controller.rb
+- spec/dummy/app/controllers/extended_rollbar_controller.rb
 - spec/dummy/app/controllers/option_blocks_controller.rb
 - spec/dummy/app/controllers/request_cycle_cache_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
@@ -561,6 +599,7 @@ test_files:
 - spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/rollbar.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/locales/en.yml
@@ -573,6 +612,7 @@ test_files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
+- spec/extended_rollbar_spec.rb
 - spec/item/access_errors_spec.rb
 - spec/item/accessors_spec.rb
 - spec/item/add_error_spec.rb
@@ -639,6 +679,7 @@ test_files:
 - spec/record/handle_includes_errors_spec.rb
 - spec/record/has_many_spec.rb
 - spec/record/has_one_spec.rb
+- spec/record/href_for_spec.rb
 - spec/record/ignore_errors_spec.rb
 - spec/record/immutable_chains_spec.rb
 - spec/record/includes_all_spec.rb
@@ -677,6 +718,7 @@ test_files:
 - spec/request_cycle_cache_spec.rb
 - spec/require_lhs_spec.rb
 - spec/spec_helper.rb
+- spec/stubs/all_spec.rb
 - spec/support/fixtures/json/feedback.json
 - spec/support/fixtures/json/feedbacks.json
 - spec/support/fixtures/json/localina_content_ad.json

data/lib/lhs/concerns/record/request_cycle_cache/interceptor.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-require 'active_support'
-
-class LHS::Record
-
-  module RequestCycleCache
-    extend ActiveSupport::Concern
-
-    class Interceptor < LHC::Interceptor
-
-      VERSION = 1
-      CACHED_METHODS = [:get].freeze
-
-      def before_request
-        request.options = request.options.merge({
-          cache: {
-            expires_in: 5.minutes,
-            race_condition_ttl: 5.seconds,
-            key: cache_key_for(request),
-            methods: CACHED_METHODS,
-            use: LHS.config.request_cycle_cache
-          }
-        }.merge(request.options))
-      end
-
-      private
-
-      def cache_key_for(request)
-        [
-          "LHS_REQUEST_CYCLE_CACHE(v#{VERSION})",
-          request.method.upcase,
-          [request.url, request.params.presence].compact.join('?'),
-          "REQUEST=#{LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id}",
-          "HEADERS=#{request.headers.hash}"
-        ].join(' ')
-      end
-    end
-  end
-end

data/lib/lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-require 'active_support'
-
-class LHS::Record
-
-  module RequestCycleCache
-    class RequestCycleThreadRegistry
-      # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
-      # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v5.
-      extend ActiveSupport::PerThreadRegistry
-      attr_accessor :request_id
-    end
-  end
-end

data/lib/lhs/test/request_cycle_cache_helper.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.configure do |config|
-  config.before(:each) do
-    LHS.config.request_cycle_cache.clear
-  end
-end