lhs 19.4.0 → 19.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eec02ca16e6732bb24ad68d18099937f48734dd000326fdfa07cd0365d3a0622
-  data.tar.gz: 2e327627fdd24ae4588499376847512ff76d514f90666cbb9115bdcecae0403a
+  metadata.gz: 0a07eb02cb34aed5f562ed302246c31eacf746e786ffaf74d61420897662c5f3
+  data.tar.gz: 2d74239dda28e2d769a43d238c77b1594285283c3b676265f76643ce17649965
 SHA512:
-  metadata.gz: b31fd1517f82df7b7d789888c2f878a9a9ce2f6ac6686b2193210f9a3c5d156f705852bac48974ae495dca7b6da374cec44dd3f0188cdea26891237c459465ea
-  data.tar.gz: cf095950ddf9e8e00369f73051b8350dc86e5d3922679d50121983f9414bd343eae85d3e1d44e5a768daa2ba4b2eb24bdbe33737230ecdd5d63ec9cf6b3cf52d
+  metadata.gz: 8dabe6d68096aaba06f5c397aafd9b67d48c73209b42604b8c3579d5000c3a380bb7d58377d2bae373f45dd8d3d3fb8d834293b39e233e5259f354c50d956435
+  data.tar.gz: 3389c1ddcbc753e23d4d73b4d93ab28da0d837df602b096b274041c671db1bd2252b2374439268e11c5b6e7d4577a8d2a745c20f290d489ac7f2c5ca6f0ba2d7

data/lib/lhs/item.rb

@@ -54,6 +54,6 @@ class LHS::Item < LHS::Proxy
     return _data unless _record.item_key
     nested_data = _data.dig(*_record.item_key)
     return _data unless nested_data
-    nested_data
+    LHS::Data.new(nested_data, _data._parent, _record, _data._request, _data._endpoint)
   end
 end

data/lib/lhs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LHS
-  VERSION = '19.4.0'
+  VERSION = '19.4.1'
 end

data/spec/record/item_key_spec.rb

@@ -11,7 +11,7 @@ describe LHS::Record do
     end
   end
 
-  let(:json_body) do
+  let(:location_response) do
     {
       response: {
         location: {
@@ -22,13 +22,13 @@ describe LHS::Record do
   end
 
   let(:stub_request_by_id) do
-    stub_request(:get, "http://uberall/location/1")
-      .to_return(body: json_body)
+    stub_request(:get, 'http://uberall/location/1')
+      .to_return(body: location_response)
   end
 
   let(:stub_request_by_get_parameters) do
-    stub_request(:get, "http://uberall/location?identifier=1&limit=1")
-      .to_return(body: json_body)
+    stub_request(:get, 'http://uberall/location?identifier=1&limit=1')
+      .to_return(body: location_response)
   end
 
   it 'uses configured item_key to unwrap response data for find' do
@@ -42,4 +42,40 @@ describe LHS::Record do
     location = Location.find_by(identifier: 1)
     expect(location.id).to eq 1
   end
+
+  describe 'Holding on to request object' do
+    let(:account_response) do
+      { id: 1 }.to_json
+    end
+
+    let(:stub_location_by_id) do
+      stub_request(:get, 'http://uberall/location/1')
+        .to_return(headers: { 'X-Custom-Header' => 'rspec' }, body: location_response)
+    end
+
+    let(:stub_account_by_id) do
+      stub_request(:get, 'http://yext/account/1')
+        .to_return(headers: { 'X-Custom-Header' => 'rspec' }, body: account_response)
+    end
+
+    before do
+      class Account < LHS::Record
+        endpoint 'http://yext/account'
+        endpoint 'http://yext/account/{id}'
+      end
+
+      stub_location_by_id
+      stub_account_by_id
+    end
+
+    it 'preserves request object for nested items' do
+      location = Location.find(1)
+      expect(location._request).to be_present
+    end
+
+    it 'preserves request object for unnested items' do
+      account = Account.find(1)
+      expect(account._request).to be_present
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 19.4.0
+  version: 19.4.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-19 00:00:00.000000000 Z
+date: 2019-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -480,7 +480,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.3.0
 rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: 'REST services accelerator: Rails gem providing an easy, active-record-like