lhs 16.1.1 → 16.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 040a79027ac392157392edd52aa521fb295de1e5a7dc9e6450c08c55bb0998a2
-  data.tar.gz: 9689bd2cd92b51ce3c74072077a8219a8c844514c2efcda4d119f43f621b98fc
+  metadata.gz: 07100d466b8e07fda10f73bf8b76c45eee3caf8d187221e919e8ea9fb32a795e
+  data.tar.gz: 92aa74f46a7f46df4d76c18b3ae9c6b57cc1aae8d6c55ae14c793acad5cd086a
 SHA512:
-  metadata.gz: b1a9e030f8741fe429bc56f43e48d9b694c1d7b7c3e296c7ec4b9d6cfdd3b123828dd115e9ac3371dc1ed0d01fc82cd029330422e8418d89053f9160c0fa8be4
-  data.tar.gz: 7503c74fe4756bb2086334253d06939f1ebc9a0b4cbfdadae460229c2ccc2243cba2acbf01c74593aaef0d81bcfc35937258ff360e05c9cf9262e9ba70861a03
+  metadata.gz: f31cbc7ea4f1b72c49aa5953a66857b0d8128ed7b6a521d3b61fe1f7eceb8f11c13e0a31bb69a069ab8db1fc758f6c9d367250bcecb09324c8899e331aed580d
+  data.tar.gz: 15be398c376a80e30ada0f68ad3be7bc1265525eeec7a911046b41c34aaf17f759299492574774f2c393132dae392b4a29b21ce73f81cbadf9aafd98444c21b3

data/lib/lhs/concerns/proxy/accessors.rb

@@ -13,6 +13,7 @@ class LHS::Proxy
     private
 
     def set(name, value)
+      clear_cache!
       key = name.to_s.gsub(/=$/, '')
       _data._raw[key.to_sym] = value
     end
@@ -76,10 +77,11 @@ class LHS::Proxy
       data = (value.is_a?(LHS::Data) || value.is_a?(LHS::Record)) ? value : LHS::Data.new(value, _data, _record, _request)
       data.errors = LHS::Problems::Nested::Errors.new(errors, name) if errors.any?
       data.warnings = LHS::Problems::Nested::Warnings.new(warnings, name) if warnings.any?
-      return data.becomes(record) if record && !value.is_a?(LHS::Record)
       if _record && _record._relations[name]
         klass = _record._relations[name][:record_class_name].constantize
         return cache.compute_if_absent(klass) { data.becomes(klass) }
+      elsif record && !value.is_a?(LHS::Record)
+        return data.becomes(record)
       end
       data
     end
@@ -111,5 +113,9 @@ class LHS::Proxy
     def cache
       @cache ||= Concurrent::Map.new
     end
+
+    def clear_cache!
+      @cache = nil
+    end
   end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = '16.1.1'
+  VERSION = '16.1.2'
 end

data/spec/record/has_one_spec.rb

@@ -10,7 +10,8 @@ describe LHS::Record do
       stub_request(:get, "http://myservice/transactions/#{id}")
         .to_return(body: {
           user: {
-            email_address: 'steve@local.ch'
+            email_address: 'steve@local.ch',
+            comments: []
           }
         }.to_json)
     end
@@ -26,11 +27,15 @@ describe LHS::Record do
       end
 
       class User < LHS::Record
+        has_many :comments
 
         def email
           self[:email_address]
         end
       end
+
+      class Comment < LHS::Record
+      end
     end
 
     it 'casts the relation into the correct type' do
@@ -43,11 +48,21 @@ describe LHS::Record do
       expect(user.parent._raw).to eq transaction._raw
     end
 
-    it 'the relation is cached in memory' do
-      object_id = transaction.user.object_id
-      expect(transaction.user.object_id).to eql(object_id)
+    it 'caches the relation in memory' do
+      allow(LHS::Record).to receive(:for_url).and_return(User)
+      user_object_id = transaction.user.object_id
+      expect(transaction.user.object_id).to eql(user_object_id)
       transaction2 = Transaction.find(2)
-      expect(transaction2.user.object_id).not_to eql(object_id)
+      expect(transaction2.user.object_id).not_to eql(user_object_id)
+    end
+
+    it 'recalculates cache for relation when it was modified' do
+      allow(LHS::Record).to receive(:for_url).and_return(Comment)
+      expect(user.comments).to be_blank
+      comments_object_id = user.comments.object_id
+      user.comments = [Comment.new]
+      expect(user.comments.object_id).not_to eql(comments_object_id)
+      expect(user.comments).not_to be_blank
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 16.1.1
+  version: 16.1.2
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors