lhs 16.0.1 → 16.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 519bda1b6733055661e7c322952675d1a8e05dc4b946314ccf84ec1fbcff7fe5
-  data.tar.gz: 9a8fca55ca2145b107872375e09244b0fa7bb9d54e18f193a627689cdeac1dc8
+  metadata.gz: 40c9a3c78d7e3f84b0652f9903eaba8b6f7312a7bd1b0e1a2f59100a6f296acb
+  data.tar.gz: a70e74d0de431175fe821751884d6b4eb60cc7e9bdd8c1237e906e41723c6b97
 SHA512:
-  metadata.gz: 8b34a119d3d592fc15ce1c0bf1bee4f4f6943ab043b34dc783e1c564f939bc5c6e0e13a092a61357a6cd31a9cba895103182cfadbf5bd61300c241c3ace77d23
-  data.tar.gz: 5318780360ec447fae0820747c6bc0b86a8f9c2a0b37d827a5086c391e1b160a68cd186380171630b2b915944a319577e7385ba535e06bcb2bb468c968f74ab8
+  metadata.gz: 8b5952d6ef6362ac7f9689a6c845469af65d8047228b267af4c28828adafdc776458af6a6562f395ae4dcc622b8462ef30f6b6e9c62a105a35ba9eb02f3d2b27
+  data.tar.gz: c554b8122c917cab6866bed3c081cebfc66d35971c10a085617fc0eec546d9e1e2542c7cfeae93400c1a07e4402398750317fcbd270f9b3d09a9bfe16f3eb9fe

data/README.md

@@ -2077,7 +2077,7 @@ In case an API does not provide pagination information in the repsponse data (li
 `find_each` is a more fine grained way to process single records that are fetched in batches.
 
 ```ruby
-Record.find_each(start: 50, batch_size: 20, params: { has_reviews: true }) do |record|
+Record.find_each(start: 50, batch_size: 20, params: { has_reviews: true }, headers: { 'Authorization': 'Bearer 123' }) do |record|
   # Iterates over each record. Starts with record no. 50 and fetches 20 records each batch.
   record
   break if record.some_attribute == some_value
@@ -2089,7 +2089,7 @@ end
 `find_in_batches` is used by `find_each` and processes batches.
 
 ```ruby
-Record.find_in_batches(start: 50, batch_size: 20, params: { has_reviews: true }) do |records|
+Record.find_in_batches(start: 50, batch_size: 20, params: { has_reviews: true }, headers: { 'Authorization': 'Bearer 123' }) do |records|
   # Iterates over multiple records (batch size is 20). Starts with record no. 50 and fetches 20 records each batch.
   records
   break if records.first.name == some_value

data/lib/lhs/concerns/record/batch.rb

@@ -19,11 +19,13 @@ class LHS::Record
       # Process batches of entries
       def find_in_batches(options = {})
         raise 'No block given' unless block_given?
-        start = options[:start] || 1
-        batch_size = options[:batch_size] || LHS::Pagination::Base::DEFAULT_LIMIT
-        params = options[:params] || {}
+        options = options.dup
+        start = options.delete(:start) || 1
+        batch_size = options.delete(:batch_size) || LHS::Pagination::Base::DEFAULT_LIMIT
         loop do # as suggested by Matz
-          data = request(params: params.merge(limit_key(:parameter) => batch_size, pagination_key(:parameter) => start))
+          options = options.dup
+          options[:params] = (options[:params] || {}).merge(limit_key(:parameter) => batch_size, pagination_key(:parameter) => start)
+          data = request(options)
           batch_size = data._raw.dig(*limit_key(:body))
           left = data._raw.dig(*total_key).to_i - data._raw.dig(*pagination_key(:body)).to_i - data._raw.dig(*limit_key(:body)).to_i
           yield new(data)

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = '16.0.1'
+  VERSION = '16.1.0'
 end

data/spec/record/find_each_spec.rb

@@ -41,5 +41,15 @@ describe LHS::Collection do
       end
       expect(count).to eq total
     end
+
+    it 'passes options to the requests made' do
+      request = stub_request(:get, "http://local.ch/v2/feedbacks?limit=100&offset=1")
+        .with(headers: { 'Authorization' => 'Bearer 123' })
+        .to_return(body: {
+          items: []
+        }.to_json)
+      Record.find_each(headers: { 'Authorization' => 'Bearer 123' }) { |record| }
+      expect(request).to have_been_made
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 16.0.1
+  version: 16.1.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-29 00:00:00.000000000 Z
+date: 2018-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel