lhs 10.0.0 → 10.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 728cf6034afb426a4b3fb40dd3a8dcdbffd3d004
-  data.tar.gz: 18872dbdb2fe63ea9b4dc1db69fd370f1499fce3
+  metadata.gz: 60b6bf77d4c64a170300990ecc6d783a3a63ddae
+  data.tar.gz: 84dbd1de5a4ce2010b04db5af5e75412d34e6823
 SHA512:
-  metadata.gz: 5d2733b6ee17ed421ab06af04d65c5bfd09f2cdee35f7fbd82bc04ea59152fb9977100b60a6143fa872a90039b589af19b187da48e2d80d5ccf20202278aa8ce
-  data.tar.gz: 11e83155ac46883623f321bf12da0357f709fddf3343feb225f2e1af1fadfb4847668f299f921c2a0900ac506c6c1040191f636269c261c3a76ef04acf49927a
+  metadata.gz: 2a793212e6532c238884005e278bf02e3c996ea78e3d72cdc007494af88d726e20f007d95e4b0d6f52199833d4e5878543c5eda0210dbae73ba92e5c39441352
+  data.tar.gz: e4afed4db96bf107f4a76cb2003679ac2fd27b2c34f11541cfd381ad884f53e4f487b4770d6e0b640c614a2bf27a57c6bb22f120998cb5edbad3579d9e6b7539

data/README.md

@@ -77,12 +77,12 @@ Some endpoints could respond a plain list of links without any expanded data. Li
 If you want to have LHS expand those items, use `expanded` as part of a Query-Chain:
 
 ```json
-  { 
+  {
     "items" : [
       {"href": "http://local.ch/customer/1/accounts/1"},
       {"href": "http://local.ch/customer/1/accounts/2"},
       {"href": "http://local.ch/customer/1/accounts/3"}
-    ] 
+    ]
   }
 end
 ```
@@ -99,7 +99,7 @@ You can also apply options to `expanded` in order to apply anything on the reque
 
 ## Chaining where statements
 
-LHS supports chaining where statements. 
+LHS supports chaining where statements.
 That allows you to chain multiple where-queries:
 
 ```ruby
@@ -170,7 +170,12 @@ record = Record.where(color: 'blue')
 
 ## Find single records
 
-`find` finds a unique record by uniqe identifier (usualy id).
+`find` finds a unique record by unique identifier (usualy id or href).
+
+```ruby
+  Record.find(123)
+  Record.find('https://api.example.com/records/123')
+```
 
 If no record is found an error is raised.
 
@@ -237,14 +242,14 @@ You can apply options to the request chain. Those options will be forwarded to t
 ```ruby
   # Authenticate with OAuth
   options = { auth: { bearer: '123456' } }
-  
+
   AuthenticatedRecord = Record.options(options)
-  
+
   blue_records = AuthenticatedRecord.where(color: 'blue')
   active_records = AuthenticatedRecord.where(active: true)
 
   AuthenticatedRecord.create(color: 'red')
-  
+
   record = AuthenticatedRecord.find(123)
   # Find resolves the current query and applies all options from the chain
   # All further requests are made from scratch and not based on the previous options
@@ -316,7 +321,7 @@ See [Validation](#Validation) for handling validation errors when creating recor
 ```ruby
   class Review < LHS::Record
     endpoint ':service/reviews'
-  end 
+  end
 
   class Comment < LHS::Record
     endpoint ':service/reviews/:review_id/comments'
@@ -396,7 +401,7 @@ Build and persist new items from scratch are done either with `new` or it's alia
 
 ## Custom setters and getters
 
-Sometimes it is the case that you want to have your custom getters and setters and convert the data to a processable format behind the scenes. 
+Sometimes it is the case that you want to have your custom getters and setters and convert the data to a processable format behind the scenes.
 The initializer will now use custom setter if one is defined:
 
 ```ruby
@@ -889,9 +894,9 @@ Example.find(1) # GET records/1
 
 ## Testing: How to write tests when using LHS
 
-[WebMock](https://github.com/bblimke/webmock)! 
+[WebMock](https://github.com/bblimke/webmock)!
 
-Best practice is to let LHS fetch your records and Webmock to stub/mock endpoints responses. 
+Best practice is to let LHS fetch your records and Webmock to stub/mock endpoints responses.
 This follows the [Black Box Testing](https://en.wikipedia.org/wiki/Black-box_testing) approach and prevents you from building up constraints to LHS' internal structures/mechanisms, which will break when we change internal things.
 LHS provides interfaces that result in HTTP requests, this is what you should test.
 

data/lib/lhs/concerns/record/find.rb

@@ -60,12 +60,19 @@ class LHS::Record
       end
 
       def request_options(args, options)
+        options ||= {}
         if args.is_a? Hash
-          (options || {}).merge(params: args)
+          options.merge(params: args)
+        elsif href?(args)
+          options.merge(url: args)
         else
-          (options || {}).merge(params: { id: args })
+          options.merge(params: { id: args })
         end
       end
+
+      def href?(str)
+        str.is_a?(String) && %r{^https?://}.match(str)
+      end
     end
   end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "10.0.0"
+  VERSION = "10.1.0"
 end

data/spec/record/find_spec.rb

@@ -14,12 +14,23 @@ describe LHS::Record do
   end
 
   context 'find' do
-    it 'finds a single unique record' do
-      stub_request(:get, "#{datastore}/feedbacks/z12f-3asm3ngals")
-        .to_return(status: 200, body: load_json(:feedback))
-      record = Record.find('z12f-3asm3ngals')
-      expect(record).to be_kind_of Record
-      expect(record.source_id).to be_kind_of String
+    context 'finds a single unique record' do
+      before(:each) do
+        stub_request(:get, "#{datastore}/feedbacks/z12f-3asm3ngals")
+          .to_return(status: 200, body: load_json(:feedback))
+      end
+
+      it 'by id' do
+        record = Record.find('z12f-3asm3ngals')
+        expect(record).to be_kind_of Record
+        expect(record.source_id).to be_kind_of String
+      end
+
+      it 'by href' do
+        record = Record.find("#{datastore}/feedbacks/z12f-3asm3ngals")
+        expect(record).to be_kind_of Record
+        expect(record.source_id).to be_kind_of String
+      end
     end
 
     it 'raises if nothing was found' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 10.0.0
+  version: 10.1.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-06 00:00:00.000000000 Z
+date: 2017-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -387,7 +387,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface for http json services