lhs 1.6.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 803f2217b1ffc03a2bc4616749a30488f3f22cec
-  data.tar.gz: b85d7cb23ca19ede404500f728361bb12ad3b6f1
+  metadata.gz: 911fecf1a1b1e1d5a011b185b4d6ba8fb63f7445
+  data.tar.gz: 24b82515d4cfe87227d949afe0cd23048962bce7
 SHA512:
-  metadata.gz: 53f23df937f8d461e4b9d416f6e8ceb2d846fccc8896ec4005e136bc3a7c16ebe03c202e702a0e4af563f024f403852d18be21a1a0f64ea317ba24da1636e6f4
-  data.tar.gz: 236dff73bd2c94a5bb3cd7d01989c5ff255ea81e68dc6670809d27e9f5c2ade9499a67eb7191b3d6ccaf5b3010c50c9163837c237d7c737df0af52f3efc719aa
+  metadata.gz: 43a4a6f1605313a18ce9f26e00aafa80e11530d99c2f52e3fab6bf26fd40a4e249af9ab87f854e76a4b335df26940deb27e1a5ad8bbdc39481bb9a0aa80ca46e
+  data.tar.gz: 66e736a905f730e2216fe676051f16436437c45e7ca1f393c0169e13204d511b3f44f3d8c2b66ef66f5fbd9024cf7046fd13f0dbd7920213538667ee13948bd4

data/docs/items.md

@@ -39,6 +39,7 @@ You can persist changes like you would usually do with `save`.
 ## Update
 
 `update` will return false if persisting fails. `update!` instead will an raise exception.
+Update always updates the data of the local object first, before it tries to sync with an endpoint.
 
 ```ruby
 feedback = Feedback.find('1z-5r1fkaj')

data/lib/lhs/concerns/item/update.rb

@@ -15,9 +15,14 @@ class LHS::Item < LHS::Proxy
 
     def update!(params)
       service = _data._root._service
-      data = _data._raw.dup
-      data = service.instance.request(method: :post, url: href, body: data.merge(params).to_json, headers: {'Content-Type' => 'application/json'})
-      self._data.merge_raw!(data)
+      _data.merge_raw!(LHS::Data.new(params))
+      response_data = service.instance.request(
+        method: :post,
+        url: href,
+        body: _data.to_json,
+        headers: {'Content-Type' => 'application/json'}
+      )
+      _data.merge_raw!(response_data)
       true
     end
   end

data/lib/lhs/data.rb

@@ -33,34 +33,6 @@ class LHS::Data
     _root._service
   end
 
-  def current_page
-    offset + 1
-  end
-
-  def first_page
-    1
-  end
-
-  def last_page
-    total_pages
-  end
-
-  def prev_page
-    current_page - 1
-  end
-
-  def next_page
-    current_page + 1
-  end
-
-  def limit_value
-    limit
-  end
-
-  def total_pages
-    total / limit
-  end
-
   protected
 
   # Use existing mapping to provide data

data/lib/lhs/item.rb

@@ -81,6 +81,6 @@ class LHS::Item < LHS::Proxy
   end
 
   def date_time_regex
-    /(?<date>\d{4}-\d{2}-\d{2})?(?<time>T\d{2}:\d{2}:\d{2}(\.\d*.\d{2}:\d{2})*)?/
+    /(?<date>\d{4}-\d{2}-\d{2})?(?<time>T\d{2}:\d{2}:\d{2}\.\d*.\d{2}:\d{2})?/
   end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "1.6.1"
+  VERSION = "2.0.0"
 end

data/spec/data/item_spec.rb

@@ -41,16 +41,4 @@ describe LHS::Data do
       expect(item.valid_from).to be_kind_of Date
     end
   end
-
-  context 'different date time formats' do
-    let(:item) do
-      item = data[0]
-      item._raw[:created_date] = '2016-07-09T13:45:00+00:00'
-      item
-    end
-
-    it 'returns TimeWithZone if string can be parsed as date_time' do
-      expect(item.created_date).to be_kind_of ActiveSupport::TimeWithZone
-    end
-  end
 end

data/spec/item/update_spec.rb

@@ -38,10 +38,18 @@ describe LHS::Item do
 
     it 'merges reponse data with object' do
       stub_request(:post, item.href)
-      .to_return(status: 200, body: item._raw.merge(likes: 'Banana').to_json)
+        .to_return(status: 200, body: item._raw.merge(likes: 'Banana').to_json)
       item.update(name: 'Steve')
       expect(item.likes).to eq 'Banana'
     end
+
+    it 'updates local version of an object even if BE request fails' do
+      stub_request(:post, item.href)
+        .to_return(status: 400, body: item._raw.merge(likes: 'Banana').to_json)
+      item.update(name: 'Andrea')
+      expect(item.name).to eq 'Andrea'
+      expect(item.likes).to_not eq 'Banana'
+    end
   end
 
   context 'update!' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 2.0.0
 platform: ruby
 authors:
 - local.ch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-23 00:00:00.000000000 Z
+date: 2015-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -167,7 +167,6 @@ files:
 - spec/data/collection_spec.rb
 - spec/data/item_spec.rb
 - spec/data/merge_spec.rb
-- spec/data/pagination_spec.rb
 - spec/data/raw_spec.rb
 - spec/data/respond_to_spec.rb
 - spec/data/root_spec.rb
@@ -280,7 +279,6 @@ test_files:
 - spec/data/collection_spec.rb
 - spec/data/item_spec.rb
 - spec/data/merge_spec.rb
-- spec/data/pagination_spec.rb
 - spec/data/raw_spec.rb
 - spec/data/respond_to_spec.rb
 - spec/data/root_spec.rb

data/spec/data/pagination_spec.rb

@@ -1,60 +0,0 @@
-require 'rails_helper'
-
-describe LHS::Data do
-  context 'pagination' do
-    let(:datastore) { 'http://local.ch/v2' }
-    let(:record) { Feedback.where(entry_id: 1) }
-    let(:total) { 200 }
-    let(:total_pages) { total / limit }
-    let(:current_page) { offset + 1 }
-    let(:prev_page) { current_page - 1 }
-    let(:next_page) { current_page + 1 }
-    let(:offset) { 0 }
-    let(:limit) { 10 }
-    let(:body_json) do
-      {
-        items: [],
-        total: total,
-        offset: offset,
-        limit: limit
-      }.to_json
-    end
-
-    before(:each) do
-      LHC.config.placeholder('datastore', datastore)
-      class Feedback < LHS::Service
-        endpoint ':datastore/feedbacks'
-      end
-      stub_request(:get, 'http://local.ch/v2/feedbacks?entry_id=1')
-        .to_return(body: body_json)
-    end
-
-    it 'responds to limit_value' do
-      expect(record.limit_value).to eq(limit)
-    end
-
-    it 'responds to total_pages' do
-      expect(record.total_pages).to eq(total_pages)
-    end
-
-    it 'responds to current_page' do
-      expect(record.current_page).to eq(current_page)
-    end
-
-    it 'responds to first_page' do
-      expect(record.first_page).to eq(1)
-    end
-
-    it 'responds to last_page' do
-      expect(record.last_page).to eq(total_pages)
-    end
-
-    it 'responds to prev_page' do
-      expect(record.prev_page).to eq(prev_page)
-    end
-
-    it 'responds to next_page' do
-      expect(record.next_page).to eq(next_page)
-    end
-  end
-end