lhs 0.3.0

data/spec/item/save_errors_spec.rb

@@ -0,0 +1,48 @@
+require 'rails_helper'
+
+describe LHS::Item do
+
+  context 'save failed' do
+
+    let(:datastore) { 'http://datastore-stg.lb-service.sunrise.intra.local.ch/v2' }
+
+    before(:each) do
+      LHC.config.placeholder(:datastore, datastore)
+      class SomeService < LHS::Service
+        endpoint ':datastore/:campaign_id/feedbacks'
+        endpoint ':datastore/feedbacks'
+      end
+    end
+
+    let(:save_error) do
+      {
+        "status" => 400,
+        "message" => "ratings must be set when review or name or review_title is set | The property value is required; it cannot be null, empty, or blank.",
+        "fields" => [
+          {
+            "name" => "ratings",
+            "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
+          },{
+            "name" => "recommended",
+            "details" => [{"code" => "REQUIRED_PROPERTY_VALUE"}]
+          }
+        ]
+      }
+    end
+
+    it 'provides errors when creation failed' do
+      stub_request(:post, "#{datastore}/feedbacks")
+      .to_return(status: 400, body: save_error.to_json)
+      record = SomeService.build
+      record.name = 'Steve'
+      result = record.save
+      expect(result).to eq false
+      expect(record.errors).to be
+      expect(record.name).to eq 'Steve'
+      expect(record.errors.include?(:ratings)).to eq true
+      expect(record.errors.include?(:recommended)).to eq true
+      expect(record.errors[:ratings]).to eq ['REQUIRED_PROPERTY_VALUE']
+      expect(record.errors[:recommended]).to eq ['REQUIRED_PROPERTY_VALUE']
+    end
+  end
+end

data/spec/item/save_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+describe LHS::Item do
+
+  before(:each) do
+    class SomeService < LHS::Service
+      endpoint ':datastore/v2/:campaign_id/feedbacks'
+      endpoint ':datastore/v2/feedbacks'
+    end
+  end
+
+  let(:json) do
+    load_json(:feedbacks)
+  end
+
+  let(:data) do
+    LHS::Data.new(json, nil, SomeService)
+  end
+
+  let(:item) do
+    data[0]
+  end
+
+  context 'save' do
+
+    it 'persists changes on the backend' do
+      stub_request(:post, item.href)
+      .with(body: item._raw.merge(name: 'Steve').to_json)
+      item.name = 'Steve'
+      expect(item.save).to eq true
+    end
+
+    it 'returns false if persting goes wrong' do
+      stub_request(:post, item.href)
+      .with(body: item._raw.to_json)
+      .to_return(status: 500)
+      expect(item.save).to eq false
+    end
+
+    it 'merges reponse data with object' do
+      stub_request(:post, item.href)
+      .with(body: item._raw.to_json)
+      .to_return(status: 200, body: item._raw.merge(name: 'Steve').to_json)
+      item.save
+      expect(item.name).to eq 'Steve'
+    end
+  end
+
+  context 'save!' do
+
+    it 'raises if something goes wrong' do
+      stub_request(:post, item.href)
+      .with(body: item._raw.to_json)
+      .to_return(status: 500)
+      expect(->{ item.save! }).to raise_error LHC::ServerError
+    end
+  end
+end

data/spec/item/setter_spec.rb

@@ -0,0 +1,38 @@
+require 'rails_helper'
+
+describe LHS::Item do
+
+  before(:each) do
+    class SomeService < LHS::Service
+      endpoint ':datastore/v2/:campaign_id/feedbacks'
+      endpoint ':datastore/v2/feedbacks'
+    end
+  end
+
+  let(:json) do
+    load_json(:feedbacks)
+  end
+
+  let(:data) do
+    LHS::Data.new(json, nil, SomeService)
+  end
+
+  let(:item) do
+    data[0]
+  end
+
+  context 'item setter' do
+
+    it 'sets the value for an existing attribute' do
+      expect(item.name = 'Steve').to eq 'Steve'
+      expect(item.name).to eq 'Steve'
+      expect(item._raw['name']).to eq 'Steve'
+    end
+
+    it 'sets things to nil' do
+      item.name = 'Steve'
+      expect(item.name = nil).to eq nil
+      expect(item.name).to eq nil
+    end
+  end
+end

data/spec/item/update_spec.rb

@@ -0,0 +1,56 @@
+require 'rails_helper'
+
+describe LHS::Item do
+
+  before(:each) do
+    class SomeService < LHS::Service
+      endpoint ':datastore/v2/:campaign_id/feedbacks'
+      endpoint ':datastore/v2/feedbacks'
+    end
+  end
+
+  let(:json) do
+    load_json(:feedbacks)
+  end
+
+  let(:data) do
+    LHS::Data.new(json, nil, SomeService)
+  end
+
+  let(:item) do
+    data[0]
+  end
+
+  context 'update' do
+
+    it 'persists changes on the backend' do
+      stub_request(:post, item.href)
+      .with(body: item._raw.merge(name: 'Steve').to_json)
+      result = item.update(name: 'Steve')
+      expect(result).to eq true
+    end
+
+    it 'returns false if persisting went wrong' do
+      stub_request(:post, item.href).to_return(status: 500)
+      result = item.update(name: 'Steve')
+      expect(result).to eq false
+    end
+
+    it 'merges reponse data with object' do
+      stub_request(:post, item.href)
+      .to_return(status: 200, body: item._raw.merge(likes: 'Banana').to_json)
+      item.update(name: 'Steve')
+      expect(item.likes).to eq 'Banana'
+    end
+  end
+
+  context 'update!' do
+
+    it 'raises if something goes wrong' do
+      stub_request(:post, item.href)
+      .with(body: item._raw.merge(name: 'Steve').to_json)
+      .to_return(status: 500)
+      expect(->{ item.update!(name: 'Steve') }).to raise_error LHC::ServerError
+    end
+  end
+end

data/spec/proxy/load_spec.rb

@@ -0,0 +1,47 @@
+require 'rails_helper'
+
+describe LHS::Proxy do
+
+  before(:each) do
+    class SomeService < LHS::Service
+      endpoint ':datastore/v2/feedbacks'
+    end
+  end
+
+  let(:json) do
+    load_json(:feedbacks)
+  end
+
+  let(:data) do
+    LHS::Data.new(json, nil, SomeService)
+  end
+
+  let(:item) do
+    data[0]
+  end
+
+  let(:link) do
+    item.campaign
+  end
+
+  before(:each) do
+    stub_request(:get, 'http://datastore-stg.lb-service.sunrise.intra.local.ch/v2/content-ads/51dfc5690cf271c375c5a12d')
+      .to_return(status: 200, body: load_json(:localina_content_ad))
+  end
+
+  context 'load' do
+
+    it 'is loading data remotely when not present yet' do
+      link.load!.id
+    end
+
+    it 'can be reloaded' do
+      link.load!.id
+      stub_request(:get, 'http://datastore-stg.lb-service.sunrise.intra.local.ch/v2/content-ads/51dfc5690cf271c375c5a12d')
+        .to_return(status: 404)
+      link.load!.id
+      expect(-> { link.reload!.id })
+        .to raise_error LHC::NotFound
+    end
+  end
+end

data/spec/rails_helper.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+require File.expand_path("../dummy/config/environment", __FILE__)
+require 'rspec/rails'
+
+ENV["RAILS_ENV"] ||= 'test'
+
+RSpec.configure do |config|
+  config.infer_spec_type_from_file_location!
+end

data/spec/service/all_spec.rb

@@ -0,0 +1,31 @@
+require 'rails_helper'
+
+describe LHS::Collection do
+
+  let(:datastore) { 'http://datastore-stg.lb-service.sunrise.intra.local.ch/v2' }
+
+  before(:each) do
+    LHC.config.placeholder('datastore', datastore)
+    class SomeService < LHS::Service
+      endpoint ':datastore/:campaign_id/feedbacks'
+      endpoint ':datastore/feedbacks'
+    end
+  end
+
+  context 'all' do
+
+    it 'fetches all records from the backend' do
+      stub_request(:get, "#{datastore}/feedbacks?limit=100")
+      .to_return(status: 200, body: {items: (1..100).to_a, total: 300, limit: 100, offset: 0}.to_json)
+      stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=101")
+      .to_return(status: 200, body: {items: (101..200).to_a, total: 300, limit: 100, offset: 101}.to_json)
+      stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=201")
+      .to_return(status: 200, body: {items: (201..300).to_a, total: 300, limit: 100, offset: 201}.to_json)
+      all = SomeService.all
+      expect(all).to be_kind_of LHS::Data
+      expect(all._proxy).to be_kind_of LHS::Collection
+      expect(all.count).to eq 300
+      expect(all[299]).to eq 300
+    end
+  end
+end

data/spec/service/build_spec.rb

@@ -0,0 +1,25 @@
+require 'rails_helper'
+
+describe LHS::Service do
+
+  context 'new' do
+
+    let(:datastore) { 'http://datastore-stg.lb-service.sunrise.intra.local.ch/v2' }
+
+    before(:each) do
+      LHC.config.placeholder('datastore', datastore)
+      class Feedback < LHS::Service
+        endpoint ':datastore/content-ads/:campaign_id/feedbacks'
+        endpoint ':datastore/feedbacks'
+      end
+    end
+
+    it 'builds a new item from scratch' do
+      feedback = Feedback.build recommended: true
+      expect(feedback.recommended).to eq true
+      stub_request(:post, "http://datastore-stg.lb-service.sunrise.intra.local.ch/v2/feedbacks")
+      .with(body: "{\"recommended\":true}")
+      feedback.save
+    end
+  end
+end

data/spec/service/create_spec.rb

@@ -0,0 +1,81 @@
+require 'rails_helper'
+
+describe LHS::Service do
+
+  context 'create' do
+
+    let(:datastore) { 'http://datastore-stg.lb-service.sunrise.intra.local.ch/v2' }
+
+    before(:each) do
+      LHC.config.placeholder('datastore', datastore)
+      class Feedback < LHS::Service
+        endpoint ':datastore/content-ads/:campaign_id/feedbacks'
+        endpoint ':datastore/feedbacks'
+      end
+    end
+
+    let(:object) do
+      {
+        recommended: true,
+        source_id: 'aaa'
+      }
+    end
+
+    it 'creates new record on the backend' do
+      stub_request(:post, "#{datastore}/feedbacks")
+      .with(body: object.to_json)
+      .to_return(status: 200, body: object.to_json)
+      record = Feedback.create(object)
+      expect(record.recommended).to eq true
+      expect(record.errors).to eq nil
+    end
+
+    it 'uses proper endpoint when creating data' do
+      stub_request(:post, "#{datastore}/content-ads/12345/feedbacks")
+      .with(body: object.to_json)
+      .to_return(status: 200, body: object.to_json)
+      Feedback.create(object.merge(campaign_id: '12345'))
+    end
+
+    it 'merges backend response object with object' do
+      body = object.merge(additional_key: 1)
+      stub_request(:post, "#{datastore}/content-ads/12345/feedbacks")
+      .with(body: object.to_json)
+      .to_return(status: 200, body: body.to_json)
+      data = Feedback.create(object.merge(campaign_id: '12345'))
+      expect(data.additional_key).to eq 1
+    end
+
+    context 'creation errors' do
+      let(:creation_error) do
+        {
+          "status" => 400,
+          "fields" => [
+            {
+              "name" => "ratings",
+              "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
+              },{
+              "name" => "recommended",
+              "details" => [{"code" => "REQUIRED_PROPERTY_VALUE"}]
+            }
+          ]
+        }
+      end
+
+      it 'provides errors accessor on the record when creation failed using create' do
+        stub_request(:post, "#{datastore}/content-ads/12345/feedbacks")
+        .to_return(status: 400, body: creation_error.to_json)
+        feedback = Feedback.create(object.merge(campaign_id: '12345'))
+        expect(feedback.errors).to be_kind_of LHS::Errors
+      end
+
+      it 'raises an exception when creation failed using create!' do
+        stub_request(:post, "#{datastore}/content-ads/12345/feedbacks")
+        .to_return(status: 400, body: creation_error.to_json)
+        expect(->{
+          Feedback.create!(object.merge(campaign_id: '12345'))
+        }).to raise_error
+      end
+    end
+  end
+end

data/spec/service/creation_failed_spec.rb

@@ -0,0 +1,54 @@
+require 'rails_helper'
+
+describe LHS::Service do
+
+  context 'creation failed' do
+
+    let(:datastore) { 'http://datastore-stg.lb-service.sunrise.intra.local.ch/v2' }
+
+    before(:each) do
+      LHC.config.placeholder(:datastore, datastore)
+      class SomeService < LHS::Service
+        endpoint ':datastore/:campaign_id/feedbacks'
+        endpoint ':datastore/feedbacks'
+      end
+    end
+
+    let(:error_message) { "ratings must be set when review or name or review_title is set | The property value is required; it cannot be null, empty, or blank." }
+
+    let(:creation_error) do
+      {
+        "status" => 400,
+        "message" => error_message,
+        "fields" => [
+          {
+            "name" => "ratings",
+            "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
+          },{
+            "name" => "recommended",
+            "details" => [{"code" => "REQUIRED_PROPERTY_VALUE"}]
+          }
+        ]
+      }
+    end
+
+    it 'provides errors when creation failed' do
+      stub_request(:post, "#{datastore}/feedbacks")
+      .to_return(status: 400, body: creation_error.to_json)
+      record = SomeService.create(name: 'Steve')
+      expect(record.errors).to be
+      expect(record.name).to eq 'Steve'
+      expect(record.errors.include?(:ratings)).to eq true
+      expect(record.errors.include?(:recommended)).to eq true
+      expect(record.errors[:ratings]).to eq ['REQUIRED_PROPERTY_VALUE']
+      expect(record.errors.messages).to eq({:ratings=>["REQUIRED_PROPERTY_VALUE"], :recommended=>["REQUIRED_PROPERTY_VALUE"]})
+      expect(record.errors.message).to eq error_message
+    end
+
+    it 'doesnt fail when no fields are provided by the backend' do
+      stub_request(:post, "#{datastore}/feedbacks")
+      .to_return(status: 400, body: {}.to_json)
+      SomeService.create(name: 'Steve')
+    end
+  end
+end