lhm 2.1.0 → 2.2.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZWY5MTRiZmFmYTBkNzg0NDhhNjM1MjBlOGM5OWQ1YTljMTkzOTYxOQ==
-  data.tar.gz: !binary |-
-    MjE3ODI5NDk3MjUxNmRlNzFkN2ZmYTVmZjZmNWM1OTk3MzA1N2NiNA==
+SHA1:
+  metadata.gz: dea357ff2aae21b2cee84cc6d546aa2328fd6164
+  data.tar.gz: b6b3e4b06ed6f7ea1b14ac2be2444cc8b6357966
 SHA512:
-  metadata.gz: !binary |-
-    MjBlNGMyNjllMDU5Y2ZmY2E0MjQwOWY0YzIzODk5YjQ0ZDAxOWVlMjU2OTA0
-    ZWUxYmJmMzFiYzg1MTMzNmMzYzI5OWU3Y2M2MjBmOTQ3MzllZjA5MmViMGNh
-    MzQ5NmM0YzVmZGMxZWQ3NzdiNmIxMzI1MGE2ZDM0MTU4NGU1NjQ=
-  data.tar.gz: !binary |-
-    ZmFlNTRkMDkyOWJlOTkzZjA2ZTdiNjA1MGNjZWVjODNiMGY3OWE1MWY2YmVk
-    ZWFmZGFhMGJhODNjNGVjZGE1NmQyZWRjMTg5NzBkZDY5NWMxNDJmNWE2NTU3
-    ODc4MmYxMWRmODM5NDdiNTRkNmVlMGQwZTEzNmE5MzM4YzlhMzY=
+  metadata.gz: a4a2e08f68b46ba6141bd37093f3c5341488c60d4a1bf6069b1339481f11ff1117ebe1198a383e09f1ae635d68966e98256d31a981ff89171eb582fd7b075170
+  data.tar.gz: 49174830b37493a1652394a4ee717f52939675d39289bc183f38969ae840cc5c9f00b5668d585888751916e395f471a3f24501192c8bf52cd3321d1c9d50dc32

data/.rubocop.yml

@@ -0,0 +1,256 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-01-12 14:49:41 +0100 using RuboCop version 0.26.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Enabled: false
+
+# Offense count: 1
+Lint/ConditionPosition:
+  Enabled: false
+
+# Offense count: 1
+Lint/HandleExceptions:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+# Offense count: 4
+Lint/UselessAssignment:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 131
+
+# Offense count: 3
+Metrics/CyclomaticComplexity:
+  Max: 19
+
+# Offense count: 77
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 197
+
+# Offense count: 11
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 27
+
+# Offense count: 3
+Metrics/PerceivedComplexity:
+  Max: 15
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/AccessModifierIndentation:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/AlignParameters:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/AndOr:
+  Enabled: false
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/BarePercentLiterals:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Blocks:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+# Offense count: 5
+Style/ClassVars:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredMethods.
+Style/CollectionMethods:
+  Enabled: false
+
+# Offense count: 24
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 28
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/DotPosition:
+  Enabled: false
+
+# Offense count: 4
+Style/DoubleNegation:
+  Enabled: false
+
+# Offense count: 1
+Style/EachWithObject:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: Exclude.
+Style/FileName:
+  Enabled: false
+
+# Offense count: 11
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/FormatString:
+  Enabled: false
+
+# Offense count: 10
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Enabled: false
+
+# Offense count: 9
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Enabled: false
+
+# Offense count: 88
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/HashSyntax:
+  Enabled: false
+
+# Offense count: 3
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Offense count: 14
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/IndentHash:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IndentationConsistency:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IndentationWidth:
+  Enabled: false
+
+# Offense count: 2
+Style/ModuleFunction:
+  Enabled: false
+
+# Offense count: 2
+Style/MultilineBlockChain:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/NegatedIf:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/NumericLiterals:
+  MinDigits: 8
+
+# Offense count: 14
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/RaiseArgs:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Enabled: false
+
+# Offense count: 1
+Style/RescueModifier:
+  Enabled: false
+
+# Offense count: 1
+Style/SelfAssignment:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/SignalException:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
+Style/SpaceInsideHashLiteralBraces:
+  SupportedStyles: space
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/SpecialGlobalVars:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
+Style/TrivialAccessors:
+  Enabled: false
+
+# Offense count: 15
+# Cop supports --auto-correct.
+Style/UnneededPercentQ:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/WordArray:
+  MinSize: 2
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowSafeAssignment.
+Style/ParenthesesAroundCondition:
+  Enabled: false

data/.travis.yml

@@ -4,10 +4,9 @@ before_script:
 rvm:
   - 1.9.3
   - 2.0.0
-  - 2.1.1
+  - 2.1
+sudo: false
 matrix:
-  allow_failures:
-    - gemfile: gemfiles/ar-2.3_mysql.gemfile
   fast_finish: true
 gemfile:
   - gemfiles/ar-2.3_mysql.gemfile

data/CHANGELOG.md

@@ -1,3 +1,24 @@
+# 2.2.0 (not released)
+
+* #84 - Require index names to be strings or symbols (Thibaut)
+* #39 - Adding the ability to rename columns (erikogan)
+* #67 - Allow for optional time filter on .cleanup (joelr)
+
+# 2.1.0
+
+* #48 - Add percentage output for migrations (@arthurnn)
+* #60 - Quote table names (@spickermann)
+* #59 - Escape table name in select_limit and select_start methods (@stevehodgkiss)
+* #57 - Ensure chunking 'where' clause handled separately (@rentalcustard)
+* #54 - Chunker handle stride changes (@rentalcustard)
+* #52 - Implement ability to control timeout and stride from Throttler (@edmundsalvacion)
+* #51 - Ensure Lhm.cleanup removes temporary triggers (@edmundsalvacion)
+* #46 - Allow custom throttler (@arthurnn)
+
+# 2.0.0
+
+* #44 - Conditional migrations (@durran)
+
 # 1.3.0 (May 28, 2013)
 
 * Add Lhm.cleanup method for removing copy tables, thanks @bogdan

data/README.md

@@ -45,15 +45,13 @@ the [twitter solution][2], it does not require the presence of an indexed
 Lhm currently only works with MySQL databases and requires an established
 ActiveRecord or DataMapper connection.
 
-It is compatible and [continuously tested][4] with MRI 1.9.x,
+It is compatible and [continuously tested][4] with MRI 1.9.x, 2.0.x, 2.1.x,
 ActiveRecord 2.3.x and 3.x (mysql and mysql2 adapters), as well as DataMapper
 1.2 (dm-mysql-adapter).
 
 Lhm also works with dm-master-slave-adapter, it'll bind to the master before
 running the migrations.
 
-The test suite is also run against MRI 2.0.0 in Continuous Integration, but
-there are a few bugs left to fix.
 
 ## Limitations
 
@@ -141,6 +139,23 @@ end
 **Note:** Lhm won't delete the old, leftover table. This is on purpose, in order
 to prevent accidental data loss.
 
+## Throttler
+
+Lhm is using a throttle mecanism to read data in your original table.
+
+By default, 40000 rows are read each 0.1 second.
+
+If you want to change that behiavour, you can pass an instance of a throttler with the `throttler` option.
+
+In this example, 1000 rows will be read with a 10 seconds delay between each processing:
+```ruby
+my_throttler = Lhm::Throttler::Time.new(stride: 1000, delay: 10)
+
+Lhm.change_table :users, throttler: my_throttler  do |m|
+  #
+end
+```
+
 ## Table rename strategies
 
 There are two different table rename strategies available: LockedSwitcher and
@@ -198,6 +213,18 @@ To remove any Lhm tables/triggers found:
 Lhm.cleanup(true)
 ```
 
+Optionally only remove tables up to a specific Time, if you want to retain previous migrations.
+
+Rails:
+```ruby
+Lhm.cleanup(true, until: 1.day.ago)
+```
+
+Ruby:
+```ruby
+Lhm.cleanup(true, until: Time.now - 86400)
+```
+
 ## Contributing
 
 First, get set up for local development:

data/Rakefile

@@ -3,14 +3,14 @@ require 'bundler'
 
 Bundler::GemHelper.install_tasks
 
-Rake::TestTask.new("unit") do |t|
+Rake::TestTask.new('unit') do |t|
   t.libs << 'lib'
   t.libs << 'spec'
   t.test_files = FileList['spec/unit/*_spec.rb']
   t.verbose = true
 end
 
-Rake::TestTask.new("integration") do |t|
+Rake::TestTask.new('integration') do |t|
   t.libs << 'lib'
   t.libs << 'spec'
   t.test_files = FileList['spec/integration/*_spec.rb']

data/bin/lhm-config.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+if [ -z ${LHM_TEST_CONFIG+x} ] ; then
+  source $HOME/.lhm
+else
+  source $LHM_TEST_CONFIG
+fi

data/bin/lhm-kill-queue

@@ -6,7 +6,6 @@ require 'optparse'
 
 module Lhm
   class KillQueue
-
     def initialize
       @port = 3306
       @grace = 10
@@ -14,20 +13,20 @@ module Lhm
       @marker = "%#{ SqlHelper.annotation }%"
 
       OptionParser.new do |opts|
-        opts.on("-h", "--hostname HOSTNAME") { |v| @hostname = v }
-        opts.on("-u", "--username USERNAME") { |v| @username = v }
-        opts.on("-p", "--password PASSWORD") { |v| @password = v }
-        opts.on("-d", "--database DATABASE") { |v| @database = v }
-        opts.on("-m", "--mode MODE") { |v| @mode = v.to_sym }
-        opts.on("-y", "--confirm") { |v| @confirm = true }
+        opts.on('-h', '--hostname HOSTNAME') { |v| @hostname = v }
+        opts.on('-u', '--username USERNAME') { |v| @username = v }
+        opts.on('-p', '--password PASSWORD') { |v| @password = v }
+        opts.on('-d', '--database DATABASE') { |v| @database = v }
+        opts.on('-m', '--mode MODE') { |v| @mode = v.to_sym }
+        opts.on('-y', '--confirm') { |v| @confirm = true }
       end.parse!
 
-      unless(@hostname && @username && @password && @database)
+      unless (@hostname && @username && @password && @database)
         abort usage
       end
 
-      unless([:kill, :master, :slave].include?(@mode))
-        abort "specify -m kill OR -m master OR -m slave"
+      unless ([:kill, :master, :slave].include?(@mode))
+        abort 'specify -m kill OR -m master OR -m slave'
       end
 
       connect
@@ -73,7 +72,7 @@ module Lhm
       sleep(@grace + @tiny)
 
       [list_non_lhm].flatten.each do |process|
-        if(select?(process))
+        if (select?(process))
           kill_process(process)
           sleep(@tiny)
         end
@@ -115,11 +114,11 @@ module Lhm
     def kill_process(process_id)
       puts "killing #{ select_statement(process_id) }"
 
-      if(@confirm)
+      if (@confirm)
         print "confirm ('y' to confirm): "
 
-        if(gets.strip != 'y')
-          puts "skipped."
+        if (gets.strip != 'y')
+          puts 'skipped.'
           return
         end
       end
@@ -169,4 +168,3 @@ end
 
 killer = Lhm::KillQueue.new
 killer.run
-