lhm 2.1.0 → 2.2.0

data/spec/unit/migrator_spec.rb

@@ -10,125 +10,137 @@ describe Lhm::Migrator do
   include UnitHelper
 
   before(:each) do
-    @table = Lhm::Table.new("alt")
+    @table = Lhm::Table.new('alt')
     @creator = Lhm::Migrator.new(@table)
   end
 
-  describe "index changes" do
-    it "should add an index" do
+  describe 'index changes' do
+    it 'should add an index' do
       @creator.add_index(:a)
 
       @creator.statements.must_equal([
-        "create index `index_alt_on_a` on `lhmn_alt` (`a`)"
+        'create index `index_alt_on_a` on `lhmn_alt` (`a`)'
       ])
     end
 
-    it "should add a composite index" do
+    it 'should add a composite index' do
       @creator.add_index([:a, :b])
 
       @creator.statements.must_equal([
-        "create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`, `b`)"
+        'create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`, `b`)'
       ])
     end
 
-    it "should add an index with prefix length" do
-      @creator.add_index(["a(10)", "b"])
+    it 'should add an index with prefix length' do
+      @creator.add_index(['a(10)', 'b'])
 
       @creator.statements.must_equal([
-        "create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(10), `b`)"
+        'create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(10), `b`)'
       ])
     end
 
-    it "should add an index with a custom name" do
+    it 'should add an index with a custom name' do
       @creator.add_index([:a, :b], :custom_index_name)
 
       @creator.statements.must_equal([
-        "create index `custom_index_name` on `lhmn_alt` (`a`, `b`)"
+        'create index `custom_index_name` on `lhmn_alt` (`a`, `b`)'
       ])
     end
 
-    it "should add a unique index" do
-      @creator.add_unique_index(["a(5)", :b])
+    it 'should raise an error when the index name is not a string or symbol' do
+      assert_raises ArgumentError do
+        @creator.add_index([:a, :b], :name => :custom_index_name)
+      end
+    end
+
+    it 'should add a unique index' do
+      @creator.add_unique_index(['a(5)', :b])
 
       @creator.statements.must_equal([
-        "create unique index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(5), `b`)"
+        'create unique index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(5), `b`)'
       ])
     end
 
-    it "should add a unique index with a custom name" do
+    it 'should add a unique index with a custom name' do
       @creator.add_unique_index([:a, :b], :custom_index_name)
 
       @creator.statements.must_equal([
-        "create unique index `custom_index_name` on `lhmn_alt` (`a`, `b`)"
+        'create unique index `custom_index_name` on `lhmn_alt` (`a`, `b`)'
       ])
     end
 
-    it "should remove an index" do
-      @creator.remove_index(["b", "a"])
+    it 'should raise an error when the unique index name is not a string or symbol' do
+      assert_raises ArgumentError do
+        @creator.add_unique_index([:a, :b], :name => :custom_index_name)
+      end
+    end
+
+    it 'should remove an index' do
+      @creator.remove_index(['b', 'a'])
 
       @creator.statements.must_equal([
-        "drop index `index_alt_on_b_and_a` on `lhmn_alt`"
+        'drop index `index_alt_on_b_and_a` on `lhmn_alt`'
       ])
     end
 
-    it "should remove an index with a custom name" do
+    it 'should remove an index with a custom name' do
       @creator.remove_index([:a, :b], :custom_index_name)
 
       @creator.statements.must_equal([
-        "drop index `custom_index_name` on `lhmn_alt`"
+        'drop index `custom_index_name` on `lhmn_alt`'
       ])
     end
   end
 
-  describe "column changes" do
-    it "should add a column" do
-      @creator.add_column("logins", "INT(12)")
+  describe 'column changes' do
+    it 'should add a column' do
+      @creator.add_column('logins', 'INT(12)')
 
       @creator.statements.must_equal([
-        "alter table `lhmn_alt` add column `logins` INT(12)"
+        'alter table `lhmn_alt` add column `logins` INT(12)'
       ])
     end
 
-    it "should remove a column" do
-      @creator.remove_column("logins")
+    it 'should remove a column' do
+      @creator.remove_column('logins')
 
       @creator.statements.must_equal([
-        "alter table `lhmn_alt` drop `logins`"
+        'alter table `lhmn_alt` drop `logins`'
       ])
     end
 
-    it "should change a column" do
-      @creator.change_column("logins", "INT(11)")
+    it 'should change a column' do
+      @creator.change_column('logins', 'INT(11)')
 
       @creator.statements.must_equal([
-        "alter table `lhmn_alt` modify column `logins` INT(11)"
+        'alter table `lhmn_alt` modify column `logins` INT(11)'
       ])
     end
   end
 
-  describe "direct changes" do
-    it "should accept a ddl statement" do
-     ddl = @creator.ddl("alter table `%s` add column `f` tinyint(1)" % @creator.name)
+  describe 'direct changes' do
+    it 'should accept a ddl statement' do
+     ddl = @creator.ddl('alter table `%s` add column `f` tinyint(1)' % @creator.name)
 
      @creator.statements.must_equal([
-       "alter table `lhmn_alt` add column `f` tinyint(1)"
+       'alter table `lhmn_alt` add column `f` tinyint(1)'
      ])
     end
   end
 
-  describe "multiple changes" do
-    it "should add two columns" do
-      @creator.add_column("first", "VARCHAR(64)")
-      @creator.add_column("last", "VARCHAR(64)")
+  describe 'multiple changes' do
+    it 'should add two columns' do
+      @creator.add_column('first', 'VARCHAR(64)')
+      @creator.add_column('last', 'VARCHAR(64)')
       @creator.statements.length.must_equal(2)
 
       @creator.
         statements[0].
-        must_equal("alter table `lhmn_alt` add column `first` VARCHAR(64)")
+        must_equal('alter table `lhmn_alt` add column `first` VARCHAR(64)')
 
       @creator.
         statements[1].
-        must_equal("alter table `lhmn_alt` add column `last` VARCHAR(64)")
+        must_equal('alter table `lhmn_alt` add column `last` VARCHAR(64)')
     end
   end
 end

data/spec/unit/printer_spec.rb

@@ -5,13 +5,13 @@ require 'lhm/printer'
 describe Lhm::Printer do
   include UnitHelper
 
-  describe "percentage printer" do
+  describe 'percentage printer' do
 
     before(:each) do
       @printer = Lhm::Printer::Percentage.new
     end
 
-    it "prints the percentage" do
+    it 'prints the percentage' do
       mock = MiniTest::Mock.new
       10.times do |i|
         mock.expect(:write, :return_value) do |message|
@@ -25,7 +25,7 @@ describe Lhm::Printer do
       mock.verify
     end
 
-    it "always print a bigger message" do
+    it 'always print a bigger message' do
       @length = 0
       mock = MiniTest::Mock.new
       3.times do |i|
@@ -45,7 +45,7 @@ describe Lhm::Printer do
       mock.verify
     end
 
-    it "prints the end message" do
+    it 'prints the end message' do
       mock = MiniTest::Mock.new
       mock.expect(:write, :return_value, [String])
       mock.expect(:write, :return_value, ["\n"])
@@ -57,16 +57,16 @@ describe Lhm::Printer do
     end
   end
 
-  describe "dot printer" do
+  describe 'dot printer' do
 
     before(:each) do
       @printer = Lhm::Printer::Dot.new
     end
 
-    it "prints the dots" do
+    it 'prints the dots' do
       mock  = MiniTest::Mock.new
       10.times do
-        mock.expect(:write, :return_value, ["."])
+        mock.expect(:write, :return_value, ['.'])
       end
 
       @printer.instance_variable_set(:@output, mock)

data/spec/unit/sql_helper_spec.rb

@@ -6,27 +6,27 @@ require File.expand_path(File.dirname(__FILE__)) + '/unit_helper'
 require 'lhm/sql_helper'
 
 describe Lhm::SqlHelper do
-  it "should name index with a single column" do
+  it 'should name index with a single column' do
     Lhm::SqlHelper.
       idx_name(:users, :name).
-      must_equal("index_users_on_name")
+      must_equal('index_users_on_name')
   end
 
-  it "should name index with multiple columns" do
+  it 'should name index with multiple columns' do
     Lhm::SqlHelper.
       idx_name(:users, [:name, :firstname]).
-      must_equal("index_users_on_name_and_firstname")
+      must_equal('index_users_on_name_and_firstname')
   end
 
-  it "should name index with prefixed column" do
+  it 'should name index with prefixed column' do
     Lhm::SqlHelper.
-      idx_name(:tracks, ["title(10)", "album"]).
-      must_equal("index_tracks_on_title_and_album")
+      idx_name(:tracks, ['title(10)', 'album']).
+      must_equal('index_tracks_on_title_and_album')
   end
 
-  it "should quote column names in index specification" do
+  it 'should quote column names in index specification' do
     Lhm::SqlHelper.
-      idx_spec(["title(10)", "album"]).
-      must_equal("`title`(10), `album`")
+      idx_spec(['title(10)', 'album']).
+      must_equal('`title`(10), `album`')
   end
 end

data/spec/unit/table_spec.rb

@@ -8,26 +8,26 @@ require 'lhm/table'
 describe Lhm::Table do
   include UnitHelper
 
-  describe "names" do
-    it "should name destination" do
-      @table = Lhm::Table.new("users")
-      @table.destination_name.must_equal "lhmn_users"
+  describe 'names' do
+    it 'should name destination' do
+      @table = Lhm::Table.new('users')
+      @table.destination_name.must_equal 'lhmn_users'
     end
   end
 
-  describe "constraints" do
-    it "should be satisfied with a single column primary key called id" do
-      @table = Lhm::Table.new("table", "id")
+  describe 'constraints' do
+    it 'should be satisfied with a single column primary key called id' do
+      @table = Lhm::Table.new('table', 'id')
       @table.satisfies_primary_key?.must_equal true
     end
 
-    it "should not be satisfied with a primary key unless called id" do
-      @table = Lhm::Table.new("table", "uuid")
+    it 'should not be satisfied with a primary key unless called id' do
+      @table = Lhm::Table.new('table', 'uuid')
       @table.satisfies_primary_key?.must_equal false
     end
 
-    it "should not be satisfied with multicolumn primary key" do
-      @table = Lhm::Table.new("table", ["id", "secondary"])
+    it 'should not be satisfied with multicolumn primary key' do
+      @table = Lhm::Table.new('table', ['id', 'secondary'])
       @table.satisfies_primary_key?.must_equal false
     end
   end

data/spec/unit/throttler_spec.rb

@@ -11,22 +11,22 @@ describe Lhm::Throttler do
     end
   end
 
-  describe "#setup_throttler" do
-    describe "when passing a key" do
+  describe '#setup_throttler' do
+    describe 'when passing a key' do
       before do
         @mock.setup_throttler(:time_throttler, :delay => 2)
       end
 
-      it "instantiates the time throttle" do
+      it 'instantiates the time throttle' do
         @mock.throttler.class.must_equal Lhm::Throttler::Time
       end
 
-      it "returns 2 seconds as time" do
+      it 'returns 2 seconds as time' do
         @mock.throttler.timeout_seconds.must_equal 2
       end
     end
 
-    describe "when passing an instance" do
+    describe 'when passing an instance' do
 
       before do
         @instance = Class.new(Lhm::Throttler::Time) do
@@ -38,35 +38,35 @@ describe Lhm::Throttler do
         @mock.setup_throttler(@instance)
       end
 
-      it "returns the instace given" do
+      it 'returns the instace given' do
         @mock.throttler.must_equal @instance
       end
 
-      it "returns 0 seconds as time" do
+      it 'returns 0 seconds as time' do
         @mock.throttler.timeout_seconds.must_equal 0
       end
     end
 
-    describe "when passing a class" do
+    describe 'when passing a class' do
 
       before do
         @klass = Class.new(Lhm::Throttler::Time)
         @mock.setup_throttler(@klass)
       end
 
-      it "has the same class as given" do
+      it 'has the same class as given' do
         @mock.throttler.class.must_equal @klass
       end
     end
   end
 
-  describe "#throttler" do
+  describe '#throttler' do
 
-    it "returns the default Time based" do
+    it 'returns the default Time based' do
       @mock.throttler.class.must_equal Lhm::Throttler::Time
     end
 
-    it "should default to 100 milliseconds" do
+    it 'should default to 100 milliseconds' do
       @mock.throttler.timeout_seconds.must_equal 0.1
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhm
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - SoundCloud
@@ -11,34 +11,34 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-31 00:00:00.000000000 Z
+date: 2015-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 5.0.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 5.0.8
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Migrate large tables without downtime by copying to a temporary table
@@ -50,12 +50,14 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
 - CHANGELOG.md
 - LICENSE
 - README.md
 - Rakefile
+- bin/lhm-config.sh
 - bin/lhm-kill-queue
 - bin/lhm-spec-clobber.sh
 - bin/lhm-spec-grants.sh
@@ -126,12 +128,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []