lhm 1.2.0 → 2.2.0

data/spec/integration/integration_helper.rb

@@ -1,19 +1,13 @@
 # Copyright (c) 2011 - 2013, SoundCloud Ltd., Rany Keddo, Tobias Bielohlawek, Tobias
 # Schmidt
-
-require File.expand_path(File.dirname(__FILE__)) + "/../bootstrap"
-
+require 'test_helper'
+require 'yaml'
 begin
-  require 'active_record'
-  begin
-    require 'mysql2'
-  rescue LoadError
-    require 'mysql'
-  end
+  require 'active_support'
 rescue LoadError
-  require 'dm-core'
-  require 'dm-mysql-adapter'
 end
+$password = YAML.load_file(File.expand_path(File.dirname(__FILE__)) + '/database.yml')['password'] rescue nil
+
 require 'lhm/table'
 require 'lhm/sql_helper'
 require 'lhm/connection'
@@ -42,14 +36,19 @@ module IntegrationHelper
         :host     => '127.0.0.1',
         :database => 'lhm',
         :username => 'root',
-        :port     => port
+        :port     => port,
+        :password => $password
       )
       adapter = ActiveRecord::Base.connection
     elsif defined?(DataMapper)
-      adapter = DataMapper.setup(:default, "mysql://root@localhost:#{port}/lhm")
+      adapter = DataMapper.setup(:default, "mysql://root:#{$password}@localhost:#{port}/lhm")
     end
 
     Lhm.setup(adapter)
+    unless defined?(@@cleaned_up)
+      Lhm.cleanup(true)
+      @@cleaned_up  = true
+    end
     @connection = Lhm::Connection.new(adapter)
   end
 
@@ -87,7 +86,6 @@ module IntegrationHelper
       connect_master!
     end
 
-
     yield block
 
     if master_slave_mode?
@@ -109,6 +107,10 @@ module IntegrationHelper
     table_read(fixture_name)
   end
 
+  def table_rename(from_name, to_name)
+    execute "rename table `#{ from_name }` to `#{ to_name }`"
+  end
+
   def table_read(fixture_name)
     Lhm::Table.parse(fixture_name, @connection)
   end
@@ -127,7 +129,7 @@ module IntegrationHelper
   end
 
   def count_all(table)
-    query = "select count(*) from #{ table }"
+    query = "select count(*) from `#{ table }`"
     select_value(query).to_i
   end
 
@@ -141,7 +143,7 @@ module IntegrationHelper
     non_unique = type == :non_unique ? 1 : 0
 
     !!select_one(%Q<
-      show indexes in #{ table_name }
+      show indexes in `#{ table_name }`
      where key_name = '#{ key_name }'
        and non_unique = #{ non_unique }
     >)
@@ -152,6 +154,36 @@ module IntegrationHelper
   #
 
   def master_slave_mode?
-    !!ENV["MASTER_SLAVE"]
+    !!ENV['MASTER_SLAVE']
+  end
+
+  #
+  # Misc
+  #
+
+  def capture_stdout
+    out = StringIO.new
+    $stdout = out
+    yield
+    return out.string
+  ensure
+    $stdout = ::STDOUT
+  end
+
+  def simulate_failed_migration
+    Lhm::Entangler.class_eval do
+      alias_method :old_after, :after
+      def after
+        true
+      end
+    end
+
+    yield
+  ensure
+    Lhm::Entangler.class_eval do
+      undef_method :after
+      alias_method :after, :old_after
+      undef_method :old_after
+    end
   end
 end

data/spec/integration/lhm_spec.rb

@@ -3,33 +3,71 @@
 
 require File.expand_path(File.dirname(__FILE__)) + '/integration_helper'
 
-require 'lhm'
-
 describe Lhm do
   include IntegrationHelper
 
   before(:each) { connect_master! }
 
-  describe "changes" do
+  describe 'changes' do
     before(:each) do
       table_create(:users)
+      table_create(:tracks)
+      table_create(:permissions)
+    end
+
+    describe 'when providing a subset of data to copy' do
+
+      before do
+        execute('insert into tracks set id = 13, public = 0')
+        11.times { |n| execute("insert into tracks set id = #{n + 1}, public = 1") }
+        11.times { |n| execute("insert into permissions set track_id = #{n + 1}") }
+
+        Lhm.change_table(:permissions, :atomic_switch => false) do |t|
+          t.filter('inner join tracks on tracks.`id` = permissions.`track_id` and tracks.`public` = 1')
+        end
+      end
+
+      describe 'when no additional data is inserted into the table' do
+
+        it 'migrates the existing data' do
+          slave do
+            count_all(:permissions).must_equal(11)
+          end
+        end
+      end
+
+      describe 'when additional data is inserted' do
+
+        before do
+          execute('insert into tracks set id = 14, public = 0')
+          execute('insert into tracks set id = 15, public = 1')
+          execute('insert into permissions set track_id = 14')
+          execute('insert into permissions set track_id = 15')
+        end
+
+        it 'migrates all data' do
+          slave do
+            count_all(:permissions).must_equal(13)
+          end
+        end
+      end
     end
 
-    it "should add a column" do
+    it 'should add a column' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_column(:logins, "INT(12) DEFAULT '0'")
       end
 
       slave do
-        table_read(:users).columns["logins"].must_equal({
-          :type => "int(12)",
-          :is_nullable => "YES",
+        table_read(:users).columns['logins'].must_equal({
+          :type => 'int(12)',
+          :is_nullable => 'YES',
           :column_default => '0'
         })
       end
     end
 
-    it "should copy all rows" do
+    it 'should copy all rows' do
       23.times { |n| execute("insert into users set reference = '#{ n }'") }
 
       Lhm.change_table(:users, :atomic_switch => false) do |t|
@@ -41,17 +79,17 @@ describe Lhm do
       end
     end
 
-    it "should remove a column" do
+    it 'should remove a column' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.remove_column(:comment)
       end
 
       slave do
-        table_read(:users).columns["comment"].must_equal nil
+        table_read(:users).columns['comment'].must_equal nil
       end
     end
 
-    it "should add an index" do
+    it 'should add an index' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_index([:comment, :created_at])
       end
@@ -61,7 +99,7 @@ describe Lhm do
       end
     end
 
-    it "should add an index with a custom name" do
+    it 'should add an index with a custom name' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_index([:comment, :created_at], :my_index_name)
       end
@@ -71,7 +109,7 @@ describe Lhm do
       end
     end
 
-    it "should add an index on a column with a reserved name" do
+    it 'should add an index on a column with a reserved name' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_index(:group)
       end
@@ -81,7 +119,7 @@ describe Lhm do
       end
     end
 
-    it "should add a unqiue index" do
+    it 'should add a unqiue index' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.add_unique_index(:comment)
       end
@@ -91,7 +129,7 @@ describe Lhm do
       end
     end
 
-    it "should remove an index" do
+    it 'should remove an index' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.remove_index([:username, :created_at])
       end
@@ -101,62 +139,144 @@ describe Lhm do
       end
     end
 
-    it "should remove an index with a custom name" do
+    it 'should remove an index with a custom name' do
+      Lhm.change_table(:users, :atomic_switch => false) do |t|
+        t.remove_index([:username, :group])
+      end
+
+      slave do
+        index?(:users, :index_with_a_custom_name).must_equal(false)
+      end
+    end
+
+    it 'should remove an index with a custom name by name' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
-        t.remove_index(:reference, :index_users_on_reference)
+        t.remove_index(:irrelevant_column_name, :index_with_a_custom_name)
       end
 
       slave do
-        index?(:users, :index_users_on_reference).must_equal(false)
+        index?(:users, :index_with_a_custom_name).must_equal(false)
       end
     end
 
-    it "should apply a ddl statement" do
+    it 'should apply a ddl statement' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
-        t.ddl("alter table %s add column flag tinyint(1)" % t.name)
+        t.ddl('alter table %s add column flag tinyint(1)' % t.name)
       end
 
       slave do
-        table_read(:users).columns["flag"].must_equal({
-          :type => "tinyint(1)",
-          :is_nullable => "YES",
+        table_read(:users).columns['flag'].must_equal({
+          :type => 'tinyint(1)',
+          :is_nullable => 'YES',
           :column_default => nil
         })
       end
     end
 
-    it "should change a column" do
+    it 'should change a column' do
       Lhm.change_table(:users, :atomic_switch => false) do |t|
         t.change_column(:comment, "varchar(20) DEFAULT 'none' NOT NULL")
       end
 
       slave do
-        table_read(:users).columns["comment"].must_equal({
-          :type => "varchar(20)",
-          :is_nullable => "NO",
-          :column_default => "none"
+        table_read(:users).columns['comment'].must_equal({
+          :type => 'varchar(20)',
+          :is_nullable => 'NO',
+          :column_default => 'none'
         })
       end
     end
 
-    it "should change the last column in a table" do
+    it 'should change the last column in a table' do
       table_create(:small_table)
 
       Lhm.change_table(:small_table, :atomic_switch => false) do |t|
-        t.change_column(:id, "int(5)")
+        t.change_column(:id, 'int(5)')
+      end
+
+      slave do
+        table_read(:small_table).columns['id'].must_equal({
+          :type => 'int(5)',
+          :is_nullable => 'NO',
+          :column_default => '0'
+        })
+      end
+    end
+
+    it 'should rename a column' do
+      table_create(:users)
+
+      execute("INSERT INTO users (username) VALUES ('a user')")
+      Lhm.change_table(:users, :atomic_switch => false) do |t|
+        t.rename_column(:username, :login)
+      end
+
+      slave do
+        table_data = table_read(:users)
+        table_data.columns['username'].must_equal(nil)
+        table_read(:users).columns['login'].must_equal({
+          :type => 'varchar(255)',
+          :is_nullable => 'YES',
+          :column_default => nil
+        })
+
+        # DM & AR versions of select_one return different structures. The
+        # real test is whether the data was copied
+        result = select_one('SELECT login from users')
+        result = result['login'] if result.respond_to?(:has_key?)
+        result.must_equal('a user')
+      end
+    end
+
+    it 'should rename a column with a default' do
+      table_create(:users)
+
+      execute("INSERT INTO users (username) VALUES ('a user')")
+      Lhm.change_table(:users, :atomic_switch => false) do |t|
+        t.rename_column(:group, :fnord)
       end
 
       slave do
-        table_read(:small_table).columns["id"].must_equal({
-          :type => "int(5)",
-          :is_nullable => "NO",
-          :column_default => "0"
+        table_data = table_read(:users)
+        table_data.columns['group'].must_equal(nil)
+        table_read(:users).columns['fnord'].must_equal({
+          :type => 'varchar(255)',
+          :is_nullable => 'YES',
+          :column_default => 'Superfriends'
         })
+
+        # DM & AR versions of select_one return different structures. The
+        # real test is whether the data was copied
+        result = select_one('SELECT `fnord` from users')
+        result = result['fnord'] if result.respond_to?(:has_key?)
+        result.must_equal('Superfriends')
+      end
+    end
+
+    it 'works when mysql reserved words are used' do
+      table_create(:lines)
+      execute("insert into `lines` set id = 1, `between` = 'foo'")
+      execute("insert into `lines` set id = 2, `between` = 'bar'")
+
+      Lhm.change_table(:lines) do |t|
+        t.add_column('by', 'varchar(10)')
+        t.remove_column('lines')
+        t.add_index('by')
+        t.add_unique_index('between')
+        t.remove_index('by')
+      end
+
+      slave do
+        table_read(:lines).columns.must_include 'by'
+        table_read(:lines).columns.wont_include 'lines'
+        index_on_columns?(:lines, ['between'], :unique).must_equal true
+        index_on_columns?(:lines, ['by']).must_equal false
+        count_all(:lines).must_equal(2)
       end
     end
 
-    describe "parallel" do
-      it "should perserve inserts during migration" do
+    describe 'parallel' do
+      it 'should perserve inserts during migration' do
         50.times { |n| execute("insert into users set reference = '#{ n }'") }
 
         insert = Thread.new do
@@ -180,7 +300,7 @@ describe Lhm do
         end
       end
 
-      it "should perserve deletes during migration" do
+      it 'should perserve deletes during migration' do
         50.times { |n| execute("insert into users set reference = '#{ n }'") }
 
         delete = Thread.new do

data/spec/integration/locked_switcher_spec.rb

@@ -12,30 +12,30 @@ describe Lhm::LockedSwitcher do
 
   before(:each) { connect_master! }
 
-  describe "switching" do
+  describe 'switching' do
     before(:each) do
-      @origin = table_create("origin")
-      @destination = table_create("destination")
+      @origin = table_create('origin')
+      @destination = table_create('destination')
       @migration = Lhm::Migration.new(@origin, @destination)
     end
 
-    it "rename origin to archive" do
+    it 'rename origin to archive' do
       switcher = Lhm::LockedSwitcher.new(@migration, connection)
       switcher.run
 
       slave do
         table_exists?(@origin).must_equal true
-        table_read(@migration.archive_name).columns.keys.must_include "origin"
+        table_read(@migration.archive_name).columns.keys.must_include 'origin'
       end
     end
 
-    it "rename destination to origin" do
+    it 'rename destination to origin' do
       switcher = Lhm::LockedSwitcher.new(@migration, connection)
       switcher.run
 
       slave do
         table_exists?(@destination).must_equal false
-        table_read(@origin.name).columns.keys.must_include "destination"
+        table_read(@origin.name).columns.keys.must_include 'destination'
       end
     end
   end

data/spec/integration/table_spec.rb

@@ -2,46 +2,44 @@
 # Schmidt
 
 require File.expand_path(File.dirname(__FILE__)) + '/integration_helper'
-
-require 'lhm'
 require 'lhm/table'
 
 describe Lhm::Table do
   include IntegrationHelper
 
   describe Lhm::Table::Parser do
-    describe "create table parsing" do
+    describe 'create table parsing' do
       before(:each) do
         connect_master!
         @table = table_create(:users)
       end
 
-      it "should parse table name in show create table" do
-        @table.name.must_equal("users")
+      it 'should parse table name in show create table' do
+        @table.name.must_equal('users')
       end
 
-      it "should parse primary key" do
-        @table.pk.must_equal("id")
+      it 'should parse primary key' do
+        @table.pk.must_equal('id')
       end
 
-      it "should parse column type in show create table" do
-        @table.columns["username"][:type].must_equal("varchar(255)")
+      it 'should parse column type in show create table' do
+        @table.columns['username'][:type].must_equal('varchar(255)')
       end
 
-      it "should parse column metadata" do
-        @table.columns["username"][:column_default].must_equal nil
+      it 'should parse column metadata' do
+        @table.columns['username'][:column_default].must_equal nil
       end
 
-      it "should parse indices" do
+      it 'should parse indices' do
         @table.
-          indices["index_users_on_username_and_created_at"].
-          must_equal(["username", "created_at"])
+          indices['index_users_on_username_and_created_at'].
+          must_equal(['username', 'created_at'])
       end
 
-      it "should parse index" do
+      it 'should parse index' do
         @table.
-          indices["index_users_on_reference"].
-          must_equal(["reference"])
+          indices['index_users_on_reference'].
+          must_equal(['reference'])
       end
     end
   end

data/spec/test_helper.rb

@@ -0,0 +1,28 @@
+# Copyright (c) 2011 - 2013, SoundCloud Ltd., Rany Keddo, Tobias Bielohlawek, Tobias
+# Schmidt
+
+require 'minitest/autorun'
+require 'minitest/spec'
+require 'minitest/mock'
+require 'pathname'
+require 'lhm'
+
+$project = Pathname.new(File.dirname(__FILE__) + '/..').cleanpath
+$spec = $project.join('spec')
+$fixtures = $spec.join('fixtures')
+
+begin
+  require 'active_record'
+  begin
+    require 'mysql2'
+  rescue LoadError
+    require 'mysql'
+  end
+rescue LoadError
+  require 'dm-core'
+  require 'dm-mysql-adapter'
+end
+
+logger = Logger.new STDOUT
+logger.level = Logger::WARN
+Lhm.logger = logger

data/spec/unit/atomic_switcher_spec.rb

@@ -12,19 +12,19 @@ describe Lhm::AtomicSwitcher do
 
   before(:each) do
     @start       = Time.now
-    @origin      = Lhm::Table.new("origin")
-    @destination = Lhm::Table.new("destination")
+    @origin      = Lhm::Table.new('origin')
+    @destination = Lhm::Table.new('destination')
     @migration   = Lhm::Migration.new(@origin, @destination, @start)
     @switcher    = Lhm::AtomicSwitcher.new(@migration, nil)
   end
 
-  describe "atomic switch" do
-    it "should perform a single atomic rename" do
+  describe 'atomic switch' do
+    it 'should perform a single atomic rename' do
       @switcher.
         statements.
         must_equal([
-          "rename table `origin` to `#{ @migration.archive_name }`, " +
-          "`destination` to `origin`"
+          "rename table `origin` to `#{ @migration.archive_name }`, " \
+          '`destination` to `origin`'
         ])
     end
   end