lhm-shopify 4.1.0 → 4.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 850cda6d2f610db2985c780d2a90d176e8520b373e21dafbe67df47e9a07ba0f
-  data.tar.gz: 982ab91c6319f5f7803d73d9f3734a57d28a13e76184500a665a5ab5b91d434f
+  metadata.gz: b1a16e83f2a989c0624948b4ef8bfe2c3b7359aa1420ee5d2c41dee1b9ec6e29
+  data.tar.gz: 9baa1e49780b70edd51caec39460a3ad440f2d7f10f65aa8295da541a762cd42
 SHA512:
-  metadata.gz: 8bdb254a7cd2091f7d1d125080bc843b43fc9039a7b2a99cba62752bee84726971e8018fb77738fdd0b15867a7f959ff419802270de75c08c2a72cd44d8b004b
-  data.tar.gz: b7d3a989384483ba9f43dd000f1e46c62805e15a0e15c4fcba0fedc964787d4fb1eafe294a2b23deae2d5b035057739551385eca08d24529d8c8e951ba44b163
+  metadata.gz: 0d96f3ba67d232682ecb5fa27f9f7cb33f850125546364a41ede17c6dda187e00d8b91e6ab8a5189022e9fd3117af4e9bb6272c1392d0d8510252cea6ae9ac00
+  data.tar.gz: 407a0497d1ce019d3f7e835ceb157441a1cd76f5723a7a7d3a61d95c2232adb42ac56b6aba9b07d5720eeeab0e6ce6a68d50d297dbd9736fd4e641835d372a86

data/.github/workflows/test.yml

@@ -18,6 +18,11 @@ jobs:
         ruby: ["3.0", "3.1", "3.2", "head"]
         mysql: ["5.7", "8.0"]
         adapter: ["mysql2", "trilogy"]
+        exclude:
+          - activerecord: 6.1
+            ruby: head
+          - activerecord: 7.0
+            ruby: head
 
     env:
       BUNDLE_GEMFILE: "${{ github.workspace }}/gemfiles/activerecord_${{ matrix.activerecord }}.gemfile"

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Unreleased
 
+# 4.2.0 (Mar, 2024)
+* Support `DROP DEFAULT` & `SET DEFAULT` in `change_column` operations.
+
+# 4.1.1 (Nov, 2023)
+* Fix check for warnings against PK in MySQL 8+
+
 # 4.1.0 (Oct, 2023)
 * Test against MySQL 8.0.
 * Test against Ruby Head.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lhm-shopify (4.1.0)
+    lhm-shopify (4.2.0)
       retriable (>= 3.0.0)
 
 GEM
@@ -38,7 +38,7 @@ GEM
       ruby2_keywords
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    minitest (5.20.0)
+    minitest (5.22.2)
     mocha (2.1.0)
       ruby2_keywords (>= 0.0.5)
     mutex_m (0.1.2)

data/gemfiles/activerecord_6.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    lhm-shopify (4.1.0)
+    lhm-shopify (4.2.0)
       retriable (>= 3.0.0)
 
 GEM
@@ -31,7 +31,7 @@ GEM
     docile (1.4.0)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    minitest (5.20.0)
+    minitest (5.22.2)
     mocha (2.1.0)
       ruby2_keywords (>= 0.0.5)
     mysql2 (0.5.5)

data/gemfiles/activerecord_7.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    lhm-shopify (4.1.0)
+    lhm-shopify (4.2.0)
       retriable (>= 3.0.0)
 
 GEM
@@ -30,7 +30,7 @@ GEM
     docile (1.4.0)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    minitest (5.20.0)
+    minitest (5.22.2)
     mocha (2.1.0)
       ruby2_keywords (>= 0.0.5)
     mysql2 (0.5.5)

data/gemfiles/activerecord_7.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    lhm-shopify (4.1.0)
+    lhm-shopify (4.2.0)
       retriable (>= 3.0.0)
 
 GEM
@@ -38,7 +38,7 @@ GEM
       ruby2_keywords
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    minitest (5.20.0)
+    minitest (5.22.2)
     mocha (2.1.0)
       ruby2_keywords (>= 0.0.5)
     mutex_m (0.1.2)

data/lib/lhm/chunker.rb

@@ -23,6 +23,7 @@ module Lhm
       @chunk_finder = ChunkFinder.new(migration, connection, options)
       @options = options
       @raise_on_warnings = options.fetch(:raise_on_warnings, false)
+      @pk_duplicate_warning_regexp ||= /Duplicate entry .+ for key '(#{@migration.destination_name}\.)?PRIMARY'/
       @verifier = options[:verifier]
       if @throttler = options[:throttler]
         @throttler.connection = @connection if @throttler.respond_to?(:connection=)
@@ -80,11 +81,11 @@ module Lhm
 
     def raise_on_non_pk_duplicate_warning
       @connection.select_all("SHOW WARNINGS", should_retry: true, log_prefix: LOG_PREFIX).each do |row|
-        unless row["Message"].match?(/Duplicate entry .+ for key 'PRIMARY'/)
-          m = "Unexpected warning found for inserted row: #{row["Message"]}"
-          Lhm.logger.warn(m)
-          raise Error.new(m) if @raise_on_warnings
-        end
+        next if row["Message"].match?(@pk_duplicate_warning_regexp)
+
+        m = "Unexpected warning found for inserted row: #{row["Message"]}"
+        Lhm.logger.warn(m)
+        raise Error.new(m) if @raise_on_warnings
       end
     end
 

data/lib/lhm/migrator.rb

@@ -67,7 +67,11 @@ module Lhm
     # @param [String] name Name of the column to change
     # @param [String] definition Valid SQL column definition
     def change_column(name, definition)
-      ddl('alter table `%s` modify column `%s` %s' % [@name, name, definition])
+      if definition.match?(/^(DROP|SET) DEFAULT/i)
+        ddl('alter table `%s` alter column `%s` %s' % [@name, name, definition])
+      else
+        ddl('alter table `%s` modify column `%s` %s' % [@name, name, definition])
+      end
     end
 
     # Rename an existing column.

data/lib/lhm/version.rb

@@ -2,5 +2,5 @@
 # Schmidt
 
 module Lhm
-  VERSION = '4.1.0'
+  VERSION = '4.2.0'
 end

data/spec/integration/chunker_spec.rb

@@ -31,7 +31,6 @@ describe Lhm::Chunker do
       replica do
         value(count_all(@destination.name)).must_equal(1)
       end
-
     end
 
     it 'should copy and ignore duplicate primary key' do
@@ -39,7 +38,7 @@ describe Lhm::Chunker do
       execute("insert into origin set id = 1002 ")
       execute("insert into destination set id = 1002 ")
 
-      Lhm::Chunker.new(@migration, connection, {throttler: throttler, printer: printer} ).run
+      Lhm::Chunker.new(@migration, connection, {raise_on_warnings: true, throttler: throttler, printer: printer} ).run
 
       replica do
         value(count_all(@destination.name)).must_equal(2)
@@ -55,7 +54,7 @@ describe Lhm::Chunker do
       execute("insert into composite_primary_key set id = 1002, shop_id = 1")
       execute("insert into composite_primary_key_dest set id = 1002, shop_id = 1")
 
-      Lhm::Chunker.new(migration, connection, {throttler: throttler, printer: printer} ).run
+      Lhm::Chunker.new(migration, connection, {raise_on_warning: true, throttler: throttler, printer: printer} ).run
 
       replica do
         value(count_all(destination.name)).must_equal(2)

data/spec/unit/migrator_spec.rb

@@ -116,6 +116,22 @@ describe Lhm::Migrator do
         'alter table `lhmn_alt` modify column `logins` INT(11)'
       ])
     end
+
+    it "should drop a default" do
+      @creator.change_column('foo', 'DROP DEFAULT')
+
+      value(@creator.statements).must_equal([
+        'alter table `lhmn_alt` alter column `foo` DROP DEFAULT'
+      ])
+    end
+
+    it "should set a default" do
+      @creator.change_column('foo', "SET DEFAULT 'bar'")
+
+      value(@creator.statements).must_equal([
+        "alter table `lhmn_alt` alter column `foo` SET DEFAULT 'bar'"
+      ])
+    end
   end
 
   describe 'direct changes' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhm-shopify
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.2.0
 platform: ruby
 authors:
 - SoundCloud
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-12 00:00:00.000000000 Z
+date: 2024-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: retriable
@@ -320,7 +320,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.20
+rubygems_version: 3.5.6
 signing_key: 
 specification_version: 4
 summary: online schema changer for mysql