lhm-shopify 4.0.0 → 4.1.0

data/lib/lhm/table.rb

@@ -39,10 +39,9 @@ module Lhm
       end
 
       def ddl
-        sql = "show create table `#{ @table_name }`"
-        specification = nil
-        @connection.execute(sql).each { |row| specification = row.last }
-        specification
+        query = "SHOW CREATE TABLE #{ @connection.quote_table_name(@table_name) }"
+
+        @connection.select_one(query)["Create Table"]
       end
 
       def parse

data/lib/lhm/throttler/replica_lag.rb

@@ -91,6 +91,14 @@ module Lhm
 
       attr_reader :host, :connection
 
+      def self.client
+        defined?(Mysql2::Client) ? Mysql2::Client : Trilogy
+      end
+
+      def self.client_error
+        defined?(Mysql2::Error) ? Mysql2::Error : Trilogy::Error
+      end
+
       def initialize(host, connection_config = nil)
         @host = host
         @connection_config = prepare_connection_config(connection_config)
@@ -108,13 +116,11 @@ module Lhm
       private
 
       def client(config)
-        begin
-          Lhm.logger.info "Connecting to #{@host} on database: #{config[:database]}"
-          Mysql2::Client.new(config)
-        rescue Mysql2::Error => e
-          Lhm.logger.info "Error connecting to #{@host}: #{e}"
-          nil
-        end
+        Lhm.logger.info "Connecting to #{@host} on database: #{config[:database]}"
+        self.class.client.new(config)
+      rescue self.class.client_error => e
+        Lhm.logger.info "Error connecting to #{@host}: #{e}"
+        nil
       end
 
       def prepare_connection_config(config_proc)
@@ -133,12 +139,10 @@ module Lhm
       end
 
       def query_connection(query, result)
-        begin
-          @connection.query(query).map { |row| row[result] }
-        rescue Mysql2::Error => e
-          Lhm.logger.info "Unable to connect and/or query #{host}: #{e}"
-          [nil]
-        end
+        @connection.query(query).map { |row| row[result] }
+      rescue self.class.client_error => e
+        Lhm.logger.info "Unable to connect and/or query #{host}: #{e}"
+        [nil]
       end
 
       private

data/lib/lhm/version.rb

@@ -2,5 +2,5 @@
 # Schmidt
 
 module Lhm
-  VERSION = '4.0.0'
+  VERSION = '4.1.0'
 end

data/scripts/helpers/wait-for-dbs.sh

@@ -1,19 +1,19 @@
 #!/bin/bash
 # Wait for writer
 echo "Waiting for MySQL-1: "
-while ! (mysqladmin ping --host="127.0.0.1" --port=33006 --user=root --password=password --silent 2> /dev/null); do
+while ! (mysqladmin ping --host="127.0.0.1" --port=13006 --user=root --password=password --silent 2> /dev/null); do
   echo -ne "."
   sleep 1
 done
 # Wait for reader
 echo "Waiting for MySQL-2: "
-while ! (mysqladmin ping --host="127.0.0.1" --port=33007 --user=root --password=password --silent 2> /dev/null); do
+while ! (mysqladmin ping --host="127.0.0.1" --port=13007 --user=root --password=password --silent 2> /dev/null); do
   echo -ne "."
   sleep 1
 done
 # Wait for proxysql
 echo "Waiting for ProxySQL:"
-while ! (mysqladmin ping --host="127.0.0.1" --port=33005 --user=root --password=password --silent 2> /dev/null); do
+while ! (mysqladmin ping --host="127.0.0.1" --port=13005 --user=root --password=password --silent 2> /dev/null); do
   echo -ne "."
   sleep 1
 done

data/scripts/mysql/writer/create_users.sql

@@ -3,4 +3,4 @@ CREATE USER IF NOT EXISTS 'writer'@'%' IDENTIFIED BY 'password';
 CREATE USER IF NOT EXISTS 'reader'@'%' IDENTIFIED BY 'password';
 
 CREATE USER IF NOT EXISTS 'replication'@'%' IDENTIFIED BY 'password';
-GRANT REPLICATION SLAVE ON *.* TO' replication'@'%' IDENTIFIED BY 'password';
+GRANT REPLICATION SLAVE ON *.* TO' replication'@'%';

data/spec/integration/atomic_switcher_spec.rb

@@ -33,8 +33,8 @@ describe Lhm::AtomicSwitcher do
       ar_connection = mock()
       ar_connection.stubs(:data_source_exists?).returns(true)
       ar_connection.stubs(:active?).returns(true)
-      ar_connection.stubs(:execute).returns([["dummy"]], [["dummy"]], [["dummy"]])
-                   .then
+      ar_connection.stubs(:select_value).returns("dummy")
+      ar_connection.stubs(:execute)
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.')
                    .then
                    .returns([["dummy"]]) # Matches initial host -> triggers retry
@@ -62,16 +62,12 @@ describe Lhm::AtomicSwitcher do
       ar_connection = mock()
       ar_connection.stubs(:data_source_exists?).returns(true)
       ar_connection.stubs(:active?).returns(true)
-      ar_connection.stubs(:execute).returns([["dummy"]], [["dummy"]], [["dummy"]])
-                   .then
+      ar_connection.stubs(:select_value).returns("dummy")
+      ar_connection.stubs(:execute)
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.')
                    .then
-                   .returns([["dummy"]]) # triggers retry 1
-                   .then
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.')
                    .then
-                   .returns([["dummy"]]) # triggers retry 2
-                   .then
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.') # triggers retry 2
 
       connection = Lhm::Connection.new(connection: ar_connection, options: {

data/spec/integration/chunker_spec.rb

@@ -74,7 +74,8 @@ describe Lhm::Chunker do
         Lhm::Chunker.new(migration, connection, {raise_on_warnings: true, throttler: throttler, printer: printer} ).run
       end
 
-      assert_match "Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'", exception.message
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+      assert_match "Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'", exception.message
     end
 
     it 'should copy and warn on unexpected warnings by default' do
@@ -87,8 +88,10 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(migration, connection, {throttler: throttler, printer: printer} ).run
 
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+
       assert_equal 2, log_messages.length
-      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'"), log_messages
+      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'"), log_messages
     end
 
     it 'should log two times for two unexpected warnings' do
@@ -103,9 +106,11 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(migration, connection, {throttler: throttler, printer: printer} ).run
 
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+
       assert_equal 3, log_messages.length
-      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'"), log_messages
-      assert log_messages[2].include?("Unexpected warning found for inserted row: Duplicate entry '1002' for key 'index_custom_primary_key_on_id'"), log_messages
+      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'"), log_messages
+      assert log_messages[2].include?("Unexpected warning found for inserted row: Duplicate entry '1002' for key '#{error_key}'"), log_messages
     end
 
     it 'should copy and warn on unexpected warnings' do
@@ -118,8 +123,10 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(migration, connection, {raise_on_warnings: false, throttler: throttler, printer: printer} ).run
 
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+
       assert_equal 2, log_messages.length
-      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'"), log_messages
+      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'"), log_messages
     end
 
     it 'should create the modified destination, even if the source is empty' do
@@ -222,7 +229,7 @@ describe Lhm::Chunker do
         def throttler.replica_connection(replica)
           config = ActiveRecord::Base.connection_pool.db_config.configuration_hash.dup
           config[:host] = replica
-          config[:port] = 33007
+          config[:port] = 13007
           ActiveRecord::Base.send('mysql2_connection', config)
         end
       end
@@ -261,4 +268,12 @@ describe Lhm::Chunker do
       end
     end
   end
+
+  def index_key(table_name, index_name)
+    if mysql_version.start_with?("8")
+      "#{table_name}.#{index_name}"
+    else
+      index_name
+    end
+  end
 end

data/spec/integration/database.yml

@@ -2,17 +2,17 @@ master:
   host: mysql-1
   user: root
   password: password
-  port: 33006
+  port: 13006
 replica:
   host: mysql-2
   user: root
   password: password
-  port: 33007
+  port: 13007
 proxysql:
   host: proxysql
   user: root
   password: password
-  port: 33005
+  port: 13005
 master_toxic:
   host: toxiproxy
   user: root

data/spec/integration/integration_helper.rb

@@ -22,7 +22,7 @@ module IntegrationHelper
   def self.included(base)
     base.after(:each) do
       cleanup_connection = new_mysql_connection
-      results = cleanup_connection.query("SELECT table_name FROM information_schema.tables WHERE table_schema = '#{$db_name}';")
+      results = DATABASE.query(cleanup_connection, "SELECT table_name FROM information_schema.tables WHERE table_schema = '#{$db_name}';")
       table_names_for_cleanup = results.map { |row| "#{$db_name}." + row.values.first }
       cleanup_connection.query("DROP TABLE IF EXISTS #{table_names_for_cleanup.join(', ')};") if table_names_for_cleanup.length > 0
     end
@@ -35,6 +35,14 @@ module IntegrationHelper
     @connection
   end
 
+  def mysql_version
+    @mysql_version ||= begin
+      # This SQL returns a value of shape: X.Y.ZZ-AA-log
+      result = connection.query("SELECT VERSION()")
+      result.dig(0, 0).split("-", 2)[0]
+    end
+  end
+
   def connect_proxysql!
     connect!(
       '127.0.0.1',
@@ -81,7 +89,7 @@ module IntegrationHelper
 
   def ar_conn(host, port, user, password)
     ActiveRecord::Base.establish_connection(
-      :adapter  => 'mysql2',
+      :adapter  => DATABASE.adapter,
       :host     => host,
       :username => user,
       :port     => port,
@@ -171,7 +179,7 @@ module IntegrationHelper
   end
 
   def new_mysql_connection(role='master')
-    Mysql2::Client.new(
+    DATABASE.client.new(
       host: '127.0.0.1',
       database: $db_name,
       username: $db_config[role]['user'],

data/spec/integration/lhm_spec.rb

@@ -9,6 +9,10 @@ describe Lhm do
 
   before(:each) { connect_master!; Lhm.cleanup(true) }
 
+  let(:collation) do
+    mysql_version.start_with?("8.0") ? "utf8mb3_general_ci" : "utf8_general_ci"
+  end
+
   describe 'id column requirement' do
     it 'should migrate the table when id is pk' do
       table_create(:users)
@@ -17,9 +21,11 @@ describe Lhm do
         t.add_column(:logins, "int(12) default '0'")
       end
 
+      expected_type = mysql_version.start_with?("8.0") ? "int" : "int(12)"
+
       replica do
         value(table_read(:users).columns['logins']).must_equal({
-          :type           => 'int(12)',
+          :type           => expected_type,
           :is_nullable    => 'YES',
           :column_default => '0',
           :comment => '',
@@ -35,9 +41,11 @@ describe Lhm do
         t.add_column(:logins, "int(12) default '0'")
       end
 
+      expected_type = mysql_version.start_with?("8.0") ? "int" : "int(12)"
+
       replica do
         value(table_read(:custom_primary_key).columns['logins']).must_equal({
-          :type           => 'int(12)',
+          :type           => expected_type,
           :is_nullable    => 'YES',
           :column_default => '0',
           :comment => '',
@@ -53,9 +61,11 @@ describe Lhm do
         t.add_column(:logins, "int(12) default '0'")
       end
 
+      expected_type = mysql_version.start_with?("8.0") ? "int" : "int(12)"
+
       replica do
         value(table_read(:composite_primary_key).columns['logins']).must_equal({
-          :type           => 'int(12)',
+          :type           => expected_type,
           :is_nullable    => 'YES',
           :column_default => '0',
           :comment => '',
@@ -132,9 +142,11 @@ describe Lhm do
         t.add_column(:logins, "INT(12) DEFAULT '0'")
       end
 
+      expected_type = mysql_version.start_with?("8.0") ? "int" : "int(12)"
+
       replica do
         value(table_read(:users).columns['logins']).must_equal({
-          :type => 'int(12)',
+          :type => expected_type,
           :is_nullable => 'YES',
           :column_default => '0',
           :comment => '',
@@ -272,7 +284,7 @@ describe Lhm do
           :is_nullable => 'NO',
           :column_default => 'none',
           :comment => '',
-          :collate => 'utf8_general_ci',
+          :collate => collation,
         })
       end
     end
@@ -284,9 +296,11 @@ describe Lhm do
         t.change_column(:id, 'int(5)')
       end
 
+      expected_type = mysql_version.start_with?("8.0") ? "int" : "int(5)"
+
       replica do
         value(table_read(:small_table).columns['id']).must_equal({
-          :type => 'int(5)',
+          :type => expected_type,
           :is_nullable => 'NO',
           :column_default => nil,
           :comment => '',
@@ -311,7 +325,7 @@ describe Lhm do
           :is_nullable => 'YES',
           :column_default => nil,
           :comment => '',
-          :collate => 'utf8_general_ci',
+          :collate => collation,
         })
 
         result = select_one('SELECT login from users')
@@ -336,7 +350,7 @@ describe Lhm do
           :is_nullable => 'YES',
           :column_default => 'Superfriends',
           :comment => '',
-          :collate => 'utf8_general_ci',
+          :collate => collation,
         })
 
         result = select_one('SELECT `fnord` from users')
@@ -383,11 +397,13 @@ describe Lhm do
         t.rename_column(:reference, :ref)
       end
 
+      expected_type = mysql_version.start_with?("8.0") ? "int" : "int(11)"
+
       replica do
         table_data = table_read(:users)
         assert_nil table_data.columns['reference']
         value(table_read(:users).columns['ref']).must_equal({
-           :type => 'int(11)',
+           :type => expected_type,
            :is_nullable => 'YES',
            :column_default => nil,
            :comment => 'RefComment',
@@ -418,7 +434,7 @@ describe Lhm do
            :is_nullable => 'YES',
            :column_default => nil,
            :comment => '',
-           :collate => 'utf8_general_ci',
+           :collate => collation,
          })
 
         result = select_one('SELECT `fnord` from users')
@@ -443,7 +459,7 @@ describe Lhm do
           :is_nullable => 'YES',
           :column_default => nil,
           :comment => '',
-          :collate => 'utf8_general_ci',
+          :collate => collation,
         })
 
         result = select_one('SELECT `user_name` from users')
@@ -470,7 +486,7 @@ describe Lhm do
           :is_nullable => 'NO',
           :column_default => nil,
           :comment => '',
-          :collate => 'utf8_general_ci',
+          :collate => collation,
         })
 
         result = select_one('SELECT `user_name` from users')
@@ -517,7 +533,7 @@ describe Lhm do
           :is_nullable => 'YES',
           :column_default => 'Superfriends',
           :comment => '',
-          :collate => 'utf8_general_ci',
+          :collate => collation,
         })
       end
     end

data/spec/integration/proxysql_spec.rb

@@ -1,34 +1,34 @@
 describe "ProxySQL integration" do
   it "Should contact the writer" do
-    conn = Mysql2::Client.new(
+    conn = DATABASE.client.new(
       host: '127.0.0.1',
       username: "writer",
       password: "password",
-      port: "33005",
+      port: "13005",
       )
 
-    assert_equal conn.query("SELECT @@global.hostname as host").each.first["host"], "mysql-1"
+    assert_equal DATABASE.query(conn, "SELECT @@global.hostname as host").each.first["host"], "mysql-1"
   end
 
   it "Should contact the reader" do
-    conn = Mysql2::Client.new(
+    conn = DATABASE.client.new(
       host: '127.0.0.1',
       username: "reader",
       password: "password",
-      port: "33005",
+      port: "13005",
       )
 
-    assert_equal conn.query("SELECT @@global.hostname as host").each.first["host"], "mysql-2"
+    assert_equal DATABASE.query(conn, "SELECT @@global.hostname as host").each.first["host"], "mysql-2"
   end
 
   it "Should override default hostgroup from user if rule matches" do
-    conn = Mysql2::Client.new(
+    conn = DATABASE.client.new(
       host: '127.0.0.1',
       username: "reader",
       password: "password",
-      port: "33005",
+      port: "13005",
       )
 
-    assert_equal conn.query("SELECT @@global.hostname as host #{Lhm::ProxySQLHelper::ANNOTATION}").each.first["host"], "mysql-1"
+    assert_equal DATABASE.query(conn, "SELECT @@global.hostname as host #{Lhm::ProxySQLHelper::ANNOTATION}").each.first["host"], "mysql-1"
   end
-end
+end

data/spec/integration/sql_retry/db_connection_helper.rb

@@ -1,5 +1,4 @@
 require 'yaml'
-require 'mysql2'
 
 class DBConnectionHelper
 
@@ -11,12 +10,11 @@ class DBConnectionHelper
     end
 
     def new_mysql_connection(role = :master, with_data = false, toxic = false)
-
       key = role.to_s + toxic_postfix(toxic)
 
       conn = ActiveRecord::Base.establish_connection(
         :host => '127.0.0.1',
-        :adapter => "mysql2",
+        :adapter => DATABASE.adapter,
         :username => db_config[key]['user'],
         :password => db_config[key]['password'],
         :database => test_db_name,
@@ -49,4 +47,4 @@ class DBConnectionHelper
       end
     end
   end
-end
+end

data/spec/integration/sql_retry/lock_wait_spec.rb

@@ -1,5 +1,4 @@
 require 'minitest/autorun'
-require 'mysql2'
 require 'integration/sql_retry/lock_wait_timeout_test_helper'
 require 'lhm'
 
@@ -22,7 +21,7 @@ describe Lhm::SqlRetry do
     # Assert our pre-conditions
     assert_equal 2, @helper.record_count
 
-    Mysql2::Client.any_instance.stubs(:active?).returns(true)
+    DATABASE.client.any_instance.stubs(:active?).returns(true)
   end
 
   after(:each) do
@@ -43,8 +42,8 @@ describe Lhm::SqlRetry do
 
     exception = assert_raises { @helper.trigger_wait_lock }
 
-    assert_match /Lock wait timeout exceeded; try restarting transaction/, exception.message
-    assert_equal Mysql2::Error::TimeoutError, exception.class
+    assert_match Regexp.new("Lock wait timeout exceeded; try restarting transaction"), exception.message
+    assert_equal DATABASE.timeout_error, exception.class
 
     assert_equal 2, @helper.record_count # no records inserted
     puts "*" * 64
@@ -82,10 +81,10 @@ describe Lhm::SqlRetry do
     logs = @logger.string.split("\n")
     assert_equal 2, logs.length
 
-    assert logs.first.include?("Mysql2::Error::TimeoutError: 'Lock wait timeout exceeded; try restarting transaction' - 1 tries")
+    assert logs.first.include?("Lock wait timeout exceeded; try restarting transaction' - 1 tries")
     assert logs.first.include?("0.2 seconds until the next try")
 
-    assert logs.last.include?("Mysql2::Error::TimeoutError: 'Lock wait timeout exceeded; try restarting transaction' - 2 tries")
+    assert logs.last.include?("Lock wait timeout exceeded; try restarting transaction' - 2 tries")
     assert logs.last.include?("0.2 seconds until the next try")
   end
 
@@ -118,8 +117,8 @@ describe Lhm::SqlRetry do
 
     exception = assert_raises { @helper.trigger_wait_lock }
 
-    assert_match /Lock wait timeout exceeded; try restarting transaction/, exception.message
-    assert_equal Mysql2::Error::TimeoutError, exception.class
+    assert_match Regexp.new("Lock wait timeout exceeded; try restarting transaction"), exception.message
+    assert_equal DATABASE.timeout_error, exception.class
 
     assert_equal 2, @helper.record_count # no records inserted
     puts "*" * 64

data/spec/integration/sql_retry/lock_wait_timeout_test_helper.rb

@@ -14,13 +14,21 @@ class LockWaitTimeoutTestHelper
 
     @lock_duration = lock_duration
 
-    # While implementing this, I discovered that MySQL seems to have an off-by-one
-    # bug with the innodb_lock_wait_timeout. If you ask it to wait 2 seconds, it will wait 3.
-    # In order to avoid surprisingly the user, let's account for that here, but also
-    # guard against a case where we go below 1, the minimum value.
-    raise ArgumentError, "innodb_lock_wait_timeout must be greater than or equal to 2" unless innodb_lock_wait_timeout >= 2
     raise ArgumentError, "innodb_lock_wait_timeout must be an integer" if innodb_lock_wait_timeout.class != Integer
-    @innodb_lock_wait_timeout = innodb_lock_wait_timeout - 1
+
+    result = DATABASE.query(@main_conn, "SELECT VERSION()")
+    mysql_version = result.to_a.dig(0, "VERSION()").split("-", 2)[0]
+
+    if mysql_version.start_with?("8")
+      @innodb_lock_wait_timeout = innodb_lock_wait_timeout
+    else
+      # While implementing this, I discovered that MySQL seems to have an off-by-one
+      # bug with the innodb_lock_wait_timeout. If you ask it to wait 2 seconds, it will wait 3.
+      # In order to avoid surprisingly the user, let's account for that here, but also
+      # guard against a case where we go below 1, the minimum value.
+      raise ArgumentError, "innodb_lock_wait_timeout must be greater than or equal to 2" unless innodb_lock_wait_timeout >= 2
+      @innodb_lock_wait_timeout = innodb_lock_wait_timeout - 1
+    end
 
     @threads = []
     @queue = Queue.new
@@ -51,7 +59,7 @@ class LockWaitTimeoutTestHelper
   end
 
   def record_count(connection = main_conn)
-    response = connection.query("SELECT COUNT(id) FROM #{test_table_name}")
+    response = mysql_exec(connection, "SELECT COUNT(id) FROM #{test_table_name}")
     response.first.values.first
   end
 
@@ -79,7 +87,7 @@ class LockWaitTimeoutTestHelper
   attr_reader :main_conn, :lock_duration, :innodb_lock_wait_timeout
 
   def new_mysql_connection
-    Mysql2::Client.new(
+    DATABASE.client.new(
       host: '127.0.0.1',
       username: db_config['master']['user'],
       password: db_config['master']['password'],
@@ -103,8 +111,8 @@ class LockWaitTimeoutTestHelper
   private
 
   def mysql_exec(connection, statement)
-    if connection.class == Mysql2::Client
-      connection.query(statement)
+    if connection.class == DATABASE.client
+      DATABASE.query(connection, statement)
     elsif connection.class.to_s.include?("ActiveRecord")
       connection.execute(statement)
     else

data/spec/integration/sql_retry/proxysql_helper.rb

@@ -2,7 +2,7 @@ class ProxySQLHelper
   class << self
     # Flips the destination hostgroup for /maintenance:lhm/ from 0 (i.e. writer) to 1 (i.e. reader)
     def with_lhm_hostgroup_flip
-      conn = Mysql2::Client.new(
+      conn = DATABASE.client.new(
         host: '127.0.0.1',
         username: "remote-admin",
         password: "password",

data/spec/integration/sql_retry/retry_with_proxysql_spec.rb

@@ -1,5 +1,4 @@
 require 'minitest/autorun'
-require 'mysql2'
 require 'lhm'
 require 'toxiproxy'
 
@@ -50,7 +49,7 @@ describe Lhm::SqlRetry, "ProxiSQL tests for LHM retry" do
       end
     end
 
-    assert_equal @connection.execute("Select * from #{DBConnectionHelper.test_table_name} WHERE id=2000").to_a.first.first, 2000
+    assert_equal 2000, @connection.select_one("SELECT * FROM #{DBConnectionHelper.test_table_name} WHERE id=2000")["id"]
 
     logs = @logger.string.split("\n")
 

data/spec/integration/table_spec.rb

@@ -23,7 +23,7 @@ describe Lhm::Table do
       end
 
       it 'should parse columns' do
-        value(@table.columns['id'][:type]).must_match(/(bigint|int)\(\d+\)/)
+        value(@table.columns['id'][:type]).must_match(/(bigint|int)(\(\d+\))?/)
       end
 
       it 'should return true for method that should be renamed' do