lhm-shopify 3.5.5 → 4.1.0

data/lib/lhm/throttler/slave_lag.rb

@@ -1,161 +1,11 @@
+require 'lhm/throttler/replica_lag'
+
 module Lhm
   module Throttler
-
-    def self.format_hosts(hosts)
-      formatted_hosts = []
-      hosts.each do |host|
-        if host && !host.match(/localhost/) && !host.match(/127.0.0.1/)
-          formatted_hosts << host.partition(':')[0]
-        end
-      end
-      formatted_hosts
-    end
-
-    class SlaveLag
-      include Command
-
-      INITIAL_TIMEOUT = 0.1
-      DEFAULT_STRIDE = 2_000
-      DEFAULT_MAX_ALLOWED_LAG = 10
-
-      MAX_TIMEOUT = INITIAL_TIMEOUT * 1024
-
-      attr_accessor :timeout_seconds, :allowed_lag, :stride, :connection
-
+    class SlaveLag < ReplicaLag
       def initialize(options = {})
-        @timeout_seconds = INITIAL_TIMEOUT
-        @stride = options[:stride] || DEFAULT_STRIDE
-        @allowed_lag = options[:allowed_lag] || DEFAULT_MAX_ALLOWED_LAG
-        @slaves = {}
-        @get_config = options[:current_config]
-        @check_only = options[:check_only]
-      end
-
-      def execute
-        sleep(throttle_seconds)
-      end
-
-      private
-
-      def throttle_seconds
-        lag = max_current_slave_lag
-
-        if lag > @allowed_lag && @timeout_seconds < MAX_TIMEOUT
-          Lhm.logger.info("Increasing timeout between strides from #{@timeout_seconds} to #{@timeout_seconds * 2} because #{lag} seconds of slave lag detected is greater than the maximum of #{@allowed_lag} seconds allowed.")
-          @timeout_seconds = @timeout_seconds * 2
-        elsif lag <= @allowed_lag && @timeout_seconds > INITIAL_TIMEOUT
-          Lhm.logger.info("Decreasing timeout between strides from #{@timeout_seconds} to #{@timeout_seconds / 2} because #{lag} seconds of slave lag detected is less than or equal to the #{@allowed_lag} seconds allowed.")
-          @timeout_seconds = @timeout_seconds / 2
-        else
-          @timeout_seconds
-        end
-      end
-
-      def slaves
-        @slaves[@connection] ||= get_slaves
-      end
-
-      def get_slaves
-        slaves = []
-        if @check_only.nil? or !@check_only.respond_to?(:call)
-          slave_hosts = master_slave_hosts
-          while slave_hosts.any? do
-            host = slave_hosts.pop
-            slave = Slave.new(host, @get_config)
-            if !slaves.map(&:host).include?(host) && slave.connection
-              slaves << slave
-              slave_hosts.concat(slave.slave_hosts)
-            end
-          end
-        else
-          slave_config = @check_only.call
-          slaves << Slave.new(slave_config['host'], @get_config)
-        end
-        slaves
-      end
-
-      def master_slave_hosts
-        Throttler.format_hosts(@connection.select_values(Slave::SQL_SELECT_SLAVE_HOSTS))
-      end
-
-      def max_current_slave_lag
-        max = slaves.map { |slave| slave.lag }.push(0).max
-        Lhm.logger.info "Max current slave lag: #{max}"
-        max
-      end
-    end
-
-    class Slave
-      SQL_SELECT_SLAVE_HOSTS = "SELECT host FROM information_schema.processlist WHERE command LIKE 'Binlog Dump%'"
-      SQL_SELECT_MAX_SLAVE_LAG = 'SHOW SLAVE STATUS'
-
-      attr_reader :host, :connection
-
-      def initialize(host, connection_config = nil)
-        @host = host
-        @connection_config = prepare_connection_config(connection_config)
-        @connection = client(@connection_config)
-      end
-
-      def slave_hosts
-        Throttler.format_hosts(query_connection(SQL_SELECT_SLAVE_HOSTS, 'host'))
-      end
-
-      def lag
-        query_connection(SQL_SELECT_MAX_SLAVE_LAG, 'Seconds_Behind_Master').first.to_i
-      end
-
-      private
-
-      def client(config)
-        begin
-          Lhm.logger.info "Connecting to #{@host} on database: #{config[:database]}"
-          Mysql2::Client.new(config)
-        rescue Mysql2::Error => e
-          Lhm.logger.info "Error connecting to #{@host}: #{e}"
-          nil
-        end
-      end
-
-      def prepare_connection_config(config_proc)
-        config = if config_proc
-          if config_proc.respond_to?(:call) # if we get a proc
-            config_proc.call
-          else
-            raise ArgumentError, "Expected #{config_proc.inspect} to respond to `call`"
-          end
-        else
-          db_config
-        end
-        config.deep_symbolize_keys!
-        config[:host] = @host
-        config
-      end
-
-      def query_connection(query, result)
-        begin
-          @connection.query(query).map { |row| row[result] }
-        rescue Mysql2::Error => e
-          Lhm.logger.info "Unable to connect and/or query #{host}: #{e}"
-          [nil]
-        end
-      end
-
-      private
-
-      def db_config
-        if ar_supports_db_config?
-          ActiveRecord::Base.connection_pool.db_config.configuration_hash.dup
-        else
-          ActiveRecord::Base.connection_pool.spec.config.dup
-        end
-      end
-
-      def ar_supports_db_config?
-        # https://api.rubyonrails.org/v6.0/classes/ActiveRecord/ConnectionAdapters/ConnectionPool.html <-- has spec
-        # vs
-        # https://api.rubyonrails.org/v6.1/classes/ActiveRecord/ConnectionAdapters/ConnectionPool.html <-- has db_config
-        ActiveRecord::VERSION::MAJOR > 6 || ActiveRecord::VERSION::MAJOR == 6 && ActiveRecord::VERSION::MINOR >= 1
+        Lhm.logger.warn("Class `SlaveLag` is deprecated. Use `ReplicaLag` class instead.")
+        super(options)
       end
     end
   end

data/lib/lhm/throttler/threads_running.rb

@@ -3,14 +3,16 @@ module Lhm
     class ThreadsRunning
       include Command
 
+      DEFAULT_STRIDE = 2_000
       DEFAULT_INITIAL_TIMEOUT = 0.1
       DEFAULT_HEALTHY_RANGE = (0..50)
 
-      attr_accessor :timeout_seconds, :healthy_range, :connection
+      attr_accessor :timeout_seconds, :healthy_range, :connection, :stride
       attr_reader :max_timeout_seconds, :initial_timeout_seconds
 
       def initialize(options = {})
         @initial_timeout_seconds = options[:initial_timeout] || DEFAULT_INITIAL_TIMEOUT
+        @stride = options[:stride] || DEFAULT_STRIDE
         @max_timeout_seconds = options[:max_timeout] || (@initial_timeout_seconds * 1024)
         @timeout_seconds = @initial_timeout_seconds
         @healthy_range = options[:healthy_range] || DEFAULT_HEALTHY_RANGE

data/lib/lhm/throttler.rb

@@ -1,12 +1,16 @@
 require 'lhm/throttler/time'
+require 'lhm/throttler/replica_lag'
 require 'lhm/throttler/slave_lag'
 require 'lhm/throttler/threads_running'
 
 module Lhm
   module Throttler
-    CLASSES = { :time_throttler => Throttler::Time,
-                :slave_lag_throttler => Throttler::SlaveLag,
-                :threads_running_throttler => Throttler::ThreadsRunning }
+    CLASSES = {
+      :time_throttler => Throttler::Time,
+      :replica_lag_throttler => Throttler::ReplicaLag,
+      :slave_lag_throttler => Throttler::SlaveLag,
+      :threads_running_throttler => Throttler::ThreadsRunning
+    }
 
     def throttler
       @throttler ||= Throttler::Time.new

data/lib/lhm/version.rb

@@ -2,5 +2,5 @@
 # Schmidt
 
 module Lhm
-  VERSION = '3.5.5'
+  VERSION = '4.1.0'
 end

data/scripts/helpers/wait-for-dbs.sh

@@ -1,19 +1,19 @@
 #!/bin/bash
 # Wait for writer
 echo "Waiting for MySQL-1: "
-while ! (mysqladmin ping --host="127.0.0.1" --port=33006 --user=root --password=password --silent 2> /dev/null); do
+while ! (mysqladmin ping --host="127.0.0.1" --port=13006 --user=root --password=password --silent 2> /dev/null); do
   echo -ne "."
   sleep 1
 done
 # Wait for reader
 echo "Waiting for MySQL-2: "
-while ! (mysqladmin ping --host="127.0.0.1" --port=33007 --user=root --password=password --silent 2> /dev/null); do
+while ! (mysqladmin ping --host="127.0.0.1" --port=13007 --user=root --password=password --silent 2> /dev/null); do
   echo -ne "."
   sleep 1
 done
 # Wait for proxysql
 echo "Waiting for ProxySQL:"
-while ! (mysqladmin ping --host="127.0.0.1" --port=33005 --user=root --password=password --silent 2> /dev/null); do
+while ! (mysqladmin ping --host="127.0.0.1" --port=13005 --user=root --password=password --silent 2> /dev/null); do
   echo -ne "."
   sleep 1
 done

data/scripts/mysql/writer/create_users.sql

@@ -3,4 +3,4 @@ CREATE USER IF NOT EXISTS 'writer'@'%' IDENTIFIED BY 'password';
 CREATE USER IF NOT EXISTS 'reader'@'%' IDENTIFIED BY 'password';
 
 CREATE USER IF NOT EXISTS 'replication'@'%' IDENTIFIED BY 'password';
-GRANT REPLICATION SLAVE ON *.* TO' replication'@'%' IDENTIFIED BY 'password';
+GRANT REPLICATION SLAVE ON *.* TO' replication'@'%';

data/spec/.lhm.example

@@ -1,4 +1,4 @@
 mysqldir=/usr/local/mysql
 basedir=~/lhm-cluster
 master_port=3306
-slave_port=3307
+replica_port=3307

data/spec/README.md

@@ -1,4 +1,4 @@
-# Preparing for master slave integration tests
+# Preparing for master replica integration tests
 
 ## Configuration
 
@@ -7,10 +7,10 @@ create ~/.lhm:
     mysqldir=/usr/local/mysql
     basedir=~/lhm-cluster
     master_port=3306
-    slave_port=3307
+    replica_port=3307
 
 mysqldir specifies the location of your mysql install. basedir is the
-directory master and slave databases will get installed into.
+directory master and replica databases will get installed into.
 
 ## Automatic setup
 
@@ -18,8 +18,8 @@ directory master and slave databases will get installed into.
 
     bin/lhm-spec-clobber.sh
 
-You can set the integration specs up to run against a master slave setup by
-running the included that. This deletes the configured lhm master slave setup and reinstalls and configures a master slave setup.
+You can set the integration specs up to run against a master replica setup by
+running the included that. This deletes the configured lhm master replica setup and reinstalls and configures a master replica setup.
 
 Follow the manual instructions if you want more control over this process.
 
@@ -33,7 +33,7 @@ Follow the manual instructions if you want more control over this process.
 
     basedir=/opt/lhm-luster
     mysqld --defaults-file="$basedir/master/my.cnf"
-    mysqld --defaults-file="$basedir/slave/my.cnf"
+    mysqld --defaults-file="$basedir/replica/my.cnf"
 
 ### run the grants
 
@@ -46,13 +46,12 @@ Setup the dependency gems
     export BUNDLE_GEMFILE=gemfiles/ar-4.2_mysql2.gemfile
     bundle install
 
-To run specs in slave mode, set the MASTER_SLAVE=1 when running tests:
+To run specs in replica mode, set the MASTER_REPLICA=1 when running tests:
 
-    MASTER_SLAVE=1 bundle exec rake specs
+    MASTER_REPLICA=1 bundle exec rake specs
 
 # connecting
 
 you can connect by running (with the respective ports):
 
     mysql --protocol=TCP -p3307
-

data/spec/integration/atomic_switcher_spec.rb

@@ -33,8 +33,8 @@ describe Lhm::AtomicSwitcher do
       ar_connection = mock()
       ar_connection.stubs(:data_source_exists?).returns(true)
       ar_connection.stubs(:active?).returns(true)
-      ar_connection.stubs(:execute).returns([["dummy"]], [["dummy"]], [["dummy"]])
-                   .then
+      ar_connection.stubs(:select_value).returns("dummy")
+      ar_connection.stubs(:execute)
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.')
                    .then
                    .returns([["dummy"]]) # Matches initial host -> triggers retry
@@ -62,16 +62,12 @@ describe Lhm::AtomicSwitcher do
       ar_connection = mock()
       ar_connection.stubs(:data_source_exists?).returns(true)
       ar_connection.stubs(:active?).returns(true)
-      ar_connection.stubs(:execute).returns([["dummy"]], [["dummy"]], [["dummy"]])
-                   .then
+      ar_connection.stubs(:select_value).returns("dummy")
+      ar_connection.stubs(:execute)
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.')
                    .then
-                   .returns([["dummy"]]) # triggers retry 1
-                   .then
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.')
                    .then
-                   .returns([["dummy"]]) # triggers retry 2
-                   .then
                    .raises(ActiveRecord::StatementInvalid, 'Lock wait timeout exceeded; try restarting transaction.') # triggers retry 2
 
       connection = Lhm::Connection.new(connection: ar_connection, options: {
@@ -110,7 +106,7 @@ describe Lhm::AtomicSwitcher do
       switcher = Lhm::AtomicSwitcher.new(@migration, connection)
       switcher.run
 
-      slave do
+      replica do
         value(data_source_exists?(@origin)).must_equal true
         value(table_read(@migration.archive_name).columns.keys).must_include 'origin'
       end
@@ -120,7 +116,7 @@ describe Lhm::AtomicSwitcher do
       switcher = Lhm::AtomicSwitcher.new(@migration, connection)
       switcher.run
 
-      slave do
+      replica do
         value(data_source_exists?(@destination)).must_equal false
         value(table_read(@origin.name).columns.keys).must_include 'destination'
       end

data/spec/integration/chunk_insert_spec.rb

@@ -19,10 +19,10 @@ describe Lhm::ChunkInsert do
       assert_equal 1, @instance.insert_and_return_count_of_rows_created
     end
 
-    it "inserts the record into the slave" do
+    it "inserts the record into the replica" do
       @instance.insert_and_return_count_of_rows_created
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(1)
       end
     end

data/spec/integration/chunker_spec.rb

@@ -28,7 +28,7 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(@migration, connection, {throttler: throttler, printer: printer} ).run
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(1)
       end
 
@@ -41,7 +41,7 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(@migration, connection, {throttler: throttler, printer: printer} ).run
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(2)
       end
     end
@@ -57,7 +57,7 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(migration, connection, {throttler: throttler, printer: printer} ).run
 
-      slave do
+      replica do
         value(count_all(destination.name)).must_equal(2)
       end
     end
@@ -74,7 +74,8 @@ describe Lhm::Chunker do
         Lhm::Chunker.new(migration, connection, {raise_on_warnings: true, throttler: throttler, printer: printer} ).run
       end
 
-      assert_match "Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'", exception.message
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+      assert_match "Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'", exception.message
     end
 
     it 'should copy and warn on unexpected warnings by default' do
@@ -87,8 +88,10 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(migration, connection, {throttler: throttler, printer: printer} ).run
 
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+
       assert_equal 2, log_messages.length
-      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'"), log_messages
+      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'"), log_messages
     end
 
     it 'should log two times for two unexpected warnings' do
@@ -103,9 +106,11 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(migration, connection, {throttler: throttler, printer: printer} ).run
 
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+
       assert_equal 3, log_messages.length
-      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'"), log_messages
-      assert log_messages[2].include?("Unexpected warning found for inserted row: Duplicate entry '1002' for key 'index_custom_primary_key_on_id'"), log_messages
+      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'"), log_messages
+      assert log_messages[2].include?("Unexpected warning found for inserted row: Duplicate entry '1002' for key '#{error_key}'"), log_messages
     end
 
     it 'should copy and warn on unexpected warnings' do
@@ -118,8 +123,10 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(migration, connection, {raise_on_warnings: false, throttler: throttler, printer: printer} ).run
 
+      error_key = index_key("custom_primary_key_dest", "index_custom_primary_key_on_id")
+
       assert_equal 2, log_messages.length
-      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key 'index_custom_primary_key_on_id'"), log_messages
+      assert log_messages[1].include?("Unexpected warning found for inserted row: Duplicate entry '1001' for key '#{error_key}'"), log_messages
     end
 
     it 'should create the modified destination, even if the source is empty' do
@@ -127,7 +134,7 @@ describe Lhm::Chunker do
 
       Lhm::Chunker.new(@migration, connection, {throttler: throttler, printer: printer} ).run
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(0)
       end
 
@@ -136,20 +143,17 @@ describe Lhm::Chunker do
     it 'should copy 23 rows from origin to destination in one shot, regardless of the value of the id' do
       23.times { |n| execute("insert into origin set id = '#{ n * n + 23 }'") }
 
-      printer = MiniTest::Mock.new
-      printer.expect(:notify, :return_value, [Integer, Integer])
-      printer.expect(:end, :return_value, [])
+      printer = mock("printer")
+      printer.expects(:notify).with(kind_of(Integer), kind_of(Integer))
+      printer.expects(:end)
 
       Lhm::Chunker.new(
         @migration, connection, { throttler: throttler, printer: printer }
       ).run
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(23)
       end
-
-      printer.verify
-
     end
 
     it 'should copy all the records of a table, even if the last chunk starts with the last record of it.' do
@@ -160,42 +164,40 @@ describe Lhm::Chunker do
         @migration, connection, { throttler: Lhm::Throttler::Time.new(stride: 10), printer: printer }
       ).run
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(11)
       end
 
     end
 
-    it 'should copy 23 rows from origin to destination in one shot with slave lag based throttler, regardless of the value of the id' do
+    it 'should copy 23 rows from origin to destination in one shot with replica lag based throttler, regardless of the value of the id' do
       23.times { |n| execute("insert into origin set id = '#{ 100000 + n * n + 23 }'") }
 
-      printer = MiniTest::Mock.new
-      printer.expect(:notify, :return_value, [Integer, Integer])
-      printer.expect(:end, :return_value, [])
+      printer = mock("printer")
+      printer.expects(:notify).with(kind_of(Integer), kind_of(Integer))
+      printer.expects(:end)
 
-      Lhm::Throttler::Slave.any_instance.stubs(:slave_hosts).returns(['127.0.0.1'])
-      Lhm::Throttler::SlaveLag.any_instance.stubs(:master_slave_hosts).returns(['127.0.0.1'])
+      Lhm::Throttler::Replica.any_instance.stubs(:replica_hosts).returns(['127.0.0.1'])
+      Lhm::Throttler::ReplicaLag.any_instance.stubs(:master_replica_hosts).returns(['127.0.0.1'])
 
       Lhm::Chunker.new(
-        @migration, connection, { throttler: Lhm::Throttler::SlaveLag.new(stride: 100), printer: printer }
+        @migration, connection, { throttler: Lhm::Throttler::ReplicaLag.new(stride: 100), printer: printer }
       ).run
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(23)
       end
-
-      printer.verify
     end
 
-    it 'should throttle work stride based on slave lag' do
+    it 'should throttle work stride based on replica lag' do
       15.times { |n| execute("insert into origin set id = '#{ (n * n) + 1 }'") }
 
       printer = mock()
       printer.expects(:notify).with(instance_of(Integer), instance_of(Integer)).twice
       printer.expects(:end)
 
-      throttler = Lhm::Throttler::SlaveLag.new(stride: 10, allowed_lag: 0)
-      def throttler.max_current_slave_lag
+      throttler = Lhm::Throttler::ReplicaLag.new(stride: 10, allowed_lag: 0)
+      def throttler.max_current_replica_lag
         1
       end
 
@@ -203,14 +205,14 @@ describe Lhm::Chunker do
         @migration, connection, { throttler: throttler, printer: printer }
       ).run
 
-      assert_equal(Lhm::Throttler::SlaveLag::INITIAL_TIMEOUT * 2 * 2, throttler.timeout_seconds)
+      assert_equal(Lhm::Throttler::ReplicaLag::INITIAL_TIMEOUT * 2 * 2, throttler.timeout_seconds)
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(15)
       end
     end
 
-    it 'should detect a single slave with no lag in the default configuration' do
+    it 'should detect a single replica with no lag in the default configuration' do
       15.times { |n| execute("insert into origin set id = '#{ (n * n) + 1 }'") }
 
       printer = mock()
@@ -218,16 +220,16 @@ describe Lhm::Chunker do
       printer.expects(:verify)
       printer.expects(:end)
 
-      Lhm::Throttler::Slave.any_instance.stubs(:slave_hosts).returns(['127.0.0.1'])
-      Lhm::Throttler::SlaveLag.any_instance.stubs(:master_slave_hosts).returns(['127.0.0.1'])
+      Lhm::Throttler::Replica.any_instance.stubs(:replica_hosts).returns(['127.0.0.1'])
+      Lhm::Throttler::ReplicaLag.any_instance.stubs(:master_replica_hosts).returns(['127.0.0.1'])
 
-      throttler = Lhm::Throttler::SlaveLag.new(stride: 10, allowed_lag: 0)
+      throttler = Lhm::Throttler::ReplicaLag.new(stride: 10, allowed_lag: 0)
 
-      if master_slave_mode?
-        def throttler.slave_connection(slave)
+      if master_replica_mode?
+        def throttler.replica_connection(replica)
           config = ActiveRecord::Base.connection_pool.db_config.configuration_hash.dup
-          config[:host] = slave
-          config[:port] = 33007
+          config[:host] = replica
+          config[:port] = 13007
           ActiveRecord::Base.send('mysql2_connection', config)
         end
       end
@@ -236,10 +238,10 @@ describe Lhm::Chunker do
         @migration, connection, { throttler: throttler, printer: printer }
       ).run
 
-      assert_equal(Lhm::Throttler::SlaveLag::INITIAL_TIMEOUT, throttler.timeout_seconds)
-      assert_equal(0, throttler.send(:max_current_slave_lag))
+      assert_equal(Lhm::Throttler::ReplicaLag::INITIAL_TIMEOUT, throttler.timeout_seconds)
+      assert_equal(0, throttler.send(:max_current_replica_lag))
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(15)
       end
 
@@ -261,9 +263,17 @@ describe Lhm::Chunker do
 
       assert_match "Verification failed, aborting early", exception.message
 
-      slave do
+      replica do
         value(count_all(@destination.name)).must_equal(0)
       end
     end
   end
+
+  def index_key(table_name, index_name)
+    if mysql_version.start_with?("8")
+      "#{table_name}.#{index_name}"
+    else
+      index_name
+    end
+  end
 end

data/spec/integration/database.yml

@@ -2,17 +2,17 @@ master:
   host: mysql-1
   user: root
   password: password
-  port: 33006
-slave:
+  port: 13006
+replica:
   host: mysql-2
   user: root
   password: password
-  port: 33007
+  port: 13007
 proxysql:
   host: proxysql
   user: root
   password: password
-  port: 33005
+  port: 13005
 master_toxic:
   host: toxiproxy
   user: root

data/spec/integration/entangler_spec.rb

@@ -27,7 +27,7 @@ describe Lhm::Entangler do
         execute("insert into origin (common) values ('inserted')")
       end
 
-      slave do
+      replica do
         value(count(:destination, 'common', 'inserted')).must_equal(1)
       end
     end
@@ -39,7 +39,7 @@ describe Lhm::Entangler do
         execute("delete from origin where common = 'inserted'")
       end
 
-      slave do
+      replica do
         value(count(:destination, 'common', 'inserted')).must_equal(0)
       end
     end
@@ -50,7 +50,7 @@ describe Lhm::Entangler do
         execute("update origin set common = 'updated'")
       end
 
-      slave do
+      replica do
         value(count(:destination, 'common', 'updated')).must_equal(1)
       end
     end
@@ -60,7 +60,7 @@ describe Lhm::Entangler do
 
       execute("insert into origin (common) values ('inserted')")
 
-      slave do
+      replica do
         value(count(:destination, 'common', 'inserted')).must_equal(0)
       end
     end