lhm-shopify 3.4.0 → 3.5.5

data/spec/unit/entangler_spec.rb

@@ -6,6 +6,7 @@ require File.expand_path(File.dirname(__FILE__)) + '/unit_helper'
 require 'lhm/table'
 require 'lhm/migration'
 require 'lhm/entangler'
+require 'lhm/connection'
 
 describe Lhm::Entangler do
   include UnitHelper
@@ -34,7 +35,7 @@ describe Lhm::Entangler do
         values (`NEW`.`info`, `NEW`.`tags`)
       }
 
-      @entangler.entangle.must_include strip(ddl)
+      value(@entangler.entangle).must_include strip(ddl)
     end
 
     it 'should create an update trigger to the destination table' do
@@ -45,7 +46,7 @@ describe Lhm::Entangler do
         values (`NEW`.`info`, `NEW`.`tags`)
       }
 
-      @entangler.entangle.must_include strip(ddl)
+      value(@entangler.entangle).must_include strip(ddl)
     end
 
     it 'should create a delete trigger to the destination table' do
@@ -56,38 +57,100 @@ describe Lhm::Entangler do
         where `destination`.`id` = OLD.`id`
       }
 
-      @entangler.entangle.must_include strip(ddl)
+      value(@entangler.entangle).must_include strip(ddl)
     end
 
     it 'should retry trigger creation when it hits a lock wait timeout' do
-      connection = mock()
       tries = 1
-      @entangler = Lhm::Entangler.new(@migration, connection, retriable: {base_interval: 0, tries: tries})
-      connection.expects(:execute).times(tries).raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')
+      ar_connection = mock()
+      ar_connection.stubs(:execute)
+                       .returns([["dummy"]], [["dummy"]], [["dummy"]])
+                       .then
+                       .raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')
+      ar_connection.stubs(:active?).returns(true)
+
+      connection = Lhm::Connection.new(connection: ar_connection, options: {
+        reconnect_with_consistent_host: true,
+        retriable: {
+          base_interval: 0,
+          tries: tries
+        }
+      })
+
+      @entangler = Lhm::Entangler.new(@migration, connection)
 
       assert_raises(Mysql2::Error) { @entangler.before }
     end
 
     it 'should not retry trigger creation with other mysql errors' do
-      connection = mock()
-      connection.expects(:execute).once.raises(Mysql2::Error, 'The MySQL server is running with the --read-only option so it cannot execute this statement.')
-
-      @entangler = Lhm::Entangler.new(@migration, connection, retriable: {base_interval: 0})
+      ar_connection = mock()
+      ar_connection.stubs(:execute)
+                   .returns([["dummy"]], [["dummy"]], [["dummy"]])
+                   .then
+                   .raises(Mysql2::Error, 'The MySQL server is running with the --read-only option so it cannot execute this statement.')
+      ar_connection.stubs(:active?).returns(true)
+      connection = Lhm::Connection.new(connection: ar_connection, options: {
+        reconnect_with_consistent_host: true,
+        retriable: {
+          base_interval: 0
+        },
+      })
+
+      @entangler = Lhm::Entangler.new(@migration, connection)
       assert_raises(Mysql2::Error) { @entangler.before }
     end
 
     it 'should succesfully finish after retrying' do
-      connection = mock()
-      connection.stubs(:execute).raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction').then.returns(true)
-      @entangler = Lhm::Entangler.new(@migration, connection, retriable: {base_interval: 0})
+      ar_connection = mock()
+      ar_connection.stubs(:execute)
+                   .returns([["dummy"]], [["dummy"]], [["dummy"]])
+                   .then
+                   .raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')
+                   .then
+                   .returns([["dummy"]])
+      ar_connection.stubs(:active?).returns(true)
+
+      connection = Lhm::Connection.new(connection: ar_connection, options: {
+        reconnect_with_consistent_host: true,
+        retriable: {
+          base_interval: 0
+        },
+      })
+
+      @entangler = Lhm::Entangler.new(@migration, connection)
 
       assert @entangler.before
     end
 
     it 'should retry as many times as specified by configuration' do
-      connection = mock()
-      connection.expects(:execute).times(5).raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')
-      @entangler = Lhm::Entangler.new(@migration, connection, retriable: {tries: 5, base_interval: 0})
+      ar_connection = mock()
+      ar_connection.stubs(:execute)
+                   .returns([["dummy"]], [["dummy"]], [["dummy"]]) # initial
+                   .then
+                   .raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')
+                   .then
+                   .returns([["dummy"]]) # reconnect 1
+                   .then
+                   .raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')
+                   .then
+                   .returns([["dummy"]])  # reconnect 2
+                   .then
+                   .raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')
+                   .then
+                   .returns([["dummy"]])  # reconnect 3
+                   .then
+                   .raises(Mysql2::Error, 'Lock wait timeout exceeded; try restarting transaction')  # final error
+      ar_connection.stubs(:active?).returns(true)
+
+      connection = Lhm::Connection.new(connection: ar_connection, options: {
+        reconnect_with_consistent_host: true,
+        retriable: {
+          tries: 5,
+          base_interval: 0
+        },
+      })
+
+      @entangler = Lhm::Entangler.new(@migration, connection)
 
       assert_raises(Mysql2::Error) { @entangler.before }
     end
@@ -101,24 +164,24 @@ describe Lhm::Entangler do
       end
 
       it 'should use truncated names' do
-        @entangler.trigger(:ins).length.must_be :<=, 64
-        @entangler.trigger(:upd).length.must_be :<=, 64
-        @entangler.trigger(:del).length.must_be :<=, 64
+        value(@entangler.trigger(:ins).length).must_be :<=, 64
+        value(@entangler.trigger(:upd).length).must_be :<=, 64
+        value(@entangler.trigger(:del).length).must_be :<=, 64
       end
     end
   end
 
   describe 'removal' do
     it 'should remove insert trigger' do
-      @entangler.untangle.must_include('drop trigger if exists `lhmt_ins_origin`')
+      value(@entangler.untangle).must_include('drop trigger if exists `lhmt_ins_origin`')
     end
 
     it 'should remove update trigger' do
-      @entangler.untangle.must_include('drop trigger if exists `lhmt_upd_origin`')
+      value(@entangler.untangle).must_include('drop trigger if exists `lhmt_upd_origin`')
     end
 
     it 'should remove delete trigger' do
-      @entangler.untangle.must_include('drop trigger if exists `lhmt_del_origin`')
+      value(@entangler.untangle).must_include('drop trigger if exists `lhmt_del_origin`')
     end
   end
 end

data/spec/unit/intersection_spec.rb

@@ -18,7 +18,7 @@ describe Lhm::Intersection do
     destination.columns['retained'] = varchar
 
     intersection = Lhm::Intersection.new(origin, destination)
-    intersection.destination.include?('dropped').must_equal(false)
+    value(intersection.destination.include?('dropped')).must_equal(false)
   end
 
   it 'should have unchanged columns' do
@@ -30,7 +30,7 @@ describe Lhm::Intersection do
     destination.columns['retained'] = varchar
 
     intersection = Lhm::Intersection.new(origin, destination)
-    intersection.destination.must_equal(['retained'])
+    value(intersection.destination).must_equal(['retained'])
   end
 
   it 'should have renamed columns' do
@@ -41,8 +41,8 @@ describe Lhm::Intersection do
     destination.columns['new_name'] = varchar
 
     intersection = Lhm::Intersection.new(origin, destination, { 'old_name' => 'new_name' })
-    intersection.origin.must_equal(['old_name'])
-    intersection.destination.must_equal(['new_name'])
+    value(intersection.origin).must_equal(['old_name'])
+    value(intersection.destination).must_equal(['new_name'])
   end
 
   def varchar

data/spec/unit/lhm_spec.rb

@@ -11,9 +11,9 @@ describe Lhm do
   describe 'logger' do
 
     it 'should use the default parameters if no logger explicitly set' do
-      Lhm.logger.must_be_kind_of Logger
-      Lhm.logger.level.must_equal Logger::INFO
-      Lhm.logger.instance_eval { @logdev }.dev.must_equal STDOUT
+      value(Lhm.logger).must_be_kind_of Logger
+      value(Lhm.logger.level).must_equal Logger::INFO
+      value(Lhm.logger.instance_eval { @logdev }.dev).must_equal STDOUT
     end
 
     it 'should use s new logger if set' do
@@ -21,9 +21,26 @@ describe Lhm do
       l.level = Logger::ERROR
       Lhm.logger = l
 
-      Lhm.logger.level.must_equal Logger::ERROR
-      Lhm.logger.instance_eval { @logdev }.dev.must_be_kind_of File
-      Lhm.logger.instance_eval { @logdev }.dev.path.must_equal 'omg.ponies'
+      value(Lhm.logger.level).must_equal Logger::ERROR
+      value(Lhm.logger.instance_eval { @logdev }.dev).must_be_kind_of File
+      value(Lhm.logger.instance_eval { @logdev }.dev.path).must_equal 'omg.ponies'
+    end
+  end
+
+  describe 'api' do
+
+    before(:each) do
+      @connection = mock()
+    end
+
+    it 'should create a new connection when calling setup' do
+      Lhm.setup(@connection)
+      value(Lhm.connection).must_be_kind_of(Lhm::Connection)
+    end
+
+    it 'should create a new connection when none is created' do
+      ActiveRecord::Base.stubs(:connection).returns(@connection)
+      value(Lhm.connection).must_be_kind_of(Lhm::Connection)
     end
   end
 end

data/spec/unit/locked_switcher_spec.rb

@@ -20,32 +20,27 @@ describe Lhm::LockedSwitcher do
 
   describe 'uncommitted' do
     it 'should disable autocommit first' do
-      @switcher.
-        statements[0..1].
-        must_equal([
-          'set @lhm_auto_commit = @@session.autocommit',
-          'set session autocommit = 0'
-        ])
+      value(@switcher.statements[0..1]).must_equal([
+        'set @lhm_auto_commit = @@session.autocommit',
+        'set session autocommit = 0'
+      ])
     end
 
     it 'should reapply original autocommit settings at the end' do
-      @switcher.
-        statements[-1].
-        must_equal('set session autocommit = @lhm_auto_commit')
+      value(@switcher.statements[-1])
+        .must_equal('set session autocommit = @lhm_auto_commit')
     end
   end
 
   describe 'switch' do
     it 'should lock origin and destination table, switch, commit and unlock' do
-      @switcher.
-        switch.
-        must_equal([
-          'lock table `origin` write, `destination` write',
-          "alter table `origin` rename `#{ @migration.archive_name }`",
-          'alter table `destination` rename `origin`',
-          'commit',
-          'unlock tables'
-        ])
+      value(@switcher.switch).must_equal([
+        'lock table `origin` write, `destination` write',
+        "alter table `origin` rename `#{ @migration.archive_name }`",
+        'alter table `destination` rename `origin`',
+        'commit',
+        'unlock tables'
+      ])
     end
   end
 end

data/spec/unit/migrator_spec.rb

@@ -18,7 +18,7 @@ describe Lhm::Migrator do
     it 'should add an index' do
       @creator.add_index(:a)
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'create index `index_alt_on_a` on `lhmn_alt` (`a`)'
       ])
     end
@@ -26,7 +26,7 @@ describe Lhm::Migrator do
     it 'should add a composite index' do
       @creator.add_index([:a, :b])
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`, `b`)'
       ])
     end
@@ -34,7 +34,7 @@ describe Lhm::Migrator do
     it 'should add an index with prefix length' do
       @creator.add_index(['a(10)', 'b'])
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'create index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(10), `b`)'
       ])
     end
@@ -42,7 +42,7 @@ describe Lhm::Migrator do
     it 'should add an index with a custom name' do
       @creator.add_index([:a, :b], :custom_index_name)
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'create index `custom_index_name` on `lhmn_alt` (`a`, `b`)'
       ])
     end
@@ -56,7 +56,7 @@ describe Lhm::Migrator do
     it 'should add a unique index' do
       @creator.add_unique_index(['a(5)', :b])
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'create unique index `index_alt_on_a_and_b` on `lhmn_alt` (`a`(5), `b`)'
       ])
     end
@@ -64,7 +64,7 @@ describe Lhm::Migrator do
     it 'should add a unique index with a custom name' do
       @creator.add_unique_index([:a, :b], :custom_index_name)
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'create unique index `custom_index_name` on `lhmn_alt` (`a`, `b`)'
       ])
     end
@@ -78,7 +78,7 @@ describe Lhm::Migrator do
     it 'should remove an index' do
       @creator.remove_index(['b', 'a'])
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'drop index `index_alt_on_b_and_a` on `lhmn_alt`'
       ])
     end
@@ -86,7 +86,7 @@ describe Lhm::Migrator do
     it 'should remove an index with a custom name' do
       @creator.remove_index([:a, :b], :custom_index_name)
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'drop index `custom_index_name` on `lhmn_alt`'
       ])
     end
@@ -96,7 +96,7 @@ describe Lhm::Migrator do
     it 'should add a column' do
       @creator.add_column('logins', 'INT(12)')
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'alter table `lhmn_alt` add column `logins` INT(12)'
       ])
     end
@@ -104,7 +104,7 @@ describe Lhm::Migrator do
     it 'should remove a column' do
       @creator.remove_column('logins')
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'alter table `lhmn_alt` drop `logins`'
       ])
     end
@@ -112,7 +112,7 @@ describe Lhm::Migrator do
     it 'should change a column' do
       @creator.change_column('logins', 'INT(11)')
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'alter table `lhmn_alt` modify column `logins` INT(11)'
       ])
     end
@@ -122,7 +122,7 @@ describe Lhm::Migrator do
     it 'should accept a ddl statement' do
       @creator.ddl('alter table `%s` add column `f` tinyint(1)' % @creator.name)
 
-      @creator.statements.must_equal([
+      value(@creator.statements).must_equal([
         'alter table `lhmn_alt` add column `f` tinyint(1)'
       ])
     end
@@ -132,15 +132,13 @@ describe Lhm::Migrator do
     it 'should add two columns' do
       @creator.add_column('first', 'VARCHAR(64)')
       @creator.add_column('last', 'VARCHAR(64)')
-      @creator.statements.length.must_equal(2)
+      value(@creator.statements.length).must_equal(2)
 
-      @creator.
-        statements[0].
-        must_equal('alter table `lhmn_alt` add column `first` VARCHAR(64)')
+      value(@creator.statements[0])
+        .must_equal('alter table `lhmn_alt` add column `first` VARCHAR(64)')
 
-      @creator.
-        statements[1].
-        must_equal('alter table `lhmn_alt` add column `last` VARCHAR(64)')
+      value(@creator.statements[1])
+        .must_equal('alter table `lhmn_alt` add column `last` VARCHAR(64)')
     end
   end
 end

data/spec/unit/printer_spec.rb

@@ -1,6 +1,9 @@
 require File.expand_path(File.dirname(__FILE__)) + '/unit_helper'
 
 require 'lhm/printer'
+require 'logger'
+
+
 
 describe Lhm::Printer do
   include UnitHelper
@@ -12,24 +15,17 @@ describe Lhm::Printer do
     end
 
     it 'prints the percentage' do
-      mock = MiniTest::Mock.new
+      r, w = IO.pipe
+      Lhm.logger = Logger.new(w)
+
       10.times do |i|
-        mock.expect(:write, :return_value) do |message|
-          message = message.first if message.is_a?(Array)
-          assert_match(/^\r/, message)
-          assert_match(/#{i}\/10/, message)
-        end
+        @printer.notify(i, 10)
+        assert_match(/#{i}\/10/, log_expression_message(r.gets))
       end
-
-      @printer.instance_variable_set(:@output, mock)
-      10.times { |i| @printer.notify(i, 10) }
-      mock.verify
     end
 
     it 'always prints a bigger message' do
       @length = 0
-      printer_mock = mock()
-      printer_mock.expects(:write).at_least_once
 
       def assert_length(printer)
         new_length = printer.instance_variable_get(:@max_length)
@@ -37,7 +33,6 @@ describe Lhm::Printer do
         @length = new_length
       end
 
-      @printer.instance_variable_set(:@output, printer_mock)
       @printer.notify(10, 100)
       assert_length(@printer)
       @printer.notify(0, 100)
@@ -51,27 +46,20 @@ describe Lhm::Printer do
     end
 
     it 'prints the end message' do
-      mock = MiniTest::Mock.new
-      mock.expect(:write, :return_value, [String])
-      mock.expect(:write, :return_value, ["\n"])
-
-      @printer.instance_variable_set(:@output, mock)
+      r, w = IO.pipe
+      Lhm.logger = Logger.new(w)
       @printer.end
 
-      mock.verify
+      assert_equal(log_expression_message(r.gets), "100% complete\n")
     end
 
     it 'prints the exception message' do
-      mock = MiniTest::Mock.new
-      mock.expect(:write, :return_value, ["\rfailed: woops"])
-      mock.expect(:write, :return_value, ["\n"])
-
+      r, w = IO.pipe
+      Lhm.logger = Logger.new(w)
       e = StandardError.new('woops')
-
-      @printer.instance_variable_set(:@output, mock)
       @printer.exception(e)
 
-      mock.verify
+      assert_equal(log_expression_message(r.gets), "failed: #{e}\n")
     end
   end
 

data/spec/unit/sql_helper_spec.rb

@@ -7,26 +7,22 @@ require 'lhm/sql_helper'
 
 describe Lhm::SqlHelper do
   it 'should name index with a single column' do
-    Lhm::SqlHelper.
-      idx_name(:users, :name).
-      must_equal('index_users_on_name')
+    value(Lhm::SqlHelper.idx_name(:users, :name))
+      .must_equal('index_users_on_name')
   end
 
   it 'should name index with multiple columns' do
-    Lhm::SqlHelper.
-      idx_name(:users, [:name, :firstname]).
-      must_equal('index_users_on_name_and_firstname')
+    value(Lhm::SqlHelper.idx_name(:users, [:name, :firstname]))
+      .must_equal('index_users_on_name_and_firstname')
   end
 
   it 'should name index with prefixed column' do
-    Lhm::SqlHelper.
-      idx_name(:tracks, ['title(10)', 'album']).
-      must_equal('index_tracks_on_title_and_album')
+    value(Lhm::SqlHelper.idx_name(:tracks, ['title(10)', 'album']))
+      .must_equal('index_tracks_on_title_and_album')
   end
 
   it 'should quote column names in index specification' do
-    Lhm::SqlHelper.
-      idx_spec(['title(10)', 'album']).
-      must_equal('`title`(10), `album`')
+    value(Lhm::SqlHelper.idx_spec(['title(10)', 'album']))
+      .must_equal('`title`(10), `album`')
   end
 end

data/spec/unit/table_spec.rb

@@ -11,7 +11,7 @@ describe Lhm::Table do
   describe 'names' do
     it 'should name destination' do
       @table = Lhm::Table.new('users')
-      @table.destination_name.must_equal 'lhmn_users'
+      value(@table.destination_name).must_equal 'lhmn_users'
     end
   end
 
@@ -23,25 +23,25 @@ describe Lhm::Table do
     it 'should be satisfied with a single column primary key called id' do
       @table = Lhm::Table.new('table', 'id')
       set_columns(@table, { 'id' => { :type => 'int(1)' } })
-      @table.satisfies_id_column_requirement?.must_equal true
+      value(@table.satisfies_id_column_requirement?).must_equal true
     end
 
     it 'should be satisfied with a primary key not called id, as long as there is still an id' do
       @table = Lhm::Table.new('table', 'uuid')
       set_columns(@table, { 'id' => { :type => 'int(1)' } })
-      @table.satisfies_id_column_requirement?.must_equal true
+      value(@table.satisfies_id_column_requirement?).must_equal true
     end
 
     it 'should be satisifed if display attributes are not present (deprecated in mysql 8)' do
       @table = Lhm::Table.new('table', 'id')
       set_columns(@table, { 'id' => { :type => 'int' } })
-      @table.satisfies_id_column_requirement?.must_equal true
+      value(@table.satisfies_id_column_requirement?).must_equal true
     end
 
     it 'should not be satisfied if id is not numeric' do
       @table = Lhm::Table.new('table', 'id')
       set_columns(@table, { 'id' => { :type => 'varchar(255)' } })
-      @table.satisfies_id_column_requirement?.must_equal false
+      value(@table.satisfies_id_column_requirement?).must_equal false
     end
   end
 end

data/spec/unit/throttler/slave_lag_spec.rb

@@ -39,7 +39,7 @@ describe Lhm::Throttler::Slave do
     @logs = StringIO.new
     Lhm.logger = Logger.new(@logs)
 
-    @dummy_mysql_client_config = lambda { {'username' => 'user', 'password' => 'pw', 'database' => 'db'} }
+    @dummy_mysql_client_config = lambda { { 'username' => 'user', 'password' => 'pw', 'database' => 'db' } }
   end
 
   describe "#client" do
@@ -64,7 +64,7 @@ describe Lhm::Throttler::Slave do
 
     describe 'with proper config' do
       it "creates a new Mysql2::Client" do
-        expected_config = {username: 'user', password: 'pw', database: 'db', host: 'slave'}
+        expected_config = { username: 'user', password: 'pw', database: 'db', host: 'slave' }
         Mysql2::Client.stubs(:new).with(expected_config).returns(mock())
 
         assert Lhm::Throttler::Slave.new('slave', @dummy_mysql_client_config).connection
@@ -73,8 +73,12 @@ describe Lhm::Throttler::Slave do
 
     describe 'with active record config' do
       it 'logs and creates client' do
-        active_record_config = {username: 'user', password: 'pw', database: 'db'}
-        ActiveRecord::Base.stubs(:connection_pool).returns(stub(spec: stub(config: active_record_config)))
+        active_record_config = { username: 'user', password: 'pw', database: 'db' }
+        if ActiveRecord::VERSION::MAJOR > 6 || ActiveRecord::VERSION::MAJOR == 6 && ActiveRecord::VERSION::MINOR >= 1
+          ActiveRecord::Base.stubs(:connection_pool).returns(stub(db_config: stub(configuration_hash: active_record_config)))
+        else
+          ActiveRecord::Base.stubs(:connection_pool).returns(stub(spec: stub(config: active_record_config)))
+        end
 
         Mysql2::Client.stubs(:new).returns(mock())
 
@@ -92,9 +96,9 @@ describe Lhm::Throttler::Slave do
       class Connection
         def self.query(query)
           if query == Lhm::Throttler::Slave::SQL_SELECT_MAX_SLAVE_LAG
-            [{'Seconds_Behind_Master' => 20}]
+            [{ 'Seconds_Behind_Master' => 20 }]
           elsif query == Lhm::Throttler::Slave::SQL_SELECT_SLAVE_HOSTS
-            [{'host' => '1.1.1.1:80'}]
+            [{ 'host' => '1.1.1.1:80' }]
           end
         end
       end
@@ -104,7 +108,7 @@ describe Lhm::Throttler::Slave do
 
       class StoppedConnection
         def self.query(query)
-          [{'Seconds_Behind_Master' => nil}]
+          [{ 'Seconds_Behind_Master' => nil }]
         end
       end
 
@@ -138,7 +142,7 @@ describe Lhm::Throttler::Slave do
         Lhm::Throttler::Slave.any_instance.stubs(:config).returns([])
 
         slave = Lhm::Throttler::Slave.new('slave', @dummy_mysql_client_config)
-        assert_send([Lhm.logger, :info, "Unable to connect and/or query slave: error"])
+        Logger.any_instance.expects(:info).with("Unable to connect and/or query slave: Can't connect to MySQL server")
         assert_equal(0, slave.lag)
       end
     end
@@ -286,7 +290,7 @@ describe Lhm::Throttler::SlaveLag do
       describe 'with the :check_only option' do
         describe 'with a callable argument' do
           before do
-            check_only = lambda {{'host' => '1.1.1.3'}}
+            check_only = lambda { { 'host' => '1.1.1.3' } }
             @throttler = Lhm::Throttler::SlaveLag.new :check_only => check_only
           end
 
@@ -300,6 +304,7 @@ describe Lhm::Throttler::SlaveLag do
         describe 'with a non-callable argument' do
           before do
             @throttler = Lhm::Throttler::SlaveLag.new :check_only => 'I cannot be called'
+
             def @throttler.master_slave_hosts
               ['1.1.1.1', '1.1.1.4']
             end