lhc 3.4.0 → 3.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb463da7364d39d932831f54620966aa82caafa6
-  data.tar.gz: 2af2b5e6e49064dc6cc6f116f1d4605496dd1dce
+  metadata.gz: b266f3f9dca6060abde6e24879a26487caec842e
+  data.tar.gz: 45fab92b295af92fdc2bc60488f1551471851c30
 SHA512:
-  metadata.gz: 723ca264ea852ba2c36f5a76c6775f0943a1a44395567b1701e40e54be6a4784b3d6b10a3c5b76727864987926d394b2ec2506066f633c57d63db6bab5e63947
-  data.tar.gz: d18edd4d615302b5c39c61c8d148b0880dcec0cd8e0be14fb0e151a87f90e9bed9dc75863d6955588810c2e84d3e61da068441c23c337885fae1d16550943af0
+  metadata.gz: 1d471705267c62e35f0a979c341f6a107cd7c03060698e21f72031d4d4aca57d4cbbc8c45aa1587cb01846fc18bb688acd33b893a2e7d545319717081bea113f
+  data.tar.gz: 6b913de77b69c93878445e073ae41363e2d0e6d31ca6baa4d7effec68b2142c20aef545426ac6798f8b62738612f1661f04239c21a0c90b762700da2b9cc13da

data/.rubocop.localch.yml

@@ -0,0 +1,190 @@
+# This is master rubocop configuration.
+# DO NOT EDIT THIS FILE - it WILL be overwriten on every config update
+AllCops:
+  TargetRubyVersion: 2.1
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+    - '**/Capfile'
+  Exclude:
+    - 'db/**/*'
+    - 'script/**/*'
+    - 'vendor/bundle/**/*'
+    - 'bin/**/*'
+    - 'config/unicorn.rb'
+    - 'config/compass.rb'
+    - 'Rakefile'
+
+Rails:
+  Enabled: true
+
+require:
+  - rubocop-rspec
+
+Lint/HandleExceptions:
+  Exclude:
+    - spec/**/*
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Performance/StringReplacement:
+  Enabled: false
+
+Performance/TimesMap:
+  Enabled: false
+
+Performance/RedundantBlockCall:
+  Enabled: false
+
+Performance/RedundantMatch:
+  Enabled: false
+
+Performance/RedundantMerge:
+  Enabled: false
+
+Performance/Casecmp:
+  Enabled: false
+
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Style/StringLiterals:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Exclude:
+    - spec/**/*
+
+Style/DotPosition:
+  EnforcedStyle: leading
+
+Style/AlignParameters:
+  Enabled: false
+
+Style/NumericLiterals:
+  Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+Style/GlobalVars:
+  Enabled: false
+
+Style/CommentAnnotation:
+  Enabled: false
+
+Style/SymbolProc:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/FormatString:
+  Enabled: false
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/BarePercentLiterals:
+  Enabled: false
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/UnneededCapitalW:
+  Enabled: false
+
+Style/UnneededPercentQ:
+  Enabled: false
+
+Style/BlockDelimiters:
+  Exclude:
+    - spec/**/*
+
+Style/BracesAroundHashParameters:
+  EnforcedStyle: context_dependent
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/AccessorMethodName:
+  Exclude:
+    - spec/support/pages/**/*
+
+Style/NegatedIf:
+  Enabled: false
+
+Style/MutableConstant:
+  Enabled: false
+
+Style/ConditionalAssignment:
+  Enabled: false
+
+Style/IndentArray:
+  EnforcedStyle: consistent
+
+Style/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+RSpec/DescribeClass:
+  Exclude:
+    - spec/views/**/*
+    - spec/routing/**/*
+    - spec/requests/**/*
+    - spec/features/**/*
+
+RSpec/FilePath:
+  Enabled: false
+
+Rails/Output:
+  Exclude:
+    - 'config/application.rb'
+    - 'config/initializers/asset_manifest_warning.rb'

data/.rubocop.yml

@@ -0,0 +1,10 @@
+# This is project specific rubocop configuration file.
+# You can tweak project settings here
+inherit_from:
+  - ./.rubocop.localch.yml
+
+Lint/IneffectiveAccessModifier:
+  Enabled: false
+
+Rails:
+  Enabled: false

data/cider-ci.yml

@@ -1,3 +1,4 @@
 jobs:
   _cider-ci_include:
-    - cider-ci/jobs/tests.yml
+    - cider-ci/jobs/rubocop.yml
+    - cider-ci/jobs/rspec.yml

data/cider-ci/jobs/rspec.yml

@@ -0,0 +1,48 @@
+rspec:
+  name: 'RSPec tests'
+
+  run-on:
+    - type: branch
+      include-match: ^.*$
+
+  context:
+    task-defaults:
+      ports:
+        CAPYBARA_PORT:
+          inet_address: "localhost"
+          min: 8000
+          max: 8999
+        PHANTOMJS_PORT:
+          inet_address: "localhost"
+          min: 44600
+          max: 44999
+
+      scripts:
+        rspec:
+          start-when:
+            - script: bundle
+            - script: ruby-version
+            - script: tmp-cache
+
+
+        _cider-ci_include:
+          - cider-ci/scripts/bundle.yml
+          - cider-ci/scripts/tmp-cache.yml
+          - cider-ci/scripts/ruby-version.yml
+          - cider-ci/scripts/rspec.yml
+
+
+      trial-attachments:
+        logs:
+          include-match: log\/.*\.log$
+          content-type: text/plain
+        image-screenshots:
+          include-match: tmp\/capybara\/.*\.png$
+          content-type: image/png
+        html-screenshots:
+          include-match: tmp\/capybara\/.*\.html$
+          content-type: text/html
+
+    _cider-ci_generate-tasks:
+      include-match: spec/.*_spec.rb
+      exclude-match: spec/support/shared/*

data/cider-ci/jobs/rubocop.yml

@@ -0,0 +1,55 @@
+rubocop:
+  name: 'Rubocop analysis'
+
+  run-on:
+    - type: branch
+      include-match: ^.*$
+
+  context:
+    task-defaults:
+      environment-variables:
+        GIT_REPOSITORY: local-ch/location-app
+        RESULT_PATH: 'tmp/checkstyle.json'
+
+      scripts:
+        rubocop:
+          start-when:
+            - script: bundle
+            - script: ruby-version
+            - script: tmp-cache
+
+        
+        github_comment:
+          start-when:
+            - script: rubocop
+              states: [failed]
+        
+
+        _cider-ci_include:
+          - cider-ci/scripts/bundle.yml
+          - cider-ci/scripts/tmp-cache.yml
+          - cider-ci/scripts/ruby-version.yml
+          - cider-ci/scripts/rubocop.yml
+          
+          - cider-ci/scripts/github_comment.yml
+          
+
+      max-auto-trials: 1
+
+      trial-attachments:
+        logs:
+          include-match: tmp\/checkstyle.json$
+          content-type: application/json
+
+      tree-attachments:
+        logs:
+          include-match: tmp\/checkstyle.json$
+          content-type: application/json
+
+    tasks:
+      rubocop:
+        scripts:
+          rubocop: {}
+          
+          github_comment: {}
+          

data/cider-ci/scripts/bundle.yml

@@ -0,0 +1,2 @@
+bundle:
+  body: sed 's/^source.*/source "http\:\/\/52.29.7.59:9292"/g' Gemfile > Gemfile.tmp ; mv Gemfile.tmp Gemfile && bundle install

data/cider-ci/scripts/github_comment.yml

@@ -0,0 +1,6 @@
+github_comment:
+  ignore-state: true
+  body: |
+    #!/usr/bin/env bash
+
+    bundle exec rake checkstyle

data/cider-ci/scripts/rspec.yml

@@ -0,0 +1,4 @@
+rspec:
+  body: |
+    #!/usr/bin/env bash
+    RAILS_ENV=test bundle exec rspec $CIDER_CI_TASK_FILE

data/cider-ci/scripts/rubocop.yml

@@ -0,0 +1,5 @@
+rubocop:
+  body: |
+    #!/usr/bin/env bash
+
+    bundle exec rubocop  --config .rubocop.yml --format json --out $RESULT_PATH --format progress

data/cider-ci/scripts/ruby-version.yml

@@ -0,0 +1,2 @@
+ruby-version:
+  body: ruby --version

data/cider-ci/scripts/tmp-cache.yml

@@ -0,0 +1,2 @@
+tmp-cache:
+  body: mkdir -p tmp/cache

data/lhc.gemspec

@@ -29,4 +29,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'webmock'
   s.add_development_dependency 'geminabox'
   s.add_development_dependency 'pry'
-end
+  s.add_development_dependency 'ciderizer'
+end

data/lib/lhc.rb

@@ -1,4 +1,4 @@
-Dir[File.dirname(__FILE__) + '/lhc/concerns/lhc/*.rb'].sort.each {|file| require file }
+Dir[File.dirname(__FILE__) + '/lhc/concerns/lhc/*.rb'].sort.each { |file| require file }
 
 module LHC
   include BasicMethods

data/lib/lhc/concerns/lhc/basic_methods.rb

@@ -1,12 +1,10 @@
 require 'active_support'
 
 module LHC
-
   module BasicMethods
     extend ActiveSupport::Concern
 
     module ClassMethods
-
       def request(options)
         if options.is_a? Array
           parallel_requests(options)
@@ -18,8 +16,8 @@ module LHC
       [:get, :post, :put, :delete].each do |http_method|
         define_method(http_method) do |url, options = {}|
           request(options.merge(
-            url: url,
-            method: http_method
+                    url: url,
+                    method: http_method
           ))
         end
       end
@@ -29,8 +27,8 @@ module LHC
       def parallel_requests(options)
         hydra = Typhoeus::Hydra.hydra
         requests = []
-        options.each do |options|
-          request = LHC::Request.new(options, false)
+        options.each do |option|
+          request = LHC::Request.new(option, false)
           requests << request
           hydra.queue request.raw
         end

data/lib/lhc/concerns/lhc/formats.rb

@@ -1,10 +1,8 @@
 module LHC
-
   module Formats
     extend ActiveSupport::Concern
 
     module ClassMethods
-
       def json
         JsonFormat
       end

data/lib/lhc/endpoint.rb

@@ -13,11 +13,12 @@ class LHC::Endpoint
 
   def compile(params)
     url.gsub(PLACEHOLDER) do |match|
-      replacement = if params.is_a? Proc
-        params.call(match)
-      else
-        find_value(match, params)
-      end
+      replacement =
+        if params.is_a? Proc
+          params.call(match)
+        else
+          find_value(match, params)
+        end
       replacement || fail("Compilation incomplete. Unable to find value for #{match.gsub(':', '')}.")
     end
   end
@@ -34,7 +35,8 @@ class LHC::Endpoint
     removed = {}
     url.scan(PLACEHOLDER) do |match|
       match = match.gsub(/^\:/, '')
-      if value = find_value(match, params)
+      value = find_value(match, params)
+      if value
         removed[match.to_sym] = value
         params.delete(match.to_sym)
       end