lhc 3.4.0 → 3.5.0

data/spec/dummy/bin/rails

@@ -1,4 +1,4 @@
 #!/usr/bin/env ruby
-APP_PATH = File.expand_path('../../config/application',  __FILE__)
+APP_PATH = File.expand_path('../../config/application', __FILE__)
 require_relative '../config/boot'
 require 'rails/commands'

data/spec/dummy/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run Rails.application

data/spec/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,3 @@
 # Be sure to restart your server when you modify this file.
 
-Rails.application.config.action_dispatch.cookies_serializer = :json
+Rails.application.config.action_dispatch.cookies_serializer = :json

data/spec/endpoint/compile_spec.rb

@@ -1,20 +1,18 @@
 require 'rails_helper'
 
 describe LHC::Endpoint do
-
   context 'compile' do
-
     it 'uses parameters for interpolation' do
-      endpoint = LHC::Endpoint.new(':datastore/v2/:campaign_id/feedbacks')
+      endpoint = described_class.new(':datastore/v2/:campaign_id/feedbacks')
       expect(
         endpoint.compile(datastore: 'http://datastore', campaign_id: 'abc')
       ).to eq "http://datastore/v2/abc/feedbacks"
     end
 
     it 'uses provided proc to find values' do
-      endpoint = LHC::Endpoint.new(':datastore/v2')
+      endpoint = described_class.new(':datastore/v2')
       config = { datastore: 'http://datastore' }
-      find_value = ->(match){
+      find_value = lambda { |match|
         config[match.gsub(':', '').to_sym]
       }
       expect(

data/spec/endpoint/match_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHC::Endpoint do
-
   context 'match' do
-
     context 'matching' do
       it 'checks if a url matches a template' do
         {
@@ -12,23 +10,23 @@ describe LHC::Endpoint do
           ':datastore/v2/places/:namespace/:id' => 'http://local.ch:8082/v2/places/switzerland/ZW9OJyrbt'
         }.each do |template, url|
           expect(
-            LHC::Endpoint.match?(url, template)
+            described_class.match?(url, template)
           ).to be, "#{url} should match #{template}!"
         end
       end
     end
 
     context 'not matching' do
-        it 'checks if a url matches a template' do
-          {
-            ':datastore/v2/places' => 'http://local.ch:8082/v2/places/ZW9OJyrbt4OZE9ueu80w-A',
-            ':datastore/:campaign_id/feedbacks' => 'http://datastore.local.ch/feedbacks'
-          }.each do |template, url|
-            expect(
-              LHC::Endpoint.match?(url, template)
-            ).not_to be, "#{url} should not match #{template}!"
-          end
+      it 'checks if a url matches a template' do
+        {
+          ':datastore/v2/places' => 'http://local.ch:8082/v2/places/ZW9OJyrbt4OZE9ueu80w-A',
+          ':datastore/:campaign_id/feedbacks' => 'http://datastore.local.ch/feedbacks'
+        }.each do |template, url|
+          expect(
+            described_class.match?(url, template)
+          ).not_to be, "#{url} should not match #{template}!"
         end
+      end
     end
   end
 end

data/spec/endpoint/placeholders_spec.rb

@@ -1,11 +1,9 @@
 require 'rails_helper'
 
 describe LHC::Endpoint do
-
   context 'placeholders' do
-
     it 'returns all placeholders alphabetically sorted' do
-      endpoint = LHC::Endpoint.new(':datastore/v2/:campaign_id/feedbacks')
+      endpoint = described_class.new(':datastore/v2/:campaign_id/feedbacks')
       expect(
         endpoint.placeholders
       ).to eq [':campaign_id', ':datastore']

data/spec/endpoint/remove_interpolated_params_spec.rb

@@ -1,16 +1,15 @@
 require 'rails_helper'
 
 describe LHC::Endpoint do
-
   it 'removes params used for interpolation' do
     params = {
       datastore: 'http://datastore',
       campaign_id: 'abc',
       has_reviews: true
     }
-    endpoint = LHC::Endpoint.new(':datastore/v2/:campaign_id/feedbacks')
+    endpoint = described_class.new(':datastore/v2/:campaign_id/feedbacks')
     removed = endpoint.remove_interpolated_params!(params)
-    expect(params).to eq ({ has_reviews: true })
+    expect(params).to eq(has_reviews: true)
     expect(removed).to eq(datastore: 'http://datastore', campaign_id: 'abc')
   end
 end

data/spec/endpoint/values_as_params_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHC::Endpoint do
-
   context 'values_as_params' do
-
     it 'provides params extracting values from a provided url and template' do
       [
         [':datastore/v2/places', 'http://local.ch:8082/v2/places', {
@@ -17,9 +15,9 @@ describe LHC::Endpoint do
           datastore: 'http://local.ch:8082',
           namespace: 'switzerland',
           id: 'ZW9OJyrbt'
-        }],
+        }]
       ].each do |example|
-        params = LHC::Endpoint.values_as_params(example[0], example[1])
+        params = described_class.values_as_params(example[0], example[1])
         expect(params).to eq example[2]
       end
     end

data/spec/error/find_spec.rb

@@ -1,56 +1,54 @@
 require 'rails_helper'
 
 describe LHC::Error do
-
   def response(code)
-    LHC::Response.new(OpenStruct.new({code: code}), nil)
+    LHC::Response.new(OpenStruct.new(code: code), nil)
   end
 
   context 'find' do
-
     it 'finds error class by status code' do
-      expect(LHC::Error.find(response('400'))).to eq LHC::BadRequest
-      expect(LHC::Error.find(response('401'))).to eq LHC::Unauthorized
-      expect(LHC::Error.find(response('402'))).to eq LHC::PaymentRequired
-      expect(LHC::Error.find(response('403'))).to eq LHC::Forbidden
-      expect(LHC::Error.find(response('403'))).to eq LHC::Forbidden
-      expect(LHC::Error.find(response('404'))).to eq LHC::NotFound
-      expect(LHC::Error.find(response('405'))).to eq LHC::MethodNotAllowed
-      expect(LHC::Error.find(response('406'))).to eq LHC::NotAcceptable
-      expect(LHC::Error.find(response('407'))).to eq LHC::ProxyAuthenticationRequired
-      expect(LHC::Error.find(response('408'))).to eq LHC::RequestTimeout
-      expect(LHC::Error.find(response('409'))).to eq LHC::Conflict
-      expect(LHC::Error.find(response('410'))).to eq LHC::Gone
-      expect(LHC::Error.find(response('411'))).to eq LHC::LengthRequired
-      expect(LHC::Error.find(response('412'))).to eq LHC::PreconditionFailed
-      expect(LHC::Error.find(response('413'))).to eq LHC::RequestEntityTooLarge
-      expect(LHC::Error.find(response('414'))).to eq LHC::RequestUriToLong
-      expect(LHC::Error.find(response('415'))).to eq LHC::UnsupportedMediaType
-      expect(LHC::Error.find(response('416'))).to eq LHC::RequestedRangeNotSatisfiable
-      expect(LHC::Error.find(response('417'))).to eq LHC::ExpectationFailed
-      expect(LHC::Error.find(response('422'))).to eq LHC::UnprocessableEntity
-      expect(LHC::Error.find(response('423'))).to eq LHC::Locked
-      expect(LHC::Error.find(response('424'))).to eq LHC::FailedDependency
-      expect(LHC::Error.find(response('426'))).to eq LHC::UpgradeRequired
-      expect(LHC::Error.find(response('500'))).to eq LHC::InternalServerError
-      expect(LHC::Error.find(response('501'))).to eq LHC::NotImplemented
-      expect(LHC::Error.find(response('502'))).to eq LHC::BadGateway
-      expect(LHC::Error.find(response('503'))).to eq LHC::ServiceUnavailable
-      expect(LHC::Error.find(response('504'))).to eq LHC::GatewayTimeout
-      expect(LHC::Error.find(response('505'))).to eq LHC::HttpVersionNotSupported
-      expect(LHC::Error.find(response('507'))).to eq LHC::InsufficientStorage
-      expect(LHC::Error.find(response('510'))).to eq LHC::NotExtended
+      expect(described_class.find(response('400'))).to eq LHC::BadRequest
+      expect(described_class.find(response('401'))).to eq LHC::Unauthorized
+      expect(described_class.find(response('402'))).to eq LHC::PaymentRequired
+      expect(described_class.find(response('403'))).to eq LHC::Forbidden
+      expect(described_class.find(response('403'))).to eq LHC::Forbidden
+      expect(described_class.find(response('404'))).to eq LHC::NotFound
+      expect(described_class.find(response('405'))).to eq LHC::MethodNotAllowed
+      expect(described_class.find(response('406'))).to eq LHC::NotAcceptable
+      expect(described_class.find(response('407'))).to eq LHC::ProxyAuthenticationRequired
+      expect(described_class.find(response('408'))).to eq LHC::RequestTimeout
+      expect(described_class.find(response('409'))).to eq LHC::Conflict
+      expect(described_class.find(response('410'))).to eq LHC::Gone
+      expect(described_class.find(response('411'))).to eq LHC::LengthRequired
+      expect(described_class.find(response('412'))).to eq LHC::PreconditionFailed
+      expect(described_class.find(response('413'))).to eq LHC::RequestEntityTooLarge
+      expect(described_class.find(response('414'))).to eq LHC::RequestUriToLong
+      expect(described_class.find(response('415'))).to eq LHC::UnsupportedMediaType
+      expect(described_class.find(response('416'))).to eq LHC::RequestedRangeNotSatisfiable
+      expect(described_class.find(response('417'))).to eq LHC::ExpectationFailed
+      expect(described_class.find(response('422'))).to eq LHC::UnprocessableEntity
+      expect(described_class.find(response('423'))).to eq LHC::Locked
+      expect(described_class.find(response('424'))).to eq LHC::FailedDependency
+      expect(described_class.find(response('426'))).to eq LHC::UpgradeRequired
+      expect(described_class.find(response('500'))).to eq LHC::InternalServerError
+      expect(described_class.find(response('501'))).to eq LHC::NotImplemented
+      expect(described_class.find(response('502'))).to eq LHC::BadGateway
+      expect(described_class.find(response('503'))).to eq LHC::ServiceUnavailable
+      expect(described_class.find(response('504'))).to eq LHC::GatewayTimeout
+      expect(described_class.find(response('505'))).to eq LHC::HttpVersionNotSupported
+      expect(described_class.find(response('507'))).to eq LHC::InsufficientStorage
+      expect(described_class.find(response('510'))).to eq LHC::NotExtended
     end
 
     it 'finds error class also by extended status codes' do
-      expect(LHC::Error.find(response('40001'))).to eq LHC::BadRequest
-      expect(LHC::Error.find(response('50002'))).to eq LHC::InternalServerError
+      expect(described_class.find(response('40001'))).to eq LHC::BadRequest
+      expect(described_class.find(response('50002'))).to eq LHC::InternalServerError
     end
 
     it 'returns UnknownError if no specific error was found' do
-      expect(LHC::Error.find(response('0'))).to eq LHC::UnknownError
-      expect(LHC::Error.find(response(''))).to eq LHC::UnknownError
-      expect(LHC::Error.find(response('600'))).to eq LHC::UnknownError
+      expect(described_class.find(response('0'))).to eq LHC::UnknownError
+      expect(described_class.find(response(''))).to eq LHC::UnknownError
+      expect(described_class.find(response('600'))).to eq LHC::UnknownError
     end
   end
 end

data/spec/error/response_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHC::Error do
-
   context 'response' do
-
     it 'throws timeout exception in case of a timeout' do
       stub_request(:any, 'local.ch').to_return(status: 403)
       begin

data/spec/error/timeout_spec.rb

@@ -1,12 +1,10 @@
 require 'rails_helper'
 
 describe LHC::Error do
-
   context 'timeout' do
-
     it 'throws timeout exception in case of a timeout' do
       stub_request(:any, 'local.ch').to_timeout
-      expect(->{
+      expect(lambda {
         LHC.get('local.ch')
       }).to raise_error LHC::Timeout
     end

data/spec/interceptors/after_request_spec.rb

@@ -1,21 +1,19 @@
 require 'rails_helper'
 
 describe LHC do
-
   context 'interceptor' do
-
     before(:each) do
       class SomeInterceptor < LHC::Interceptor
         def after_request(request)
         end
       end
-      LHC.configure { |c| c.interceptors = [SomeInterceptor] }
+      described_class.configure { |c| c.interceptors = [SomeInterceptor] }
     end
 
     it 'can perform some actions after a request was fired' do
       expect_any_instance_of(SomeInterceptor).to receive(:after_request)
       stub_request(:get, 'http://local.ch')
-      LHC.get('http://local.ch')
+      described_class.get('http://local.ch')
     end
   end
 end

data/spec/interceptors/after_response_spec.rb

@@ -1,12 +1,10 @@
 require 'rails_helper'
 
 describe LHC do
-
   context 'interceptor' do
-
     before(:each) do
       class Services
-        def self.timing(path, time)
+        def self.timing(_path, _time)
         end
       end
     end
@@ -27,7 +25,7 @@ describe LHC do
           Services.timing(path.downcase, response.time)
         end
       end
-      LHC.configure { |c| c.interceptors = [StatsTimingInterceptor] }
+      described_class.configure { |c| c.interceptors = [StatsTimingInterceptor] }
     end
 
     let(:url) { "http://local.ch/v2/feedbacks/-Sc4_pYNpqfsudzhtivfkA" }
@@ -35,7 +33,7 @@ describe LHC do
     it 'can take action after a response was received' do
       allow(Services).to receive(:timing).with('web.dummy.test.get.http.local.ch.200', 0)
       stub_request(:get, url)
-      LHC.get(url)
+      described_class.get(url)
       expect(Services).to have_received(:timing)
     end
   end

data/spec/interceptors/before_request_spec.rb

@@ -1,21 +1,19 @@
 require 'rails_helper'
 
 describe LHC do
-
   context 'interceptor' do
-
     before(:each) do
       class TrackingIdInterceptor < LHC::Interceptor
         def before_request(request)
           request.params[:tid] = 123
         end
       end
-      LHC.configure { |c| c.interceptors = [TrackingIdInterceptor] }
+      described_class.configure { |c| c.interceptors = [TrackingIdInterceptor] }
     end
 
     it 'can modify requests before they are send' do
       stub_request(:get, "http://local.ch/?tid=123")
-      LHC.get('http://local.ch')
+      described_class.get('http://local.ch')
     end
   end
 end

data/spec/interceptors/before_response_spec.rb

@@ -1,21 +1,19 @@
 require 'rails_helper'
 
 describe LHC do
-
   context 'interceptor' do
-
     before(:each) do
       class SomeInterceptor < LHC::Interceptor
         def before_response(request)
         end
       end
-      LHC.configure { |c| c.interceptors = [SomeInterceptor] }
+      described_class.configure { |c| c.interceptors = [SomeInterceptor] }
     end
 
     it 'can perform some actions before a reponse is received' do
       expect_any_instance_of(SomeInterceptor).to receive(:before_response)
       stub_request(:get, 'http://local.ch')
-      LHC.get('http://local.ch')
+      described_class.get('http://local.ch')
     end
   end
 end

data/spec/interceptors/default_interceptors_spec.rb

@@ -1,15 +1,13 @@
 require 'rails_helper'
 
 describe LHC do
-
   context 'default interceptors' do
-
     before(:each) do
-      LHC.configure {}
+      described_class.configure {}
     end
 
-    it 'should always return a list for default interceptors' do
-      expect(LHC.config.interceptors).to eq []
+    it 'alwayses return a list for default interceptors' do
+      expect(described_class.config.interceptors).to eq []
     end
   end
 end

data/spec/interceptors/define_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHC do
-
   context 'interceptor' do
-
     before(:each) do
       class SomeInterceptor < LHC::Interceptor
       end
@@ -12,18 +10,18 @@ describe LHC do
     end
 
     it 'performs interceptor when they are set globally' do
-      LHC.configure { |c| c.interceptors = [SomeInterceptor] }
+      described_class.configure { |c| c.interceptors = [SomeInterceptor] }
       expect_any_instance_of(SomeInterceptor).to receive(:before_request)
       stub_request(:get, 'http://local.ch')
-      LHC.get('http://local.ch')
+      described_class.get('http://local.ch')
     end
 
     it 'overrides interceptors on request level' do
-      LHC.configure { |c| c.interceptors = [SomeInterceptor] }
+      described_class.configure { |c| c.interceptors = [SomeInterceptor] }
       expect_any_instance_of(AnotherInterceptor).to receive(:before_request)
       expect_any_instance_of(SomeInterceptor).not_to receive(:before_request)
       stub_request(:get, 'http://local.ch')
-      LHC.get('http://local.ch', interceptors: [AnotherInterceptor])
+      described_class.get('http://local.ch', interceptors: [AnotherInterceptor])
     end
   end
 end

data/spec/interceptors/response_competition_spec.rb

@@ -1,21 +1,20 @@
 require 'rails_helper'
 
 describe LHC do
-
   context 'interceptor response competition' do
-
     before(:each) do
-
+      # rubocop:disable Style/ClassVars
       class LocalCacheInterceptor < LHC::Interceptor
         @@cached = false
         cattr_accessor :cached
 
-        def before_request(request)
+        def before_request(_request)
           if @@cached
             return LHC::Response.new(Typhoeus::Response.new(response_body: 'Im served from local cache'), nil)
           end
         end
       end
+      # rubocop:enable Style/ClassVars
 
       class RemoteCacheInterceptor < LHC::Interceptor
 
@@ -26,14 +25,14 @@ describe LHC do
         end
       end
 
-      LHC.configure { |c| c.interceptors = [LocalCacheInterceptor, RemoteCacheInterceptor] }
+      described_class.configure { |c| c.interceptors = [LocalCacheInterceptor, RemoteCacheInterceptor] }
     end
 
     it 'can handle multiple interceptors that compete for returning the response' do
-      response = LHC.get('http://local.ch')
+      response = described_class.get('http://local.ch')
       expect(response.body).to eq 'Im served from remote cache'
       LocalCacheInterceptor.cached = true
-      response = LHC.get('http://local.ch')
+      response = described_class.get('http://local.ch')
       expect(response.body).to eq 'Im served from local cache'
     end
   end