lhc 6.2.0 → 6.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7caf5dc6e24346cc42e287a8bac832cd81011c5a
-  data.tar.gz: 17bd6df84e9fce4212921c8348b2053031f62da1
+  metadata.gz: 503f2e88095de04d6f071fd2285459f106ff2f7d
+  data.tar.gz: 1e7c8bd5c1878d11ce293208c43f7886714891bf
 SHA512:
-  metadata.gz: cb849054f246290fe96388ed66abaf3ded5dc8d2a00b7eb7afd857efbfd3d9e820bf0014780c296a37f865c2665cee1b399f1a6d9bc549d48092177cb4885908
-  data.tar.gz: 2f3a0b17c338a1c36dca14e1fa2b3cfc3d1897263cc373a9912a4da9717c5a909677cc4c0fd987ef7e010c964ad2529ae4df816db31384560be826bc28d2256e
+  metadata.gz: 0e8fbabecb039bfe29377cdd7ee30f52aea980d459918953f5df9b1e92b48c9e15ce15392122dc1dabb9934ca3fc8ac5fb44d2c6f64a1545996bebe24ca6d12e
+  data.tar.gz: a21700e4b7979715066c2659bc492fee013dee54a0471427f6c6dac414c3ff94855bb1b289f3c6900d36714e7200b105e52ec1f46067aeb16909d6a837458d05

data/README.md

@@ -139,7 +139,7 @@ Anything but a response code indicating success (2**) throws an exception.
 
 → [Read more about exceptions](docs/exceptions.md)
 
-## Custom error handling
+### Custom error handling
 
 You can provide custom error handlers to handle errors happening during the request.
 
@@ -153,6 +153,20 @@ response = LHC.get('http://something', error_handler: handler)
 response.data.name # 'unknown'
 ```
 
+### Ignore certain errors
+
+As it's discouraged to rescue errors and then don't handle them (ruby styleguide),
+but you often want to continue working with `nil`, LHC provides the `ignored_errors` option.
+
+Errors listed in this option will not be raised and will leave the `response.body` and `response.data` to stay `nil`.
+
+```ruby
+response = LHC.get('http://something', ignored_errors: [LHC::NotFound])
+
+response.body # nil
+response.data # nil
+```
+
 ## Interceptors
 
 To monitor and manipulate the http communication done with LHC, you can define interceptors.

data/lib/lhc/request.rb

@@ -8,9 +8,10 @@ class LHC::Request
 
   TYPHOEUS_OPTIONS ||= [:params, :method, :body, :headers, :follow_location]
 
-  attr_accessor :response, :options, :raw, :format, :error_handler
+  attr_accessor :response, :options, :raw, :format, :error_handler, :errors_ignored
 
   def initialize(options, self_executing = true)
+    self.errors_ignored = options.fetch(:ignored_errors, [])
     self.options = options.deep_dup || {}
     self.error_handler = options.delete :error_handler
     use_configured_endpoint!
@@ -101,12 +102,16 @@ class LHC::Request
   end
 
   def handle_error(response)
+    return if errors_ignored.include?(error)
     throw_error(response) unless error_handler
     response.body_replacement = error_handler.call(response)
   end
 
+  def error
+    @error ||= LHC::Error.find(response)
+  end
+
   def throw_error(response)
-    error = LHC::Error.find(response)
     fail error.new(error, response)
   end
 end

data/lib/lhc/response.rb

@@ -20,7 +20,7 @@ class LHC::Response
   end
 
   def data
-    @data ||= LHC::Response::Data.new(self)
+    @data ||= body.present? ? LHC::Response::Data.new(self) : nil
   end
 
   def [](key)
@@ -28,7 +28,7 @@ class LHC::Response
   end
 
   def body
-    body_replacement || raw.body
+    body_replacement || raw.body.presence
   end
 
   # Provides response time in ms.

data/lib/lhc/version.rb

@@ -1,3 +1,3 @@
 module LHC
-  VERSION ||= "6.2.0"
+  VERSION ||= "6.3.0"
 end

data/spec/request/ignore_errors_spec.rb

@@ -0,0 +1,13 @@
+require 'rails_helper'
+
+describe LHC::Request do
+  context 'ignore errors' do
+    it 'raises errors for anything but 2XX response codes' do
+      stub_request(:get, 'http://local.ch').to_return(status: 404)
+      response = LHC.get('http://local.ch', ignored_errors: [LHC::NotFound])
+      expect(response.body).to eq nil
+      expect(response.data).to eq nil
+      expect(response.success?).to eq false
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 6.2.0
+  version: 6.3.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhc/contributors
@@ -278,6 +278,7 @@ files:
 - spec/request/encoding_spec.rb
 - spec/request/error_handling_spec.rb
 - spec/request/headers_spec.rb
+- spec/request/ignore_errors_spec.rb
 - spec/request/option_dup_spec.rb
 - spec/request/parallel_requests_spec.rb
 - spec/request/request_without_rails_spec.rb
@@ -320,7 +321,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: LocalHttpClient
@@ -405,6 +406,7 @@ test_files:
 - spec/request/encoding_spec.rb
 - spec/request/error_handling_spec.rb
 - spec/request/headers_spec.rb
+- spec/request/ignore_errors_spec.rb
 - spec/request/option_dup_spec.rb
 - spec/request/parallel_requests_spec.rb
 - spec/request/request_without_rails_spec.rb