lhc 13.2.0 → 13.4.0.pre.pro1766.1

data/spec/request/scrubbed_options_spec.rb

@@ -0,0 +1,185 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe LHC::Request do
+  before :each do
+    LHC.config.interceptors = [LHC::Auth]
+    LHC.config.endpoint(:local, 'http://local.ch', auth: auth)
+    LHC.config.scrubs[:params] << 'api_key'
+    LHC.config.scrubs[:headers] << 'private_key'
+    LHC.config.scrubs[:body] << 'user_token'
+    stub_request(:post, "http://local.ch?#{params.to_query}").with(headers: authorization_header.merge(headers), body: body.to_json)
+  end
+
+  let(:bearer_token) { '123456' }
+  let(:authorization_header) { { 'Authorization' => "Bearer #{bearer_token}" } }
+  let(:auth) { { bearer: -> { bearer_token } } }
+  let(:params) { { api_key: 'api-key-params' } }
+  let(:headers) { { private_key: 'private-key-header' } }
+  let(:body) { { user_token: 'user-token-body' } }
+
+  let(:request) do
+    response = LHC.post(:local, params: params, headers: headers, body: body)
+    response.request
+  end
+
+  it 'provides srubbed request options' do
+    expect(request.scrubbed_options[:params]).to include(api_key: LHC::Scrubber::SCRUB_DISPLAY)
+    expect(request.scrubbed_options[:headers]).to include(private_key: LHC::Scrubber::SCRUB_DISPLAY)
+    expect(request.scrubbed_options[:body]).to include(user_token: LHC::Scrubber::SCRUB_DISPLAY)
+    expect(request.scrubbed_options[:auth][:bearer_token]).to eq(LHC::Scrubber::SCRUB_DISPLAY)
+    expect(request.scrubbed_options[:auth][:basic]).to be nil
+  end
+
+  context 'when options do not have auth' do
+    let(:authorization_header) { {} }
+    let(:auth) { nil }
+
+    it 'provides srubbed request options' do
+      expect(request.scrubbed_options[:params]).to include(api_key: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:headers]).to include(private_key: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:body]).to include(user_token: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:auth]).to be nil
+    end
+  end
+
+  context 'when body data is nested' do
+    let(:body) do
+      {
+        data: {
+          attributes: {
+            employee: {
+              name: 'Muster',
+              surname: 'Hans',
+              password: 'test-1234',
+              password_confirmation: 'test-1234'
+            }
+          }
+        }
+      }
+    end
+
+    it 'srubbes nested attributes' do
+      expect(request.scrubbed_options[:params]).to include(api_key: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:headers]).to include(private_key: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:body][:data][:attributes][:employee]).to include(password: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:body][:data][:attributes][:employee]).to include(password_confirmation: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:auth][:bearer_token]).to eq(LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:auth][:basic]).to be nil
+    end
+  end
+
+  context 'basic authentication' do
+    let(:username) { 'steve' }
+    let(:password) { 'abcdefg' }
+    let(:credentials_base_64_codiert) { Base64.strict_encode64("#{username}:#{password}").chomp }
+    let(:authorization_header) { { 'Authorization' => "Basic #{credentials_base_64_codiert}" } }
+    let(:auth) { { basic: { username: username, password: password } } }
+
+    it 'provides srubbed request headers' do
+      expect(request.scrubbed_options[:auth][:basic][:username]).to eq(LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:auth][:basic][:password]).to eq(LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:auth][:basic][:base_64_encoded_credentials]).to eq(LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:auth][:bearer]).to be nil
+    end
+  end
+
+  context 'when nothing should get scrubbed' do
+    before :each do
+      LHC.config.scrubs = {}
+    end
+
+    it 'does not filter anything' do
+      expect(request.scrubbed_options[:params]).not_to include(api_key: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:headers]).not_to include(private_key: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:body]).not_to include(user_token: LHC::Scrubber::SCRUB_DISPLAY)
+      expect(request.scrubbed_options[:auth][:bearer_token]).not_to eq(LHC::Scrubber::SCRUB_DISPLAY)
+    end
+  end
+
+  context 'custom data structures that respond to as_json (like LHS data or record)' do
+    before do
+      class CustomStructure
+
+        def initialize(data)
+          @data = data
+        end
+
+        def as_json
+          @data.as_json
+        end
+
+        def to_json
+          as_json.to_json
+        end
+      end
+
+      stub_request(:post, 'http://local.ch').with(body: custom_structure.to_json)
+    end
+
+    let(:custom_structure) do
+      CustomStructure.new(user_token: '12345')
+    end
+
+    let(:request) do
+      response = LHC.post(:local, body: custom_structure)
+      response.request
+    end
+
+    it 'provides srubbed request options' do
+      expect(request.scrubbed_options[:body]).to include('user_token' => LHC::Scrubber::SCRUB_DISPLAY)
+    end
+  end
+
+  context 'encoded data hash' do
+    let(:body) { { user_token: 'user-token-body' } }
+
+    let(:request) do
+      response = LHC.post(:local, body: body.to_json)
+      response.request
+    end
+
+    before :each do
+      stub_request(:post, 'http://local.ch').with(body: body.to_json)
+    end
+
+    it 'provides srubbed request options' do
+      expect(request.scrubbed_options[:body]).to include('user_token' => LHC::Scrubber::SCRUB_DISPLAY)
+    end
+  end
+
+  context 'array' do
+    let(:body) { [{ user_token: 'user-token-body' }] }
+
+    let(:request) do
+      response = LHC.post(:local, body: body)
+      response.request
+    end
+
+    before :each do
+      stub_request(:post, 'http://local.ch').with(body: body.to_json)
+    end
+
+    it 'provides srubbed request options' do
+      expect(request.scrubbed_options[:body]).to eq([user_token: LHC::Scrubber::SCRUB_DISPLAY])
+    end
+  end
+
+  context 'encoded array' do
+    let(:body) { [{ user_token: 'user-token-body' }] }
+
+    let(:request) do
+      response = LHC.post(:local, body: body.to_json)
+      response.request
+    end
+
+    before :each do
+      stub_request(:post, 'http://local.ch').with(body: body.to_json)
+    end
+
+    it 'provides srubbed request options' do
+      expect(request.scrubbed_options[:body]).to eq(['user_token' => LHC::Scrubber::SCRUB_DISPLAY])
+    end
+  end
+end

data/spec/request/scrubbed_params_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe LHC::Request do
+  let(:params) { { api_key: 'xyz-123', secret_key: '123-xyz' } }
+  let(:response) { LHC.get(:local, params: params) }
+
+  before :each do
+    LHC.config.endpoint(:local, 'http://local.ch')
+    stub_request(:get, "http://local.ch?#{params.to_query}")
+  end
+
+  it 'scrubs "api_key"' do
+    LHC.config.scrubs[:params] << 'api_key'
+    expect(response.request.scrubbed_params).to include(api_key: LHC::Scrubber::SCRUB_DISPLAY)
+    expect(response.request.scrubbed_params).to include(secret_key: '123-xyz')
+  end
+
+  it 'scrubs "api_key" and "secret_key"' do
+    LHC.config.scrubs[:params].push('api_key', 'secret_key')
+    expect(response.request.scrubbed_params).to include(api_key: LHC::Scrubber::SCRUB_DISPLAY)
+    expect(response.request.scrubbed_params).to include(secret_key: LHC::Scrubber::SCRUB_DISPLAY)
+  end
+end

data/spec/response/data_spec.rb

@@ -75,9 +75,9 @@ describe LHC::Response do
     it 'does not throw a stack level to deep issue when accessing data in a rescue context' do
       begin
         LHC.get('http://listings')
-      rescue LHC::Error => error
+      rescue LHC::Error => e
         expect(
-          error.response.request.response.data.meta.errors.detect { |item| item.code == 2000 }.msg
+          e.response.request.response.data.meta.errors.detect { |item| item.code == 2000 }.msg
         ).to eq 'I like to hide error messages (this is meta).'
       end
     end

data/spec/support/zipkin_mock.rb

@@ -3,6 +3,7 @@
 module ZipkinTracer
   class TraceContainer
     attr_reader :trace_id, :parent_id, :span_id, :sampled, :flags
+
     class << self
       attr_accessor :current
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 13.2.0
+  version: 13.4.0.pre.pro1766.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhc/contributors
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-01 00:00:00.000000000 Z
+date: 2021-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -142,14 +142,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.57.1
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.57.1
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -205,7 +219,6 @@ files:
 - ".github/workflows/rubocop.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
-- ".rubocop.localch.yml"
 - ".rubocop.yml"
 - ".ruby-version"
 - Gemfile
@@ -257,6 +270,11 @@ files:
 - lib/lhc/response/data/collection.rb
 - lib/lhc/response/data/item.rb
 - lib/lhc/rspec.rb
+- lib/lhc/scrubber.rb
+- lib/lhc/scrubbers/auth_scrubber.rb
+- lib/lhc/scrubbers/body_scrubber.rb
+- lib/lhc/scrubbers/headers_scrubber.rb
+- lib/lhc/scrubbers/params_scrubber.rb
 - lib/lhc/test/cache_helper.rb
 - lib/lhc/version.rb
 - script/ci/build.sh
@@ -268,6 +286,7 @@ files:
 - spec/basic_methods/request_without_rails_spec.rb
 - spec/config/endpoints_spec.rb
 - spec/config/placeholders_spec.rb
+- spec/config/scrubs_spec.rb
 - spec/core_ext/hash/deep_transform_values_spec.rb
 - spec/dummy/README.rdoc
 - spec/dummy/Rakefile
@@ -369,6 +388,9 @@ files:
 - spec/request/parallel_requests_spec.rb
 - spec/request/params_encoding_spec.rb
 - spec/request/request_without_rails_spec.rb
+- spec/request/scrubbed_headers_spec.rb
+- spec/request/scrubbed_options_spec.rb
+- spec/request/scrubbed_params_spec.rb
 - spec/request/url_patterns_spec.rb
 - spec/request/user_agent_spec.rb
 - spec/request/user_agent_without_rails_spec.rb
@@ -402,12 +424,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements:
 - Ruby >= 2.0.0
 rubygems_version: 3.1.4
@@ -423,6 +445,7 @@ test_files:
 - spec/basic_methods/request_without_rails_spec.rb
 - spec/config/endpoints_spec.rb
 - spec/config/placeholders_spec.rb
+- spec/config/scrubs_spec.rb
 - spec/core_ext/hash/deep_transform_values_spec.rb
 - spec/dummy/README.rdoc
 - spec/dummy/Rakefile
@@ -524,6 +547,9 @@ test_files:
 - spec/request/parallel_requests_spec.rb
 - spec/request/params_encoding_spec.rb
 - spec/request/request_without_rails_spec.rb
+- spec/request/scrubbed_headers_spec.rb
+- spec/request/scrubbed_options_spec.rb
+- spec/request/scrubbed_params_spec.rb
 - spec/request/url_patterns_spec.rb
 - spec/request/user_agent_spec.rb
 - spec/request/user_agent_without_rails_spec.rb

data/.rubocop.localch.yml

@@ -1,325 +0,0 @@
-# This is master rubocop configuration.
-# DO NOT EDIT THIS FILE - it WILL be overwriten on every config update
-AllCops:
-  TargetRubyVersion: 2.3
-  DisplayCopNames: true
-  DisplayStyleGuide: true
-  Exclude:
-    - 'db/**/*'
-    - 'script/**/*'
-    - 'vendor/bundle/**/*'
-    - 'vendor/assets/**/*'
-    - 'bin/**/*'
-    - 'config/unicorn.rb'
-    - 'config/compass.rb'
-    - 'Rakefile'
-    - 'app/controllers/error_trap_controller.rb'
-    - 'app/controllers/hsts_controller.rb'
-    - 'spec/lib/util_spec.rb'
-
-Rails:
-  Enabled: true
-
-require:
-  - rubocop-rspec
-
-Bundler/OrderedGems:
-  Enabled: false
-
-Lint/HandleExceptions:
-  Exclude:
-    - spec/**/*
-
-Lint/UriEscapeUnescape:
-  Enabled: false
-
-Style/RescueStandardError:
-  Enabled: false
-
-Metrics/LineLength:
-  Enabled: false
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Enabled: false
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Performance/StringReplacement:
-  Enabled: false
-
-Performance/TimesMap:
-  Enabled: false
-
-Performance/RedundantBlockCall:
-  Enabled: false
-
-Performance/RedundantMatch:
-  Enabled: false
-
-Performance/RedundantMerge:
-  Enabled: false
-
-Performance/Casecmp:
-  Enabled: false
-
-Layout/MultilineOperationIndentation:
-  EnforcedStyle: indented
-
-Layout/DotPosition:
-  EnforcedStyle: leading
-
-Layout/AlignParameters:
-  Enabled: false
-
-Layout/EmptyLinesAroundClassBody:
-  Enabled: false
-
-Layout/IndentArray:
-  EnforcedStyle: consistent
-
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-
-Layout/MultilineMethodCallBraceLayout:
-  EnforcedStyle: symmetrical
-
-Layout/EmptyLinesAroundBlockBody:
-  EnforcedStyle: no_empty_lines
-
-Layout/IndentHeredoc:
-  Enabled: false
-
-Layout/MultilineArrayBraceLayout:
-  EnforcedStyle: symmetrical
-
-Layout/MultilineHashBraceLayout:
-  EnforcedStyle: symmetrical
-
-Style/StringLiterals:
-  Enabled: false
-
-Style/RegexpLiteral:
-  Exclude:
-    - spec/**/*
-
-Style/NumericLiterals:
-  Enabled: false
-
-Style/WordArray:
-  Enabled: false
-
-Style/Next:
-  Enabled: false
-
-Style/PercentLiteralDelimiters:
-  Enabled: false
-
-Style/GlobalVars:
-  Enabled: false
-
-Style/CommentAnnotation:
-  Enabled: false
-
-Style/SymbolProc:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/FormatString:
-  Enabled: false
-
-Style/AsciiComments:
-  Enabled: false
-
-Style/BarePercentLiterals:
-  Enabled: false
-
-Style/SingleLineBlockParams:
-  Enabled: false
-
-Style/MultilineBlockChain:
-  Enabled: false
-
-Style/UnneededCapitalW:
-  Enabled: false
-
-Style/UnneededPercentQ:
-  Enabled: false
-
-Style/BlockDelimiters:
-  Exclude:
-    - spec/**/*
-
-Style/BracesAroundHashParameters:
-  EnforcedStyle: context_dependent
-
-Style/IfUnlessModifier:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-Style/GuardClause:
-  Enabled: false
-
-Naming/AccessorMethodName:
-  Exclude:
-    - spec/support/pages/**/*
-
-Style/NegatedIf:
-  Enabled: false
-
-Style/MutableConstant:
-  Enabled: false
-
-Style/ConditionalAssignment:
-  Enabled: false
-
-Style/Lambda:
-  Enabled: false
-
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-Style/SymbolArray:
-  Enabled: false
-
-Style/HashSyntax:
-  EnforcedStyle: ruby19
-
-Style/FormatStringToken:
-  Enabled: false
-
-Style/EmptyMethod:
-  EnforcedStyle: expanded
-
-Style/TernaryParentheses:
-  EnforcedStyle: require_parentheses_when_complex
-
-Naming/VariableNumber:
-  Enabled: false
-
-Style/PerlBackrefs:
-  Enabled: false
-
-Style/RegexpLiteral:
-  AllowInnerSlashes: false
-
-Style/BlockComments:
-  Enabled: false
-
-Style/RedundantParentheses:
-  Enabled: false
-
-Naming/FileName:
-  Exclude:
-    - Gemfile
-    - Brewfile
-    - Guardfile
-
-Style/NumericPredicate:
-  Enabled: false
-
-RSpec/DescribeClass:
-  Exclude:
-    - spec/views/**/*
-    - spec/routing/**/*
-    - spec/requests/**/*
-    - spec/features/**/*
-
-RSpec/FilePath:
-  Enabled: false
-
-RSpec/NamedSubject:
-  Enabled: false
-
-RSpec/MultipleExpectations:
-  Enabled: false
-
-RSpec/ExampleLength:
-  Enabled: false
-
-RSpec/HookArgument:
-  EnforcedStyle: implicit
-
-RSpec/MessageSpies:
-  EnforcedStyle: receive
-
-RSpec/NestedGroups:
-  Enabled: false
-
-RSpec/VerifiedDoubles:
-  Enabled: false
-
-RSpec/LeadingSubject:
-  Enabled: false
-
-RSpec/ExpectInHook:
-  Enabled: false
-
-RSpec/ReturnFromStub:
-  Enabled: false
-
-RSpec/SubjectStub:
-  Enabled: false
-
-RSpec/EmptyLineAfterSubject:
-  Enabled: false
-
-RSpec/LetSetup:
-  Enabled: false
-
-RSpec/ImplicitExpect:
-  EnforcedStyle: is_expected
-
-RSpec/ScatteredLet:
-  Enabled: false
-
-RSpec/ContextWording:
-  Enabled: false
-
-Rails/Output:
-  Exclude:
-    - 'config/application.rb'
-    - 'config/initializers/asset_manifest_warning.rb'
-
-Rails/DynamicFindBy:
-  Enabled: false
-
-Rails/Presence:
-  Enabled: false
-
-Capybara/CurrentPathExpectation:
-  Enabled: false
-
-Naming/UncommunicativeMethodParamName:
-  Enabled: false
-
-Style/ExpandPathArguments:
-  Enabled: false