lhc 10.5.0 → 10.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3cf5537cde6885a7e37d2bb70d7b222e761804018d0aab94bd9249c68a40d3f7
-  data.tar.gz: 1d501413fd820cffc020cc39eec04b4e775440abebdf61e030f8d6114b660922
+  metadata.gz: b0317c2927977e904543c2d6f64b70324e6b94634ffce6ff1752cbaddd2acf2a
+  data.tar.gz: 19883b07caef846a43108601e931102348933abc4191af2c506d60496b86ec2e
 SHA512:
-  metadata.gz: 5fc4d1cb8b374931d4c53d295319e6f3c16657e0bde1dd7aa0799812bbc378390165f097b7c6627ced47f92d2ebe7459d5180745a4b00692875fbdfffda2c931
-  data.tar.gz: d5d39be61013fe93e275d2725e7fc4cfec83f27646c36762a2c3fbe64d1c40aa9831f7274fb7a46a7ff1500244a19a8fe76b2887539cb0e2f435a438178ff21a
+  metadata.gz: 6668ebf6f02d6cd4b9e49ff9f5fd22985dff77f7ae451b2062c1a65b93f32c1f8e3efabc981c0ce98b183e4f8435a8330dd274452cb5807444ce9da432e05377
+  data.tar.gz: ba098ab293a43a2035e79af76630d5a0fb5c867e73f5f0da7886fac697feeda98eed0c838bb8a3c72a83e577324f0e7b668f7dfb18b4b16bb0da5bd0d34cb27c

data/README.md

@@ -815,6 +815,20 @@ If you want to retry all requests made from your application, you just need to c
   configuration.interceptors = [LHC::Retry]
 ```
 
+##### Do not retry certain response codes
+
+If you do not want to retry based on certain response codes, use retry in combination with explicit `ignore_errors`:
+
+```ruby
+  LHC.get('http://local.ch', ignore_errors: [LHC::NotFound], retry: { max: 1 })
+```
+
+Or if you use `LHC::Retry.all`:
+
+```ruby
+LHC.get('http://local.ch', ignore_errors: [LHC::NotFound])
+```
+
 #### Rollbar Interceptor
 
 Forward errors to rollbar when exceptions occur during http requests.

data/lib/lhc/interceptors/retry.rb

@@ -24,6 +24,7 @@ class LHC::Retry < LHC::Interceptor
 
   def retry?(request)
     return false if request.response.success?
+    return false if request.error_ignored?
     return false if !request.options.dig(:retry) && !LHC::Retry.all
     request.options[:retries] < max(request)
   end

data/lib/lhc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LHC
-  VERSION ||= '10.5.0'
+  VERSION ||= '10.5.1'
 end

data/spec/interceptors/retry/main_spec.rb

@@ -7,6 +7,8 @@ describe LHC::Rollbar do
     LHC.config.interceptors = [LHC::Retry]
   end
 
+  let(:status) { 500 }
+
   let(:request_stub) do
     @retry_count = 0
     stub_request(:get, 'http://local.ch').to_return do |_|
@@ -14,7 +16,7 @@ describe LHC::Rollbar do
         { status: 200 }
       else
         @retry_count += 1
-        { status: 500 }
+        { status: status }
       end
     end
   end
@@ -58,4 +60,14 @@ describe LHC::Rollbar do
       expect(request_stub).to have_been_requested.times(3)
     end
   end
+
+  context 'ignore error' do
+    let(:status) { 404 }
+
+    it 'does not retry if the error is explicitly ignored' do
+      request_stub
+      LHC.get('http://local.ch', retry: { max: 1 }, ignored_errors: [LHC::NotFound])
+      expect(request_stub).to have_been_requested.times(1)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 10.5.0
+  version: 10.5.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhc/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-23 00:00:00.000000000 Z
+date: 2019-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport