lhc-core-interceptors 2.1.1 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a967e9c58513d9f17dd68b40145b8565c8fcda1
-  data.tar.gz: c28a928b398293f96b4c495e6d8e26d6824c2437
+  metadata.gz: 0ee16284796c7f53b053b526ed636722b2ed5ea8
+  data.tar.gz: 7a190e5024b2dfdd546ff12982cd97d11cdad36b
 SHA512:
-  metadata.gz: c2c5594f8edbab3f1322f1c3358fdac32aa4fa2386e80fa0f3c5ba42f1959e0840d6026c0ac09605bc684a7a33cbe5f9e85e6c295aba8c61d248dab8d36c1ca7
-  data.tar.gz: c5a6cb2c063d0657b7f4b389e07df9ed22c773a3ab3322200c0fdba768e8cee464c56edbd886ebc2b0680326b25cc4cd9ebbb2e3dedcb765c29a5c7d14689afb
+  metadata.gz: fa70a751b5be926bcf04bce083ca290e35ece2b29f861790d442bb4901b48004ae2bfd6f5dece684b3c05eee01e09e6eadb1d1e0492563dfe0d68bc8a086748d
+  data.tar.gz: f7c1aba4e0dfe23cf207132050f247ffc91eda1fd93dcb3acf5534451daa318882efcf144746b59a6e9409645d7687244af7f9d453c561602ee02484f801c8b2

data/README.md

@@ -67,7 +67,15 @@ In case of a successful response it reports the response code with a count and t
   "lhc.<app_name>.<env>.<host>.<http_method>.time", 43
 ```
 
-In case a response timeouts it is also reporting that.
+In case your workers/processes are getting killed due limited time constraints, 
+you are able to detect deltas with relying on "before_request", and "after_request" counts:
+
+```ruby
+  "lhc.<app_name>.<env>.<host>.<http_method>.before_request", 1
+  "lhc.<app_name>.<env>.<host>.<http_method>.after_request", 1
+```
+
+Timeouts are also reported:
 
 ```ruby
   "lhc.<app_name>.<env>.<host>.<http_method>.timeout", 1

data/lib/lhc-core-interceptors/monitoring.rb

@@ -9,10 +9,15 @@ class LHC::Monitoring < LHC::Interceptor
 
   config_accessor :statsd
 
+  def before_request(request)
+    return unless statsd
+    LHC::Monitoring.statsd.count("#{key(request)}.before_request", 1)
+  end
+
   def after_request(request)
     return unless statsd
-    key = "#{key(request)}.count"
-    LHC::Monitoring.statsd.count(key, 1)
+    LHC::Monitoring.statsd.count("#{key(request)}.count", 1)
+    LHC::Monitoring.statsd.count("#{key(request)}.after_request", 1)
   end
 
   def after_response(response)

data/lib/lhc-core-interceptors/version.rb

@@ -1,3 +1,3 @@
 module LHCCoreInterceptors
-  VERSION = '2.1.1'
+  VERSION = '2.2.0'
 end

data/spec/monitoring/main_spec.rb

@@ -27,6 +27,8 @@ describe LHC::Monitoring do
   context 'statsd configured' do
     it 'reports trial, response and timing by default ' do
       stub
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.before_request', 1)
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.after_request', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.count', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.200', 1)
       expect(Statsd).to receive(:timing).with('lhc.dummy.test.local_ch.get.time', anything)
@@ -35,6 +37,8 @@ describe LHC::Monitoring do
 
     it 'does not report timing when response failed' do
       stub_request(:get, 'http://local.ch').to_return(status: 500)
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.before_request', 1)
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.after_request', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.count', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.500', 1)
       expect(Statsd).not_to receive(:timing)
@@ -43,6 +47,8 @@ describe LHC::Monitoring do
 
     it 'reports timeout instead of status code if response timed out' do
       stub_request(:get, 'http://local.ch').to_timeout
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.before_request', 1)
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.after_request', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.count', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.timeout', 1)
       expect(Statsd).not_to receive(:timing)
@@ -51,6 +57,8 @@ describe LHC::Monitoring do
 
     it 'allows to set the stats key for request' do
       stub
+      expect(Statsd).to receive(:count).with('defined_key.before_request', 1)
+      expect(Statsd).to receive(:count).with('defined_key.after_request', 1)
       expect(Statsd).to receive(:count).with('defined_key.count', 1)
       expect(Statsd).to receive(:count).with('defined_key.200', 1)
       expect(Statsd).to receive(:timing).with('defined_key.time', anything)
@@ -63,6 +71,8 @@ describe LHC::Monitoring do
 
     it 'reports trial, response and timing by default ' do
       stub
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.before_request', 1)
+      expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.after_request', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.count', 1)
       expect(Statsd).to receive(:count).with('lhc.dummy.test.local_ch.get.200', 1)
       expect(Statsd).to receive(:timing).with('lhc.dummy.test.local_ch.get.time', anything)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhc-core-interceptors
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.2.0
 platform: ruby
 authors:
 - local.ch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-01 00:00:00.000000000 Z
+date: 2016-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc