lgustafson-validatable 1.8.6

data/test/functional/test_validatable.rb

@@ -0,0 +1,519 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+functional_tests do
+
+  expect "can't be empty" do
+    child_class = Module.new do
+      include Validatable
+      validates_presence_of :name
+    end
+    klass = Class.new do
+      include Validatable
+      include_validations_from :child 
+      define_method :child do
+        child_class
+      end
+      attr_accessor :name
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:name)
+  end
+  
+  expect "can't be empty" do
+    child_class = Module.new do
+      include Validatable
+      validates_presence_of :name
+    end
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :address
+      include_validations_from :child 
+      define_method :child do
+        child_class
+      end
+      attr_accessor :name, :address
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:address)
+  end
+  
+  expect :is_set do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :result
+      before_validation do
+        self.result = :is_set
+      end
+    end
+    
+    instance = klass.new
+    instance.valid?
+    instance.result
+  end
+  
+  expect :is_set do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :name, :result
+      validates_presence_of :name, :after_validate => lambda { |result, attribute| self.result = :is_set }
+    end
+
+    instance = klass.new
+    instance.valid?
+    instance.result
+  end
+
+  expect false do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :name
+      validates_presence_of :name
+    end
+    subclass = Class.new klass do
+    end
+    subsubclass = Class.new subclass do
+    end
+    subsubclass.new.valid?
+  end
+  
+  expect false do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :name
+      validates_presence_of :name
+    end
+    subclass = Class.new klass do
+    end
+    subclass.new.valid?
+  end
+  
+  expect true do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :name
+      validates_presence_of :name
+    end
+    subclass = Class.new klass do
+    end
+    instance = subclass.new
+    instance.name = 'a name'
+    instance.valid?
+  end
+
+  expect ArgumentError do
+    Class.new do
+      include Validatable
+      attr_accessor :name
+      validates_presence_of :name, :times => 1
+      validates_presence_of :name, :times => 1
+    end
+  end
+
+  expect ArgumentError do
+    Class.new do
+      include Validatable
+      attr_accessor :name
+      validates_presence_of :name, :times => 1, :key => 'anything'
+      validates_presence_of :name, :times => 1, :key => 'anything'
+    end
+  end
+
+  expect "is invalid" do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name, :address
+      validates_presence_of :name
+      validates_format_of :address, :with => /.+/
+    end
+    klass = Class.new do
+      include Validatable
+      include_errors_from :child 
+      define_method :child do
+        child_class.new
+      end
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:address)
+  end
+  
+  expect "is invalid" do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name, :address
+      validates_presence_of :name
+      validates_format_of :address, :with => /.+/
+    end
+    klass = Class.new do
+      include Validatable
+      include_errors_from :child 
+      define_method :child do
+        valid_child = child_class.new
+        valid_child.name = "nom de plume"
+        valid_child.address = "nowhere"
+        [valid_child, child_class.new]
+      end
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:address)
+  end
+
+  expect true do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name, :address
+      validates_presence_of :name
+      validates_format_of :address, :with => /.+/
+    end
+    klass = Class.new do
+      include Validatable
+      include_errors_from :child 
+      define_method :child do
+        valid_child = child_class.new
+        valid_child.name = "nom de plume"
+        valid_child.address = "nowhere"
+        also_valid = child_class.new
+        also_valid.name = "nom de guerre"
+        also_valid.address = "somewhere else"
+        [valid_child, valid_child]
+      end
+    end
+    instance = klass.new
+    instance.valid?
+  end
+  
+  expect "can't be empty" do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name, :address
+      validates_presence_of :name
+      validates_format_of :address, :with => /.+/
+    end
+    klass = Class.new do
+      include Validatable
+      include_errors_from :child 
+      define_method :child do
+        child_class.new
+      end
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:name)
+  end
+
+
+  test "when child validations have errors, level 2 and higher parent validations are not performed" do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name
+      validates_presence_of :name
+    end
+
+    klass = Class.new do
+      include Validatable
+      extend Forwardable
+      def_delegator :child, :name
+      validates_true_for :name, :logic => lambda { false }, :level => 2, :message => "invalid message"
+      include_errors_from :child 
+      define_method :child do
+        @child ||= child_class.new
+      end
+    end
+    instance = klass.new
+    instance.valid?
+    assert_equal "can't be empty", instance.errors.on(:name)
+  end
+
+  test "when child validations have errors, level 1 parent validations are still performed" do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name
+      validates_presence_of :name
+    end
+
+    klass = Class.new do
+      include Validatable
+      validates_true_for :address, :logic => lambda {|*x| false }, :level => 1, :message => "invalid message"
+      include_errors_from :child 
+      define_method :child do
+        @child ||= child_class.new
+      end
+
+    end
+    instance = klass.new
+    instance.valid?
+    assert_equal "can't be empty", instance.errors.on(:name)
+    assert_equal "invalid message", instance.errors.on(:address)
+  end
+
+  expect "can't be empty" do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name, :address
+      validates_presence_of :name
+    end
+    klass = Class.new do
+      include Validatable
+      include_errors_from :child, :map => {:name => :namen}
+      define_method :child do
+        child_class.new
+      end
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:namen)
+  end
+
+  expect "can't be empty" do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name, :address
+      validates_presence_of :name
+    end
+    klass = Class.new do
+      include Validatable
+      include_errors_from :child, :if => lambda {|*x| true }
+      define_method :child do
+        child_class.new
+      end
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:name)
+  end
+
+  expect true do
+    child_class = Class.new do
+      include Validatable
+      attr_accessor :name, :address
+      validates_presence_of :name
+    end
+    klass = Class.new do
+      include Validatable
+      include_errors_from :child, :if => lambda {|*x| false }
+      define_method :child do
+        child_class.new
+      end
+    end
+    instance = klass.new
+    instance.valid?
+  end
+  
+  test ':if with symbol should work' do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :name, :name_required
+      validates_presence_of :name, :if => :name_required?
+      
+      def name_required?
+        name_required
+      end
+    end
+    instance = klass.new
+    instance.name_required = false
+    assert instance.valid?
+    instance.name_required = true
+    assert !instance.valid?
+    assert_equal "can't be empty", instance.errors.on(:name)
+  end
+  
+  test ':if with string should work' do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :name, :name_required
+      validates_presence_of :name, :if => 'name_required?'
+      
+      def name_required?
+        name_required
+      end
+    end
+    instance = klass.new
+    instance.name_required = false
+    assert instance.valid?
+    instance.name_required = true
+    assert !instance.valid?
+    assert_equal "can't be empty", instance.errors.on(:name)
+  end
+
+  test "classes only have valid_for_* methods for groups that appear in their validations" do
+    class_with_group_one = Class.new do
+      include Validatable
+      validates_presence_of :name, :groups => :group_one
+      attr_accessor :name
+    end
+    class_with_group_two = Class.new do
+      include Validatable
+      validates_presence_of :name, :groups => :group_two
+      attr_accessor :name
+    end
+    assert_equal false, class_with_group_one.public_instance_methods.include?(:valid_for_group_two?)
+    assert_equal false, class_with_group_two.public_instance_methods.include?(:valid_for_group_one?)
+  end
+
+  test "nonmatching groups are not used as validations" do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :groups => :group_one
+      validates_presence_of :address, :groups => :group_two
+      attr_accessor :name, :address
+    end
+    instance = klass.new
+    assert_equal nil, instance.errors.on(:name)
+  end
+
+  expect "can't be empty twice changed message" do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name
+      attr_accessor :name
+    end
+
+    Validatable::ValidationBase.class_eval do
+      after_validate do |result, instance, attribute|
+        instance.errors.add(attribute, " changed message")
+      end
+    end
+    Validatable::ValidatesPresenceOf.class_eval do
+      after_validate do |result, instance, attribute|
+        instance.errors.add(attribute, " twice")
+      end
+    end
+    instance = klass.new
+    instance.valid?
+    Validatable::ValidatesPresenceOf.after_validations.clear
+    Validatable::ValidationBase.after_validations.clear
+    instance.errors.on(:name).join
+  end
+
+  expect false do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :groups => :group_one
+      attr_accessor :name
+    end
+    instance = klass.new
+    instance.valid_for_group_one?
+  end
+
+  expect false do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :groups => [:group_one, :group_two]
+      attr_accessor :name
+    end
+    instance = klass.new
+    instance.valid_for_group_one?
+  end
+
+  expect true do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :groups => :group_one
+      validates_presence_of :address
+      attr_accessor :name, :address
+    end
+    instance = klass.new
+    instance.address = 'anything'
+    instance.valid?
+  end
+
+  expect true do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :groups => :group_one
+      attr_accessor :name
+    end
+    instance = klass.new
+    instance.valid?
+  end
+
+  expect true do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :times => 1
+      attr_accessor :name
+    end
+    instance = klass.new
+    instance.valid?
+    instance.valid?
+  end
+
+  expect false do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :times => 1
+      attr_accessor :name
+    end
+    instance1 = klass.new
+    instance1.valid?
+    instance2 = klass.new
+    instance2.valid?
+  end
+
+  expect "name message" do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :level => 1, :message => "name message"
+      validates_presence_of :address, :level => 2
+      attr_accessor :name, :address
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:name)
+  end
+
+  expect nil do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :level => 1, :message => "name message"
+      validates_presence_of :address, :level => 2
+      attr_accessor :name, :address
+    end
+    instance = klass.new
+    instance.valid?
+    instance.errors.on(:address)
+  end
+  
+  expect "Mod::Klass/Validatable::ValidatesPresenceOf/name" do
+    module Mod
+      class Klass
+        include Validatable
+        validates_presence_of :name
+      end
+    end
+    Mod::Klass.validations.first.key
+  end
+
+  expect "/Validatable::ValidatesPresenceOf/custom key" do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :key => "custom key"
+    end
+    klass.validations.first.key
+  end
+  
+  expect "can't be empty" do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :address
+      attr_accessor :name, :address
+    end
+    instance = klass.new
+    instance.validate_only("presence_of/name")
+    instance.errors.on(:name)
+  end
+
+  expect nil do
+    klass = Class.new do
+      include Validatable
+      validates_presence_of :name, :address
+      attr_accessor :name, :address
+    end
+    instance = klass.new
+    instance.validate_only("presence_of/name")
+    instance.errors.on(:address)
+  end
+end

data/test/functional/test_validates_acceptance_of.rb

@@ -0,0 +1,16 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+module Functional
+  class ValidatesAcceptanceOfTest < Test::Unit::TestCase
+    test "given no acceptance, when validated, then error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_acceptance_of :name
+      end
+      instance = klass.new
+      instance.valid?
+      assert_equal "must be accepted", instance.errors.on(:name)
+    end
+  end
+end

data/test/functional/test_validates_associated.rb

@@ -0,0 +1,41 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+module Functional
+  class ValidatesAssociatedTest < Test::Unit::TestCase
+    def setup
+      @parent = Class.new do
+        include Validatable
+        attr_accessor :children
+        validates_associated :children
+      end
+      @child = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_presence_of :name
+      end
+    end
+
+    test "given invalid child, when validated, then error is in the parent's error collection" do
+      instance = @parent.new
+      instance.children = [@child.new]
+      instance.valid?
+      assert_equal "is invalid", instance.errors.on(:children)
+    end
+
+    test "given two invalid children, when validated, then both children have errors" do
+      instance = @parent.new
+      instance.children = [@child.new, @child.new]
+      instance.valid?
+      instance.children.each do |child|
+        assert_not_nil child.errors.on(:name)
+      end
+    end
+
+    test "given valid child, when validated, the parent is valid" do
+      instance = @parent.new
+      instance.children = [@child.new]
+      instance.children.first.name = 'x'
+      assert instance.valid?
+    end
+  end
+end

data/test/functional/test_validates_confirmation_of.rb

@@ -0,0 +1,56 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+module Functional
+  class ValidatesConfirmationOfTest < Test::Unit::TestCase
+    test "given non matching attributes, when validated, then error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_confirmation_of :name
+      end
+      instance = klass.new
+      instance.name = "foo"
+      instance.name_confirmation = "bar"
+      instance.valid?
+      assert_equal "doesn't match confirmation", instance.errors.on(:name)
+    end
+
+    test "given matching attributes, when validated, then no error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_confirmation_of :name
+      end
+      instance = klass.new
+      instance.name = "foo"
+      instance.name_confirmation = "foo"
+      assert_equal true, instance.valid?
+    end
+
+    test "given matching attributes of different case, when validated with case sensitive false, then no error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_confirmation_of :name, :case_sensitive => false
+      end
+      instance = klass.new
+      instance.name = "foo"
+      instance.name_confirmation = "FOO"
+      assert_equal true, instance.valid?
+    end
+
+    test "given matching attributes of different case, when validated with case sensitive true, then error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_confirmation_of :name
+      end
+      instance = klass.new
+      instance.name = "foo"
+      instance.name_confirmation = "FOO"
+      assert_equal false, instance.valid?
+      assert_equal "doesn't match confirmation", instance.errors.on(:name)
+      
+    end
+  end
+end

data/test/functional/test_validates_each.rb

@@ -0,0 +1,14 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+functional_tests do
+  expect :is_set do
+    klass = Class.new do
+      include Validatable
+      attr_accessor :name, :result
+      validates_each :name, :logic => lambda {|*x| @result = :is_set }
+    end
+    instance = klass.new
+    instance.valid?
+    instance.result
+  end
+end

data/test/functional/test_validates_exclusion_of.rb

@@ -0,0 +1,29 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+module Functional
+  class ValidatesExclusionOfTest < Test::Unit::TestCase
+    test "given excluded state, when validated, then error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :state
+        validates_exclusion_of :state, :within => %w(in out)
+      end
+      instance = klass.new
+      instance.state = 'in'
+      instance.valid?
+      assert_equal "is reserved", instance.errors.on(:state)
+    end
+    
+    test "given non-excluded state, when validated, then no error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :state
+        validates_exclusion_of :state, :within => %w(in out)
+      end
+      instance = klass.new
+      instance.state = 'foo'
+      instance.valid?
+      assert_nil instance.errors.on(:state)
+    end
+  end
+end

data/test/functional/test_validates_format_of.rb

@@ -0,0 +1,34 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+module Functional
+  class ValidatesFormatOfTest < Test::Unit::TestCase
+    test "given invalid name format, when validated, then error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_format_of :name, :with => /.+/
+      end
+      instance = klass.new
+      instance.valid?
+      assert_equal "is invalid", instance.errors.on(:name)
+    end
+
+    test "given invalid name format and nil name, when validated, then error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_format_of :name, :with => /.+/, :if => Proc.new { !name.nil? }
+      end
+      assert_equal true, klass.new.valid?
+    end
+    
+    test "given invalid name format and a name, when validated, then error is in the objects error collection" do
+      klass = Class.new do
+        include Validatable
+        attr_accessor :name
+        validates_format_of :name, :with => /.+/, :if => Proc.new { name.nil? }
+      end
+      assert_equal false, klass.new.valid?
+    end
+  end
+end