lex-microsoft_teams 0.6.40 → 0.6.43

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f6f9d39d6ddf7f53a0d22f727e6ca9cfede2aa3487cef4c8ffee064b549a158c
-  data.tar.gz: efbe44cedda75981daae45b173f795c968f2883e17d8526b512c0324a9269e73
+  metadata.gz: bb45b23e2ed5d3a627ff36c180ca4de1b760780281a7b9e3ced3700926295b00
+  data.tar.gz: 7cf60a638335e21601ccf7f5e7ca972dc5786e466dbd8c7826311e8efcacf9c6
 SHA512:
-  metadata.gz: 2147849085641ca61d971a3f7b37009a481285cf9edb1dead731d03f6007dac3845168d2aeeb19f6737cd8673144e0673b860e924676136b7c6213ef61240114
-  data.tar.gz: 297f2da23ebd6a9db658ca27eecb1504376cee05745f4dea3e5b9b5d4a29d33923c28375a766b99de9a5e58d935dc6688c3552cb55442514b4a187085335f7a2
+  metadata.gz: c8f00e377cd7434969144294d19bece1adb691ac72ffd757f635098bb3eff8074c07507a338d8fcb1a228700fcf10a528236e7cac09972867690826f951aaab3
+  data.tar.gz: 6392e91d554d507df66ade582982a2ffb491be6ec270276e13e3e6c05cfb581f5b1cbfbddaf5445bec3fbe962b73a41bc529f5aa2bb7fdc6a3ba7e7346cb6ae3

data/CHANGELOG.md

@@ -2,6 +2,28 @@
 
 ## [Unreleased]
 
+## [0.6.43] - 2026-04-23
+
+### Fixed
+- `Helpers::Client#graph_connection` — added `TokenCache.instance.cached_delegated_token` fallback when no `token:` kwarg is passed and settings has no static token. Fixes "Access token is empty" errors when runners are invoked via LLM tool dispatch without an explicit token argument
+- `Helpers::Client#bot_connection` — same fix using `TokenCache.instance.cached_app_token`
+
+## [0.6.42] - 2026-04-23
+
+### Fixed
+- `Helpers::TokenCache#vault_path` — replaced `ENV.fetch('USER', 'default')` with `Legion::Identity::Process.canonical_name` (the resolved Kerberos/LDAP identity), matching the pattern used in `legion-llm` PR #80. Falls back to `ENV['USER'].split('@').first` (email domain stripped) if Identity is not yet resolved
+- Also removed the `microsoft_teams` namespace segment from the returned suffix — `Crypt::Helper#vault_write` wraps the path in its own `vault_path(suffix)` which already prepends the lex namespace, so including it again caused double-prefixed Vault paths (`microsoft_teams/users/.../microsoft_teams/delegated_token`).
+- Final Vault path is now: `microsoft_teams/users/{canonical_name}/delegated_token`
+- Configurable via `settings[:auth][:delegated][:vault_path]` if a custom path is needed
+
+## [0.6.41] - 2026-04-23
+
+### Fixed
+- `Helpers::Client#graph_connection` and `#bot_connection` — replaced `Legion::Settings[:microsoft_teams]` with `settings` (provided by `Legion::Settings::Helper` via `Helpers::Lex`), which correctly scopes to the lex key automatically and is the approved pattern inside a lex
+- `Helpers::TokenCache#teams_auth_settings` — same fix; replaced `Legion::Settings[:microsoft_teams]` with `settings`, removed the now-redundant `defined?(Legion::Settings)` guard and `if ms` nil guards (settings always returns a Hash)
+- The only remaining `Legion::Settings` references in `token_cache.rb` are for cross-lex lookups (`:crypt, :vault, :connected`) which are intentional and correct
+- Token write paths (`save_to_local`, `save_to_vault`) confirmed clean — write to `local_token_path` (defaulting to `~/.legionio/tokens/`) and Vault respectively, not into settings
+
 ## [0.6.40] - 2026-04-23
 
 ### Fixed

data/lib/legion/extensions/microsoft_teams/helpers/client.rb

@@ -7,8 +7,12 @@ module Legion
     module MicrosoftTeams
       module Helpers
         module Client
+          include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
+                                                      Legion::Extensions::Helpers.const_defined?(:Lex, false)
+
           def graph_connection(token: nil, api_url: 'https://graph.microsoft.com/v1.0', **_opts)
-            token ||= Legion::Settings[:microsoft_teams]&.dig(:auth, :delegated, :token)
+            token ||= settings&.dig(:auth, :delegated, :token)
+            token ||= TokenCache.instance.cached_delegated_token if defined?(TokenCache)
             Faraday.new(url: api_url) do |conn|
               conn.request :json
               conn.response :json, content_type: /\bjson$/
@@ -18,7 +22,8 @@ module Legion
           end
 
           def bot_connection(token: nil, service_url: 'https://smba.trafficmanager.net/teams/', **_opts)
-            token ||= Legion::Settings[:microsoft_teams]&.dig(:auth, :bot, :token)
+            token ||= settings&.dig(:auth, :bot, :token)
+            token ||= TokenCache.instance.cached_app_token if defined?(TokenCache)
             Faraday.new(url: service_url) do |conn|
               conn.request :json
               conn.response :json, content_type: /\bjson$/

data/lib/legion/extensions/microsoft_teams/helpers/token_cache.rb

@@ -277,8 +277,14 @@ module Legion
           def vault_path(_suffix = nil)
             settings = teams_auth_settings
             delegated = settings[:delegated]
-            custom = delegated[:vault_path] if delegated.is_a?(Hash)
-            custom || "users/#{ENV.fetch('USER', 'default')}/microsoft_teams/delegated_token"
+            return delegated[:vault_path] if delegated.is_a?(Hash) && delegated[:vault_path]
+
+            identity = if defined?(Legion::Identity::Process) && Legion::Identity::Process.resolved?
+                         Legion::Identity::Process.canonical_name
+                       else
+                         ENV.fetch('USER', 'default').split('@').first
+                       end
+            "users/#{identity}/delegated_token"
           end
 
           def local_token_path
@@ -387,13 +393,11 @@ module Legion
           end
 
           def teams_auth_settings
-            return {} unless defined?(Legion::Settings)
-
-            ms = Legion::Settings[:microsoft_teams]
-            auth = ms && ms[:auth].is_a?(Hash) ? ms[:auth].dup : {}
-            auth[:tenant_id] ||= ms[:tenant_id] if ms
-            auth[:client_id] ||= ms[:client_id] if ms
-            auth[:client_secret] ||= ms[:client_secret] if ms
+            ms = settings
+            auth = ms[:auth].is_a?(Hash) ? ms[:auth].dup : {}
+            auth[:tenant_id] ||= ms[:tenant_id]
+            auth[:client_id] ||= ms[:client_id]
+            auth[:client_secret] ||= ms[:client_secret]
             auth[:tenant_id] ||= ENV.fetch('AZURE_TENANT_ID', nil)
             auth[:client_id] ||= ENV.fetch('AZURE_CLIENT_ID', nil)
             auth[:client_secret] ||= ENV.fetch('AZURE_CLIENT_SECRET', nil)

data/lib/legion/extensions/microsoft_teams/version.rb

@@ -3,7 +3,7 @@
 module Legion
   module Extensions
     module MicrosoftTeams
-      VERSION = '0.6.40'
+      VERSION = '0.6.43'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-microsoft_teams
 version: !ruby/object:Gem::Version
-  version: 0.6.40
+  version: 0.6.43
 platform: ruby
 authors:
 - Esity