lex-llm 0.4.16 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9bacfc210039561fd7cde72d580809804b78435a4be39c887ae5d51a9ab82d6f
-  data.tar.gz: 46b3c44bc28c7137f6a68934779505dc3bd671630192d51f695d32fa9900c302
+  metadata.gz: 9ab0a51687719efbd7f048be70ff4ba57b6d81fafddfcaefb2f0d78f5f3721ae
+  data.tar.gz: 49e57ce1c99330d956cc92b6c6a75a283f078f5e0b8fb036ae7aad9579caccd0
 SHA512:
-  metadata.gz: 406335de47bd45b026ffbce054cad7e7bf3f36bfb324746646064e3a75ef9d85f94987b759277ff2ecb6145969db64d3e1216c11ccc651a5fafa14bc80308fda
-  data.tar.gz: 7b8aa303c770e39cdbff2353fb01868752aecc46fd3ea194b3e07e6207b1da3515972563f154f053d2ff8cb1d541218b1e0dec2d6d3ab458e58571399650240a
+  metadata.gz: 8d8fcea6f732dd4c5dfcd713024796a640941d18c8ef90f3c5b5ca0b3fcbc0094942f2cadabbdd78669ecabce8cd76f893488a92f15ec70c21ebec865fb0a531
+  data.tar.gz: 4a062635e491cb84b60117b1c28520a8fc5bb4d0775609ed1104639e549114c2a373e68461833008a234e33d7ac14a5fe1292cc2f37fe37b0f00818387cc4851

data/.rubocop.yml

@@ -13,12 +13,18 @@ AllCops:
     - lib/generators/**/templates/**/*
   SuggestExtensions: false
 
+Layout/LineLength:
+  Max: 190
 Metrics/ClassLength:
   Enabled: false
 Metrics/AbcSize:
-  Enabled: false
+  Enabled: true
+  Max: 50
+Metrics/PerceivedComplexity:
+  Max: 50
 Metrics/CyclomaticComplexity:
-  Enabled: false
+  Enabled: true
+  Max: 50
 Metrics/MethodLength:
   Enabled: false
 Metrics/ModuleLength:
@@ -40,3 +46,8 @@ RSpec/MultipleExpectations:
   Enabled: false
 RSpec/LeakyLocalVariable:
   Enabled: false
+# Conformance kit specs live under spec/legion/extensions/llm/conformance/
+# but the test classes use Canonical::Conformance:: namespace — path can't match.
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - 'spec/legion/extensions/llm/conformance/**/*'

data/B1b-conformance-kit.md

@@ -0,0 +1,79 @@
+# B1b — Conformance Kit (lex-llm spec support)
+
+> **Status:** Complete (self-test green: 54 examples, 0 failures)
+> **Date:** 2026-06-10
+> **Repo:** lex-llm (conformance kit only)
+> **Branch:** feat/canonical-types
+> **Design doc:** 2026-06-09-nxn-canonical-routing-design.md Amendment B
+> **Implementation plan:** Phase 2 (conformance kit in lex-llm)
+> **Dependency:** B1a canonical types (coordinator commit e1cbf820)
+> **Self-test green:** `bundle exec rspec spec/legion/extensions/llm/conformance` → 54 examples, 0 failures
+
+---
+
+## What was delivered
+
+### Shared example groups
+
+**provider_translator_examples.rb** (~390 lines)
+`it_behaves_like 'a canonical provider translator'` — 54 scenarios across render_request,
+parse_response, parse_chunk, stop_reason, round-trip.
+
+**client_translator_examples.rb** (~270 lines)
+Mirror group for client translators: `it_behaves_like 'a canonical client translator'` —
+parse_request/format_request round-trip, format_response, format_chunk, format_error.
+
+### Fixture corpus (19 JSON files)
+
+All under `spec/legion/extensions/llm/conformance/fixtures/`:
+- simple_text request/response, system_prompt, params_mapping (all 10 G18 fields),
+  tools_request, tool_use_response, tool_results_continuation_request (enhanced: mixed client + registry tool calls per G4)
+- canonical_thinking_request.json
+- canonical_thinking_response.json (thinking content + signature, thinking_tokens)
+- canonical_empty_response.json
+- canonical_error_response.json
+- canonical_stop_reason_matrix.json (6 canonical enums + 5 provider mappings)
+- canonical_streaming_text_chunks.json
+- canonical_streaming_thinking_chunks.json (thinking + text + signature + done)
+- canonical_streaming_tool_call_chunks.json (multi-chunk tool-call identity per A7)
+- canonical_streaming_error_chunks.json (**new**: mid-stream error per G5/G6)
+- canonical_streaming_accumulated_response.json (**new**: expected assembled response from tool-call chunks)
+- canonical_fleet_round_trip.json (per R6)
+- canonical_metering_audit_events.json (per G15e: schemas + example events)
+
+### Self-test echo translator
+
+Echo translator + spec that passes both provider and client translator groups, proving the shared examples work correctly.
+
+### Infrastructure fixes
+
+1. **lex-llm.gemspec** — spec.files now includes spec/ (was excluded); spec.require_paths adds 'spec' — enables cross-gem conformance kit loading per the amended Phase 2 spec.
+2. .rubocop.yml — excluded conformance directory from RSpec/SpecFilePathFormat.
+3. **provider_translator_examples.rb** — parse_response now tests translator.parse_response(wire) instead of canonical::Response.from_hash(fixture).
+
+### Issues found & fixed during this session
+
+1. **parse_response tests didn't exercise the translator** — Fixed by using `fixture_symbolized` + calling `translator.parse_response(wire).
+2. **Malformed rubocop directives in canonical lib files** — 5 files had `# rubocop:disable Metrics/ParameterLists, Metrics/PerceivedComplexity -- factory` where the trailing `, --` triggered `Lint/CopDirectiveSyntax`. Fixed & committed.
+3. **RSpec/SpecFilePathFormat rubocop violation** — `echo_translator_spec.rb` in `spec/legion/extensions/llm/conformance/` triggered the cop. Excluded conformance directory.
+4. **Symbolized vs string-keyed fixtures** — Fixed by using `fixture_symbolized` for self-test.
+
+---
+
+## Test results
+
+Conformance kit: 54 examples, 0 failures
+Full test suite: 630 examples, 0 failures
+Line coverage: 79.01% (3569 / 4517)
+Branch coverage: 52.76% (908 / 1721)
+RuboCop: clean (136 files, 0 offenses)
+
+---
+
+## Next steps
+
+1. **Phase 3** — Provider gems adopt the kit (anthropic first, then openai, vllm, ollama, bedrock). Each runs `it_behaves_like 'a canonical provider translator'`.
+2. **Phase 5** — Client translators in legion-llm adopt the client shared examples.
+3. **Bug fix** — Resolve ToolCall.from_hash JSON::ParserError constant resolution in lib/canonical (feat/canonical-types branch). The coordinator commit e1cbf820 fixed this with `Legion::JSON`.
+4. **Provider-specific fixtures** — Real provider gems will supply their own wire-format fixtures; the canonical fixtures serve as the round-trip anchor. A future step would add anthropic/openai wire-format reference fixtures (sanitized from `legionio-e2e/results/`) for direct cross-verification.
+5. **Streaming tool-call incremental fragments** — The `canonical_streaming_tool_call_chunks.json` fixture carries complete (canonical-form) tool call args per chunk due to the ParserError bug. The fix in #3 allows incremental fragments if desired.

data/CHANGELOG.md

@@ -1,5 +1,38 @@
 # Changelog
 
+## 0.5.0 - 2026-06-10
+
+### Added
+- **Canonical types module** — `Legion::Extensions::Llm::Canonical` provides immutable `Data.define` value objects (Thinking, Usage, Params, ContentBlock, ToolDefinition, ToolCall, Message, Request, Response, Chunk) forming the single N×N client↔provider routing contract. Includes `from_hash`/`to_h` for serialization, `CONTRACT_VERSION` for provider gem compatibility checks, and explicit factory validation per Amendment A.
+- **Conformance kit** — Shared RSpec example groups shipped under `spec/legion/extensions/llm/conformance/` (provider_translator_examples, client_translator_examples) with JSON fixtures for canonical↔provider translation contract testing. Packaged via gemspec `spec.files`; `gemspec.require_paths` remains `['lib']` only — conformance specs are consumed by provider gems at test time via `Gem.loaded_specs['lex-llm'].full_gem_path`.
+- **Conformance kit coordinator** — Fixtures read with explicit UTF-8 encoding so locale-less CI shells do not fail on JSON.parse.
+
+### Changed
+- **Zeitwerk autoloading removed** — Replaced lazy Zeitwerk::Loader with deterministic explicit `require_relative` for every file in `lib/`. Contract constants now exist at `require` time so provider gems can subclass against them during phased extension loading (core → lex-identity → lex-llm → lex-llm-*). Removed undeclared `zeitwerk ~> 2` runtime dependency from gemspec. Load order: canonical types and base classes first, then components referencing them. Transport exchange/message modules remain as Ruby `autoload` to avoid forcing `legion-transport` at boot time.
+
+## 0.4.19 - 2026-06-10
+
+### Fixed
+- **Connection logging bodies** — `setup_logging` now enables request body logging when the logger is at DEBUG level OR when `fleet.request.logger.request_payload` is explicitly true. Previously relied solely on log-level check; the new `request_payload` setting provides explicit control for fleet worker scenarios.
+- **OpenAI-compatible tool formatting** — `format_openai_tools` now handles both `ToolDefinition` objects and plain Hashes (from `native_dispatch`) by checking `respond_to?` for method access and falling back to symbol/string key access. Prevents `NoMethodError` when tools arrive as hash-backed definitions.
+
+### Added
+- **Fleet request_payload setting** — Added `fleet.request.logger.request_payload` (default: `false`) to `default_settings` for explicit control over request body logging in Faraday middleware.
+
+## 0.4.18 - 2026-06-05
+
+### Fixed
+- **Test suite** — All 377 specs passing. Specs exercise shared streaming, chat, models, fleet, credential sources, and provider contract behavior.
+- **RuboCop** — Zero offenses across 110 files.
+
+## 0.4.17 - 2026-06-04
+
+### Added
+- **faraday-typhoeus dependency** — Added `faraday-typhoeus >= 0.2` as a runtime dependency. Connection middleware now prefers `:typhoeus` (libcurl) adapter over `:net_http` to work around Ruby 4.0 + net-http-0.9.1 SSL keep-alive issues that drop connections mid-read (`connection.rb`)
+
+### Fixed
+- **Streaming on_data rejects status 0/nil** — `v2_on_data` handler only accepted `env&.status == 200`, causing typhoeus streaming chunks (where status is nil or 0 during active streaming before headers arrive) to be treated as failed responses. Now accepts nil/0 status as valid streaming state (`streaming.rb`)
+
 ## 0.4.16 - 2026-05-31
 
 ### Security