lex-apollo 0.4.7 → 0.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ed5f6ac36b031c41850cae2f4e4c6768666c4151c730b7557f7d5f21ac24df7
-  data.tar.gz: 870ffad7838f068a01aa2b03af51ba2ae7df1cfe30debda9a8d3275705ef775a
+  metadata.gz: ef4d63cf3e8b7a9ce86f11af1150b851a911fa7383ca2233d753bc328be31cb5
+  data.tar.gz: 8d4e3f73d3d7d04c1dff338eb226a3385d0977d57d77c2378d41723b3fff80e6
 SHA512:
-  metadata.gz: '0583ae3da3f19c3e852929e97947bf49b94e89d37f918d65fcc2507719049ac641ab6867c1e2b7eee899c923c1cb52ec75670c3cab345b159506d34a01099463'
-  data.tar.gz: 4f77f0e210baa01f3e77b06808ddfe06456d4f10358b8add5e4d602b8669be9b8223e6b69c30f2b56b2d18f20e5d0eabde504b05a8426812236d9a5918631bc4
+  metadata.gz: fae193470f3da5dedcdb5ee91310ac824064aa3ebd60de9f21e9d9a6c5eb770db23ad21603cb6c8d7337fb7fb84b1f85f9c3155f1ff38cac2bd426a3270eaabf
+  data.tar.gz: 6d6827a8defe1e41724a3033193f774034830cddf28bd34096622410f736d233a79853567f71b5e2f7547e48194ff3d23ce685633b55f832747ad37026c54df5

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## [0.4.8] - 2026-03-25
+
+### Changed
+- Removed `Helpers::Embedding` direct Ollama bypass; all embedding generation now routes through `Legion::LLM::Embeddings.generate`
+- `Runners::Knowledge`, `Helpers::Writeback`, and `Actor::WritebackVectorize` all use `Legion::LLM::Embeddings.generate` and extract `[:vector]` from the result hash
+- Zero-vector fallback (`Array.new(1024, 0.0)`) preserved when LLM is unavailable or returns nil vector
+
+### Removed
+- `lib/legion/extensions/apollo/helpers/embedding.rb` — direct Faraday/Ollama embedding bypass (superseded by `Legion::LLM` provider routing)
+- `spec/legion/extensions/apollo/helpers/embedding_spec.rb` — tests for removed helper
+
 ## [0.4.7] - 2026-03-25
 
 ### Added

data/lib/legion/extensions/apollo/actors/writeback_vectorize.rb

@@ -14,7 +14,9 @@ module Legion
 
           def handle_vectorize(payload)
             payload = symbolize(payload)
-            embedding = Helpers::Embedding.generate(text: payload[:content])
+            result = Legion::LLM::Embeddings.generate(text: payload[:content])
+            vector = result.is_a?(Hash) ? result[:vector] : result
+            embedding = vector.is_a?(Array) && vector.any? ? vector : Array.new(1024, 0.0)
             enriched = payload.merge(embedding: embedding)
 
             if Helpers::Capability.can_write?

data/lib/legion/extensions/apollo/helpers/writeback.rb

@@ -64,8 +64,9 @@ module Legion
             can_write = Helpers::Capability.can_write?
 
             if can_embed
-              embedding = Helpers::Embedding.generate(text: payload[:content])
-              payload[:embedding] = embedding
+              result = Legion::LLM::Embeddings.generate(text: payload[:content])
+              vector = result.is_a?(Hash) ? result[:vector] : result
+              payload[:embedding] = vector.is_a?(Array) && vector.any? ? vector : Array.new(1024, 0.0)
             end
 
             if can_write && can_embed

data/lib/legion/extensions/apollo/runners/knowledge.rb

@@ -2,7 +2,6 @@
 
 require 'json'
 require_relative '../helpers/confidence'
-require_relative '../helpers/embedding'
 
 module Legion
   module Extensions
@@ -75,7 +74,7 @@ module Legion
               end
             end
 
-            embedding = Helpers::Embedding.generate(text: content)
+            embedding = embed_text(content)
             content_type_sym = content_type.to_s
             tag_array = defined?(Helpers::TagNormalizer) ? Helpers::TagNormalizer.normalize_all(tags) : Array(tags)
             domain = knowledge_domain || tag_array.first || 'general'
@@ -119,7 +118,7 @@ module Legion
           def handle_query(query:, limit: Helpers::GraphQuery.default_query_limit, min_confidence: Helpers::GraphQuery.default_query_min_confidence, status: [:confirmed], tags: nil, domain: nil, agent_id: 'unknown', **) # rubocop:disable Metrics/ParameterLists, Layout/LineLength
             return { success: false, error: 'apollo_data_not_available' } unless defined?(Legion::Data::Model::ApolloEntry)
 
-            embedding = Helpers::Embedding.generate(text: query)
+            embedding = embed_text(query)
             sql = Helpers::GraphQuery.build_semantic_search_sql(
               limit: limit, min_confidence: min_confidence,
               statuses: Array(status).map(&:to_s), tags: tags, domain: domain
@@ -228,7 +227,7 @@ module Legion
 
             return { success: true, entries: [], count: 0 } if query.nil? || query.to_s.strip.empty?
 
-            embedding = Helpers::Embedding.generate(text: query.to_s)
+            embedding = embed_text(query.to_s)
             sql = Helpers::GraphQuery.build_semantic_search_sql(
               limit: limit, min_confidence: min_confidence,
               statuses: ['confirmed'], tags: tags, domain: domain
@@ -310,6 +309,14 @@ module Legion
 
           private
 
+          def embed_text(text)
+            result = Legion::LLM::Embeddings.generate(text: text)
+            vector = result.is_a?(Hash) ? result[:vector] : result
+            vector.is_a?(Array) && vector.any? ? vector : Array.new(1024, 0.0)
+          rescue StandardError
+            Array.new(1024, 0.0)
+          end
+
           def allowed_domains_for(target_domain)
             rules = if defined?(Legion::Settings) && Legion::Settings.dig(:apollo, :domain_isolation)
                       Legion::Settings.dig(:apollo, :domain_isolation)

data/lib/legion/extensions/apollo/runners/maintenance.rb

@@ -2,7 +2,6 @@
 
 require_relative '../helpers/confidence'
 require_relative '../helpers/similarity'
-require_relative '../helpers/embedding'
 
 module Legion
   module Extensions

data/lib/legion/extensions/apollo/version.rb

@@ -3,7 +3,7 @@
 module Legion
   module Extensions
     module Apollo
-      VERSION = '0.4.7'
+      VERSION = '0.4.8'
     end
   end
 end

data/spec/legion/extensions/apollo/actors/writeback_vectorize_spec.rb

@@ -39,7 +39,6 @@ unless defined?(Legion::Transport::Message)
   $LOADED_FEATURES << 'legion/transport/exchange' unless $LOADED_FEATURES.include?('legion/transport/exchange')
 end
 
-require 'legion/extensions/apollo/helpers/embedding'
 require 'legion/extensions/apollo/helpers/capability'
 require 'legion/extensions/apollo/transport/exchanges/apollo'
 require 'legion/extensions/apollo/transport/messages/writeback'
@@ -48,6 +47,15 @@ require 'legion/extensions/apollo/actors/writeback_vectorize'
 RSpec.describe Legion::Extensions::Apollo::Actor::WritebackVectorize do
   subject(:actor) { described_class.new }
 
+  before do
+    embeddings_mod = Module.new do
+      def self.generate(*, **)
+        { vector: Array.new(1024, 0.1), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 }
+      end
+    end
+    stub_const('Legion::LLM::Embeddings', embeddings_mod)
+  end
+
   describe '#runner_function' do
     it 'returns handle_vectorize' do
       expect(actor.runner_function).to eq('handle_vectorize')
@@ -58,7 +66,8 @@ RSpec.describe Legion::Extensions::Apollo::Actor::WritebackVectorize do
     let(:payload) { { content: 'test content', content_type: 'observation', tags: %w[test] } }
 
     before do
-      allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate).and_return([0.1] * 1024)
+      allow(Legion::LLM::Embeddings).to receive(:generate)
+        .and_return({ vector: [0.1] * 1024, model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
       allow(Legion::Extensions::Apollo::Helpers::Capability).to receive(:can_write?).and_return(false)
     end
 
@@ -83,7 +92,7 @@ RSpec.describe Legion::Extensions::Apollo::Actor::WritebackVectorize do
     end
 
     it 'returns error hash on failure' do
-      allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate).and_raise(RuntimeError, 'boom')
+      allow(Legion::LLM::Embeddings).to receive(:generate).and_raise(RuntimeError, 'boom')
 
       result = actor.handle_vectorize(payload)
       expect(result[:success]).to be false

data/spec/legion/extensions/apollo/runners/knowledge_spec.rb

@@ -3,7 +3,6 @@
 require 'spec_helper'
 require 'legion/extensions/apollo/helpers/confidence'
 require 'legion/extensions/apollo/helpers/similarity'
-require 'legion/extensions/apollo/helpers/embedding'
 require 'legion/extensions/apollo/helpers/graph_query'
 require 'legion/extensions/apollo/helpers/tag_normalizer'
 require 'legion/extensions/apollo/helpers/writeback'
@@ -16,6 +15,15 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
     obj
   end
 
+  before do
+    embeddings_mod = Module.new do
+      def self.generate(*, **)
+        { vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 }
+      end
+    end
+    stub_const('Legion::LLM::Embeddings', embeddings_mod)
+  end
+
   describe '#store_knowledge' do
     it 'returns a message payload hash' do
       result = runner.store_knowledge(
@@ -119,8 +127,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
         stub_const('Legion::Data::Model::ApolloRelation', mock_relation_class)
         stub_const('Legion::Data::Model::ApolloExpertise', mock_expertise_class)
         stub_const('Legion::Data::Model::ApolloAccessLog', mock_access_log_class)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
 
         # Corroboration lookup chain
         allow(mock_entry_class).to receive(:where).and_return(double(exclude: double(limit: empty_dataset)))
@@ -249,8 +257,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
     context 'when Sequel raises an error' do
       before do
         stub_const('Legion::Data::Model::ApolloEntry', Class.new)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
         allow(Legion::Data::Model::ApolloEntry).to receive(:where)
           .and_raise(Sequel::Error, 'connection lost')
       end
@@ -289,8 +297,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
       before do
         stub_const('Legion::Data::Model::ApolloEntry', mock_entry_class)
         stub_const('Legion::Data::Model::ApolloAccessLog', mock_access_log_class)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
         allow(mock_entry_class).to receive(:db).and_return(mock_db)
         allow(mock_db).to receive(:fetch).and_return(double(all: sample_entries))
         allow(mock_entry_class).to receive(:where).and_return(double(update: true))
@@ -324,8 +332,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
 
       before do
         stub_const('Legion::Data::Model::ApolloEntry', mock_entry_class)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
         allow(mock_entry_class).to receive(:db).and_return(mock_db)
         allow(mock_db).to receive(:fetch).and_return(double(all: []))
       end
@@ -380,8 +388,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
 
       before do
         stub_const('Legion::Data::Model::ApolloEntry', mock_entry_class)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
         allow(mock_entry_class).to receive(:db).and_return(mock_db)
         allow(mock_db).to receive(:fetch).and_return(double(all: sample_entries))
         allow(mock_entry_class).to receive(:where).and_return(double(update: true))

data/spec/legion/extensions/apollo/runners/maintenance_spec.rb

@@ -3,7 +3,6 @@
 require 'spec_helper'
 require 'legion/extensions/apollo/helpers/confidence'
 require 'legion/extensions/apollo/helpers/similarity'
-require 'legion/extensions/apollo/helpers/embedding'
 require 'legion/extensions/apollo/runners/maintenance'
 
 RSpec.describe Legion::Extensions::Apollo::Runners::Maintenance do

data/spec/legion/extensions/apollo/runners/request_spec.rb

@@ -3,7 +3,6 @@
 require 'spec_helper'
 require 'legion/extensions/apollo/helpers/confidence'
 require 'legion/extensions/apollo/helpers/similarity'
-require 'legion/extensions/apollo/helpers/embedding'
 require 'legion/extensions/apollo/helpers/graph_query'
 require 'legion/extensions/apollo/runners/knowledge'
 require 'legion/extensions/apollo/runners/request'
@@ -12,6 +11,13 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Request do
   before do
     # Clear cached knowledge_host between examples
     described_class.instance_variable_set(:@knowledge_host, nil)
+
+    embeddings_mod = Module.new do
+      def self.generate(*, **)
+        { vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 }
+      end
+    end
+    stub_const('Legion::LLM::Embeddings', embeddings_mod)
   end
 
   describe '.data_required?' do
@@ -33,8 +39,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Request do
       before do
         stub_const('Legion::Data::Model::ApolloEntry', mock_entry_class)
         stub_const('Legion::Data::Model::ApolloAccessLog', mock_access_log_class)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
         allow(mock_entry_class).to receive(:db).and_return(mock_db)
         allow(mock_db).to receive(:fetch).and_return(double(all: sample_entries))
         allow(mock_entry_class).to receive(:where).and_return(double(update: true))
@@ -97,8 +103,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Request do
 
       before do
         stub_const('Legion::Data::Model::ApolloEntry', mock_entry_class)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
         allow(mock_entry_class).to receive(:db).and_return(mock_db)
         allow(mock_db).to receive(:fetch).and_return(double(all: []))
         allow(mock_entry_class).to receive(:where).and_return(double(update: true))
@@ -136,8 +142,8 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Request do
         stub_const('Legion::Data::Model::ApolloEntry', mock_entry_class)
         stub_const('Legion::Data::Model::ApolloExpertise', mock_expertise_class)
         stub_const('Legion::Data::Model::ApolloAccessLog', mock_access_log_class)
-        allow(Legion::Extensions::Apollo::Helpers::Embedding).to receive(:generate)
-          .and_return(Array.new(1536, 0.0))
+        allow(Legion::LLM::Embeddings).to receive(:generate)
+          .and_return({ vector: Array.new(1024, 0.0), model: 'test', provider: :ollama, dimensions: 1024, tokens: 0 })
         allow(mock_entry_class).to receive(:where).and_return(double(exclude: double(limit: double(each: nil), first: nil)))
         allow(mock_entry_class).to receive(:exclude)
           .and_return(double(exclude: double(limit: double(all: []))))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-apollo
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.8
 platform: ruby
 authors:
 - Esity
@@ -160,7 +160,6 @@ files:
 - lib/legion/extensions/apollo/gaia_integration.rb
 - lib/legion/extensions/apollo/helpers/capability.rb
 - lib/legion/extensions/apollo/helpers/confidence.rb
-- lib/legion/extensions/apollo/helpers/embedding.rb
 - lib/legion/extensions/apollo/helpers/entity_watchdog.rb
 - lib/legion/extensions/apollo/helpers/graph_query.rb
 - lib/legion/extensions/apollo/helpers/similarity.rb
@@ -197,7 +196,6 @@ files:
 - spec/legion/extensions/apollo/gaia_integration_spec.rb
 - spec/legion/extensions/apollo/helpers/capability_spec.rb
 - spec/legion/extensions/apollo/helpers/confidence_spec.rb
-- spec/legion/extensions/apollo/helpers/embedding_spec.rb
 - spec/legion/extensions/apollo/helpers/entity_watchdog_spec.rb
 - spec/legion/extensions/apollo/helpers/graph_query_spec.rb
 - spec/legion/extensions/apollo/helpers/similarity_spec.rb

data/lib/legion/extensions/apollo/helpers/embedding.rb

@@ -1,104 +0,0 @@
-# frozen_string_literal: true
-
-module Legion
-  module Extensions
-    module Apollo
-      module Helpers
-        module Embedding
-          DEFAULT_DIMENSION = 1024
-
-          LOCAL_EMBEDDING_MODELS = %w[mxbai-embed-large bge-large snowflake-arctic-embed].freeze
-
-          module_function
-
-          def generate(text:, **)
-            unless defined?(Legion::LLM) && Legion::LLM.started?
-              Legion::Logging.debug('[apollo] embedding fallback: LLM not started') if defined?(Legion::Logging)
-              return zero_vector
-            end
-
-            local_model = detect_local_model
-            vector = if local_model
-                       ollama_embed(text, local_model)
-                     else
-                       opts = cloud_embedding_opts
-                       result = Legion::LLM.embed(text, **opts)
-                       result.is_a?(Hash) ? result[:vector] : result
-                     end
-
-            if vector.is_a?(Array) && vector.any?
-              @dimension = vector.size
-              vector
-            else
-              Legion::Logging.warn('[apollo] embedding fallback: LLM returned no vector') if defined?(Legion::Logging)
-              zero_vector
-            end
-          end
-
-          def dimension
-            @dimension || configured_dimension
-          end
-
-          def configured_dimension
-            return DEFAULT_DIMENSION unless defined?(Legion::Settings) && !Legion::Settings[:apollo].nil?
-
-            Legion::Settings[:apollo].dig(:embedding, :dimension) || DEFAULT_DIMENSION
-          rescue StandardError
-            DEFAULT_DIMENSION
-          end
-
-          def ollama_embed(text, model)
-            require 'faraday'
-            base_url = ollama_base_url
-            Legion::Logging.debug("[apollo] embedding via local Ollama: #{model}") if defined?(Legion::Logging)
-            conn = Faraday.new(url: base_url) { |f| f.options.timeout = 10 }
-            response = conn.post('/api/embed', { model: model, input: text }.to_json,
-                                 'Content-Type' => 'application/json')
-            return nil unless response.success?
-
-            parsed = ::JSON.parse(response.body)
-            parsed['embeddings']&.first
-          rescue StandardError => e
-            Legion::Logging.warn("[apollo] local Ollama embed failed: #{e.message}") if defined?(Legion::Logging)
-            nil
-          end
-
-          def ollama_base_url
-            return 'http://localhost:11434' unless defined?(Legion::Settings)
-
-            Legion::Settings[:llm].dig(:providers, :ollama, :base_url) || 'http://localhost:11434'
-          rescue StandardError
-            'http://localhost:11434'
-          end
-
-          def cloud_embedding_opts
-            return {} unless defined?(Legion::Settings) && !Legion::Settings[:apollo].nil?
-
-            embedding = Legion::Settings[:apollo][:embedding] || {}
-            opts = {}
-            opts[:provider] = embedding[:provider].to_sym if embedding[:provider]
-            opts[:model]    = embedding[:model] if embedding[:model]
-            opts
-          rescue StandardError
-            {}
-          end
-
-          def detect_local_model
-            return nil unless defined?(Legion::LLM::Discovery::Ollama)
-
-            LOCAL_EMBEDDING_MODELS.find do |m|
-              Legion::LLM::Discovery::Ollama.model_available?(m) ||
-                Legion::LLM::Discovery::Ollama.model_available?("#{m}:latest")
-            end
-          rescue StandardError
-            nil
-          end
-
-          def zero_vector
-            Array.new(dimension, 0.0)
-          end
-        end
-      end
-    end
-  end
-end

data/spec/legion/extensions/apollo/helpers/embedding_spec.rb

@@ -1,127 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-require 'legion/extensions/apollo/helpers/embedding'
-
-RSpec.describe Legion::Extensions::Apollo::Helpers::Embedding do
-  describe '.generate' do
-    context 'when Legion::LLM is not defined' do
-      before do
-        hide_const('Legion::LLM') if defined?(Legion::LLM)
-      end
-
-      it 'returns a zero vector of the correct dimension' do
-        result = described_class.generate(text: 'hello world')
-        expect(result).to eq(Array.new(1024, 0.0))
-        expect(result.size).to eq(1024)
-      end
-    end
-
-    context 'when Legion::LLM is defined but not started' do
-      before do
-        stub_const('Legion::LLM', Module.new { def self.started? = false })
-      end
-
-      it 'returns a zero vector' do
-        result = described_class.generate(text: 'hello world')
-        expect(result).to eq(Array.new(1024, 0.0))
-      end
-    end
-
-    context 'when Legion::LLM is available and started' do
-      let(:mock_vector) { Array.new(1024) { rand(-1.0..1.0) } }
-
-      before do
-        llm = Module.new do
-          define_method(:started?) { true }
-          define_method(:embed) { |_text, **| nil }
-          extend self
-        end
-        stub_const('Legion::LLM', llm)
-        allow(Legion::LLM).to receive(:embed).and_return({ vector: mock_vector, model: 'text-embedding-3-small' })
-      end
-
-      it 'returns the vector from the LLM response hash' do
-        result = described_class.generate(text: 'hello world')
-        expect(result).to eq(mock_vector)
-        expect(Legion::LLM).to have_received(:embed).with('hello world', **{})
-      end
-    end
-
-    context 'when Legion::LLM returns a short embedding' do
-      before do
-        llm = Module.new do
-          define_method(:started?) { true }
-          define_method(:embed) { |_text, **| nil }
-          extend self
-        end
-        stub_const('Legion::LLM', llm)
-        allow(Legion::LLM).to receive(:embed).and_return({ vector: [0.1, 0.2], model: 'test' })
-      end
-
-      it 'accepts the embedding and updates dimension' do
-        result = described_class.generate(text: 'hello world')
-        expect(result).to eq([0.1, 0.2])
-        expect(described_class.dimension).to eq(2)
-      end
-    end
-
-    context 'when Legion::LLM returns nil vector' do
-      before do
-        llm = Module.new do
-          define_method(:started?) { true }
-          define_method(:embed) { |_text, **| nil }
-          extend self
-        end
-        stub_const('Legion::LLM', llm)
-        allow(Legion::LLM).to receive(:embed).and_return({ vector: nil, model: 'test', error: 'failed' })
-      end
-
-      it 'returns a zero vector as fallback' do
-        result = described_class.generate(text: 'hello world')
-        expect(result).to be_an(Array)
-        expect(result.all?(&:zero?)).to be true
-      end
-    end
-
-    context 'when Legion::LLM returns nil' do
-      before do
-        llm = Module.new do
-          define_method(:started?) { true }
-          define_method(:embed) { |_text, **| nil }
-          extend self
-        end
-        stub_const('Legion::LLM', llm)
-        allow(Legion::LLM).to receive(:embed).and_return(nil)
-      end
-
-      it 'returns a zero vector as fallback' do
-        result = described_class.generate(text: 'hello world')
-        expect(result).to be_an(Array)
-        expect(result.all?(&:zero?)).to be true
-      end
-    end
-  end
-
-  describe '.configured_dimension' do
-    context 'when Settings has apollo.embedding.dimension' do
-      before do
-        stub_const('Legion::Settings', { apollo: { embedding: { dimension: 768 } } })
-      end
-
-      it 'returns the configured dimension' do
-        expect(described_class.configured_dimension).to eq(768)
-      end
-    end
-
-    context 'when Settings has no apollo key' do
-      before do
-        stub_const('Legion::Settings', { apollo: nil })
-      end
-
-      it 'returns the default dimension' do
-        expect(described_class.configured_dimension).to eq(1024)
-      end
-    end
-  end
-end