lex-apollo 0.4.28 → 0.4.44

data/spec/legion/extensions/apollo/runners/request_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
+require 'open3'
+require 'rbconfig'
 require 'legion/extensions/apollo/helpers/confidence'
 require 'legion/extensions/apollo/helpers/similarity'
 require 'legion/extensions/apollo/helpers/graph_query'
@@ -55,30 +57,43 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Request do
     end
 
     context 'when only transport is available' do
-      let(:mock_transport) do
-        Module.new do
-          def self.connected?
-            true
-          end
-
-          def self.respond_to?(method, *args)
-            method == :connected? || super
-          end
-        end
-      end
-      let(:mock_message) { double('message', publish: true) }
-
-      before do
-        hide_const('Legion::Data::Model::ApolloEntry') if defined?(Legion::Data::Model::ApolloEntry)
-        stub_const('Legion::Transport', mock_transport)
-        stub_const('Legion::Extensions::Apollo::Transport::Messages::Query',
-                   double('QueryMsg', new: mock_message))
-      end
-
-      it 'publishes via transport' do
-        result = described_class.query(text: 'test query')
-        expect(result[:success]).to be true
-        expect(result[:dispatched]).to eq(:transport)
+      it 'delivers all request operations through the real message classes and local transport' do
+        script = <<~'RUBY'
+          require 'rspec'
+          require 'spec_helper'
+          require 'json'
+          Legion::Transport::Connection.setup
+          channel = Legion::Transport::Connection.session.create_channel
+          Legion::Extensions::Apollo::Transport::Exchanges::Apollo.new('legion.apollo', channel: channel)
+          queries = []
+          ingests = []
+          Legion::Transport::Local.subscribe('legion.apollo.query') { |payload| queries << Legion::JSON.load(payload) }
+          Legion::Transport::Local.subscribe('legion.apollo.ingest') { |payload| ingests << Legion::JSON.load(payload) }
+          request = Legion::Extensions::Apollo::Runners::Request
+          results = [
+            request.query(text: 'remote query'),
+            request.retrieve(text: 'remote retrieval'),
+            request.traverse(entry_id: 'entry-1'),
+            request.ingest(content: 'remote fact', content_type: 'fact')
+          ]
+          Legion::Transport::Connection.shutdown
+          puts "APOLLO_RESULT=#{JSON.generate(results: results, queries: queries, ingests: ingests)}"
+        RUBY
+        stdout, stderr, status = Open3.capture3(
+          { 'LEGION_MODE' => 'lite' }, RbConfig.ruby, '-Ilib', '-Ispec', '-e', script,
+          chdir: File.expand_path('../../../../..', __dir__)
+        )
+        line = stdout.lines.find { |output| output.start_with?('APOLLO_RESULT=') }
+        raise "Request process failed: #{stderr}\n#{stdout}" unless status.success? && line
+
+        state = Legion::JSON.load(line.delete_prefix('APOLLO_RESULT='))
+        expect(state[:results]).to all(include(success: true, dispatched: 'transport'))
+        expect(state[:queries]).to contain_exactly(
+          include(action: 'query', query: 'remote query'),
+          include(action: 'query', query: 'remote retrieval'),
+          include(action: 'traverse', entry_id: 'entry-1')
+        )
+        expect(state[:ingests]).to contain_exactly(include(content: 'remote fact', content_type: 'fact'))
       end
     end
 
@@ -137,7 +152,7 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Request do
       let(:mock_expertise_class) { double('ApolloExpertise') }
       let(:mock_access_log_class) { double('ApolloAccessLog') }
       let(:mock_entry) { double('entry', id: 'uuid-123', embedding: nil) }
-
+      let(:mock_db) { double('db') }
       before do
         stub_const('Legion::Data::Model::ApolloEntry', mock_entry_class)
         stub_const('Legion::Data::Model::ApolloExpertise', mock_expertise_class)
@@ -147,7 +162,9 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Request do
         allow(mock_entry_class).to receive(:where).and_return(double(exclude: double(limit: double(each: nil), first: nil)))
         allow(mock_entry_class).to receive(:exclude)
           .and_return(double(exclude: double(limit: double(all: []))))
-        allow(mock_entry_class).to receive(:db).and_return(double(fetch: double(all: [])))
+        allow(mock_entry_class).to receive(:db).and_return(mock_db)
+        allow(mock_db).to receive(:fetch).and_return(double(all: []))
+        allow(mock_db).to receive(:transaction) { |**_options, &block| block.call }
         allow(mock_entry_class).to receive(:create).and_return(mock_entry)
         allow(mock_expertise_class).to receive(:where).and_return(double(first: nil))
         allow(mock_expertise_class).to receive(:create)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-apollo
 version: !ruby/object:Gem::Version
-  version: 0.4.28
+  version: 0.4.44
 platform: ruby
 authors:
 - Esity
@@ -149,6 +149,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sinatra
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: Durable shared knowledge with vector search, concept graph, and expertise
   tracking
 email:
@@ -160,6 +188,7 @@ files:
 - CHANGELOG.md
 - README.md
 - lib/legion/extensions/apollo.rb
+- lib/legion/extensions/apollo/actors/contradiction_scanner.rb
 - lib/legion/extensions/apollo/actors/corroboration_checker.rb
 - lib/legion/extensions/apollo/actors/decay.rb
 - lib/legion/extensions/apollo/actors/entity_watchdog.rb
@@ -198,6 +227,7 @@ files:
 - lib/legion/extensions/apollo/transport/queues/writeback_store.rb
 - lib/legion/extensions/apollo/transport/queues/writeback_vectorize.rb
 - lib/legion/extensions/apollo/version.rb
+- spec/legion/extensions/apollo/actors/contradiction_scanner_spec.rb
 - spec/legion/extensions/apollo/actors/decay_spec.rb
 - spec/legion/extensions/apollo/actors/entity_watchdog_spec.rb
 - spec/legion/extensions/apollo/actors/expertise_aggregator_spec.rb
@@ -212,18 +242,21 @@ files:
 - spec/legion/extensions/apollo/helpers/capability_spec.rb
 - spec/legion/extensions/apollo/helpers/confidence_spec.rb
 - spec/legion/extensions/apollo/helpers/entity_watchdog_spec.rb
-- spec/legion/extensions/apollo/helpers/graph_query_spec.rb
 - spec/legion/extensions/apollo/helpers/similarity_spec.rb
 - spec/legion/extensions/apollo/helpers/tag_normalizer_spec.rb
 - spec/legion/extensions/apollo/helpers/writeback_spec.rb
+- spec/legion/extensions/apollo/runners/corroboration_integration_spec.rb
 - spec/legion/extensions/apollo/runners/decay_cycle_spec.rb
 - spec/legion/extensions/apollo/runners/entity_extractor_spec.rb
 - spec/legion/extensions/apollo/runners/expertise_spec.rb
 - spec/legion/extensions/apollo/runners/gas_anticipate_spec.rb
+- spec/legion/extensions/apollo/runners/gas_deposit_integration_spec.rb
 - spec/legion/extensions/apollo/runners/gas_relate_spec.rb
 - spec/legion/extensions/apollo/runners/gas_spec.rb
 - spec/legion/extensions/apollo/runners/gas_synthesize_spec.rb
+- spec/legion/extensions/apollo/runners/ingest_transaction_integration_spec.rb
 - spec/legion/extensions/apollo/runners/knowledge_spec.rb
+- spec/legion/extensions/apollo/runners/lifecycle_integration_spec.rb
 - spec/legion/extensions/apollo/runners/maintenance_spec.rb
 - spec/legion/extensions/apollo/runners/request_spec.rb
 - spec/legion/extensions/apollo/transport/messages/ingest_spec.rb

data/spec/legion/extensions/apollo/helpers/graph_query_spec.rb

@@ -1,100 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-require 'legion/extensions/apollo/helpers/graph_query'
-
-RSpec.describe Legion::Extensions::Apollo::Helpers::GraphQuery do
-  describe 'constants' do
-    it 'defines SPREAD_FACTOR' do
-      expect(described_class::SPREAD_FACTOR).to eq(0.6)
-    end
-
-    it 'defines DEFAULT_DEPTH' do
-      expect(described_class::DEFAULT_DEPTH).to eq(2)
-    end
-
-    it 'defines MIN_ACTIVATION' do
-      expect(described_class::MIN_ACTIVATION).to eq(0.1)
-    end
-  end
-
-  describe '.build_traversal_sql' do
-    it 'returns SQL string with entry_id placeholder' do
-      sql = described_class.build_traversal_sql(depth: 2)
-      expect(sql).to include('apollo_entries')
-      expect(sql).to include('apollo_relations')
-      expect(sql).to include('WITH RECURSIVE')
-      expect(sql).to include(':entry_id')
-    end
-
-    it 'includes relation type filter when specified' do
-      sql = described_class.build_traversal_sql(depth: 2, relation_types: %w[causes depends_on])
-      expect(sql).to include("'causes'")
-      expect(sql).to include("'depends_on'")
-    end
-
-    it 'respects custom depth' do
-      sql = described_class.build_traversal_sql(depth: 3)
-      expect(sql).to include('g.depth < 3')
-    end
-
-    it 'applies spread factor and min activation' do
-      sql = described_class.build_traversal_sql(depth: 2)
-      expect(sql).to include('0.6')
-      expect(sql).to include('0.1')
-    end
-  end
-
-  describe '.build_semantic_search_sql' do
-    it 'returns SQL with vector placeholder' do
-      sql = described_class.build_semantic_search_sql(limit: 5, min_confidence: 0.3)
-      expect(sql).to include('apollo_entries')
-      expect(sql).to include(':embedding')
-      expect(sql).to include('<=>')
-      expect(sql).to include('LIMIT 5')
-    end
-
-    it 'includes status filter' do
-      sql = described_class.build_semantic_search_sql(limit: 10, statuses: %w[confirmed])
-      expect(sql).to include("'confirmed'")
-    end
-
-    it 'includes tag filter when specified' do
-      sql = described_class.build_semantic_search_sql(limit: 10, tags: %w[vault dns])
-      expect(sql).to include("'vault'")
-      expect(sql).to include("'dns'")
-      expect(sql).to include('&&')
-    end
-
-    context 'without requesting_principal_id' do
-      it 'includes no access_scope filter' do
-        sql = described_class.build_semantic_search_sql(limit: 5, min_confidence: 0.3)
-        expect(sql).not_to include('access_scope')
-      end
-    end
-
-    context 'with requesting_principal_id' do
-      let(:sql) { described_class.build_semantic_search_sql(limit: 5, min_confidence: 0.3, requesting_principal_id: 42) }
-
-      it 'allows global entries unconditionally' do
-        expect(sql).to include("access_scope = 'global'")
-      end
-
-      it 'allows private entries owned by the principal via principal FK' do
-        expect(sql).to include('e.identity_principal_id = 42')
-      end
-
-      it 'allows private entries owned by the principal via identity subquery (multi-provider auth)' do
-        expect(sql).to include('SELECT id FROM identities WHERE principal_id = 42')
-      end
-
-      it 'allows team entries when principal shares a group with the submitter' do
-        expect(sql).to include('identity_group_memberships')
-      end
-
-      it 'wraps the entire access_scope condition in parentheses so it does not break AND chaining' do
-        expect(sql).to match(/AND \(.*access_scope.*\)/m)
-      end
-    end
-  end
-end