lex-apollo 0.4.20 → 0.4.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f197e46e616eb71f939175480496d17775c67985bf70d631ac8d089724c7ac7d
-  data.tar.gz: c8f6ee951339eda218647c3bee95bfda3f32c6ee62a44abcaad8940b40214bd9
+  metadata.gz: 31dc882a8d5fd761bceaba21ff853a3d3dd898df9d4377464b72b110d306af0a
+  data.tar.gz: 8dcfd2bc7c2557b298f3d503cc94b07e5a78b5a9777789f724dede41b9d0efdb
 SHA512:
-  metadata.gz: 5b4822965e47e806bf21b1e07e3a675fff365bdea474514278ab61efc1be2e3fc557756f2ad8ab32e63b2d1eb24286dfe25c44ceacbba723bd877d1402d7a5ab
-  data.tar.gz: b67b970d6cf8734abd96c5de5e993e802ba924fd966307e60fd7911f7879559e3835d262ed653a269b740bbffd2574df9e156afe4e4c9dfd6a15b70afce6d658
+  metadata.gz: 5e066b3c62555b4866bfe99d6bed13a034e2b6b23f613ae7906e8eaebee90ecb2f9dd937a5e928dd8337af8945bfba9a1528deb4d3200eb82b8a92b081b6cf59
+  data.tar.gz: dd1d625f4efc30df8951ee80db9ee0cfc1c25137bae5d8571dd09265bd5eec79add3482eba3cc88d77f43b052994597577abe634080cd995eb4dc0db7601458e

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## [0.4.21] - 2026-04-27
+
+### Changed
+- `Apollo::Runners::Knowledge#handle_ingest` now emits warn-level logs on the three early-return failure paths (nil/blank content, nil content_type, apollo_data_not_available). Companion to PR #15: that PR added `handle_exception` to the rescue paths; this PR closes the silent-failure window for the early-return paths that fire BEFORE any rescue would. Tag values in the log line are sanitized via `gsub(/[\r\n]+/, ' ')` to prevent log-line injection from caller-controlled tags.
+
 ## [0.4.20] - 2026-04-25
 
 ### Fixed

data/lib/legion/extensions/apollo/runners/knowledge.rb

@@ -85,9 +85,8 @@ module Legion
 
             content = normalize_text_input(content)
             log.debug("Apollo Knowledge.handle_ingest content_length=#{content.length} content_type=#{content_type} tags=#{Array(tags).size} source_agent=#{source_agent} source_channel=#{source_channel || 'nil'}") # rubocop:disable Layout/LineLength
-            return { success: false, error: 'content is required' } if content.strip.empty?
-            return { success: false, error: 'content_type is required' } if content_type.nil?
-            return { success: false, error: 'apollo_data_not_available' } unless defined?(Legion::Data::Model::ApolloEntry)
+            early_error = ingest_early_return_error(content: content, content_type: content_type, tags: tags)
+            return early_error if early_error
 
             hash = content_hash || (defined?(Helpers::Writeback) ? Helpers::Writeback.content_hash(content) : nil)
             existing = active_duplicate_for_hash(hash)
@@ -353,6 +352,27 @@ module Legion
 
           private
 
+          def ingest_early_return_error(content:, content_type:, tags:)
+            if content.strip.empty?
+              safe_tags = Array(tags).map(&:to_s).map { |t| t.gsub(/[\r\n]+/, ' ') }
+              log.warn('[apollo][handle_ingest] early-return: content is required ' \
+                       "content_type=#{content_type} tags=#{safe_tags.inspect}")
+              return { success: false, error: 'content is required' }
+            end
+
+            if content_type.nil?
+              log.warn('[apollo][handle_ingest] early-return: content_type is required ' \
+                       "content_length=#{content.to_s.length}")
+              return { success: false, error: 'content_type is required' }
+            end
+
+            return nil if defined?(Legion::Data::Model::ApolloEntry)
+
+            log.warn('[apollo][handle_ingest] early-return: apollo_data_not_available ' \
+                     "content_type=#{content_type}")
+            { success: false, error: 'apollo_data_not_available' }
+          end
+
           def normalize_content_type(raw)
             sym = raw.to_s.delete_prefix(':').gsub(%r{[/\s]}, '_').strip.downcase.to_sym
             sym = CONTENT_TYPE_ALIASES.fetch(sym, sym)

data/lib/legion/extensions/apollo/version.rb

@@ -3,7 +3,7 @@
 module Legion
   module Extensions
     module Apollo
-      VERSION = '0.4.20'
+      VERSION = '0.4.21'
     end
   end
 end

data/spec/legion/extensions/apollo/runners/knowledge_spec.rb

@@ -337,6 +337,36 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
         )
       end
     end
+
+    context 'early-return warn logs' do
+      let(:logger) { instance_double('Logger', debug: nil, info: nil, warn: nil) }
+
+      before { allow(host).to receive(:log).and_return(logger) }
+
+      it 'emits a warn log when content is nil' do
+        host.handle_ingest(content: nil, content_type: 'fact')
+        expect(logger).to have_received(:warn).with(/early-return: content is required/)
+      end
+
+      it 'emits a warn log when content_type is nil' do
+        host.handle_ingest(content: 'something', content_type: nil)
+        expect(logger).to have_received(:warn).with(/early-return: content_type is required/)
+      end
+
+      it 'emits a warn log when apollo_data_not_available' do
+        hide_const('Legion::Data::Model::ApolloEntry') if defined?(Legion::Data::Model::ApolloEntry)
+        host.handle_ingest(content: 'something', content_type: 'fact')
+        expect(logger).to have_received(:warn).with(/early-return: apollo_data_not_available/)
+      end
+
+      it 'sanitizes newline-bearing tags in the warn log' do
+        host.handle_ingest(content: nil, content_type: 'fact', tags: ["evil\nFAKE LOG LINE", 'normal'])
+        expect(logger).to have_received(:warn) do |msg|
+          expect(msg).to include('evil FAKE LOG LINE')
+          expect(msg).not_to include("\n")
+        end
+      end
+    end
   end
 
   describe '#handle_query' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-apollo
 version: !ruby/object:Gem::Version
-  version: 0.4.20
+  version: 0.4.21
 platform: ruby
 authors:
 - Esity