lex-agentic-executive 0.1.12 → 0.2.1

data/spec/legion/extensions/agentic/executive/goal_management/helpers/task_dispatcher_spec.rb

@@ -0,0 +1,184 @@
+# frozen_string_literal: true
+
+require 'legion/extensions/agentic/executive/goal_management/helpers/constants'
+require 'legion/extensions/agentic/executive/goal_management/helpers/goal'
+require 'legion/extensions/agentic/executive/goal_management/helpers/task_dispatcher'
+
+RSpec.describe Legion::Extensions::Agentic::Executive::GoalManagement::Helpers::TaskDispatcher do
+  subject(:dispatcher) { described_class.new }
+
+  let(:goal_hash) do
+    {
+      id:      'goal-123',
+      content: 'ensure safety monitors are healthy',
+      domain:  :safety,
+      status:  :active
+    }
+  end
+
+  let(:unknown_domain_goal) do
+    { id: 'goal-999', content: 'do something', domain: :unknown_domain, status: :active }
+  end
+
+  let(:nil_domain_goal) do
+    { id: 'goal-nil', content: 'no domain', domain: nil, status: :active }
+  end
+
+  describe '#dispatch_goal' do
+    context 'when the domain has no runner mapping' do
+      it 'returns dispatched: false with reason :no_runner' do
+        result = dispatcher.dispatch_goal(goal: unknown_domain_goal)
+        expect(result[:dispatched]).to be false
+        expect(result[:reason]).to eq(:no_runner)
+      end
+
+      it 'includes the domain in the response' do
+        result = dispatcher.dispatch_goal(goal: unknown_domain_goal)
+        expect(result[:domain]).to eq(:unknown_domain)
+      end
+
+      it 'includes goal_id in the response' do
+        result = dispatcher.dispatch_goal(goal: unknown_domain_goal)
+        expect(result[:goal_id]).to eq('goal-999')
+      end
+    end
+
+    context 'when domain is nil' do
+      it 'returns dispatched: false' do
+        result = dispatcher.dispatch_goal(goal: nil_domain_goal)
+        expect(result[:dispatched]).to be false
+      end
+    end
+
+    context 'when the runner class is not loaded' do
+      it 'returns dispatched: false' do
+        result = dispatcher.dispatch_goal(goal: goal_hash)
+        expect(result[:dispatched]).to be false
+      end
+    end
+
+    context 'when Legion::Runner is available' do
+      before do
+        stub_const('Legion::Runner', Class.new do
+          def self.run(**_opts)
+            { success: true, status: 'task.completed', task_id: 'task-abc', result: {} }
+          end
+        end)
+
+        stub_const('Legion::Extensions::MindGrowth::Runners::Monitor', Module.new)
+      end
+
+      it 'dispatches a leaf goal and returns task_id' do
+        result = dispatcher.dispatch_goal(goal: goal_hash)
+        expect(result[:success]).to be true
+        expect(result[:task_id]).to eq('task-abc')
+        expect(result[:dispatched]).to be true
+      end
+
+      it 'includes runner_mapping in the response' do
+        result = dispatcher.dispatch_goal(goal: goal_hash)
+        expect(result[:runner_mapping]).to eq('Legion::Extensions::MindGrowth::Runners::Monitor')
+      end
+
+      it 'dispatches cognition goals to the current MindGrowth analyzer runner' do
+        stub_const('Legion::Extensions::MindGrowth::Runners::Analyzer', Module.new)
+        result = dispatcher.dispatch_goal(goal: goal_hash.merge(domain: :cognition))
+
+        expect(result[:dispatched]).to be true
+        expect(result[:runner_mapping]).to eq('Legion::Extensions::MindGrowth::Runners::Analyzer')
+      end
+
+      it 'includes goal_id in the response' do
+        result = dispatcher.dispatch_goal(goal: goal_hash)
+        expect(result[:goal_id]).to eq('goal-123')
+      end
+
+      it 'sets success: false when runner does not return task.completed status' do
+        stub_const('Legion::Runner', Class.new do
+          def self.run(**_opts)
+            { success: false, status: 'task.failed', task_id: nil, result: {} }
+          end
+        end)
+
+        result = dispatcher.dispatch_goal(goal: goal_hash)
+        expect(result[:dispatched]).to be true
+        expect(result[:success]).to be false
+      end
+    end
+
+    context 'when a client_class domain is used (introspection)' do
+      let(:introspection_goal) do
+        { id: 'goal-456', content: 'check volition', domain: :introspection, status: :active }
+      end
+
+      context 'when client class is not available' do
+        before do
+          hide_const('Legion::Extensions::Agentic::Executive::Volition::Client')
+        end
+
+        it 'returns dispatched: false' do
+          result = dispatcher.dispatch_goal(goal: introspection_goal)
+          expect(result[:dispatched]).to be false
+        end
+      end
+
+      context 'when client class is available' do
+        before do
+          client_double = instance_double('VolitionClient',
+                                          volition_status: { status: 'task.completed', task_id: 'task-xyz' })
+          client_class  = class_double('Legion::Extensions::Agentic::Executive::Volition::Client',
+                                       new: client_double)
+          stub_const('Legion::Extensions::Agentic::Executive::Volition::Client', client_class)
+        end
+
+        it 'dispatches via client and returns dispatched: true' do
+          result = dispatcher.dispatch_goal(goal: introspection_goal)
+          expect(result[:dispatched]).to be true
+          expect(result[:task_id]).to eq('task-xyz')
+        end
+      end
+    end
+  end
+
+  describe 'DOMAIN_RUNNERS constant' do
+    it 'defines a safety mapping' do
+      expect(described_class::DOMAIN_RUNNERS).to have_key(:safety)
+    end
+
+    it 'defines a cognition mapping' do
+      expect(described_class::DOMAIN_RUNNERS).to have_key(:cognition)
+    end
+
+    it 'defines a perception mapping' do
+      expect(described_class::DOMAIN_RUNNERS).to have_key(:perception)
+    end
+
+    it 'defines an introspection mapping' do
+      expect(described_class::DOMAIN_RUNNERS).to have_key(:introspection)
+    end
+
+    it 'is frozen' do
+      expect(described_class::DOMAIN_RUNNERS).to be_frozen
+    end
+
+    it 'safety mapping has a runner_class' do
+      expect(described_class::DOMAIN_RUNNERS[:safety]).to have_key(:runner_class)
+    end
+
+    it 'introspection mapping has a client_class' do
+      expect(described_class::DOMAIN_RUNNERS[:introspection]).to have_key(:client_class)
+    end
+
+    it 'all mappings have a function' do
+      described_class::DOMAIN_RUNNERS.each_value do |mapping|
+        expect(mapping).to have_key(:function)
+      end
+    end
+
+    it 'all mappings have an args_builder callable' do
+      described_class::DOMAIN_RUNNERS.each_value do |mapping|
+        expect(mapping[:args_builder]).to respond_to(:call)
+      end
+    end
+  end
+end

data/spec/legion/extensions/agentic/executive/volition/helpers/goal_bridge_spec.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+require 'legion/extensions/agentic/executive/goal_management/client'
+require 'legion/extensions/agentic/executive/volition/helpers/goal_bridge'
+
+RSpec.describe Legion::Extensions::Agentic::Executive::Volition::Helpers::GoalBridge do
+  let(:goal_client) { Legion::Extensions::Agentic::Executive::GoalManagement::Client.new }
+  let(:bridge) { described_class.new(goal_client: goal_client) }
+
+  describe '#bridge_intentions' do
+    let(:intentions) do
+      [
+        { intention_id: 'int-001', drive: :curiosity, domain: :cognition,
+          goal: 'explore knowledge gap in perception', salience: 0.8,
+          state: :active, context: {} },
+        { intention_id: 'int-002', drive: :corrective, domain: :safety,
+          goal: 'fix degraded safety monitor', salience: 0.6,
+          state: :active, context: {} }
+      ]
+    end
+
+    it 'creates a goal for each active intention' do
+      result = bridge.bridge_intentions(intentions)
+      expect(result[:bridged]).to eq(2)
+      expect(result[:goal_ids].size).to eq(2)
+      expect(goal_client.list_active_goals[:goals]).to be_empty
+      proposed = goal_client.goal_status[:statuses][:proposed]
+      expect(proposed).to eq(2)
+    end
+
+    it 'maps salience to goal priority' do
+      result = bridge.bridge_intentions(intentions)
+      goals = result[:goal_ids].map { |id| goal_client.get_goal_tree(goal_id: id) }
+      priorities = goals.map { |g| g[:tree][:priority] }
+      expect(priorities.first).to be > priorities.last
+    end
+
+    it 'skips non-active intentions' do
+      intentions[1][:state] = :suspended
+      result = bridge.bridge_intentions(intentions)
+      expect(result[:bridged]).to eq(1)
+      expect(result[:skipped]).to eq(1)
+    end
+
+    it 'skips duplicate intentions already bridged' do
+      bridge.bridge_intentions(intentions)
+      result = bridge.bridge_intentions(intentions)
+      expect(result[:bridged]).to eq(0)
+      expect(result[:duplicates]).to eq(2)
+    end
+
+    it 'returns empty result for empty input' do
+      result = bridge.bridge_intentions([])
+      expect(result[:bridged]).to eq(0)
+      expect(result[:goal_ids]).to be_empty
+    end
+  end
+end

data/spec/legion/extensions/agentic/executive/volition/runners/volition_spec.rb

@@ -289,4 +289,30 @@ RSpec.describe Legion::Extensions::Agentic::Executive::Volition::Runners::Voliti
       expect(%i[pushed duplicate]).to include(second[:result])
     end
   end
+
+  describe '.form_intentions with goal bridging' do
+    let(:goal_client) { Legion::Extensions::Agentic::Executive::GoalManagement::Client.new }
+    let(:bridge) { Legion::Extensions::Agentic::Executive::Volition::Helpers::GoalBridge.new(goal_client: goal_client) }
+    let(:client) { Legion::Extensions::Agentic::Executive::Volition::Client.new(goal_bridge: bridge) }
+
+    let(:tick_results) do
+      { working_memory_integration: { curiosity_intensity: 0.7, active_wonders: 3 } }
+    end
+    let(:cognitive_state) do
+      { curiosity: { intensity: 0.7, active_count: 3, top_question: 'Why?' } }
+    end
+
+    it 'bridges new intentions to goals' do
+      result = client.form_intentions(tick_results: tick_results, cognitive_state: cognitive_state)
+      expect(result).to have_key(:bridge_result)
+      expect(result[:bridge_result][:bridged]).to be >= 0
+    end
+
+    it 'works without a goal bridge configured' do
+      client_no_bridge = Legion::Extensions::Agentic::Executive::Volition::Client.new
+      result = client_no_bridge.form_intentions(tick_results: tick_results, cognitive_state: cognitive_state)
+      expect(result).to have_key(:drives)
+      expect(result).not_to have_key(:bridge_result)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-agentic-executive
 version: !ruby/object:Gem::Version
-  version: 0.1.12
+  version: 0.2.1
 platform: ruby
 authors:
 - Esity
@@ -263,8 +263,12 @@ files:
 - lib/legion/extensions/agentic/executive/goal_management.rb
 - lib/legion/extensions/agentic/executive/goal_management/client.rb
 - lib/legion/extensions/agentic/executive/goal_management/helpers/constants.rb
+- lib/legion/extensions/agentic/executive/goal_management/helpers/decomposer.rb
+- lib/legion/extensions/agentic/executive/goal_management/helpers/feedback_listener.rb
 - lib/legion/extensions/agentic/executive/goal_management/helpers/goal.rb
 - lib/legion/extensions/agentic/executive/goal_management/helpers/goal_engine.rb
+- lib/legion/extensions/agentic/executive/goal_management/helpers/goal_persistence.rb
+- lib/legion/extensions/agentic/executive/goal_management/helpers/task_dispatcher.rb
 - lib/legion/extensions/agentic/executive/goal_management/runners/goal_management.rb
 - lib/legion/extensions/agentic/executive/goal_management/version.rb
 - lib/legion/extensions/agentic/executive/inertia.rb
@@ -322,6 +326,7 @@ files:
 - lib/legion/extensions/agentic/executive/volition/client.rb
 - lib/legion/extensions/agentic/executive/volition/helpers/constants.rb
 - lib/legion/extensions/agentic/executive/volition/helpers/drive_synthesizer.rb
+- lib/legion/extensions/agentic/executive/volition/helpers/goal_bridge.rb
 - lib/legion/extensions/agentic/executive/volition/helpers/intention.rb
 - lib/legion/extensions/agentic/executive/volition/helpers/intention_stack.rb
 - lib/legion/extensions/agentic/executive/volition/runners/volition.rb
@@ -333,6 +338,7 @@ files:
 - lib/legion/extensions/agentic/executive/working_memory/helpers/constants.rb
 - lib/legion/extensions/agentic/executive/working_memory/runners/working_memory.rb
 - lib/legion/extensions/agentic/executive/working_memory/version.rb
+- spec/integration/autonomous_goal_pipeline_spec.rb
 - spec/legion/extensions/agentic/executive/autopilot/client_spec.rb
 - spec/legion/extensions/agentic/executive/autopilot/cognitive_autopilot_spec.rb
 - spec/legion/extensions/agentic/executive/autopilot/helpers/autopilot_engine_spec.rb
@@ -402,8 +408,12 @@ files:
 - spec/legion/extensions/agentic/executive/goal_management/client_spec.rb
 - spec/legion/extensions/agentic/executive/goal_management/goal_management_spec.rb
 - spec/legion/extensions/agentic/executive/goal_management/helpers/constants_spec.rb
+- spec/legion/extensions/agentic/executive/goal_management/helpers/decomposer_spec.rb
+- spec/legion/extensions/agentic/executive/goal_management/helpers/feedback_listener_spec.rb
 - spec/legion/extensions/agentic/executive/goal_management/helpers/goal_engine_spec.rb
+- spec/legion/extensions/agentic/executive/goal_management/helpers/goal_persistence_spec.rb
 - spec/legion/extensions/agentic/executive/goal_management/helpers/goal_spec.rb
+- spec/legion/extensions/agentic/executive/goal_management/helpers/task_dispatcher_spec.rb
 - spec/legion/extensions/agentic/executive/goal_management/runners/goal_management_spec.rb
 - spec/legion/extensions/agentic/executive/inertia/helpers/belief_spec.rb
 - spec/legion/extensions/agentic/executive/inertia/helpers/inertia_engine_spec.rb
@@ -442,6 +452,7 @@ files:
 - spec/legion/extensions/agentic/executive/volition/client_spec.rb
 - spec/legion/extensions/agentic/executive/volition/helpers/constants_spec.rb
 - spec/legion/extensions/agentic/executive/volition/helpers/drive_synthesizer_spec.rb
+- spec/legion/extensions/agentic/executive/volition/helpers/goal_bridge_spec.rb
 - spec/legion/extensions/agentic/executive/volition/helpers/intention_spec.rb
 - spec/legion/extensions/agentic/executive/volition/helpers/intention_stack_spec.rb
 - spec/legion/extensions/agentic/executive/volition/runners/volition_spec.rb