lev 9.0.1 → 10.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7d1863a4a2253c9d582fabc34ec0b3347bfac6ab
-  data.tar.gz: dc9eadf03105c2863fc432dae3096431bfcef8b1
+SHA256:
+  metadata.gz: fb4ccab91175edafaeff83e3bab8ab84e5a650ebc88b5000bf848ff1ad171d49
+  data.tar.gz: ce48c8cc00ed7edfa6076b5ba91ddbf11933f0a4b9f02e65dd6548ab69fc5b6c
 SHA512:
-  metadata.gz: 92f85896091e416faa19e243d55c3035f933b3cccf0c15030bac7d883521dc04afaf61ac4d1f5e00bfea63974060628bedeba70b01f3f3df07084d830ef6e716
-  data.tar.gz: 0fb631e0ad4d3a0f9930f60abd9a258a76fea71a6389566be0f7baab05bc5131388d7d9e280a3e032e5e5de9542fdb9d43a28dac2ab69b95841d63df882c17e6
+  metadata.gz: 9dc7506db7fe12a5122596ea9f6cdf6682bc2f601f6b89d6dc26c49c1733e53a3d74ff0679430877deaf94c1009ab22a2bde64432cd8c946a5790237177c9f25
+  data.tar.gz: 53125d7cb41f17b27539b45802d4ec1dff132434c4d4dcdddc0294128c8a973a02f2bea2df8a852d986b5ecb4e46462af3d552198846a8c2f8caf10ab255d400

data/lib/lev/active_job/configured_job.rb

@@ -13,7 +13,7 @@ module Lev
       end
 
       def perform_later(*args, &block)
-        Lev::ActiveJob::Base.new.perform_later(routine_class, options, *args, &block)
+        routine_class.job_class.new.perform_later(routine_class, options, *args, &block)
       end
     end
   end

data/lib/lev/better_active_model_errors.rb

@@ -83,6 +83,14 @@ module Lev
       @messages = ActiveSupport::OrderedHash.new
     end
 
+    # copy & details are needed to match `ActiveModel::Errors` interface
+    def copy!(other)
+      initialize_dup(other)
+    end
+    def details
+      {}
+    end
+
     def initialize_dup(other)
       @types = other.types.dup
       @messages = other.messages.dup

data/lib/lev/form_builder.rb

@@ -1,7 +1,9 @@
 module Lev
   class FormBuilder < ActionView::Helpers::FormBuilder
 
-    (field_helpers - %w(label check_box radio_button fields_for file_field)).each do |selector|
+    (
+      field_helpers.map(&:to_s) - %w(label check_box radio_button fields_for file_field)
+    ).each do |selector|
       class_eval <<-RUBY_EVAL, __FILE__, __LINE__ + 1
         def #{selector}(method, options = {})                       # def text_field(method, options = {})
           set_value_if_available(method, options)                   #   ... verbatim ...
@@ -26,11 +28,11 @@ module Lev
     def fields_for(record_name, record_object = nil, fields_options = {}, &block)
       raise "Didn't put fields_for into LevitateFormBuilder yet"
     end
- 
+
   protected
 
     def get_form_params_entry(name)
-      @options[:params].present? ? 
+      @options[:params].present? ?
         (@options[:params][@object_name].present? ?
           @options[:params][@object_name][name] :
           nil) :
@@ -60,4 +62,4 @@ def lev_form_for(record_or_name_or_array, *args, &proc)
   options[:params] = params
   options[:errors] = handler_errors # @errors || (@handler_outcome ? @handler_outcome.errors : [])
   form_for(record_or_name_or_array, *(args << options.merge(:builder => Lev::FormBuilder)), &proc)
-end
+end

data/lib/lev/object.rb

@@ -8,6 +8,7 @@ class Object
       options[:transaction] ||= Lev::TransactionIsolation.mysql_default.symbol
       @transaction_isolation = Lev::TransactionIsolation.new(options[:transaction])
 
+      @job_class = options[:job_class]
       @active_job_enqueue_options = options[:active_job_enqueue_options]
 
       @raise_fatal_errors = options[:raise_fatal_errors]

data/lib/lev/routine.rb

@@ -214,23 +214,26 @@ module Lev
         Lev::ActiveJob::ConfiguredJob.new(self, options)
       end
 
-      def perform_later(*args, &block)
-        # Delegate to a subclass of Lev::Routine::ActiveJob::Base
-        Lev::ActiveJob::Base.new.perform_later(self, active_job_enqueue_options, *args, &block)
+      def job_class
+        @job_class || Lev::ActiveJob::Base
       end
 
       def active_job_enqueue_options
         @active_job_enqueue_options || { queue: :default }
       end
 
+      def perform_later(*args, &block)
+        # Delegate to a subclass of Lev::Routine::ActiveJob::Base
+        job_class.new.perform_later(self, active_job_enqueue_options, *args, &block)
+      end
+
       # Called at a routine's class level to foretell which other routines will
       # be used when this routine executes.  Helpful for figuring out ahead of
       # time what kind of transaction isolation level should be used.
       def uses_routine(routine_class, options={})
         symbol = options[:as] || class_to_symbol(routine_class)
 
-        raise Lev.configuration.illegal_argument_error, "Routine #{routine_class} has already been registered" \
-          if nested_routines[symbol]
+        warn("Routine #{routine_class} has already been registered") if nested_routines[symbol]
 
         nested_routines[symbol] = {
           routine_class: routine_class,
@@ -298,12 +301,11 @@ module Lev
           block.call
         end
       rescue Exception => e
-        # Let exceptions escape but make sure to note the error in the status
-        # if not already done
+        # Let exceptions escape but make sure to note the error in the status if not already done
         if !e.is_a?(Lev::FatalError)
           error = Error.new(code: :exception,
                             message: e.message,
-                            data: e.backtrace.first)
+                            data: e.backtrace&.first)
           status.add_error(error)
           status.failed!
         end
@@ -378,8 +380,7 @@ module Lev
       input_mapper  = new_term_mapper(options[:translations][:inputs]) ||
                       new_term_mapper({ scope: symbol })
 
-      output_mapper = new_term_mapper(options[:translations][:outputs]) ||
-                      new_term_mapper({ scope: symbol })
+      output_mapper = new_term_mapper(options[:translations][:outputs])
 
       #
       # Set up the ignored errors in the routine instance
@@ -398,7 +399,7 @@ module Lev
 
       run_result.outputs.transfer_to(outputs) do |name|
         output_mapper.map(name)
-      end
+      end unless output_mapper.nil?
 
       options[:errors_are_fatal] = true if !options.has_key?(:errors_are_fatal)
       transfer_errors_from(run_result.errors, input_mapper, options[:errors_are_fatal])
@@ -459,8 +460,9 @@ module Lev
     end
 
     def result
-      @result ||= Result.new(Outputs.new,
-                             Errors.new(status, topmost_runner.class.raise_fatal_errors?))
+      @result ||= Result.new(
+        Outputs.new, Errors.new(status, topmost_runner.class.raise_fatal_errors?)
+      )
     end
 
     def reset_result!

data/lib/lev/version.rb

@@ -1,3 +1,3 @@
 module Lev
-  VERSION = "9.0.1"
+  VERSION = '10.1.0'
 end

data/spec/better_active_model_errors_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe 'Better active model errors' do
-
+RSpec.describe 'BetterActiveModelErrors' do
   class DummyModel
     def self.human_attribute_name(attr, default='')
       return attr.capitalize
@@ -22,4 +21,16 @@ RSpec.describe 'Better active model errors' do
     expect(errors.include?('crash')).to be true
   end
 
+  it 'duplicates when copy called' do
+    model = OpenStruct.new
+
+    error = Lev::BetterActiveModelErrors.new(model)
+    error.set(:code, 'error')
+    expect(error.get(:code)).to eq 'error'
+
+    other = Lev::BetterActiveModelErrors.new(model)
+    other.set(:code, 'warning')
+    error.copy!(other)
+    expect(error.get(:code)).to eq 'warning'
+  end
 end

data/spec/create_sprocket_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe CreateSprocket do
-  
+RSpec.describe CreateSprocket do
+
   it "should transfer errors appropriately" do
     result = CreateSprocket.call(1,"42")
     errors = result.errors.collect { |error| error.translate }

data/spec/deep_merge_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Lev::Utilities do
+RSpec.describe Lev::Utilities do
 
   it "should merge properly" do
     default_options = {
@@ -38,4 +38,4 @@ describe Lev::Utilities do
     expect(merged).to eq expected
   end
 
-end
+end

data/spec/delegates_to_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe DelegatingRoutine do
+RSpec.describe DelegatingRoutine do
 
   it "should delegate" do
     result = DelegatingRoutine.call(1,8)

data/spec/outputs_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Lev::Outputs do
+RSpec.describe Lev::Outputs do
 
   let(:outputs) { Lev::Outputs.new }
 
@@ -60,7 +60,7 @@ describe Lev::Outputs do
       :y
     end
 
-    other_outputs.add(:y, 6)    
+    other_outputs.add(:y, 6)
     expect(other_outputs.y).to eq [4,5,6]
   end
 
@@ -72,9 +72,9 @@ describe Lev::Outputs do
 
     outputs.transfer_to(other_outputs)
 
-    other_outputs.add(:y, 6)    
+    other_outputs.add(:y, 6)
     expect(other_outputs.x).to eq [4,5]
     expect(other_outputs.y).to eq 6
   end
 
-end
+end

data/spec/paramify_handler_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ParamifyHandlerA do
+RSpec.describe ParamifyHandlerA do
   it 'should error out on badly formatted params' do
     result = ParamifyHandlerA.handle(params: {terms: {type: 'blah'}})
     errors = result.errors.collect { |error| error.translate }
@@ -8,7 +8,7 @@ describe ParamifyHandlerA do
   end
 end
 
-describe ParamifyHandlerB do
+RSpec.describe ParamifyHandlerB do
   it 'should error out on badly formatted ungrouped params' do
     result = ParamifyHandlerB.handle(params: {type: 'blah'})
     errors = result.errors.collect { |error| error.translate }

data/spec/routine_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Lev::Routine do
+RSpec.describe Lev::Routine do
 
   before do
     stub_const 'RaiseRuntimeError', Class.new

data/spec/sprocket_handler_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe SprocketHandler do
+RSpec.describe SprocketHandler do
   it 'should return fatal error messages' do
     allow_any_instance_of(SprocketHandler).to(
       receive(:params).and_return({

data/spec/sprocket_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper.rb'
 
-describe Sprocket do
+RSpec.describe Sprocket do
 
   it "should not be valid with bad inputs" do
     sprocket = Sprocket.new(integer_gt_2: 1, text_only_letters: 'abcd4')
@@ -8,4 +8,4 @@ describe Sprocket do
     expect(sprocket.errors.count).to eq 2
   end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lev
 version: !ruby/object:Gem::Version
-  version: 9.0.1
+  version: 10.1.0
 platform: ruby
 authors:
 - JP Slavinsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-14 00:00:00.000000000 Z
+date: 2020-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -178,20 +178,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: jobba
   requirement: !ruby/object:Gem::Requirement
@@ -206,20 +192,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.5'
-- !ruby/object:Gem::Dependency
-  name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Ride the rails but don't touch them.
 email:
 - jps@kindlinglabs.com
@@ -293,29 +265,28 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Ride the rails but don't touch them.
 test_files:
 - spec/active_job_routines_spec.rb
-- spec/better_active_model_errors_spec.rb
-- spec/create_sprocket_spec.rb
-- spec/deep_merge_spec.rb
-- spec/delegates_to_spec.rb
-- spec/outputs_spec.rb
 - spec/paramify_handler_spec.rb
-- spec/routine_spec.rb
 - spec/spec_helper.rb
-- spec/sprocket_handler_spec.rb
 - spec/sprocket_spec.rb
+- spec/create_sprocket_spec.rb
+- spec/outputs_spec.rb
+- spec/deep_merge_spec.rb
+- spec/sprocket_handler_spec.rb
 - spec/statused_routines_spec.rb
+- spec/better_active_model_errors_spec.rb
+- spec/routine_spec.rb
+- spec/support/sprocket_handler.rb
 - spec/support/create_sprocket.rb
 - spec/support/delegated_routine.rb
-- spec/support/delegating_routine.rb
+- spec/support/sprocket.rb
 - spec/support/paramify_handler_a.rb
 - spec/support/paramify_handler_b.rb
-- spec/support/sprocket.rb
-- spec/support/sprocket_handler.rb
+- spec/support/delegating_routine.rb
 - spec/transaction_spec.rb
+- spec/delegates_to_spec.rb