letter_opener_web 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26ada71a6fd80681d7272fe6de79d089d34b0464
-  data.tar.gz: 526c8509ad5b7ce76453c264b8b436a0f82955dc
+  metadata.gz: 748f7585d505b4b67ca5233b1ba66a64f2e7c36c
+  data.tar.gz: daaa6a77e9ce24dc9c2074d9e876fb4c611e3ef3
 SHA512:
-  metadata.gz: d55ba88a2fed065dd9ba7580221a880a112ebdcd97cf41a9b1cae5a735486c13f040db5f9aafc12bbabf552aa7c3c9a638c79284107439ca00f131cb6c8f7415
-  data.tar.gz: 3f76e6581920c07d2d7c40c0d8eb3719a49633158089ad41ea2d9fec0fa3e8f7c86bca1971c9bc48a6352f6284774be6fb968573d2255144d1ae66c699590a9d
+  metadata.gz: 2b6dc02e0341d730d0aac32c3f048aaf99a61dd510b9c3eabd544de4c04de1184fff4f931324cac5fbd3edda2250a23b4abc55ae33f79c4bbac4fd620352e5f8
+  data.tar.gz: a627b71d467033c5b99cf1e1e63c5ff685faf52f5d12f6abcfbcdad2f2c2fedf62aef1a260e0cd678ae4fcda0d9e426224445c1623b553693c306ce05f04d98b

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.1.2](https://github.com/fgrehm/letter_opener_web/compare/v1.1.1...v1.1.2) (Dec 12, 2013)
+
+  - Nicely handle empty links [#18](https://github.com/fgrehm/letter_opener_web/pull/18)
+
 ## [1.1.1](https://github.com/fgrehm/letter_opener_web/compare/v1.1.0...v1.1.1) (Oct 15, 2013)
 
   - Fix deprecation warning on Rails 4 [#17](https://github.com/fgrehm/letter_opener_web/pull/17)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    letter_opener_web (1.1.1)
+    letter_opener_web (1.1.2)
       letter_opener (~> 1.0)
       rails (>= 3.2)
 

data/README.md

@@ -87,3 +87,5 @@ ideas on [this pull request](https://github.com/ryanb/letter_opener/pull/12).
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/fgrehm/letter_opener_web/trend.png)](https://bitdeli.com/free "Bitdeli Badge")

data/app/models/letter_opener_web/letter.rb

@@ -74,6 +74,7 @@ module LetterOpenerWeb
         xml        = REXML::Document.new(fixed_link).root
         unless xml.attributes['href'] =~ /(plain|rich).html/
           xml.attributes['target'] = '_blank'
+          xml.add_text('') unless xml.text
           contents.gsub!(link, xml.to_s)
         end
       end

data/demo/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    letter_opener_web (1.1.1)
+    letter_opener_web (1.1.2)
       letter_opener (~> 1.0)
       rails (>= 3.2)
 

data/lib/letter_opener_web/version.rb

@@ -1,3 +1,3 @@
 module LetterOpenerWeb
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/models/letter_opener_web/letter_spec.rb

@@ -12,6 +12,7 @@ Rich text for #{mail_id}
   Link text
 </a>
 <a href='fooo.html'>Bar</a>
+<a href="example.html" class="blank"></a>
 MAIL
   end
 
@@ -42,6 +43,11 @@ MAIL
       return pending 'This spec if failing randomly on ruby 1.8' if RUBY_VERSION =~ /^1.8/
       subject.should include("<a href='a-link.html' target='_blank'>\n  <img src='an-image.jpg'/>\n  Link text\n</a>")
     end
+
+    it 'always rewrites links with a closing tag rather than making them selfclosing' do
+      return pending 'This spec if failing randomly on ruby 1.8' if RUBY_VERSION =~ /^1.8/
+      subject.should include("<a class='blank' href='example.html' target='_blank'></a>")
+    end
   end
 
   describe 'plain text version' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: letter_opener_web
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Fabio Rehm
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-15 00:00:00.000000000 Z
+date: 2013-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails