letter_opener 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c17edf454562b845730e2bc785489ab61cc5d2a9
-  data.tar.gz: 9103feb34675d63486efea05fbb3cb0bcdc12ec0
+  metadata.gz: 791bc4430c69cf7cd36b26cc8f8c610f9b1206cc
+  data.tar.gz: 948b12833885db1d6e51c8d594dc3193c800f296
 SHA512:
-  metadata.gz: 0de0bce58674322df7867f93fdf3b01795c399bdec2dc68fc027ce299f656936159f6091a2063cc90cd1b0baf64ba0d1cd3e4e89d983ddb766265b10baf4f8b8
-  data.tar.gz: 1627f2a90df1e62f402cf015dd5ca8cb75049008f5afbea38bb96855408236e9abf2d0d91c364e3d35ff2f4c6090b2356893bcc5b838beab24589bd1fc2bde5a
+  metadata.gz: 115a513680145c304e82e56530ea8f36c9555ce7714be0316f614bc7cafe2bf43dfc00af01c0b21977863d4e17df32275ad27033affdace860b43b33171dce7a
+  data.tar.gz: c846117e41eefde83358fc04ab8f30e11580d9311ca6c4e2b4ed725a0245ef858f956cf933a04e6f8d232f85b52643db0b28a0c46e22afe4323705f115f54435

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 1.4.1 ##
+ * Stop base tag appearing in plain-text previews. (thanks [Coby Chapple](https://github.com/cobyism))
+
 ## 1.4.0 ##
  * Add base tag to the iframe so links work with X-Frame-Options set to SAMEORIGIN. (thanks [Jason Tokoph](https://github.com/jtokoph))
  * Check delivery params before rendering an email to match SMTP behaviour.

data/letter_opener.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = "letter_opener"
-  s.version     = "1.4.0"
+  s.version     = "1.4.1"
   s.author      = "Ryan Bates"
   s.email       = "ryan@railscasts.com"
   s.homepage    = "http://github.com/ryanb/letter_opener"

data/lib/letter_opener/message.html.erb

@@ -124,7 +124,7 @@
       <% if type == "plain" %>
         <pre id="message_body"><%= auto_link(h(body)) %></pre>
       <% else %>
-        <iframe seamless="seamless" srcdoc="<%= h(body) %>"></iframe>
+        <iframe seamless="seamless" srcdoc="<base target='_top'><%= h(body) %>"></iframe>
       <% end %>
     </div>
   </body>

data/lib/letter_opener/message.rb

@@ -63,7 +63,7 @@ module LetterOpener
           body.gsub!(attachment.url, "attachments/#{attachment.filename}")
         end
 
-        base_tag + body
+        body
       end
     end
 
@@ -99,11 +99,6 @@ module LetterOpener
       body.respond_to?(:encoding) ? body.encoding : "utf-8"
     end
 
-    # To make links work in iframe with X-Frame-Options set to SAMEORIGIN
-    def base_tag
-      '<base target="_top">'
-    end
-
     def auto_link(text)
       text.gsub(URI.regexp(%W[https http])) do |link|
         "<a href=\"#{ link }\">#{ link }</a>"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: letter_opener
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Ryan Bates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-09 00:00:00.000000000 Z
+date: 2015-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: launchy