letsencrypt-rails-heroku 2.0.2 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 34bfad9e6385886924b26bed9062f53175f4b1ca1ee7473c2c33828aa2cb34d0
-  data.tar.gz: e27e8e2fea3cdd4ebf9a253cd816c8af307fadae6c77e7535bc1c99baba41c0e
+  metadata.gz: 5f589e4dde9bc04d66b094ae2d1fd43a34b87c3224c616e98bd3a7c08facfbca
+  data.tar.gz: 0b28b8ce30bee194a6df29900c84c086338fd70eb40fa8e2680f6ebbe1f63616
 SHA512:
-  metadata.gz: cef68fb15ea48913116f1f65aa1f53a50202e9fb31cd53078546655cbd93b9b84b1c1cae8b381ebcfa7417243deedf5e7fcf9e9c8d12c8de0310840f37ee8378
-  data.tar.gz: ae93f4a569b1f40b3bec3c8fe9d19c43790c097570b814e29219d015344a948528268b68513dd047f5a5e5ff576e1c01664ecaf6f4479687f65dd18131ded062
+  metadata.gz: af35ed069d85e13ffebc88a94fa341056658050bf542812492735b48b49654d0f21c0d28820c3875f2af658d68db2e0495a8ef8b93579d1be75aa503ba6e72df
+  data.tar.gz: 1fd670635000f7dd4585a2b87155cd7799169f4a72aa6dc3b4ac20c9ed266ea43d25750283f49a43d6d1eaec32dccd100b42ab461bb2130751bffdd3bbf15b85

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 2.0.3
+
+ - Raise an error when the HTTP challenge is nil (#71). Thanks
+   [@mashedkeyboard](https://github.com/mashedkeyboard)!
+ - Return the response body on a 403 Forbidden from Heroku, not that it's
+   that useful.
+ - Relax `platform-api` version requirements, as it works OK with v3 too.
+
 # 2.0.2
 
  - Include OpenSSL::SSL::SSLError as a valid error we retry for when waiting
@@ -5,7 +13,7 @@
 
 # 2.0.1
 
- - Fixed a typo that broke renewals with existing certificates
+ - Fixed a typo that broke renewals with existing certificates.
 
 # 2.0.0 
 

data/Gemfile

@@ -1,7 +1,7 @@
 source "https://rubygems.org"
 
 gem 'acme-client', '~> 2.0'
-gem 'platform-api', '~> 2.2'
+gem 'platform-api', '>= 2.2', '< 4'
 
 group :development do
   gem "shoulda", ">= 0"

data/Gemfile.lock

@@ -1,38 +1,42 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    acme-client (2.0.3)
-      faraday (~> 0.9, >= 0.9.1)
-    activesupport (5.0.0)
+    acme-client (2.0.7)
+      faraday (>= 0.17, < 2.0.0)
+    activesupport (6.0.3.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
+      i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-    addressable (2.4.0)
-    builder (3.2.2)
-    concurrent-ruby (1.0.2)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    builder (3.2.4)
+    concurrent-ruby (1.1.7)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
-    docile (1.1.5)
+    docile (1.3.2)
     erubis (2.7.0)
-    excon (0.62.0)
-    faraday (0.9.2)
+    excon (0.76.0)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    git (1.3.0)
-    github_api (0.14.5)
-      addressable (~> 2.4.0)
+    git (1.7.0)
+      rchardet (~> 1.8)
+    github_api (0.19.0)
+      addressable (~> 2.4)
       descendants_tracker (~> 0.0.4)
-      faraday (~> 0.8, < 0.10)
-      hashie (>= 3.4)
+      faraday (>= 0.8, < 2)
+      hashie (~> 3.5, >= 3.5.2)
       oauth2 (~> 1.0)
-    hashie (3.4.6)
-    heroics (0.0.25)
+    hashie (3.6.0)
+    heroics (0.1.1)
       erubis (~> 2.0)
       excon
       moneta
       multi_json (>= 1.9.2)
-    highline (1.7.8)
-    i18n (0.7.0)
+    highline (2.0.3)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
     json (1.8.6)
     juwelier (2.1.3)
       builder
@@ -44,43 +48,47 @@ GEM
       rake
       rdoc
       semver
-    jwt (1.5.6)
+    jwt (2.2.2)
     mini_portile2 (2.4.0)
-    minitest (5.9.0)
+    minitest (5.14.2)
     moneta (1.0.0)
-    multi_json (1.13.1)
+    multi_json (1.15.0)
     multi_xml (0.6.0)
-    multipart-post (2.0.0)
-    nokogiri (1.10.2)
+    multipart-post (2.1.1)
+    nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
-    oauth2 (1.2.0)
-      faraday (>= 0.8, < 0.10)
-      jwt (~> 1.0)
+    oauth2 (1.4.4)
+      faraday (>= 0.8, < 2.0)
+      jwt (>= 1.0, < 3.0)
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
-    platform-api (2.2.0)
-      heroics (~> 0.0.25)
+    platform-api (3.0.0)
+      heroics (~> 0.1.1)
       moneta (~> 1.0.0)
-    rack (2.0.7)
-    rake (12.0.0)
+      rate_throttle_client (~> 0.1.0)
+    public_suffix (4.0.6)
+    rack (2.2.3)
+    rake (13.0.1)
+    rate_throttle_client (0.1.2)
+    rchardet (1.8.0)
     rdoc (3.12.2)
       json (~> 1.4)
     semver (1.0.1)
-    shoulda (3.5.0)
-      shoulda-context (~> 1.0, >= 1.0.1)
-      shoulda-matchers (>= 1.4.1, < 3.0)
-    shoulda-context (1.2.1)
-    shoulda-matchers (2.8.0)
-      activesupport (>= 3.0.0)
-    simplecov (0.12.0)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
+    shoulda (4.0.0)
+      shoulda-context (~> 2.0)
+      shoulda-matchers (~> 4.0)
+    shoulda-context (2.0.0)
+    shoulda-matchers (4.4.1)
+      activesupport (>= 4.2.0)
+    simplecov (0.19.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.3)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -89,10 +97,10 @@ DEPENDENCIES
   acme-client (~> 2.0)
   bundler (~> 1.0)
   juwelier (~> 2.1.0)
-  platform-api (~> 2.2)
+  platform-api (>= 2.2, < 4)
   rdoc (~> 3.12)
   shoulda
   simplecov
 
 BUNDLED WITH
-   1.16.6
+   1.17.3

data/VERSION

@@ -1 +1 @@
-2.0.2
+2.0.3

data/letsencrypt-rails-heroku.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: letsencrypt-rails-heroku 2.0.2 ruby lib
+# stub: letsencrypt-rails-heroku 2.0.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "letsencrypt-rails-heroku".freeze
-  s.version = "2.0.2"
+  s.version = "2.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Pixie Labs".freeze, "David Somers".freeze, "Abigail McPhillips".freeze]
-  s.date = "2020-07-24"
+  s.date = "2020-10-07"
   s.description = "This gem automatically handles creation, renewal, and applying SSL certificates from LetsEncrypt to your Heroku account.".freeze
   s.email = "team@pixielabs.io".freeze
   s.extra_rdoc_files = [
@@ -38,7 +38,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "https://github.com/pixielabs/letsencrypt-rails-heroku".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "3.0.8".freeze
+  s.rubygems_version = "3.0.6".freeze
   s.summary = "Automatic LetsEncrypt certificates in your Rails app on Heroku".freeze
 
   if s.respond_to? :specification_version then
@@ -46,7 +46,7 @@ Gem::Specification.new do |s|
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<acme-client>.freeze, ["~> 2.0"])
-      s.add_runtime_dependency(%q<platform-api>.freeze, ["~> 2.2"])
+      s.add_runtime_dependency(%q<platform-api>.freeze, [">= 2.2", "< 4"])
       s.add_development_dependency(%q<shoulda>.freeze, [">= 0"])
       s.add_development_dependency(%q<rdoc>.freeze, ["~> 3.12"])
       s.add_development_dependency(%q<bundler>.freeze, ["~> 1.0"])
@@ -54,7 +54,7 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
     else
       s.add_dependency(%q<acme-client>.freeze, ["~> 2.0"])
-      s.add_dependency(%q<platform-api>.freeze, ["~> 2.2"])
+      s.add_dependency(%q<platform-api>.freeze, [">= 2.2", "< 4"])
       s.add_dependency(%q<shoulda>.freeze, [">= 0"])
       s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
       s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
@@ -63,7 +63,7 @@ Gem::Specification.new do |s|
     end
   else
     s.add_dependency(%q<acme-client>.freeze, ["~> 2.0"])
-    s.add_dependency(%q<platform-api>.freeze, ["~> 2.2"])
+    s.add_dependency(%q<platform-api>.freeze, [">= 2.2", "< 4"])
     s.add_dependency(%q<shoulda>.freeze, [">= 0"])
     s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
     s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])

data/lib/letsencrypt-rails-heroku/exceptions.rb

@@ -12,5 +12,7 @@ module Letsencrypt
     class FinalizationTimeoutError < StandardError; end
     # Error adding the certificate to Heroku.
     class HerokuCertificateError < StandardError; end
+    # No HTTP challenge available from certificate provider.
+    class NoHTTPChallengeError < StandardError; end
   end
 end

data/lib/tasks/letsencrypt.rake

@@ -66,6 +66,8 @@ namespace :letsencrypt do
       puts "Performing verification for #{authorization.domain}:"
 
       challenge = authorization.http
+      
+      raise Letsencrypt::Error::NoHTTPChallengeError, "No HTTP challenge was given by Let's Encrypt for #{authorization.domain}, and letsencrypt-rails-heroku does not currently support other challenge types." unless challenge
 
       print "Setting config vars on Heroku..."
       heroku.config_var.update(heroku_app, {
@@ -194,6 +196,11 @@ namespace :letsencrypt do
     rescue Excon::Error::UnprocessableEntity => e
       warn "Error adding certificate to Heroku. Response from Heroku’s API follows:"
       raise Letsencrypt::Error::HerokuCertificateError, e.response.body
+    rescue Excon::Error::Forbidden => e
+      warn "Error adding certificate to Heroku, expected an OK response status, got a '403 Forbidden'. Response follows:"
+      puts e.response.body
+      # Re-raise for now.
+      raise e
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: letsencrypt-rails-heroku
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.0.3
 platform: ruby
 authors:
 - Pixie Labs
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-24 00:00:00.000000000 Z
+date: 2020-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: acme-client
@@ -30,16 +30,22 @@ dependencies:
   name: platform-api
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
@@ -154,7 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.0.6
 signing_key:
 specification_version: 4
 summary: Automatic LetsEncrypt certificates in your Rails app on Heroku