leptris 1.9.311.0 → 1.9.311.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e1d58688b4d992cc2bb25615d3322a72d0233f52be0b4debc6fd84dee830259a
-  data.tar.gz: ede6154a5d49b8e5e5a7c6cada1c6bdbca716f750901968c784a93d5c7e8fa8e
+  metadata.gz: a00351d2185cc9432a2a675feb686a11e616e9bfc4ed930ed5c3737e7eee8cbf
+  data.tar.gz: 93aa8c74620619e74b7a28a4f83569a2154df36c600edd0f8126cf2129d39bda
 SHA512:
-  metadata.gz: bad58c2abfa45a8b4165ca321546b76c84cc22d92d595e95a777c1e99b5aec02877da26db285b5e3d5b437a5f816128285a6bd51268e5cccdedac5929ce7d34f
-  data.tar.gz: eb23af13bad7872c3cf641241ee6ff4a07d0bcd47ed6d745a07dbeebe22c4c4952d6b2a7baad9232c97bc0eee26619f5ba060b9e4dec175de3927e8ec5f237b1
+  metadata.gz: 169251ef7965e3ff58646406f37bbebc1308732d7e5dc3ab400b1e766df5142bde0d887acba8e3eb2eb1b22ef5f71dc934ca76b8f01c7baff96f2ee55ab41872
+  data.tar.gz: 9e84022d8a35c5135b1fdf7f7b60531c4ba2231f9f462c48b9051de2f268b84bb9a042d2d1298f3e06aa74898364a71c6a25b57010d81c265f44da571112b74a

data/CHANGELOG.md

@@ -1,3 +1,26 @@
+## [1.9.311.1] - 2026-10-06
+
+### Fixed
+
+- **Docless children now route through the adoption contract
+  (#376)**: moxml's created nodes arrive as Node wrappers whose
+  #document is nil but whose C node is live in a foreign pool —
+  the splice sites' foreign check required a document, so those
+  children bypassed the namespace lift and, worse, the returned
+  wrapper addressed the ABANDONED source instead of the installed
+  in-tree copy (moxml's flows then mutated a node the tree never
+  saw). `foreign_child?` now treats document-nil as foreign at
+  add_child, prepend_child, add_next_sibling,
+  add_previous_sibling, and append_children, so every splice
+  returns the installed wrapper. Document#root= routes docless
+  roots through the copying ex-face too — the plain set_root of a
+  foreign-pool node linked the pointer WITHOUT adopting it into
+  the destination pool, so destination-side writes landed in the
+  source arena and reads through the root memo missed them.
+  Node-level mutations on docless
+  wrappers no longer crash the version gate (they memoize
+  nothing, so there is no version to advance).
+
 ## [1.9.311.0] - 2026-10-06
 
 ### Added

data/lib/leptris/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leptris
-  VERSION = "1.9.311.0"
+  VERSION = "1.9.311.1"
 end

data/lib/leptris/xml/document.rb

@@ -388,7 +388,12 @@ class Leptris::XML::Document
     # the foreign subtree into this document's pool and reports the
     # installed element — a fresh handle distinct from the source
     # pointer. Same-document installs keep the native fast path.
-    cross = element.document && !element.document.equal?(self)
+    # Docless roots count as foreign (#376): a plain set_root of a
+    # foreign-pool node links the pointer WITHOUT adopting it into
+    # this pool — writes through this document land in the source
+    # arena and reads through the root memo miss them. The ex-face
+    # copies properly.
+    cross = Leptris::XML::Element.foreign_to?(element, self)
     installed_ptr = nil
     if cross
       out = ::FFI::MemoryPointer.new(:pointer)

data/lib/leptris/xml/element.rb

@@ -389,6 +389,15 @@ class Leptris::XML::Element < Leptris::XML::Node
     !Leptris::XML::Native.ns_lift_needed?(node.c_ptr.address)
   end
 
+  # A node is foreign to +document+ when it belongs to another one
+  # — or to NONE (#376): moxml's created nodes are live C nodes
+  # wrapped without a document, and they splice by copy exactly
+  # like attached-foreign ones. One definition of "foreign" for
+  # the element splices and Document#root=.
+  def self.foreign_to?(node, document)
+    node.document.nil? || !node.document.equal?(document)
+  end
+
   def self.lift_namespaces_for_adoption(node, target_scope)
     return unless node.is_a?(Leptris::XML::Element)
     # Declarations the node already carries (its own definitions —
@@ -419,11 +428,11 @@ class Leptris::XML::Element < Leptris::XML::Node
     # C-bound insert (TODO.perf/14): gates + predicate + version
     # bump + engine insert in one dispatch; Qnil = the child needs
     # the namespace lift — the full path below handles it.
-    # Cross-document nodes skip the fast path entirely (1.9.304,
-    # #1528): the engine deep-copies them at the splice, so the
-    # full path's lift must run FIRST and the source original is
-    # removed after (move semantics).
-    if node.document && !node.document.equal?(@document)
+    # Cross-document and docless nodes skip the fast path entirely
+    # (1.9.304, #1528; #376): the engine deep-copies them at the
+    # splice, so the full path's lift must run FIRST and the source
+    # original is removed after (move semantics).
+    if Leptris::XML::Element.foreign_to?(node, @document)
       ensure_writable!
       unless Leptris::XML::Element.skip_adoption_lift?(node)
         Leptris::XML::Element.lift_namespaces_for_adoption(node, namespaces)
@@ -455,10 +464,10 @@ class Leptris::XML::Element < Leptris::XML::Node
     # C-bound insert (TODO.perf/14): gates + predicate + version
     # bump + engine insert in one dispatch; Qnil = the child needs
     # the namespace lift — the full path below handles it.
-    # Cross-document: full path first (lift + engine copy), then
-    # the source original is removed; returns the installed copy
-    # (self's new next sibling).
-    if node.document && !node.document.equal?(@document)
+    # Cross-document and docless (#376): full path first (lift +
+    # engine copy), then the source original is removed; returns
+    # the installed copy (self's new next sibling).
+    if Leptris::XML::Element.foreign_to?(node, @document)
       ensure_writable!
       unless Leptris::XML::Element.skip_adoption_lift?(node)
         Leptris::XML::Element.lift_namespaces_for_adoption(node, namespaces)
@@ -490,10 +499,10 @@ class Leptris::XML::Element < Leptris::XML::Node
     # C-bound insert (TODO.perf/14): gates + predicate + version
     # bump + engine insert in one dispatch; Qnil = the child needs
     # the namespace lift — the full path below handles it.
-    # Cross-document: full path first (lift + engine copy), then
-    # the source original is removed; returns the installed copy
-    # (self's new previous sibling).
-    if node.document && !node.document.equal?(@document)
+    # Cross-document and docless (#376): full path first (lift +
+    # engine copy), then the source original is removed; returns
+    # the installed copy (self's new previous sibling).
+    if Leptris::XML::Element.foreign_to?(node, @document)
       ensure_writable!
       unless Leptris::XML::Element.skip_adoption_lift?(node)
         Leptris::XML::Element.lift_namespaces_for_adoption(node, namespaces)
@@ -551,9 +560,7 @@ class Leptris::XML::Element < Leptris::XML::Node
       nodes.each { |n| add_child(n) }
       return
     end
-    cross = nodes.any? do |n|
-      n.document && !n.document.equal?(@document)
-    end
+    cross = nodes.any? { |n| Leptris::XML::Element.foreign_to?(n, @document) }
     if native_fast_children?
       addrs = nodes.map { |n| n.c_ptr.address }
       done = Leptris::XML::Native.append_binding_children(
@@ -668,13 +675,13 @@ class Leptris::XML::Element < Leptris::XML::Node
     ensure_writable!
     case node_or_markup
     when Leptris::XML::Node
-      # Cross-document adoption (1.9.304, #1528): the engine
+      # Foreign-child adoption (1.9.304, #1528): the engine
       # deep-copies foreign nodes at the splice — the returned
       # wrapper must be the INSTALLED copy, not the detached
-      # source. Route those through the re-resolving path.
-      cross = node_or_markup.document &&
-              !node_or_markup.document.equal?(@document)
-      return append_installed(node_or_markup) if cross
+      # source. Docless wrappers count as foreign (#376): moxml's
+      # created nodes carry live C pointers with no owning
+      # document, and their callers expect the in-tree handle.
+      return append_installed(node_or_markup) if Leptris::XML::Element.foreign_to?(node_or_markup, @document)
       # C-bound append (TODO.perf/08-09): one dispatch runs the
       # readonly/liveness gates, the provable no-op lift
       # predicate, the version bump, and the engine append. Qnil

data/lib/leptris/xml/node.rb

@@ -281,14 +281,15 @@ class Leptris::XML::Node
   # passes through this gate, so it is where the document's mutation
   # version advances — the invalidation behind writable-document
   # memoization. Bumping before the C call is conservative: a failed
-  # mutation merely discards memos.
+  # mutation merely discards memos. Docless wrappers (#376) mutate
+  # fine — they memoize nothing, so there is no version to advance.
   def ensure_writable!
     ensure_alive!
     if readonly_document?
       raise Leptris::XML::ReadOnlyError,
         "document is readonly — mutation attempted on #{inspect}"
     end
-    @document.advance_version
+    @document&.advance_version
     nil
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: leptris
 version: !ruby/object:Gem::Version
-  version: 1.9.311.0
+  version: 1.9.311.1
 platform: ruby
 authors:
 - Ribose Inc.