leptris 1.9.11 → 1.9.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e218d64aa7c30174d4fe7a22e47cc78c35f07cbfe3d0f22430f3ba411651143
-  data.tar.gz: 030eed3a6b5a7387da757ae20406591490a1f55893425d63a443c77631903a6f
+  metadata.gz: 590285b33ed6aac05def5ff85268822fc6d5abf87cfd5b262d51b72868f70ac3
+  data.tar.gz: 8dc09c12f495c12177a5dd15ff8892340dc090d678eb342738571bfb0e142228
 SHA512:
-  metadata.gz: 45c707da19fc4114c5f35641b799e104130a8d7c93d8fd365fe72cafec0b894f80e06dba7a73d0109b0fde77868d5db3836035411a3d9951d2f5c3db3c7c8a0f
-  data.tar.gz: '06388d993c6331e3089ad5c9f87056d978096f8bbd56598a1e8abdd37db03575e7d79989f3ed9ef5ba836d58804daaa1039d1b22e2c30c6b1bc4fb59d88fbd85'
+  metadata.gz: 2781b4465ff07a85ea7ecc91824070da8412aa933bc96273a4b9159860c95a0e227e06630967685e66db9fd696a6e5648ec9474217ecae769b8163096adf18ed
+  data.tar.gz: 9d7173b435723be6f068700e27e05f796246143dcf22dd1319079c5770a71f3f933fdd7d517a71ee47cba58f1305ed2d2e270ffaee43c422c43d693dbb77f4f7

data/CHANGELOG.md

@@ -5,6 +5,50 @@ All notable changes to Leptris will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.9.13] - 2026-08-27
+
+### Changed
+
+- **Cached-true readonly guard**: readonly is one-way, so a node
+  caches TRUE once observed (FALSE stays uncached — the document
+  may still flip). Per-read guards drop from a three-call document
+  round-trip to one ivar check. Harness attr loop 0.061 -> 0.048 s.
+- **Lazy wrapper-cache allocation**: Documents no longer allocate
+  the wrapper-identity Hash up front; parse-heavy loops that free
+  before re-reading stop paying it (~9% on the tiny-doc
+  parse-query-serialize loop). Identity semantics unchanged.
+
+### Measured dead
+
+- Further readonly-[] trimming: the isolated read is at the Ruby
+  call-chain floor (~227 ns across ~7 calls); inlining the
+  attributes build would duplicate memo logic for ~10%.
+
+## [1.9.12] - 2026-08-27
+
+### Changed
+
+- **NodeSet#each materializes on the first pass**: the lazy batch
+  fetch builds the array while yielding; every later each/[]/length
+  serves from it. Iterating twice without an explicit to_a paid the
+  batch twice — measured 0.220 s -> 0.127 s (42%) on the repeated-
+  iteration loop, now matching the materialized shape.
+- **Leaner memo guard**: `readonly_cached?` checks ivar presence
+  alone — memo presence proves readonly, because every memo site
+  assigns only under readonly and readonly is one-way. Saves a
+  document round-trip on every memoized read; the harness's
+  readonly loops drop another 22-45% (attrs 0.078 -> 0.061 s,
+  namespaces 0.033 -> 0.018 s, content 0.066 -> 0.037 s).
+
+### Measured and rejected
+
+- SAX bulk pointer read for attribute pairs: a bulk read needs a
+- counting pass first, which adds calls to a one-pass walk — no
+  win, withdrawn on inspection.
+- Unconditional writable-content memoization and version-stamp
+  memoization (see the round-X report): invalidation completeness
+  and a compare costing the read, respectively.
+
 ## [1.9.11] - 2026-08-26
 
 ### Changed

data/lib/leptris/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leptris
-  VERSION = "1.9.11"
+  VERSION = "1.9.13"
 end

data/lib/leptris/xml/document.rb

@@ -3,7 +3,7 @@
 require "ffi"
 
 class Leptris::XML::Document
-  attr_reader :c_ptr, :wrapper_cache
+  attr_reader :c_ptr
 
   # @api private
   # Internal flag container shared between the Document instance and its
@@ -31,7 +31,13 @@ class Leptris::XML::Document
     # the weak map — any GC sweep evicted it and the second call built
     # a fresh object. A strong cache costs at most one wrapper per node
     # actually visited, held until the document dies.
-    @wrapper_cache = {}
+    #
+    # Allocated lazily: parse-heavy loops stop paying one Hash per
+    # document for trees that are freed before any wrap.
+  end
+
+  def wrapper_cache
+    @wrapper_cache ||= {}
   end
 
   def self.parse(xml_or_io, options: nil, readonly: false, recover: false)
@@ -230,7 +236,7 @@ class Leptris::XML::Document
     @freed.state = :freed
     Leptris::XML::FFI.leptris_document_free(@c_ptr) unless @c_ptr.nil?
     @c_ptr = nil
-    @wrapper_cache.clear
+    @wrapper_cache&.clear
   end
 
   # Enable the first-party EXSLT-style extension pack on this

data/lib/leptris/xml/element.rb

@@ -36,7 +36,7 @@ class Leptris::XML::Element < Leptris::XML::Node
     # materializes on demand — repeated reads become hash lookups,
     # with no dispatch and no lifetime guard (a hash read cannot
     # use-after-free).
-    if @document&.readonly?
+    if readonly_document?
       cached = attributes[key.to_s]
       return cached.nil? ? nil : cached.value
     end

data/lib/leptris/xml/node.rb

@@ -104,12 +104,22 @@ class Leptris::XML::Node
   # UseAfterFreeError when it was freed.
   def ensure_writable!
     ensure_alive!
-    if @document&.readonly?
+    if readonly_document?
       raise Leptris::XML::ReadOnlyError,
         "document is readonly — mutation attempted on #{inspect}"
     end
   end
 
+  # Readonly is one-way, so caching TRUE is sound: once observed,
+  # the document is readonly forever. FALSE stays uncached (the
+  # document may still flip). Saves the document round-trip on
+  # per-read guards.
+  def readonly_document?
+    return true if instance_variable_defined?(:@readonly_document)
+    return false unless @document&.readonly?
+    @readonly_document = true
+  end
+
   def line
     ensure_alive!
     Leptris::XML::FFI.leptris_node_line(@c_ptr)
@@ -264,8 +274,11 @@ class Leptris::XML::Node
 
   protected
 
+  # Memo presence alone proves readonly: every memo site assigns
+  # only under readonly, and readonly is one-way — so the guard
+  # saves the document round-trip on every memoized read.
   def readonly_cached?(ivar)
-    @document&.readonly? && instance_variable_defined?(ivar)
+    instance_variable_defined?(ivar)
   end
 
   def as_element_or_self

data/lib/leptris/xml/node_set.rb

@@ -67,43 +67,46 @@ class Leptris::XML::NodeSet
     end
   end
 
+  # Iteration materializes: the first pass batch-fetches into @array
+  # (yielding as it wraps), and every subsequent reader — each, [],
+  # length — serves from the array. Repeated iteration without an
+  # explicit to_a pays the batch exactly once.
   def each
     return enum_for(:each) unless block_given?
-    return @array.each { |n| yield n } if @array
-    if @result_ptr
-      # Batch-fetch all node pointers through the FFI seam
-      # (leptris_xpath_result_get_nodes_ex copies every node kind,
-      # not just elements) and wrap each. Wrappers are cached
-      # per-Document via Node.wrap, so re-iteration of the same
-      # NodeSet hits it.
+    unless @array
+      return self unless @result_ptr
       n = length
       if n > 0
+        # Batch-fetch all node pointers through the FFI seam
+        # (leptris_xpath_result_get_nodes_ex copies every node kind,
+        # not just elements); the batch accessor under-copies
+        # mixed-kind results (upstream leptris#477), so per-index
+        # fetch covers the remainder.
         pointers = Leptris::XML::FFI.fetch_result_nodes(@result_ptr, n)
+        nodes = []
         pointers.each do |ptr|
           next if ptr.null?
-          yield Leptris::XML::Node.wrap(ptr, @document)
+          nodes << Leptris::XML::Node.wrap(ptr, @document)
         end
-        # The batch accessor under-copies mixed-kind results (upstream
-        # leptris#477); fall back to per-index fetch for the remainder.
         (pointers.length...n).each do |i|
           ptr = Leptris::XML::FFI.leptris_xpath_result_get_node(@result_ptr, i)
           next if ptr.null?
-          yield Leptris::XML::Node.wrap(ptr, @document)
+          nodes << Leptris::XML::Node.wrap(ptr, @document)
         end
+        @array = nodes
+      else
+        @array = []
       end
-    else
-      @array.each { |n| yield n }
     end
+    @array.each { |n| yield n }
     self
   end
 
   def to_a
     return @array if @array
     return [] if @result_ptr.nil?
-    out = []
-    each { |n| out << n }
-    @array = out  # memoize so subsequent to_a / each avoids re-fetch
-    out
+    each { |n| }  # materializes @array as a side effect
+    @array
   end
   alias_method :to_ary, :to_a
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: leptris
 version: !ruby/object:Gem::Version
-  version: 1.9.11
+  version: 1.9.13
 platform: ruby
 authors:
 - Ribose Inc.