legion-llm 0.6.15 → 0.6.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89101e37722ff5c0c96015b465b3231567b5636c796b49f94b4537fb2e9d0c9d
-  data.tar.gz: 383eb42f22009930320e9a952e165f1e0a8cb95530c4c2444e70fb30d2f804fe
+  metadata.gz: 85bd29db06078f900c983a6f722cda55d6c3c5c6a72c6e4fdb8c4295c3debddb
+  data.tar.gz: 855d18648dbe9d8e02e886011c51e35dd5f7d0828a25529428fb6f865c9b5f62
 SHA512:
-  metadata.gz: 501e4e9051fcaa678c85f47841bdbb2a97b4de433ce8a8be5767f11f4c2a1ccbebcedaa0a9962db82c92c49d209cf4dc71b9027cccc91ec5f8f458b537ee8437
-  data.tar.gz: f822fa3df241dc19568b70e02198a86404baecc4ab1238ef45f5ac7d6079821e7b52db924ac45db42d23df5f70c15285d576d85e581efd609f79f49fa41471bc
+  metadata.gz: 063beb13698b8645a8c365ccc1bde00d599b7653df47304d311b4c829b7de277e13e9443c5d693fe22668ee5855d3c2d33187eb8ed4af71dc0f744a59cdceaed
+  data.tar.gz: 4244f8d0af82a82c3a45cc483c9939fe492ef7350e43cdbf2f4d5b933210b6154150e038f02931f52943c5ad8918d6b6247d4c8debc29b083ea55336c5daf570

data/CHANGELOG.md

@@ -2,6 +2,26 @@
 
 ## [Unreleased]
 
+### Added
+- `Legion::LLM::Pipeline::ToolAdapter` - wraps Tools::Base for RubyLLM sessions
+
+### Changed
+- Renamed `McpToolAdapter` to `ToolAdapter` (backwards compat alias kept)
+- Pipeline step `McpDiscovery` renamed to `ToolDiscovery`
+- Executor reads from `Legion::Tools::Registry`
+- `chat_single` wraps registry tools with ToolAdapter
+- Routes: executor handles all tool injection, routes only pass client tools
+
+### Removed
+- MCP server dependency for tool injection in routes
+
+## [0.6.16] - 2026-04-03
+
+### Fixed
+- MCP tool adapter now correctly deserializes `MCP::Tool::Response` objects instead of returning raw `#<Response:0x...>` strings
+- Removed `is_a?(Class)` guard in executor `inject_ruby_llm_tools` that silently dropped MCP adapter instances
+- Added `cached_mcp_tools` to inference route with lazy caching (only persists when tools are available)
+
 ## [0.6.15] - 2026-04-03
 
 ### Changed

data/lib/legion/llm/pipeline/executor.rb

@@ -18,7 +18,7 @@ module Legion
                     :audit, :warnings, :discovered_tools, :confidence_score,
                     :escalation_chain
 
-        include Steps::McpDiscovery
+        include Steps::ToolDiscovery
         include Steps::ToolCalls
         include Steps::KnowledgeCapture
         include Steps::ConfidenceScoring
@@ -28,14 +28,14 @@ module Legion
 
         STEPS = %i[
           tracing_init idempotency conversation_uuid context_load
-          rbac classification billing gaia_advisory tier_assignment rag_context mcp_discovery
+          rbac classification billing gaia_advisory tier_assignment rag_context tool_discovery
           routing request_normalization token_budget provider_call response_normalization
           debate confidence_scoring tool_calls context_store post_response knowledge_capture response_return
         ].freeze
 
         PRE_PROVIDER_STEPS = %i[
           tracing_init idempotency conversation_uuid context_load
-          rbac classification billing gaia_advisory tier_assignment rag_context mcp_discovery
+          rbac classification billing gaia_advisory tier_assignment rag_context tool_discovery
           routing request_normalization token_budget
         ].freeze
 
@@ -66,6 +66,8 @@ module Legion
           legion_search_sessions
         ].freeze
 
+        private_constant :ALWAYS_LOADED_MCP_TOOLS
+
         ASYNC_THREAD_POOL = Concurrent::FixedThreadPool.new(4, fallback_policy: :caller_runs)
 
         def initialize(request)
@@ -104,16 +106,16 @@ module Legion
 
         private
 
-        def inject_discovered_tools(session)
-          server = mcp_server
-          return unless server.respond_to?(:tool_registry)
+        def inject_registry_tools(session)
+          return unless defined?(::Legion::Tools::Registry)
 
           requested = requested_deferred_tool_names
+          always_loaded = always_loaded_tool_names
           injected_names = []
 
-          server.tool_registry.each do |mcp_tool_class|
-            adapter = McpToolAdapter.new(mcp_tool_class)
-            next unless ALWAYS_LOADED_MCP_TOOLS.include?(adapter.name) || requested.include?(adapter.name)
+          ::Legion::Tools::Registry.tools.each do |tool_class|
+            adapter = ToolAdapter.new(tool_class)
+            next unless always_loaded.include?(adapter.name) || requested.include?(adapter.name)
 
             session.with_tool(adapter)
             injected_names << adapter.name
@@ -123,8 +125,8 @@ module Legion
           end
 
           log.info(
-            "[llm][mcp] inject request_id=#{@request.id} " \
-            "always_loaded=#{ALWAYS_LOADED_MCP_TOOLS.size} requested_deferred=#{requested.size} " \
+            "[llm][tools] inject request_id=#{@request.id} " \
+            "always_loaded=#{always_loaded.size} requested_deferred=#{requested.size} " \
             "injected=#{injected_names.size} names=#{injected_names.first(25).join(',')}"
           )
         rescue StandardError => e
@@ -132,6 +134,18 @@ module Legion
           handle_exception(e, level: :warn, operation: 'llm.pipeline.inject_tools')
         end
 
+        # Backwards compatibility alias
+        alias inject_discovered_tools inject_registry_tools
+
+        def always_loaded_tool_names
+          return ALWAYS_LOADED_MCP_TOOLS unless defined?(::Legion::Tools::Registry)
+
+          names = ::Legion::Tools::Registry.always_loaded_names.map { |name| name.to_s.tr('.', '_') }
+          names.any? ? names : ALWAYS_LOADED_MCP_TOOLS
+        rescue StandardError
+          ALWAYS_LOADED_MCP_TOOLS
+        end
+
         def execute_steps
           executed = 0
           skipped = 0
@@ -675,11 +689,10 @@ module Legion
 
         def inject_ruby_llm_tools(session)
           (@request.tools || []).each do |tool|
-            session.with_tool(tool) if tool.is_a?(Class)
+            session.with_tool(tool)
           end
 
-          ToolRegistry.tools.each { |tool| session.with_tool(tool) } if defined?(ToolRegistry)
-          inject_discovered_tools(session)
+          inject_registry_tools(session)
         end
 
         def apply_ruby_llm_instructions(session)
@@ -864,23 +877,6 @@ module Legion
           )
         end
 
-        def mcp_server
-          return ::Legion::MCP.server if defined?(::Legion::MCP) && ::Legion::MCP.respond_to?(:server)
-
-          require 'legion/mcp'
-          return unless defined?(::Legion::MCP) && ::Legion::MCP.respond_to?(:server)
-
-          ::Legion::MCP.server
-        rescue LoadError => e
-          @warnings << "MCP unavailable: #{e.message}"
-          handle_exception(e, level: :debug, operation: 'llm.pipeline.mcp_server.require')
-          nil
-        rescue StandardError => e
-          @warnings << "MCP server load error: #{e.message}"
-          handle_exception(e, level: :warn, operation: 'llm.pipeline.mcp_server')
-          nil
-        end
-
         def requested_deferred_tool_names
           metadata = @request.metadata || {}
           requested = metadata[:requested_tools] || metadata['requested_tools'] || []

data/lib/legion/llm/pipeline/mcp_tool_adapter.rb

@@ -35,13 +35,7 @@ module Legion
         def execute(**args)
           log.info("[llm][tools] adapter.execute name=#{@tool_name} arguments=#{summarize_payload(args)}")
           result = @mcp_tool_class.call(**args)
-          content = if result.is_a?(Hash) && result[:content]
-                      result[:content].map { |c| c[:text] || c['text'] }.compact.join("\n")
-                    elsif result.is_a?(String)
-                      result
-                    else
-                      result.to_s
-                    end
+          content = extract_content(result)
           log.info("[llm][tools] adapter.result name=#{@tool_name} output=#{summarize_payload(content)}")
           content
         rescue StandardError => e
@@ -51,6 +45,21 @@ module Legion
 
         private
 
+        def extract_content(result)
+          # MCP::Tool::Response — has .content array of {type: 'text', text: '...'}
+          if result.respond_to?(:content) && result.content.is_a?(Array)
+            result.content.filter_map { |c| c[:text] || c['text'] || c.to_s }.join("\n")
+          elsif result.is_a?(Hash) && result[:content].is_a?(Array)
+            result[:content].filter_map { |c| c[:text] || c['text'] }.join("\n")
+          elsif result.is_a?(Hash)
+            Legion::JSON.dump(result)
+          elsif result.is_a?(String)
+            result
+          else
+            result.to_s
+          end
+        end
+
         def summarize_payload(payload)
           payload.to_s[0, 200].inspect
         end

data/lib/legion/llm/pipeline/profile.rb

@@ -6,18 +6,18 @@ module Legion
       module Profile
         GAIA_SKIP = %i[
           idempotency conversation_uuid context_load rbac classification
-          billing gaia_advisory mcp_discovery context_store post_response
+          billing gaia_advisory tool_discovery context_store post_response
         ].freeze
 
         SYSTEM_SKIP = %i[
           idempotency conversation_uuid context_load rbac classification
-          billing gaia_advisory rag_context mcp_discovery context_store
+          billing gaia_advisory rag_context tool_discovery context_store
           post_response
         ].freeze
 
         QUICK_REPLY_SKIP = %i[
           idempotency conversation_uuid context_load classification
-          gaia_advisory rag_context mcp_discovery confidence_scoring
+          gaia_advisory rag_context tool_discovery confidence_scoring
           tool_calls context_store post_response knowledge_capture
         ].freeze
 

data/lib/legion/llm/pipeline/steps/tool_discovery.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require 'legion/logging/helper'
+
+module Legion
+  module LLM
+    module Pipeline
+      module Steps
+        module ToolDiscovery
+          include Legion::Logging::Helper
+
+          def step_tool_discovery
+            @discovered_tools ||= []
+            start_time = Time.now
+
+            discover_registry_tools
+            discover_client_tools
+
+            total = @discovered_tools.size
+            if total.positive?
+              sources = @discovered_tools.filter_map { |t| t.dig(:source, :server) || t.dig(:source, :type) }.uniq
+              @enrichments['tool:discovery'] = {
+                content:   "#{total} tools from #{sources.length} sources",
+                data:      { tool_count: total, sources: sources },
+                timestamp: Time.now
+              }
+            end
+
+            record_tool_discovery_timeline(total, start_time)
+          rescue StandardError => e
+            @warnings << "Tool discovery error: #{e.message}"
+            handle_exception(e, level: :warn, operation: 'llm.pipeline.steps.tool_discovery')
+            record_tool_discovery_timeline(0)
+          end
+
+          # Backwards compatibility alias — step name used in STEPS array is tool_discovery
+          alias step_mcp_discovery step_tool_discovery
+
+          private
+
+          def discover_registry_tools
+            return unless defined?(::Legion::Tools::Registry)
+
+            ::Legion::Tools::Registry.tools.each do |tool_class|
+              name = tool_class.respond_to?(:tool_name) ? tool_class.tool_name : tool_class.name
+              desc = tool_class.respond_to?(:description) ? tool_class.description : ''
+              schema = tool_class.respond_to?(:input_schema) ? tool_class.input_schema : {}
+              @discovered_tools << {
+                name:        name,
+                description: desc,
+                parameters:  schema,
+                source:      { type: :registry, server: 'legion' }
+              }
+            end
+
+            log.info(
+              "[llm][tools] discover request_id=#{@request.id} " \
+              "registry_tools=#{::Legion::Tools::Registry.tools.size}"
+            )
+          rescue StandardError => e
+            @warnings << "Registry tool discovery error: #{e.message}"
+            handle_exception(e, level: :warn, operation: 'llm.pipeline.steps.tool_discovery.registry')
+          end
+
+          def discover_client_tools
+            return unless defined?(::Legion::MCP::Client::Pool)
+
+            ::Legion::MCP::Client::Pool.all_tools.each do |tool|
+              @discovered_tools << {
+                name:        tool[:name],
+                description: tool[:description],
+                parameters:  tool[:input_schema],
+                source:      tool[:source]
+              }
+            end
+          rescue StandardError => e
+            @warnings << "Client tool discovery error: #{e.message}"
+            handle_exception(e, level: :warn, operation: 'llm.pipeline.steps.tool_discovery.client')
+          end
+
+          def record_tool_discovery_timeline(count, start_time = nil)
+            duration = start_time ? ((Time.now - start_time) * 1000).to_i : 0
+            @timeline.record(
+              category: :enrichment, key: 'tool:discovery',
+              direction: :inbound, detail: "#{count} tools discovered",
+              from: 'tool_registry', to: 'pipeline',
+              duration_ms: duration
+            )
+          end
+        end
+
+        # Backwards compatibility alias
+        McpDiscovery = ToolDiscovery
+      end
+    end
+  end
+end

data/lib/legion/llm/pipeline/steps.rb

@@ -17,7 +17,7 @@ require_relative 'steps/billing'
 require_relative 'steps/gaia_advisory'
 require_relative 'steps/tier_assigner'
 require_relative 'steps/post_response'
-require_relative 'steps/mcp_discovery'
+require_relative 'steps/tool_discovery'
 require_relative 'steps/tool_calls'
 require_relative 'steps/rag_context'
 require_relative 'steps/rag_guard'

data/lib/legion/llm/pipeline/tool_adapter.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require 'ruby_llm'
+require 'legion/logging/helper'
+
+module Legion
+  module LLM
+    module Pipeline
+      class ToolAdapter < RubyLLM::Tool
+        include Legion::Logging::Helper
+
+        def initialize(tool_class)
+          @tool_class = tool_class
+          raw_name = tool_class.respond_to?(:tool_name) ? tool_class.tool_name : tool_class.name.to_s
+          @tool_name = raw_name.tr('.', '_')
+          @tool_desc = tool_class.respond_to?(:description) ? tool_class.description.to_s : ''
+          @tool_schema = tool_class.respond_to?(:input_schema) ? tool_class.input_schema : nil
+          super()
+        end
+
+        def name
+          @tool_name
+        end
+
+        def description
+          @tool_desc
+        end
+
+        def params_schema
+          return @params_schema if defined?(@params_schema)
+
+          @params_schema = (RubyLLM::Utils.deep_stringify_keys(@tool_schema) if @tool_schema.is_a?(Hash))
+        end
+
+        def execute(**args)
+          log.info("[llm][tools] adapter.execute name=#{@tool_name} arguments=#{summarize_payload(args)}")
+          result = @tool_class.call(**args)
+          content = extract_content(result)
+          log.info("[llm][tools] adapter.result name=#{@tool_name} output=#{summarize_payload(content)}")
+          content
+        rescue StandardError => e
+          handle_exception(e, level: :warn, operation: 'llm.pipeline.tool_adapter.execute', tool_name: @tool_name)
+          "Tool error: #{e.message}"
+        end
+
+        private
+
+        def extract_content(result)
+          # MCP::Tool::Response — has .content array of {type: 'text', text: '...'}
+          if result.respond_to?(:content) && result.content.is_a?(Array)
+            result.content.filter_map { |c| c[:text] || c['text'] || c.to_s }.join("\n")
+          elsif result.is_a?(Hash) && result[:content].is_a?(Array)
+            result[:content].filter_map { |c| c[:text] || c['text'] }.join("\n")
+          elsif result.is_a?(Hash)
+            Legion::JSON.dump(result)
+          elsif result.is_a?(String)
+            result
+          else
+            result.to_s
+          end
+        end
+
+        def summarize_payload(payload)
+          payload.to_s[0, 200].inspect
+        end
+      end
+
+      # Backwards compatibility alias
+      McpToolAdapter = ToolAdapter
+    end
+  end
+end

data/lib/legion/llm/pipeline.rb

@@ -11,7 +11,7 @@ require_relative 'pipeline/gaia_caller'
 require_relative 'pipeline/tool_dispatcher'
 require_relative 'pipeline/enrichment_injector'
 require_relative 'pipeline/steps'
-require_relative 'pipeline/mcp_tool_adapter'
+require_relative 'pipeline/tool_adapter'
 require_relative 'pipeline/executor'
 
 module Legion

data/lib/legion/llm/routes.rb

@@ -477,6 +477,8 @@ module Legion
             build_client_tool_class(ts[:name].to_s, ts[:description].to_s, ts[:parameters] || ts[:input_schema])
           end
 
+          log.unknown "[llm][api] inference tools client=#{tool_declarations.size}"
+
           streaming = body[:stream] == true && request.preferred_type.to_s.include?('text/event-stream')
           normalized_caller = caller_context.respond_to?(:transform_keys) ? caller_context.transform_keys(&:to_sym) : {}
           safe_caller_fields = normalized_caller.slice(:context, :session_id, :trace_id)

data/lib/legion/llm/version.rb

@@ -2,6 +2,6 @@
 
 module Legion
   module LLM
-    VERSION = '0.6.15'
+    VERSION = '0.6.17'
   end
 end

data/lib/legion/llm.rb

@@ -644,7 +644,7 @@ module Legion
 
       def chat_single(model:, provider:, intent:, tier:, message: nil, **kwargs, &block)
         explicit_tools = kwargs.delete(:tools)
-        tools = explicit_tools || ToolRegistry.tools
+        tools = explicit_tools || adapted_registry_tools
         tools = nil if tools.empty?
 
         if (intent || tier) && Router.routing_enabled?
@@ -687,6 +687,26 @@ module Legion
         response
       end
 
+      def adapted_registry_tools
+        tool_classes = if defined?(::Legion::Tools::Registry)
+                         ::Legion::Tools::Registry.tools
+                       elsif defined?(::Legion::LLM::ToolRegistry)
+                         ::Legion::LLM::ToolRegistry.tools
+                       else
+                         return []
+                       end
+
+        tool_classes.map do |tool_class|
+          Pipeline::ToolAdapter.new(tool_class)
+        rescue StandardError => e
+          handle_exception(e, level: :warn, operation: 'llm.adapted_registry_tools', tool_class: tool_class.to_s)
+          nil
+        end.compact
+      rescue StandardError => e
+        handle_exception(e, level: :warn, operation: 'llm.adapted_registry_tools')
+        []
+      end
+
       def try_defer(intent:, urgency:, model:, provider:, message:, **)
         return nil unless Scheduling.enabled? && Scheduling.should_defer?(intent: intent || :normal, urgency: urgency)
         return nil unless defined?(Batch) && Batch.enabled?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: legion-llm
 version: !ruby/object:Gem::Version
-  version: 0.6.15
+  version: 0.6.17
 platform: ruby
 authors:
 - Esity
@@ -287,7 +287,9 @@ files:
 - lib/legion/llm/pipeline/steps/tier_assigner.rb
 - lib/legion/llm/pipeline/steps/token_budget.rb
 - lib/legion/llm/pipeline/steps/tool_calls.rb
+- lib/legion/llm/pipeline/steps/tool_discovery.rb
 - lib/legion/llm/pipeline/timeline.rb
+- lib/legion/llm/pipeline/tool_adapter.rb
 - lib/legion/llm/pipeline/tool_dispatcher.rb
 - lib/legion/llm/pipeline/tracing.rb
 - lib/legion/llm/provider_registry.rb