legion-data 1.6.15 → 1.6.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7482bef7a948d0666c146430112e789f3f47cf41c8a4955d4464ec2ed46c297
-  data.tar.gz: 78495d83350dfd60bdac99ec0e4b03deb5d3a6b51070e158e784e0a3e9e7083a
+  metadata.gz: 458456d016a717f8ee9397f29f01b118ecb7e8a103142defe337788d72762176
+  data.tar.gz: cac5a1f8a0bb86ec3087da754d2432ae97ebdc65b003c4ee1aa5e9c9570cc03a
 SHA512:
-  metadata.gz: 224c494f220a6d57e2ad00dae338007a7266f3126b51487bd429f709b7f6417267ee40b0d8453a6817bd32ff35bfc8ac79c072ca4f0d978c586bed35656f68f5
-  data.tar.gz: 6550fe8cbf470a7b7ad8f5639d425e55536357a55ecc5832e5956b4bf8e32b1079cdde47367c52d45c4fa7cdf7e01604b87eed5017b8f5d8e7f00155aea71801
+  metadata.gz: 2303a3358441efcea756d106d92a102858eb3534109df30b294925213ae8cba7559969e7f2d01b6ec7ad5bbe1bdca9bf1c5af7d92e1d9fc647eeb8230c8c9269
+  data.tar.gz: e50d02ec9745f7dc178bb53ca222c104e822505190b5bacf7ed404e9a61480b4a3361817b220a399b1cd95d323503d66046050e6acabacca2fce493b842e3500

data/.github/workflows/ci.yml

@@ -10,6 +10,40 @@ jobs:
   ci:
     uses: LegionIO/.github/.github/workflows/ci.yml@main
 
+  ci-postgres:
+    name: "RSpec (PostgreSQL)"
+    timeout-minutes: 15
+    runs-on: ubuntu-latest
+    services:
+      postgres:
+        image: postgres:16-alpine
+        env:
+          POSTGRES_USER: legion
+          POSTGRES_PASSWORD: legion
+          POSTGRES_DB: legionio
+        ports:
+          - 5432:5432
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.4'
+          bundler-cache: true
+      - name: Run RSpec (PostgreSQL adapter)
+        env:
+          LEGION_DATA_ADAPTER: postgres
+          LEGION_DATA_HOST: 127.0.0.1
+          LEGION_DATA_PORT: 5432
+          LEGION_DATA_USER: legion
+          LEGION_DATA_PASSWORD: legion
+          LEGION_DATA_DATABASE: legionio
+        run: bundle exec rspec
+
   lint:
     uses: LegionIO/.github/.github/workflows/lint-patterns.yml@main
 
@@ -27,8 +61,8 @@ jobs:
     uses: LegionIO/.github/.github/workflows/stale.yml@main
 
   release:
-    needs: [ci, lint]
+    needs: [ci, ci-postgres, lint]
     if: github.event_name == 'push' && github.ref == 'refs/heads/main'
     uses: LegionIO/.github/.github/workflows/release.yml@main
     secrets:
-      rubygems-api-key: ${{ secrets.RUBYGEMS_API_KEY }}
+      rubygems-api-key: ${{ secrets.RUBYGEMS_API_KEY }}

data/.rubocop.yml

@@ -1,26 +1,8 @@
-AllCops:
-  TargetRubyVersion: 3.4
-  NewCops: enable
-  SuggestExtensions: false
+inherit_gem:
+  rubocop-legion: config/core.yml
 
-Layout/LineLength:
-  Max: 160
-
-Layout/SpaceAroundEqualsInParameterDefault:
-  EnforcedStyle: space
-
-Layout/HashAlignment:
-  EnforcedHashRocketStyle: table
-  EnforcedColonStyle: table
-
-Metrics/MethodLength:
-  Max: 50
-
-Metrics/ClassLength:
-  Max: 1500
-
-Metrics/ModuleLength:
-  Max: 1500
+Metrics/ParameterLists:
+  Max: 8
 
 Metrics/BlockLength:
   Max: 40
@@ -28,34 +10,22 @@ Metrics/BlockLength:
     - 'spec/**/*'
     - 'lib/legion/data/migrations/**/*'
 
-Metrics/AbcSize:
-  Max: 60
-
-Metrics/CyclomaticComplexity:
-  Max: 15
-
-Metrics/PerceivedComplexity:
-  Max: 17
-
-Style/Documentation:
+Naming/VariableNumber:
   Enabled: false
 
-Style/SymbolArray:
-  Enabled: true
-
-Style/FrozenStringLiteralComment:
-  Enabled: true
-  EnforcedStyle: always
+Style/FileOpen:
+  Exclude:
+    - 'lib/legion/data/connection.rb'
 
-Naming/FileName:
+# Pre-existing patterns — suppress until addressed in a dedicated cleanup PR
+ThreadSafety/ClassInstanceVariable:
   Enabled: false
 
-Naming/VariableNumber:
+ThreadSafety/ClassAndModuleAttributes:
   Enabled: false
 
-Metrics/ParameterLists:
-  Max: 8
+Legion/RescueLogging/NoCapture:
+  Enabled: false
 
-Style/FileOpen:
-  Exclude:
-    - 'lib/legion/data/connection.rb'
+Legion/Framework/EagerSequelModel:
+  Enabled: false

data/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 ## [Unreleased]
 
+## [1.6.16] - 2026-03-30
+
+### Fixed
+- Migration 019: widen `record_hash` column to size 255 via `set_column_type` (column added in migration 017)
+- Migration 019: rename `prev_hash` to `previous_hash` via `rename_column` instead of adding a duplicate column
+- Migration 019: decouple index creation from column existence checks so indexes are always guarded by their own `idxs.key?` check
+- Migration 019: `down` no longer drops `record_hash` (owned by migration 017, not 019)
+- Migration 019: replace `db.indexes` with bare `indexes()` — inside a `Sequel.migration` block `self` is the DB object, so `db` is undefined
+- Updated to rubocop-legion (`inherit_gem: config/core.yml`) for shared LegionIO cop configuration
+
+### Added
+- Migration 019 spec: 8 examples covering column presence, defaults, indexes, idempotency, and rollback
+
 ## [1.6.15] - 2026-03-29
 
 ### Added

data/Gemfile

@@ -7,7 +7,7 @@ group :test do
   gem 'rake'
   gem 'rspec'
   gem 'rspec_junit_formatter'
-  gem 'rubocop'
+  gem 'rubocop-legion'
   gem 'simplecov'
 end
 gem 'mysql2', '>= 0.5.5'

data/lib/legion/data/extract/handlers/base.rb

@@ -5,7 +5,7 @@ module Legion
     module Extract
       module Handlers
         class Base
-          @registry = {}
+          @registry = {}.freeze
 
           class << self
             attr_reader :registry
@@ -22,7 +22,7 @@ module Legion
             end
 
             def register(handler_class)
-              @registry[handler_class.type] = handler_class
+              @registry = @registry.merge(handler_class.type => handler_class).freeze
             end
 
             def for_type(type)

data/lib/legion/data/extract/handlers/xlsx.rb

@@ -16,11 +16,11 @@ module Legion
             workbook = ::RubyXL::Parser.parse(source)
             sheets = []
             workbook.worksheets.each do |sheet|
-              rows = sheet.each.map do |row|
+              rows = sheet.each.filter_map do |row|
                 next unless row
 
                 row.cells.map { |c| c&.value.to_s }.join(', ')
-              end.compact
+              end
               sheets << "Sheet: #{sheet.sheet_name}\n#{rows.join("\n")}" unless rows.empty?
             end
             text = sheets.join("\n\n")

data/lib/legion/data/extract.rb

@@ -41,7 +41,8 @@ module Legion
         end
 
         def register_handler(type, klass)
-          Handlers::Base.registry[type.to_sym] = klass
+          Handlers::Base.instance_variable_set(:@registry,
+                                               Handlers::Base.registry.merge(type.to_sym => klass).freeze)
         end
 
         private

data/lib/legion/data/migrations/019_add_audit_hash_chain.rb

@@ -4,15 +4,32 @@ Sequel.migration do
   up do
     return unless table_exists?(:audit_log)
 
-    cols = schema(:audit_log).map(&:first)
+    cols    = schema(:audit_log).map(&:first)
+    idxs    = indexes(:audit_log)
 
-    alter_table(:audit_log) do
-      add_column :record_hash, String, size: 64 unless cols.include?(:record_hash)
-      add_column :previous_hash, String, size: 64 unless cols.include?(:previous_hash)
-      add_column :retention_tier, String, size: 10, default: 'hot' unless cols.include?(:retention_tier)
-      add_index :record_hash, unique: true, if_not_exists: true
-      add_index :retention_tier, if_not_exists: true
+    # record_hash exists from migration 017 at size 64; widen to 255 if needed.
+    if cols.include?(:record_hash)
+      set_column_type :audit_log, :record_hash, String, size: 255
+    else
+      alter_table(:audit_log) { add_column :record_hash, String, size: 255 }
     end
+
+    add_index :audit_log, :record_hash unless idxs.key?(:audit_log_record_hash_index)
+
+    # Rename prev_hash (introduced in migration 017) to previous_hash for clarity,
+    # then widen it to 255 to match record_hash.
+    if cols.include?(:prev_hash) && !cols.include?(:previous_hash)
+      rename_column :audit_log, :prev_hash, :previous_hash
+      set_column_type :audit_log, :previous_hash, String, size: 255
+    elsif !cols.include?(:previous_hash)
+      alter_table(:audit_log) { add_column :previous_hash, String, size: 255 }
+    elsif cols.include?(:previous_hash)
+      set_column_type :audit_log, :previous_hash, String, size: 255
+    end
+
+    alter_table(:audit_log) { add_column :retention_tier, String, size: 10, default: 'hot' } unless cols.include?(:retention_tier)
+
+    add_index :audit_log, :retention_tier unless idxs.key?(:audit_log_retention_tier_index)
   end
 
   down do
@@ -20,10 +37,22 @@ Sequel.migration do
 
     cols = schema(:audit_log).map(&:first)
 
-    alter_table(:audit_log) do
-      drop_column :record_hash if cols.include?(:record_hash)
-      drop_column :previous_hash if cols.include?(:previous_hash)
-      drop_column :retention_tier if cols.include?(:retention_tier)
+    drop_index :audit_log, :record_hash, if_exists: true
+
+    # Restore record_hash to its original size (64 from migration 017).
+    set_column_type :audit_log, :record_hash, String, size: 64 if cols.include?(:record_hash)
+
+    # Rename previous_hash back to prev_hash (reverse of the up rename) and restore size to 64.
+    if cols.include?(:previous_hash) && !cols.include?(:prev_hash)
+      rename_column :audit_log, :previous_hash, :prev_hash
+      set_column_type :audit_log, :prev_hash, String, size: 64
+    elsif cols.include?(:previous_hash)
+      alter_table(:audit_log) { drop_column :previous_hash }
+    end
+
+    if cols.include?(:retention_tier)
+      drop_index :audit_log, :retention_tier, if_exists: true
+      alter_table(:audit_log) { drop_column :retention_tier }
     end
   end
 end

data/lib/legion/data/migrations/020_add_webhooks.rb

@@ -34,4 +34,10 @@ Sequel.migration do
       DateTime :created_at, default: Sequel::CURRENT_TIMESTAMP
     end
   end
+
+  down do
+    drop_table?(:webhook_dead_letters)
+    drop_table?(:webhook_deliveries)
+    drop_table?(:webhooks)
+  end
 end

data/lib/legion/data/settings.rb

@@ -128,7 +128,7 @@ module Legion
 end
 
 begin
-  Legion::Settings.merge_settings('data', Legion::Data::Settings.default) if Legion.const_defined?('Settings')
+  Legion::Settings.merge_settings('data', Legion::Data::Settings.default) if Legion.const_defined?('Settings', false)
 rescue StandardError => e
   Legion::Logging.fatal(e.message) if Legion::Logging.method_defined?(:fatal)
 end

data/lib/legion/data/version.rb

@@ -2,6 +2,6 @@
 
 module Legion
   module Data
-    VERSION = '1.6.15'
+    VERSION = '1.6.16'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: legion-data
 version: !ruby/object:Gem::Version
-  version: 1.6.15
+  version: 1.6.16
 platform: ruby
 authors:
 - Esity