legato 0.0.9 → 0.0.10

data/README.md

@@ -1,7 +1,16 @@
 # Legato: Google Analytics Model/Mapper #
+[![Build Status](https://travis-ci.org/tpitale/legato.png)](https://travis-ci.org/tpitale/legato)
 
 ## [Check out the Wiki!](https://github.com/tpitale/legato/wiki) ##
 
+If you've come here from Garb, welcome! There are a few changes from Garb, so you'll want to check out:
+
+* [Model Data](https://github.com/tpitale/legato/wiki/Model-Data)
+* [Query Parameters](https://github.com/tpitale/legato/wiki/Query-Parameters)
+* And the biggest difference: [Filtering](https://github.com/tpitale/legato/wiki/Filtering)
+ 
+If you're not able to upgrade quite yet, Garb has been maintained https://github.com/Sija/garb
+
 ## Google Analytics Management ##
 
 1. Get an OAuth2 Access Token from Google, Read about [OAuth2](https://github.com/tpitale/legato/wiki/OAuth2-and-Google)

data/lib/legato/management/finder.rb

@@ -15,7 +15,8 @@ module Legato
         end
 
         json = user.access_token.get(base_uri + path).body
-        MultiJson.decode(json)['items'].map {|item| new(item, user)}
+        items = MultiJson.decode(json).fetch('items', [])
+        items.map {|item| new(item, user)}
       end
     end
   end

data/lib/legato/version.rb

@@ -1,3 +1,3 @@
 module Legato
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/spec/cassettes/management/no_profiles.json

@@ -0,0 +1 @@
+{"http_interactions":[{"request":{"method":"get","uri":"https://www.googleapis.com/analytics/v3/management/accounts/~all/webproperties/~all/profiles","body":"","headers":{"Authorization":["Bearer ya29.AHES6ZSw3j6NfON_gJdtG6bHrU4bh3gPsRd945judH-Umg"]}},"response":{"status":{"code":200,"message":null},"headers":{"expires":["Mon, 12 Dec 2011 01:50:58 GMT"],"date":["Mon, 12 Dec 2011 01:50:58 GMT"],"cache-control":["private, max-age=0, must-revalidate, no-transform"],"etag":["\"0EbX2LGJDld9q3PnatPaRNNGQuE/b64HzQHPH7LaksA_n9YpboKT6LI\""],"content-type":["application/json; charset=UTF-8"],"x-content-type-options":["nosniff"],"x-frame-options":["SAMEORIGIN"],"x-xss-protection":["1; mode=block"],"server":["GSE"],"connection":["close"]},"body":"{\"kind\":\"analytics#profiles\",\"username\":\"tpitale@gmail.com\",\"totalResults\":0,\"startIndex\":1,\"itemsPerPage\":1000}","http_version":null},"recorded_at":"Mon, 12 Dec 2011 01:51:14 GMT"}],"recorded_with":"VCR 2.0.0.beta2"}

data/spec/integration/management_spec.rb

@@ -31,4 +31,13 @@ describe "Management" do
       profiles.map(&:id).include?("4506212").should == true
     end
   end
+
+  context "Management::Finder without results" do
+    use_vcr_cassette 'management/no_profiles'
+
+    it 'has no profiles' do
+      profiles = Legato::Management::Profile.all(@user)
+      profiles.map(&:id).should == []
+    end
+  end
 end

data/spec/support/examples/management_finder.rb

@@ -1,18 +1,29 @@
 shared_examples_for "a management finder" do
+  let(:response) { stub(:body => 'some json') }
+  let(:access_token) { access_token = stub(:get => response) }
+  let(:user) { stub(:access_token => access_token, :api_key => nil) }
+
+  after do
+    user.should have_received(:access_token)
+    access_token.should have_received(:get).with('https://www.googleapis.com/analytics/v3/management'+described_class.default_path)
+    response.should have_received(:body)
+    MultiJson.should have_received(:decode).with('some json')
+  end
+
   it "returns an array of all #{subject_class_name} available to a user" do
     MultiJson.stubs(:decode).returns({'items' => ['item1', 'item2']})
-    response = stub(:body => 'some json')
-    access_token = stub(:get => response)
-    user = stub(:access_token => access_token, :api_key => nil)
     described_class.stubs(:new).returns('thing1', 'thing2')
 
     described_class.all(user).should == ['thing1', 'thing2']
 
-    user.should have_received(:access_token)
-    access_token.should have_received(:get).with('https://www.googleapis.com/analytics/v3/management'+described_class.default_path)
-    response.should have_received(:body)
-    MultiJson.should have_received(:decode).with('some json')
     described_class.should have_received(:new).with('item1', user)
     described_class.should have_received(:new).with('item2', user)
   end
-end
+
+  it "returns an empty array of #{subject_class_name} when there are no results" do
+    MultiJson.stubs(:decode).returns({})
+    described_class.all(user).should == []
+
+    described_class.should have_received(:new).never
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: legato
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-18 00:00:00.000000000 Z
+date: 2013-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -178,6 +178,7 @@ files:
 - lib/legato/user.rb
 - lib/legato/version.rb
 - spec/cassettes/management/accounts.json
+- spec/cassettes/management/no_profiles.json
 - spec/cassettes/management/profiles.json
 - spec/cassettes/management/web_properties.json
 - spec/cassettes/model/basic.json
@@ -222,6 +223,7 @@ specification_version: 3
 summary: Access the Google Analytics API with Ruby
 test_files:
 - spec/cassettes/management/accounts.json
+- spec/cassettes/management/no_profiles.json
 - spec/cassettes/management/profiles.json
 - spec/cassettes/management/web_properties.json
 - spec/cassettes/model/basic.json
@@ -240,4 +242,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/examples/management_finder.rb
 - spec/support/macros/oauth.rb
-has_rdoc: