legacy_data 0.1.10 → 0.1.11

data/History.txt

@@ -0,0 +1,8 @@
+=== EDGE 
+* 
+
+=== 0.1.11 2010-03-05
+* Fix for SQLServer and other drivers that do not support constraints  
+
+=== 0.1.10 2009-10-05
+* Initial release

data/README.md

@@ -10,21 +10,21 @@ information encoded in it.
 
 - To generate an ActiveRecord model for each table in the database just type
 
-  `script/generate script/generate models_from_tables`
+  `script/generate models_from_tables`
 
 - If you don't want all tables in the database tell it which table to model
  
-  `script/generate script/generate models_from_tables --table-name comments`
+  `script/generate models_from_tables --table-name comments`
   
   This uses any foreign_key constraints in the database to spider the database and model the comments table and all associated tables.
   
 - If you *really* only want the comments table tell it not to follow any foreign_keys
 
-  `script/generate script/generate models_from_tables --table-name comments --skip-associated`
+  `script/generate models_from_tables --table-name comments --skip-associated`
 
 - If you use [factory girl](http://github.com/thoughtbot/factory_girl) it will generate a simple factory for each model it generates
 
-  `script/generate script/generate models_from_tables --table-name comments --with-factories`
+  `script/generate models_from_tables --table-name comments --with-factories`
 
 (You do need to install the plugin `gem install legacy_data` as long as http://gemcutter.org is one of your gem sources)
 

data/VERSION

@@ -1 +1 @@
-0.1.10
+0.1.11

data/generators/models_from_tables/models_from_tables_generator.rb

@@ -3,23 +3,25 @@ require File.dirname(__FILE__) + '/../../lib/legacy_data'
 class ModelsFromTablesGenerator < Rails::Generator::Base  
   def manifest
     record do |m|
-      m.directory File.join('app/models')
-
       LegacyData::TableClassNameMapper.naming_convention = options[:table_naming_convention]
       
       analyzed_tables = LegacyData::Schema.analyze(options)
 
-      LegacyData::TableClassNameMapper.let_user_validate_dictionary
+      unless analyzed_tables.blank?
+        m.directory File.join('app/models')
+
+        LegacyData::TableClassNameMapper.let_user_validate_dictionary
 
-      analyzed_tables.each do |analyzed_table|
-        analyzed_table.class_name = LegacyData::TableClassNameMapper.class_name_for(analyzed_table[:table_name])
+        analyzed_tables.each do |analyzed_table|
+          analyzed_table.class_name = LegacyData::TableClassNameMapper.class_name_for(analyzed_table[:table_name])
 
-        m.class_collisions :class_path, analyzed_table[:class_name]
-        m.template           'model.rb',      
-                             File.join('app/models', "#{analyzed_table[:class_name].underscore}.rb"), 
-                             :assigns => {:definition => analyzed_table}
+          m.class_collisions :class_path, analyzed_table[:class_name]
+          m.template           'model.rb',      
+                               File.join('app/models', "#{analyzed_table[:class_name].underscore}.rb"), 
+                               :assigns => {:definition => analyzed_table}
 
-        add_factory_girl_factory analyzed_table if options[:with_factories]
+          add_factory_girl_factory analyzed_table if options[:with_factories]
+        end
 
       end
     end

data/legacy_data.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{legacy_data}
-  s.version = "0.1.10"
+  s.version = "0.1.11"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alex Rothenberg"]
-  s.date = %q{2009-11-05}
+  s.date = %q{2010-03-05}
   s.description = %q{Create ActiveRecord models from an existing database}
   s.email = %q{alex@alexrothenberg.com}
   s.extra_rdoc_files = [
@@ -19,6 +19,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
      ".gitignore",
+     "History.txt",
      "LICENSE",
      "README.md",
      "Rakefile",
@@ -134,11 +135,10 @@ Gem::Specification.new do |s|
      "spec/models_from_tables_generator_spec.rb",
      "spec/spec_helper.rb"
   ]
-  s.has_rdoc = true
   s.homepage = %q{http://github.com/alexrothenberg/legacy_data}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.2}
+  s.rubygems_version = %q{1.3.6}
   s.summary = %q{Create ActiveRecord models from an existing database}
   s.test_files = [
     "spec/expected/factories.rb",

data/lib/legacy_data/schema.rb

@@ -26,7 +26,11 @@ module LegacyData
     def self.initialize_tables(table_name)
       clear_table_definitions
       if table_name
-        add_pending_table(table_name)
+        if connection.table_exists? table_name
+          add_pending_table(table_name)
+        else
+          log "Warning: Table '#{table_name}' does not exist"
+        end
       else
         self.tables.each {|table| add_pending_table(table) }
       end
@@ -181,7 +185,7 @@ module LegacyData
     end
     
     def custom_constraints
-      return [] unless connection.respond_to? :constraints
+      return [[],[]] unless connection.respond_to? :constraints
       custom_constraints, inclusion_constraints = {}, {}
       connection.constraints(table_name).each do |constraint|
         constraint_sql = constraint.second

data/spec/legacy_data/schema_spec.rb

@@ -1,12 +1,46 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe LegacyData::Schema do
+  describe 'which tables to start with' do
+    it 'should start with all tables when no parameter limits us' do
+      LegacyData::Schema.should_receive(:tables).and_return ['table1', 'table2']
+      LegacyData::Schema.initialize_tables(nil)
+      
+      LegacyData::Schema.table_definitions.keys.should == ['table1', 'table2']
+    end
+
+    it 'should start with one table when we pass a valid table name in' do
+      LegacyData::Schema.stub!(:connection=>connection=mock)
+      connection.should_receive(:table_exists?).with('specific_table').and_return(true)
+
+      LegacyData::Schema.initialize_tables('specific_table')
+      
+      LegacyData::Schema.table_definitions.keys.should == ['specific_table']
+    end
+
+    it 'should start with no tableswhen we pass an invalid table name in' do
+      LegacyData::Schema.should_receive(:puts).with("Warning: Table 'specific_table' does not exist")
+      LegacyData::Schema.stub!(:connection=>connection=mock)
+      connection.should_receive(:table_exists?).with('specific_table').and_return(false)
+
+      LegacyData::Schema.initialize_tables('specific_table')
+      
+      LegacyData::Schema.table_definitions.keys.should == []
+    end
+  end
+  
   describe 'following associations' do
     before :each do
+      LegacyData::Schema.stub!(:connection=>connection=mock)
+      connection.stub!(:table_exists?).with('posts'   ).and_return(true)
+      connection.stub!(:table_exists?).with('comments').and_return(true)
+
       LegacyData::Schema.stub!(:analyze_table).with('posts'   ).and_return(@posts_analysis   =mock(:posts,    {:join_table? =>false}))
       LegacyData::Schema.stub!(:analyze_table).with('comments').and_return(@comments_analysis=mock(:comments, {:join_table? =>false}))
-      @posts_analysis.stub!(   :[]).with(:relations).and_return({:belongs_to=>{                                 }, :has_many=>{:comments=>{:foreign_key=>:posts_id}}})
-      @comments_analysis.stub!(:[]).with(:relations).and_return({:belongs_to=>{:posts=>{:foreign_key=>:posts_id}}, :has_many=>{                                    }})
+      @posts_analysis.stub!(   :[]).with(:relations).and_return({:belongs_to=>{                                 }, 
+                                                                 :has_many=>{:comments=>{:foreign_key=>:posts_id}}})
+      @comments_analysis.stub!(:[]).with(:relations).and_return({:belongs_to=>{:posts=>{:foreign_key=>:posts_id}}, 
+                                                                 :has_many=>{                                    }})
     end
     
     it 'should analyze all tables when not given a table to start with' do
@@ -170,7 +204,7 @@ describe LegacyData::Schema do
     
       it 'should give no custom constraints when the adapter does not support it' do
         @connection.should_receive(:respond_to?).with(:constraints).and_return(false)
-        @schema.custom_constraints.should == []
+        @schema.custom_constraints.should == [[],[]]
       end
   
       describe 'custom constraints' do

data/spec/legacy_data/table_definition_spec.rb

@@ -54,7 +54,7 @@ describe LegacyData::TableDefinition do
         table_definition = LegacyData::TableDefinition.new(:constraints => {:custom => {:my_constraint => "some plsql logic",
                                                                                         :another_one   => "multi\nline\n  plsql logic"}
                                                                       })
-        table_definition.custom_constraints_to_s.should include <<-RB
+        table_definition.custom_constraints_to_s.should include(<<-RB )
   validate :validate_my_constraint
   def validate_my_constraint
     # TODO: validate this SQL constraint
@@ -63,7 +63,7 @@ describe LegacyData::TableDefinition do
     SQL
   end
         RB
-        table_definition.custom_constraints_to_s.should include <<-RB
+        table_definition.custom_constraints_to_s.should include(<<-RB)
   validate :validate_another_one
   def validate_another_one
     # TODO: validate this SQL constraint

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 require 'rubygems'
-require 'activerecord'
+require 'active_record'
 # require 'active_record/connection_adapters/oracle_enhanced_adapter'
 
 

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: legacy_data
 version: !ruby/object:Gem::Version 
-  version: 0.1.10
+  prerelease: false
+  segments: 
+  - 0
+  - 1
+  - 11
+  version: 0.1.11
 platform: ruby
 authors: 
 - Alex Rothenberg
@@ -9,39 +14,47 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-05 00:00:00 -05:00
+date: 2010-03-05 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :development
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: activerecord
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :runtime
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: matthuhiggins-foreigner
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        - 2
+        - 1
         version: 0.2.1
-    version: 
+  type: :runtime
+  version_requirements: *id003
 description: Create ActiveRecord models from an existing database
 email: alex@alexrothenberg.com
 executables: []
@@ -54,6 +67,7 @@ extra_rdoc_files:
 files: 
 - .document
 - .gitignore
+- History.txt
 - LICENSE
 - README.md
 - Rakefile
@@ -181,18 +195,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.2
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Create ActiveRecord models from an existing database