leftovers 0.7.0 → 0.8.0

data/lib/leftovers/matcher_builders/node_has_argument.rb

@@ -3,71 +3,67 @@
 module Leftovers
   module MatcherBuilders
     module NodeHasArgument
-      def self.build(patterns) # rubocop:disable Metrics/MethodLength
-        ::Leftovers::MatcherBuilders::Or.each_or_self(patterns) do |pat|
-          case pat
-          when ::String
-            ::Leftovers::MatcherBuilders::NodeHasKeywordArgument.build(pat, nil)
-          when ::Integer
-            ::Leftovers::MatcherBuilders::NodeHasPositionalArgument.build(pat, nil)
-          when ::Hash
-            build_from_hash(**pat)
-          # :nocov:
-          else
-            raise
+      class << self
+        def build(patterns)
+          ::Leftovers::MatcherBuilders::Or.each_or_self(patterns) do |pat|
+            case pat
+            when ::String
+              ::Leftovers::MatcherBuilders::NodeHasKeywordArgument.build(pat, nil)
+            when ::Integer
+              ::Leftovers::MatcherBuilders::NodeHasPositionalArgument.build(pat, nil)
+            when ::Hash then build_from_hash(**pat)
             # :nocov:
+            else raise Leftovers::UnexpectedCase, "Unhandled value #{pat.inspect}"
+              # :nocov:
+            end
           end
         end
-      end
 
-      def self.separate_argument_types(at) # rubocop:disable Metrics/MethodLength
-        keys = []
-        positions = []
+        private
 
-        ::Leftovers.each_or_self(at) do |k|
-          case k
-          when '*', ::Integer
-            positions << k
-          when ::String, ::Hash
-            keys << k
-          # :nocov:
-          else raise
-            # :nocov:
-          end
-        end
+        def build_from_hash(at: nil, has_value: nil, unless_arg: nil)
+          value_matcher = ::Leftovers::MatcherBuilders::NodeValue.build(has_value)
 
-        keys = nil if keys.empty?
-        positions = nil if positions.empty?
+          ::Leftovers::MatcherBuilders::AndNot.build(
+            build_argument_matcher(value_matcher, **separate_argument_types(at)),
+            ::Leftovers::MatcherBuilders::NodeHasArgument.build(unless_arg)
+          )
+        end
 
-        [keys, positions]
-      end
+        def separate_argument_types(at)
+          groups = ::Leftovers.each_or_self(at).group_by do |index|
+            case index
+            when '*', ::Integer then :positions
+            when ::String, ::Hash then :keys
+            # :nocov:
+            else raise Leftovers::UnexpectedCase, "Unhandled value #{index.inspect}"
+              # :nocov:
+            end
+          end
 
-      def self.build_from_hash( # rubocop:disable Metrics/MethodLength
-        at: nil,
-        has_value: nil,
-        unless_arg: nil
-      )
-        keys, positions = separate_argument_types(at)
+          groups.transform_values { |v| Leftovers.unwrap_array(v) }
+        end
 
-        value_matcher = ::Leftovers::MatcherBuilders::NodeValue.build(has_value)
-        matcher = if (keys && positions) || (!keys && !positions)
-          ::Leftovers::MatcherBuilders::Or.build([
-            ::Leftovers::MatcherBuilders::NodeHasPositionalArgument.build(positions, value_matcher),
-            ::Leftovers::MatcherBuilders::NodeHasKeywordArgument.build(keys, value_matcher)
-          ])
-        elsif keys
+        def build_has_keyword_argument(keys, value_matcher)
           ::Leftovers::MatcherBuilders::NodeHasKeywordArgument.build(keys, value_matcher)
-        elsif positions
+        end
+
+        def build_has_positional_argument(positions, value_matcher)
           ::Leftovers::MatcherBuilders::NodeHasPositionalArgument.build(positions, value_matcher)
-          # :nocov:
-        else
-          raise
-          # :nocov:
         end
 
-        ::Leftovers::MatcherBuilders::AndNot.build(
-          matcher, ::Leftovers::MatcherBuilders::NodeHasArgument.build(unless_arg)
-        )
+        def build_argument_matcher(value_matcher, keys: nil, positions: nil)
+          if keys && !positions
+            build_has_keyword_argument(keys, value_matcher)
+          elsif positions && !keys
+            build_has_positional_argument(positions, value_matcher)
+          else
+            ::Leftovers::MatcherBuilders::Or.build([
+              build_has_positional_argument(positions, value_matcher),
+              build_has_keyword_argument(keys, value_matcher)
+            ])
+          end
+        end
       end
     end
   end

data/lib/leftovers/matcher_builders/node_has_keyword_argument.rb

@@ -4,21 +4,24 @@ module Leftovers
   module MatcherBuilders
     module NodeHasKeywordArgument
       class << self
-        def build(keywords, value_matcher) # rubocop:disable Metrics/MethodLength
+        def build(keywords, value_matcher)
           value_matcher = ::Leftovers::MatcherBuilders::NodePairValue.build(value_matcher)
-          keyword_matcher = if ::Leftovers.each_or_self(keywords).include?('**')
+          keyword_matcher = build_keyword_matcher(keywords)
+          pair_matcher = ::Leftovers::MatcherBuilders::And.build([keyword_matcher, value_matcher])
+
+          return unless pair_matcher
+
+          ::Leftovers::Matchers::NodeHasAnyKeywordArgument.new(pair_matcher)
+        end
+
+        private
+
+        def build_keyword_matcher(keywords)
+          if ::Leftovers.each_or_self(keywords).include?('**')
             ::Leftovers::Matchers::NodeType.new(:pair)
           else
             ::Leftovers::MatcherBuilders::NodePairName.build(keywords)
           end
-
-          pair_matcher = ::Leftovers::MatcherBuilders::And.build([
-            keyword_matcher, value_matcher
-          ])
-
-          return nil unless pair_matcher
-
-          ::Leftovers::Matchers::NodeHasAnyKeywordArgument.new(pair_matcher)
         end
       end
     end

data/lib/leftovers/matcher_builders/node_has_positional_argument.rb

@@ -4,22 +4,36 @@ module Leftovers
   module MatcherBuilders
     module NodeHasPositionalArgument
       class << self
-        def build(positions, value_matcher) # rubocop:disable Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity, Metrics/MethodLength
-          if positions && value_matcher
-            ::Leftovers::MatcherBuilders::Or.each_or_self(positions) do |pos|
-              if pos == '*'
-                ::Leftovers::Matchers::NodeHasAnyPositionalArgumentWithValue.new(value_matcher)
-              else
-                ::Leftovers::Matchers::NodeHasPositionalArgumentWithValue.new(pos, value_matcher)
-              end
-            end
-          elsif positions
-            pos = 0 if ::Leftovers.each_or_self(positions).include?('*')
-            pos ||= ::Leftovers.each_or_self(positions).min
-
-            ::Leftovers::Matchers::NodeHasPositionalArgument.new(pos)
+        def build(positions, value_matcher)
+          if positions && !all_positions?(positions) && value_matcher
+            build_has_positional_value_matcher(positions, value_matcher)
+          elsif positions && !value_matcher
+            build_has_position_matcher(positions)
           elsif value_matcher
-            ::Leftovers::Matchers::NodeHasAnyPositionalArgumentWithValue.new(value_matcher)
+            build_has_any_positional_value_matcher(value_matcher)
+          end
+        end
+
+        private
+
+        def all_positions?(positions)
+          ::Leftovers.each_or_self(positions).include?('*')
+        end
+
+        def build_has_position_matcher(positions)
+          position = 0 if all_positions?(positions)
+          position ||= ::Leftovers.each_or_self(positions).min
+
+          ::Leftovers::Matchers::NodeHasPositionalArgument.new(position)
+        end
+
+        def build_has_any_positional_value_matcher(value_matcher)
+          ::Leftovers::Matchers::NodeHasAnyPositionalArgumentWithValue.new(value_matcher)
+        end
+
+        def build_has_positional_value_matcher(positions, value_matcher)
+          ::Leftovers::MatcherBuilders::Or.each_or_self(positions) do |position|
+            ::Leftovers::Matchers::NodeHasPositionalArgumentWithValue.new(position, value_matcher)
           end
         end
       end

data/lib/leftovers/matcher_builders/node_type.rb

@@ -19,7 +19,7 @@ module Leftovers
           when 'Constant'
             ::Leftovers::Matchers::NodeType.new(Set[:const, :class, :module, :casgn])
           # :nocov:
-          else raise "Unknown type #{type}"
+          else raise Leftovers::UnexpectedCase, "Unhandled value #{type.inspect}"
             # :nocov:
           end
         end

data/lib/leftovers/matcher_builders/node_value.rb

@@ -4,17 +4,15 @@ module Leftovers
   module MatcherBuilders
     module NodeValue
       class << self
-        def build(pattern) # rubocop:disable Metrics/MethodLength
-          ::Leftovers::MatcherBuilders::Or.each_or_self(pattern) do |pat|
-            case pat
+        def build(patterns)
+          ::Leftovers::MatcherBuilders::Or.each_or_self(patterns) do |pattern|
+            case pattern
             when ::Integer, ::Float, true, false, nil
-              ::Leftovers::Matchers::NodeScalarValue.new(pat)
-            when ::String
-              ::Leftovers::MatcherBuilders::NodeName.build(pat)
-            when ::Hash
-              build_from_hash(**pat)
+              ::Leftovers::Matchers::NodeScalarValue.new(pattern)
+            when ::String then ::Leftovers::MatcherBuilders::NodeName.build(pattern)
+            when ::Hash then build_from_hash(**pattern)
             # :nocov:
-            else raise
+            else raise Leftovers::UnexpectedCase, "Unhandled value #{pattern.inspect}"
               # :nocov:
             end
           end
@@ -22,27 +20,34 @@ module Leftovers
 
         private
 
-        def build_from_hash( # rubocop:disable Metrics/MethodLength, Metrics/ParameterLists
+        def build_node_name(match, has_prefix, has_suffix)
+          ::Leftovers::MatcherBuilders::NodeName.build(
+            match: match, has_prefix: has_prefix, has_suffix: has_suffix
+          )
+        end
+
+        def build_unless(unless_arg)
+          return unless unless_arg
+
+          ::Leftovers::MatcherBuilders::Unless.build(
+            ::Leftovers::MatcherBuilders::NodeValue.build(unless_arg)
+          )
+        end
+
+        def build_from_hash( # rubocop:disable Metrics/ParameterLists
           at: nil, has_value: nil,
           match: nil, has_prefix: nil, has_suffix: nil,
           type: nil,
           has_receiver: nil,
           unless_arg: nil
         )
-          matcher = ::Leftovers::MatcherBuilders::And.build([
-            ::Leftovers::MatcherBuilders::NodeHasArgument.build(
-              at: at, has_value: has_value
-            ),
-            ::Leftovers::MatcherBuilders::NodeName.build(
-              match: match, has_prefix: has_prefix, has_suffix: has_suffix
-            ),
+          ::Leftovers::MatcherBuilders::And.build([
+            ::Leftovers::MatcherBuilders::NodeHasArgument.build(at: at, has_value: has_value),
+            build_node_name(match, has_prefix, has_suffix),
             ::Leftovers::MatcherBuilders::NodeType.build(type),
-            ::Leftovers::MatcherBuilders::NodeHasReceiver.build(has_receiver)
+            ::Leftovers::MatcherBuilders::NodeHasReceiver.build(has_receiver),
+            build_unless(unless_arg)
           ])
-
-          ::Leftovers::MatcherBuilders::AndNot.build(
-            matcher, ::Leftovers::MatcherBuilders::NodeValue.build(unless_arg)
-          )
         end
       end
     end

data/lib/leftovers/matcher_builders/or.rb

@@ -5,68 +5,68 @@ require 'set'
 module Leftovers
   module MatcherBuilders
     module Or
-      def self.each_or_self(value, &block)
-        case value
-        when nil then nil
-        when Array then build(value.map(&block))
-        else build([yield(value)])
+      class << self
+        def each_or_self(value, &block)
+          case value
+          when nil then nil
+          when Array then build(value.map(&block))
+          else build([yield(value)])
+          end
         end
-      end
 
-      def self.build(matchers)
-        matchers = compact(matchers)
-        case matchers.length
-          # :nocov:
-        when 0 then nil
-          # :nocov:
-        when 1 then matchers.first
-        when 2 then ::Leftovers::Matchers::Or.new(matchers.first, matchers[1])
-        else ::Leftovers::Matchers::Any.new(matchers.dup)
+        def build(matchers)
+          matchers = compact(matchers)
+          case matchers.length
+            # :nocov:
+          when 0 then nil
+            # :nocov:
+          when 1 then matchers.first
+          when 2 then ::Leftovers::Matchers::Or.new(matchers.first, matchers[1])
+          else ::Leftovers::Matchers::Any.new(matchers.dup)
+          end
         end
-      end
 
-      def self.flatten(value) # rubocop:disable Metrics/MethodLength
-        case value
-        when ::Leftovers::Matchers::Or
-          [*flatten(value.lhs), *flatten(value.rhs)]
-        when ::Leftovers::Matchers::Any
-          flatten(value.matchers)
-        when Array
-          ret = value.map { |v| flatten(v) }
-          ret.flatten!(1)
-          ret
-        else
-          value
+        private
+
+        def flatten(value)
+          case value
+          when ::Leftovers::Matchers::Or
+            [*flatten(value.lhs), *flatten(value.rhs)]
+          when ::Leftovers::Matchers::Any
+            flatten(value.matchers)
+          when Array
+            value.flat_map { |v| flatten(v) }
+          else
+            value
+          end
         end
-      end
 
-      def self.compact(matchers) # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize,
-        return matchers if matchers.length <= 1
+        def group_by_compactable(matchers)
+          groups = matchers.group_by do |matcher|
+            case matcher
+            when ::Integer, ::Symbol then :set
+            when ::Regexp then :regexp
+            else :uncompactable
+            end
+          end
 
-        set = Set.new
-        regexps = []
-        uncompactable = []
+          groups.transform_values { |v| Leftovers.unwrap_array(v) }
+        end
 
-        matchers = flatten(matchers)
+        def build_grouped(set: nil, regexp: nil, uncompactable: nil)
+          set = set.to_set if set.is_a?(Array)
+          regexp = Regexp.union(regexp) if regexp.is_a?(Array)
 
-        matchers.each do |matcher|
-          case matcher
-          when nil then nil
-          when ::Integer, ::Symbol then set << matcher
-          # when ::Set then set.merge(matcher) # may not be necessary
-          when ::Regexp then regexps << matcher
-          else uncompactable << matcher
-          end
+          [set, regexp].concat(Array(uncompactable)).compact
         end
 
-        set = set.first if set.length <= 1
-        regexps = if regexps.length <= 1
-          regexps.first
-        else
-          Regexp.union(regexps)
-        end
+        def compact(matchers)
+          matchers = flatten(matchers)
+
+          return matchers if matchers.length <= 1
 
-        [set, regexps].compact.concat(uncompactable)
+          build_grouped(**group_by_compactable(matchers))
+        end
       end
     end
   end

data/lib/leftovers/matcher_builders/string_pattern.rb

@@ -3,7 +3,7 @@
 module Leftovers
   module MatcherBuilders
     module StringPattern
-      def self.build(match: nil, has_prefix: nil, has_suffix: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+      def self.build(match: nil, has_prefix: nil, has_suffix: nil) # rubocop:disable Metrics
         has_prefix = ::Regexp.escape(has_prefix) if has_prefix
         has_suffix = ::Regexp.escape(has_suffix) if has_suffix
 

data/lib/leftovers/merged_config.rb

@@ -39,11 +39,7 @@ module Leftovers
       @exclude_paths
       @include_paths
       @test_paths
-      @haml_paths
-      @slim_paths
-      @yaml_paths
-      @json_paths
-      @erb_paths
+      @precompilers
       @dynamic
       @keep
       @test_only
@@ -67,24 +63,8 @@ module Leftovers
       @test_paths ||= Leftovers::MatcherBuilders::Path.build(@configs.flat_map(&:test_paths))
     end
 
-    def haml_paths
-      @haml_paths ||= Leftovers::MatcherBuilders::Path.build(@configs.flat_map(&:haml_paths))
-    end
-
-    def slim_paths
-      @slim_paths ||= Leftovers::MatcherBuilders::Path.build(@configs.flat_map(&:slim_paths))
-    end
-
-    def yaml_paths
-      @yaml_paths ||= Leftovers::MatcherBuilders::Path.build(@configs.flat_map(&:yaml_paths))
-    end
-
-    def json_paths
-      @json_paths ||= Leftovers::MatcherBuilders::Path.build(@configs.flat_map(&:json_paths))
-    end
-
-    def erb_paths
-      @erb_paths ||= Leftovers::MatcherBuilders::Path.build(@configs.flat_map(&:erb_paths))
+    def precompilers
+      @precompilers ||= Leftovers::Precompilers.build(@configs.flat_map(&:precompile))
     end
 
     def dynamic

data/lib/leftovers/precompilers/erb.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'erb'
+
+module Leftovers
+  module Precompilers
+    class ERB < ::ERB::Compiler
+      def self.precompile(erb)
+        @compiler ||= new('-')
+        @compiler.compile(erb).first
+      end
+
+      def add_insert_cmd(out, content) # leftovers:keep
+        out.push("\n#{content}\n")
+      end
+
+      def add_put_cmd(out, _content) # leftovers:keep
+        out.push("\n")
+      end
+    end
+  end
+end

data/lib/leftovers/precompilers/haml.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'haml'
+
+module Leftovers
+  module Precompilers
+    module Haml
+      def self.precompile(haml)
+        ::Haml::Engine.new(haml).precompiled
+      rescue ::Haml::SyntaxError => e
+        raise Leftovers::PrecompileError.new(e.message, line: e.line)
+      end
+    end
+  end
+end

data/lib/leftovers/precompilers/json.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'json'
+
+module Leftovers
+  module Precompilers
+    module JSON
+      class << self
+        def precompile(json)
+          "__leftovers_document(#{to_ruby_argument(::JSON.parse(json))})"
+        end
+
+        private
+
+        def to_ruby_argument(value)
+          ruby = value.inspect
+          return ruby unless value.is_a?(Array)
+
+          ruby.delete_prefix!('[')
+          ruby.delete_suffix!(']')
+
+          ruby
+        end
+      end
+    end
+  end
+end

data/lib/leftovers/precompilers/precompiler.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'json'
+
+module Leftovers
+  module Precompilers
+    class Precompiler
+      def initialize(precompiler, matcher)
+        @precompiler = precompiler
+        @matcher = matcher
+      end
+
+      def precompile(content, file)
+        return unless @matcher === file.relative_path
+
+        begin
+          @precompiler.precompile(content)
+        rescue Leftovers::PrecompileError => e
+          e.warn(path: file.relative_path)
+          ''
+        rescue StandardError => e
+          Leftovers.warn "#{e.class}: #{file.relative_path} #{e.message}"
+          ''
+        end
+      end
+    end
+  end
+end

data/lib/leftovers/precompilers/slim.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'slim'
+
+module Leftovers
+  module Precompilers
+    module Slim
+      def self.precompile(file)
+        ::Slim::Engine.new(file: file).call(file)
+      rescue ::Slim::Parser::SyntaxError => e
+        raise Leftovers::PrecompileError.new(e.error, line: e.lineno, column: e.column)
+      end
+    end
+  end
+end

data/lib/leftovers/precompilers/yaml.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require 'yaml'
+
+module Leftovers
+  module Precompilers
+    module YAML
+      class Builder < ::Psych::TreeBuilder
+        def initialize
+          @constants = []
+
+          super
+        end
+
+        def add_constant_for_tag(tag, value = nil)
+          match = %r{\A!ruby/[^:]*(?::(.*))?\z}.match(tag)
+          return unless match
+
+          @constants << (match[1] || value)
+        end
+
+        def start_mapping(_anchor, tag, *rest) # leftovers:keep
+          add_constant_for_tag(tag)
+          tag = nil
+
+          super
+        end
+
+        def start_sequence(_anchor, tag, *rest) # leftovers:keep
+          add_constant_for_tag(tag)
+          tag = nil
+
+          super
+        end
+
+        def scalar(value, _anchor, tag, *rest) # leftovers:keep
+          add_constant_for_tag(tag, value)
+          tag = nil
+
+          super
+        end
+
+        def to_ruby_file
+          <<~FILE
+            __leftovers_document(#{to_ruby_argument(root.to_ruby.first)})
+            #{@constants.join("\n")}
+          FILE
+        end
+
+        private
+
+        def to_ruby_argument(value)
+          ruby = value.inspect
+          return ruby unless value.is_a?(Array)
+
+          ruby.delete_prefix!('[')
+          ruby.delete_suffix!(']')
+
+          ruby
+        end
+      end
+
+      def self.precompile(yaml)
+        builder = ::Leftovers::Precompilers::YAML::Builder.new
+        parser = ::Psych::Parser.new(builder)
+        parser.parse(yaml)
+
+        builder.to_ruby_file
+      rescue ::Psych::SyntaxError => e
+        message = [e.problem, e.context].compact.join(' ')
+        raise ::Leftovers::PrecompileError.new(message, line: e.line, column: e.column)
+      end
+    end
+  end
+end