leftovers 0.5.4 → 0.7.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: leftovers
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.7.0
 platform: ruby
 authors:
 - Dana Sherson
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-02-09 00:00:00.000000000 Z
+date: 2022-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: did_you_mean
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: haml
   requirement: !ruby/object:Gem::Requirement
@@ -112,44 +126,58 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.44.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.44.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -248,20 +276,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.15.1
-- !ruby/object:Gem::Dependency
-  name: json_schemer
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
@@ -306,7 +320,6 @@ files:
 - exe/leftovers
 - leftovers.gemspec
 - lib/.DS_Store
-- lib/config/actioncable.yml
 - lib/config/actionmailer.yml
 - lib/config/actionpack.yml
 - lib/config/actionview.yml
@@ -329,6 +342,7 @@ files:
 - lib/config/pry.yml
 - lib/config/rack.yml
 - lib/config/rails.yml
+- lib/config/railties.yml
 - lib/config/rake.yml
 - lib/config/redcarpet.yml
 - lib/config/rollbar.yml
@@ -343,30 +357,61 @@ files:
 - lib/leftovers/ast.rb
 - lib/leftovers/ast/builder.rb
 - lib/leftovers/ast/node.rb
-- lib/leftovers/backports.rb
 - lib/leftovers/cli.rb
 - lib/leftovers/collector.rb
 - lib/leftovers/config.rb
-- lib/leftovers/config_validator.rb
-- lib/leftovers/config_validator/error_processor.rb
-- lib/leftovers/config_validator/schema_hash.rb
+- lib/leftovers/config_loader.rb
+- lib/leftovers/config_loader/argument_position_schema.rb
+- lib/leftovers/config_loader/argumentless_transform_schema.rb
+- lib/leftovers/config_loader/attribute.rb
+- lib/leftovers/config_loader/document_schema.rb
+- lib/leftovers/config_loader/dynamic_schema.rb
+- lib/leftovers/config_loader/has_argument_schema.rb
+- lib/leftovers/config_loader/has_value_schema.rb
+- lib/leftovers/config_loader/keep_test_only_schema.rb
+- lib/leftovers/config_loader/node.rb
+- lib/leftovers/config_loader/object_schema.rb
+- lib/leftovers/config_loader/privacy_processor_schema.rb
+- lib/leftovers/config_loader/privacy_schema.rb
+- lib/leftovers/config_loader/require_schema.rb
+- lib/leftovers/config_loader/rule_pattern_schema.rb
+- lib/leftovers/config_loader/scalar_argument_schema.rb
+- lib/leftovers/config_loader/scalar_value_schema.rb
+- lib/leftovers/config_loader/schema.rb
+- lib/leftovers/config_loader/string_enum_schema.rb
+- lib/leftovers/config_loader/string_pattern_schema.rb
+- lib/leftovers/config_loader/string_schema.rb
+- lib/leftovers/config_loader/string_value_processor_schema.rb
+- lib/leftovers/config_loader/suggester.rb
+- lib/leftovers/config_loader/transform_schema.rb
+- lib/leftovers/config_loader/true_schema.rb
+- lib/leftovers/config_loader/value_matcher_schema.rb
+- lib/leftovers/config_loader/value_or_array_schema.rb
+- lib/leftovers/config_loader/value_processor_schema.rb
+- lib/leftovers/config_loader/value_type_schema.rb
 - lib/leftovers/definition.rb
 - lib/leftovers/definition_node.rb
+- lib/leftovers/definition_node_set.rb
 - lib/leftovers/definition_set.rb
+- lib/leftovers/definition_to_add.rb
 - lib/leftovers/dynamic_processors.rb
 - lib/leftovers/dynamic_processors/call.rb
 - lib/leftovers/dynamic_processors/call_definition.rb
 - lib/leftovers/dynamic_processors/definition.rb
 - lib/leftovers/dynamic_processors/each.rb
 - lib/leftovers/dynamic_processors/null.rb
+- lib/leftovers/dynamic_processors/set_default_privacy.rb
+- lib/leftovers/dynamic_processors/set_privacy.rb
 - lib/leftovers/erb.rb
 - lib/leftovers/file.rb
 - lib/leftovers/file_collector.rb
 - lib/leftovers/file_list.rb
 - lib/leftovers/haml.rb
+- lib/leftovers/json.rb
 - lib/leftovers/matcher_builders.rb
 - lib/leftovers/matcher_builders/and.rb
 - lib/leftovers/matcher_builders/and_not.rb
+- lib/leftovers/matcher_builders/document.rb
 - lib/leftovers/matcher_builders/name.rb
 - lib/leftovers/matcher_builders/node.rb
 - lib/leftovers/matcher_builders/node_has_argument.rb
@@ -377,6 +422,7 @@ files:
 - lib/leftovers/matcher_builders/node_pair_name.rb
 - lib/leftovers/matcher_builders/node_pair_value.rb
 - lib/leftovers/matcher_builders/node_path.rb
+- lib/leftovers/matcher_builders/node_privacy.rb
 - lib/leftovers/matcher_builders/node_type.rb
 - lib/leftovers/matcher_builders/node_value.rb
 - lib/leftovers/matcher_builders/or.rb
@@ -396,6 +442,7 @@ files:
 - lib/leftovers/matchers/node_name.rb
 - lib/leftovers/matchers/node_pair_value.rb
 - lib/leftovers/matchers/node_path.rb
+- lib/leftovers/matchers/node_privacy.rb
 - lib/leftovers/matchers/node_scalar_value.rb
 - lib/leftovers/matchers/node_type.rb
 - lib/leftovers/matchers/not.rb
@@ -451,8 +498,8 @@ files:
 - lib/leftovers/value_processors/pluralize.rb
 - lib/leftovers/value_processors/positional_argument.rb
 - lib/leftovers/value_processors/replace_value.rb
-- lib/leftovers/value_processors/return_definition.rb
-- lib/leftovers/value_processors/return_string.rb
+- lib/leftovers/value_processors/return_definition_node.rb
+- lib/leftovers/value_processors/return_sym.rb
 - lib/leftovers/value_processors/singularize.rb
 - lib/leftovers/value_processors/split.rb
 - lib/leftovers/value_processors/swapcase.rb
@@ -460,6 +507,7 @@ files:
 - lib/leftovers/value_processors/underscore.rb
 - lib/leftovers/value_processors/upcase.rb
 - lib/leftovers/version.rb
+- lib/leftovers/yaml.rb
 homepage: http://github.com/robotdana/leftovers
 licenses:
 - MIT
@@ -467,6 +515,7 @@ metadata:
   homepage_uri: http://github.com/robotdana/leftovers
   source_code_uri: http://github.com/robotdana/leftovers
   changelog_uri: http://github.com/robotdana/leftovers/blob/main/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -475,7 +524,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/config/actioncable.yml

@@ -1,4 +0,0 @@
-# THIS IS INCOMPLETE (you can help by expanding it)
-# rails is _really complicated_ and has a lot of magic which calls methods for you.
-# some is currently impossible to handle (with_options).
-# Some is just corners of rails I haven't hit yet.

data/lib/leftovers/backports.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-module Leftovers
-  module Backports
-    ruby_version = Gem::Version.new(RUBY_VERSION)
-
-    unless ruby_version >= Gem::Version.new('2.5')
-      require 'set'
-      module SetCaseEq
-        refine ::Set do
-          def ===(value)
-            include?(value)
-          end
-        end
-      end
-
-      module StringDeletePrefixSuffix
-        refine ::String do
-          def delete_prefix!(str)
-            slice!(0..(str.length - 1)) if start_with?(str)
-            self
-          end
-
-          def delete_suffix!(str)
-            slice!(-str.length..-1) if end_with?(str)
-            self
-          end
-
-          def delete_prefix(str)
-            dup.delete_prefix!(str)
-          end
-
-          def delete_suffix(str)
-            dup.delete_suffix!(str)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/leftovers/config_validator/error_processor.rb

@@ -1,196 +0,0 @@
-# frozen-string-literal: true
-
-::Leftovers.try_require 'did_you_mean'
-
-module Leftovers
-  module ConfigValidator
-    module ErrorProcessor # rubocop:disable Metrics/ModuleLength
-      LENGTH_TYPE = %w{minItems minLength minProperties}.freeze
-      TYPE_TYPE = %w{null string boolean integer number array object}.freeze
-      VALUE_TYPE = %w{enum const}.freeze
-      REQUIRED_TYPE = %w{required}.freeze
-
-      class << self
-        def process(errors) # rubocop:disable Metrics/MethodLength, Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity, Metrics/AbcSize
-          error_data_pointers = []
-          errors = group_errors(errors)
-          errors.flat_map do |data_pointer, error_group| # rubocop:disable Metrics/BlockLength
-            next if error_data_pointers.find { |x| x.start_with?(data_pointer) }
-
-            # original_error_group = error_group.dup
-            length_errors = error_group.select { |x| LENGTH_TYPE.include?(x['type']) }
-            value_errors = error_group.select { |x| VALUE_TYPE.include?(x['type']) }
-            type_errors = error_group.select { |x| TYPE_TYPE.include?(x['type']) }
-            required_errors = error_group.select { |x| REQUIRED_TYPE.include?(x['type']) }
-            messages = []
-
-            if !type_errors.empty? && (error_group - type_errors).empty?
-              error_group -= type_errors
-              error_data_pointers << data_pointer
-              any_of = group_by_same_any_of(type_errors)
-              if any_of.length == 1
-                was_class = to_json_type(type_errors.first['data'])
-                error_types = type_errors.map { |x| x['type'] }
-
-                messages << <<~MESSAGE.chomp
-                  #{data_pointer}: must be #{an to_sentence(error_types, 'or')} (was #{an was_class})
-                MESSAGE
-                # :nocov:
-              else
-                nil
-                # :nocov:
-              end
-            elsif !required_errors.empty? && error_group.first['data'].is_a?(Hash)
-              error_data_pointers << data_pointer
-              group_by_same_any_of(required_errors).each do |_any_of_key, any_of_value|
-                required_keywords = any_of_value.flat_map { |x| x['details']['missing_keys'] }
-                error_group -= any_of_value
-                if any_of_value.length > 1
-                  messages << <<~MESSAGE
-                    #{data_pointer}: requires at least one of these keywords: #{to_sentence(required_keywords, 'or')}
-                  MESSAGE
-
-                  # :nocov:
-                else
-                  nil
-                  # :nocov:
-                  # messages << "#{data_pointer}: requires keyword: #{required_keywords.first}"
-                end
-              end
-            elsif !length_errors.empty?
-              error_data_pointers << data_pointer
-              messages << "#{data_pointer}: can't be empty"
-            end
-
-            error_group.each do |error| # rubocop:disable Metrics/BlockLength
-              type = error['type']
-              case type
-              when 'schema'
-                error_data_pointers << data_pointer
-                parent_pointer = parent(data_pointer)
-                if ::File.basename(error['schema_pointer']) == 'additionalProperties'
-                  keyword = tail(data_pointer)
-                  parent_schema_pointer = parent(error['schema_pointer'])
-                  actual_keywords = schema_hash_dig(parent_schema_pointer)['properties'].keys
-                  corrections = did_you_mean(keyword, actual_keywords)
-
-                  messages << <<~MESSAGE.chomp
-                    #{parent_pointer}: invalid property keyword: #{keyword}
-                    Valid keywords: #{to_sentence actual_keywords}
-                    #{"Did you mean? #{to_sentence corrections, 'or'}" unless corrections.empty?}
-                  MESSAGE
-                  # :nocov:
-                else
-                  nil
-                  # :nocov:
-                end
-              when 'enum'
-                next if error['data'].is_a?(Hash)
-
-                error_data_pointers << data_pointer
-                given_value = error['data']
-                valid_values = value_errors.first['schema']['enum']
-                corrections = did_you_mean(given_value, valid_values)
-                messages << <<~MESSAGE
-                  #{data_pointer}: can't be: #{given_value}
-                  Valid values: #{to_sentence valid_values, 'or'}
-                  #{"Did you mean? #{to_sentence corrections, 'or'}" unless corrections.empty?}
-                MESSAGE
-              when 'not'
-                next unless error['data'].is_a?(Hash)
-
-                error_data_pointers << data_pointer
-                if error['schema']['required']
-                  invalid_combinations = error['schema']['required'] & error['data'].keys
-                  messages << <<~MESSAGE
-                    #{data_pointer}: use only one of: #{to_sentence invalid_combinations, 'or'}
-                  MESSAGE
-                  # :nocov:
-                else
-                end
-              else
-              end
-              # :nocov:
-            end
-
-            if messages.empty?
-              error_data_pointers << data_pointer
-              "#{data_pointer} is invalid"
-            else
-              messages
-            end
-          end.compact.map(&:strip)
-        end
-
-        private
-
-        def did_you_mean(word, dictionary)
-          # :nocov:
-          if defined?(::DidYouMean::SpellChecker)
-            ::DidYouMean::SpellChecker.new(dictionary: dictionary).correct(word)
-          else
-            []
-          end
-          # :nocov:
-        end
-
-        def schema_hash_dig(schema_pointer)
-          ::Leftovers::ConfigValidator::SCHEMA_HASH.dig(
-            *schema_pointer.split('/').drop(1).map { |x| x.match?(/\A\d+\z/) ? x.to_i : x }
-          )
-        end
-
-        def parent(pointer)
-          ::File.dirname(pointer)
-        end
-
-        def tail(pointer)
-          ::File.basename(pointer)
-        end
-
-        def to_json_type(value)
-          case value
-          when Hash then 'object'
-          when Float then 'number'
-          when true, false then 'boolean'
-          when nil then 'null'
-          else value.class.name.downcase
-          end
-        end
-
-        def an(str)
-          case str[0]
-          # when nil then ""
-          when 'a', 'e', 'i', 'o', 'u' then "an #{str}"
-          else "a #{str}"
-          end
-        end
-
-        def to_sentence(ary, join_word = 'and')
-          case ary.length
-          when 1 then ary.first
-          when 2 then ary.join(" #{join_word} ")
-          else
-            ary = ary.dup
-            last = ary.pop(2)
-            [*ary, last.join(", #{join_word} ")].join(', ')
-          end
-        end
-
-        def group_errors(errors)
-          errors = errors.map do |x|
-            x.delete('root_schema')
-            x
-          end
-          errors.group_by { |x| x['data_pointer'] }.sort.reverse.to_h
-        end
-
-        def group_by_same_any_of(errors)
-          errors.group_by do |x|
-            x['schema_pointer'].match?(%r{/anyOf/\d+$}) && parent(parent(x['schema_pointer']))
-          end
-        end
-      end
-    end
-  end
-end