leftovers 0.2.2 → 0.4.2

data/exe/leftovers

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require_relative '../lib/leftovers/cli'
+require_relative '../lib/leftovers'
 
-Leftovers::CLI.new(argv: ARGV, stdout: $stdout, stderr: $stderr)
+exit Leftovers::CLI.new(argv: ARGV).run

data/leftovers.gemspec

@@ -16,9 +16,10 @@ Gem::Specification.new do |spec|
 
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'http://github.com/robotdana/leftovers'
-  spec.metadata['changelog_uri'] = 'http://github.com/robotdana/leftovers/blob/master/CHANGELOG.md'
+  spec.metadata['changelog_uri'] = 'http://github.com/robotdana/leftovers/blob/main/CHANGELOG.md'
+  spec.required_ruby_version = '>= 2.4.0'
 
-  spec.files = Dir.glob('{lib,exe}/**/{*,.*}') + %w{
+  spec.files = Dir.glob('{lib,exe,docs}/**/{*,.*}') + %w{
     CHANGELOG.md
     Gemfile
     LICENSE.txt
@@ -30,17 +31,22 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'activesupport'
+  spec.add_development_dependency 'benchmark-ips'
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'haml'
   spec.add_development_dependency 'pry', '~> 0.1'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '>= 13'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.74'
-  spec.add_development_dependency 'rubocop-performance', '~> 1.4'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.35'
+  spec.add_development_dependency 'rubocop', '~> 0.93.1'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.8.1'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.44.1'
+  spec.add_development_dependency 'simplecov', '>= 0.18.5'
+  spec.add_development_dependency 'simplecov-console'
+  spec.add_development_dependency 'tty_string', '>= 0.2.1'
 
   spec.add_development_dependency 'spellr', '>= 0.8.1'
-  spec.add_dependency 'fast_ignore', '>= 0.10.0'
+  spec.add_dependency 'fast_ignore', '>= 0.15.1'
+  spec.add_dependency 'json_schemer'
   spec.add_dependency 'parallel'
   spec.add_dependency 'parser'
 end

data/lib/config/attr_encrypted.yml

@@ -1,10 +1,9 @@
-rules:
+dynamic:
   # this doesn't handle custom prefix, suffix, attribute
   - name: attr_encrypted
-    defines:
-      - argument: 1
+    defines: 0
     calls:
-      - argument: 1
+      - argument: 0
         transforms:
           - add_prefix: encrypted_
           - add_prefix: encrypted_

data/lib/config/audited.yml

@@ -1,4 +1,9 @@
-rules:
-  name: current_user_method=
-  calls:
-    argument: 1
+dynamic:
+  - name: current_user_method=
+    calls: 0
+  - name: audited
+    calls:
+      argument:
+        - associated_with
+        - if
+        - unless

data/lib/config/datagrid.yml

@@ -1,4 +1,4 @@
-rules:
+dynamic:
   - name: filter
     calls:
       arguments:

data/lib/config/flipper.yml

@@ -1,3 +1 @@
-rules:
-  skip: true
-  name: flipper_id
+keep: flipper_id

data/lib/config/graphql.yml

@@ -1,20 +1,22 @@
-rules:
-  - skip: true
-    names:
-      - cursor_from_node
-      - paged_nodes
-      - sliced_nodes
+keep:
+  - cursor_from_node
+  - paged_nodes
+  - sliced_nodes
+dynamic:
   - name: field
     calls:
-      - argument: 1
-        unless:
-          has_argument: method
-      - argument: method
+      argument: method
+  - name: field
+    unless:
+      has_argument: method
+    calls: 0
   - name: argument
+    unless:
+      has_argument: as
     calls:
-      - argument: 1
+      - argument: 0
         add_suffix: '='
-        unless:
-          has_argument: as
+  - name: argument
+    calls:
       - argument: as
         add_suffix: '='

data/lib/config/okcomputer.yml

@@ -1,3 +1 @@
-rules:
-  skip: true
-  name: check
+keep: check

data/lib/config/parser.yml

@@ -1,91 +1,89 @@
-rules:
-  skip: true
-  names: |
-    on_alias
-    on_and
-    on_and_asgn
-    on_arg
-    on_arg_expr
-    on_args
-    on_argument
-    on_array
-    on_back_ref
-    on_begin
-    on_block
-    on_block_pass
-    on_blockarg
-    on_blockarg_expr
-    on_break
-    on_case
-    on_casgn
-    on_class
-    on_const
-    on_csend
-    on_cvar
-    on_cvasgn
-    on_def
-    on_defined?
-    on_defs
-    on_dstr
-    on_dsym
-    on_eflipflop
-    on_ensure
-    on_erange
-    on_for
-    on_gvar
-    on_gvasgn
-    on_hash
-    on_if
-    on_iflipflop
-    on_irange
-    on_ivar
-    on_ivasgn
-    on_kwarg
-    on_kwbegin
-    on_kwoptarg
-    on_kwrestarg
-    on_lvar
-    on_lvasgn
-    on_masgn
-    on_match_current_line
-    on_match_with_lvasgn
-    on_mlhs
-    on_module
-    on_next
-    on_not
-    on_nth_ref
-    on_op_asgn
-    on_optarg
-    on_or
-    on_or_asgn
-    on_pair
-    on_postexe
-    on_preexe
-    on_procarg0
-    on_redo
-    on_regexp
-    on_resbody
-    on_rescue
-    on_restarg
-    on_restarg_expr
-    on_retry
-    on_return
-    on_sclass
-    on_send
-    on_shadowarg
-    on_splat
-    on_super
-    on_undef
-    on_until
-    on_until_post
-    on_var
-    on_vasgn
-    on_when
-    on_while
-    on_while_post
-    on_xstr
-    on_yield
-    process_argument_node
-    process_regular_node
-    process_var_asgn_node
-    process_variable_node
+keep:
+ - on_alias
+ - on_and
+ - on_and_asgn
+ - on_arg
+ - on_arg_expr
+ - on_args
+ - on_argument
+ - on_array
+ - on_back_ref
+ - on_begin
+ - on_block
+ - on_block_pass
+ - on_blockarg
+ - on_blockarg_expr
+ - on_break
+ - on_case
+ - on_casgn
+ - on_class
+ - on_const
+ - on_csend
+ - on_cvar
+ - on_cvasgn
+ - on_def
+ - on_defined?
+ - on_defs
+ - on_dstr
+ - on_dsym
+ - on_eflipflop
+ - on_ensure
+ - on_erange
+ - on_for
+ - on_gvar
+ - on_gvasgn
+ - on_hash
+ - on_if
+ - on_iflipflop
+ - on_irange
+ - on_ivar
+ - on_ivasgn
+ - on_kwarg
+ - on_kwbegin
+ - on_kwoptarg
+ - on_kwrestarg
+ - on_lvar
+ - on_lvasgn
+ - on_masgn
+ - on_match_current_line
+ - on_match_with_lvasgn
+ - on_mlhs
+ - on_module
+ - on_next
+ - on_not
+ - on_nth_ref
+ - on_op_asgn
+ - on_optarg
+ - on_or
+ - on_or_asgn
+ - on_pair
+ - on_postexe
+ - on_preexe
+ - on_procarg0
+ - on_redo
+ - on_regexp
+ - on_resbody
+ - on_rescue
+ - on_restarg
+ - on_restarg_expr
+ - on_retry
+ - on_return
+ - on_sclass
+ - on_send
+ - on_shadowarg
+ - on_splat
+ - on_super
+ - on_undef
+ - on_until
+ - on_until_post
+ - on_var
+ - on_vasgn
+ - on_when
+ - on_while
+ - on_while_post
+ - on_xstr
+ - on_yield
+ - process_argument_node
+ - process_regular_node
+ - process_var_asgn_node
+ - process_variable_node

data/lib/config/rails.yml

@@ -4,30 +4,30 @@ exclude_paths:
 include_paths:
   - '*.rjs'
   - '*.rhtml'
+requires:
+  - 'active_support/core_ext/string'
+  - 'active_support/inflections'
+  - './config/initializers/inflections'
 
 # THIS IS INCOMPLETE (you can help by expanding it)
 # rails is _really complicated_ and has a lot of magic which calls methods for you.
 # some is currently impossible to handle (with_options).
 # Some is just corners of rails I haven't hit yet.
-# TODO: split this up by the actual gems
-rules:
-  - skip: true
-    names:
-      - ClassMethods # ActiveSupport::Concern
-      - process_action # ActiveSupport::LogSubscriber
-      - validate_each # ActiveModel::EachValidator
-      - format_message # ActiveSupport::Logger
-      - ssl_configured? # ApplicationController
-      - APP_PATH
-      - APP_ROOT
-  - skip: true
-    names:
-      has_suffix: Helper
+keep:
+  - ClassMethods # ActiveSupport::Concern
+  - process_action # ActiveSupport::LogSubscriber
+  - validate_each # ActiveModel::EachValidator
+  - format_message # ActiveSupport::Logger
+  - ssl_configured? # ApplicationController
+  - default_url_options # called by url_for
+  - APP_PATH
+  - APP_ROOT
+  - has_suffix: Helper
     path: /app/helpers
-  - skip: true
-    names:
-      has_suffix: Preview
+  - has_suffix: Preview
     path: '**/mailers/previews/**/*_preview.rb'
+
+dynamic:
   - names:
       - after_initialize
       - after_find
@@ -53,10 +53,10 @@ rules:
       - after_destroy_commit
       - after_save_commit
     calls:
-      arguments:
-        - 1
-        - if
-        - unless
+      - arguments: 0
+      - arguments: [if, unless]
+        nested:
+          arguments: '*'
   - name:
       - after_action
       - append_after_action
@@ -72,22 +72,24 @@ rules:
       - skip_around_action
       - validates_associated
     calls:
-      - arguments:
-          - '*'
-          - if
-          - unless
+      - arguments: ['*', if, unless]
   - name: validates
     calls:
       - arguments:
           - '*'
-          - 'in'
+          - within
           - inclusion
           - scope
           - if
           - unless
-      - keys: '*'
+      - arguments: inclusion
+        nested:
+          arguments: 'in'
+      - keywords:
+          unless: [if, unless]
         camelize: true
         add_suffix: Validator
+        split: '::'
   - names:
       - validate
       - validate_associated
@@ -122,8 +124,8 @@ rules:
     - url_field
     - week_field
     calls:
-      - arguments: [1,2] # 1: with a receiver, 2: with no receiver
-      - arguments: [1,2]
+      - arguments: [0,1] # 0: with a receiver, 1: with no receiver
+      - arguments: [0,1]
         add_suffix: '='
   - name: fields_for
     calls:
@@ -131,97 +133,146 @@ rules:
       add_suffix: _attributes
   - name: options_from_collection_for_select
     calls:
-      - arguments: [2,3]
+      - arguments: [1,2]
   - name:
       - collection_select
       - collection_check_boxes
       - collection_radio_buttons
     calls:
-      - argument: 2
+      - argument: 1
         add_suffix: '='
-      - arguments: [4,5]
+      - arguments: [3,4]
   - name: grouped_collection_select
     calls:
-      - argument: 2
+      - argument: 1
         add_suffix: '='
-      - arguments: [4,5,6,7]
+      - arguments: [3,4,5,6]
   - name: option_groups_from_collection_for_select
     calls:
-      - arguments: [1,2,3,4]
+      - arguments: [0,1,2,3]
   - name: scope
     path: /app/models
     defines:
-      argument: 1 # ar
+      argument: 0 # ar
   - name: scope
     path: /config/routes*
     calls:
       argument: module # routes
       camelize: true
+      split: '::'
   - name: namespace
     calls:
-      - argument: 1
+      - argument: 0
         camelize: true
+        split: '::'
   - name:
       - attribute
       - alias_attribute
     path: app/models/*
     defines:
-      argument: 1
-      linked_transforms:
+      argument: 0
+      transforms:
         - original
         - add_suffix: '?'
         - add_suffix: '='
   - name: alias_attribute
     calls:
-      - argument: 2
-      - argument: 2
+      - argument: 1
+      - argument: 1
         add_suffix: '?'
-      - argument: 2
+      - argument: 1
         add_suffix: '='
   - name:
     - has_one
     - belongs_to
+    unless:
+      has_argument: class_name
     calls:
-      argument: 1
+      argument: 0
       camelize: true
-      unless:
-        has_argument: class_name
+      split: '::'
+
   - name:
     - has_many
     - has_and_belongs_to_many
+    unless:
+      has_argument: class_name
     calls:
-      argument: 1
-      camelize: true
-      singularize: true
-      unless:
-        has_argument: class_name
+      - argument: 0
+        camelize: true
+        singularize: true
+        split: '::'
+  - name:
+    - has_many
+    - has_and_belongs_to_many
+    defines:
+      - argument: 0
+        transforms:
+          - original
+          - add_suffix: '='
+          - singularize: true
+            add_suffix: _ids
+          - singularize: true
+            add_suffix: _ids=
   - name:
     - has_many
     - has_one
     - has_and_belongs_to_many
     calls:
-      argument: as
+      argument:
+        - as
+  - name:
+    - has_one
+    - has_many
+    calls:
+      - argument:
+          - source_type
+          - source
+          - through
   - name:
       - has_one
-      - has_many
       - belongs_to
-      - has_and_belongs_to_many
     defines:
-      - argument: 1
-        linked_transforms:
+      - argument: 0
+        transforms:
           - original
           - add_suffix: '='
+          - add_prefix: build_
+          - add_prefix: create_
+          - add_prefix: create_
+            add_suffix: '!'
+          - add_prefix: reload
+  - name: belongs_to
+    unless:
+      has_argument:
+        at: optional
+        has_value: true
+    calls:
+      argument: 0
+
+  - name:
+     - has_one
+     - has_many
+     - belongs_to
+     - has_and_belongs_to_many
+    calls:
+      - argument: class_name
+        split: '::'
+      - argument: inverse_of
+      - argument: touch
+        add_suffix: '='
+  - name:
+     - has_one
+     - has_many
+     - belongs_to
+     - has_and_belongs_to_many
+    has_argument:
+      at: [dependent, inverse_of, touch, validate]
+      unless:
+        has_value: false
     calls:
-      - argument:
-          - through
-          - class_name
-          - inverse_of
-      - argument: 1
-        if:
-          has_argument: dependent
-      - argument: 1
-        if:
-          has_argument: inverse_of
+      argument: 0
+
   - name:
       - rescue_from
     calls:
@@ -235,37 +286,47 @@ rules:
       - put
       - root
     calls:
-      - arguments: [1, action]
+      - arguments: [0, action]
       - argument: '**'
         delete_before: '#'
       - argument: '**'
         delete_after: '#'
         camelize: true
         add_suffix: Controller
+        split: '::'
   - name: delegate
+    has_argument:
+      at: prefix
+      has_value: true
     defines:
       - argument: '*'
-        if:
-          has_argument:
-            keyword: prefix
-            value: true
         add_prefix:
-          from_argument: to
-          joiner: '_'
+          argument: to
+          add_suffix: '_'
+    calls:
+      - argument: to
+      - argument: '*'
+  - name: delegate
+    has_argument:
+      at: prefix
+      has_value_type: [String, Symbol]
+    defines:
       - argument: '*'
-        if:
-          has_argument:
-            keyword: prefix
-            value:
-              type: [String, Symbol]
         add_prefix:
-          from_argument: prefix
-          joiner: '_'
+          argument: prefix
+          add_suffix: '_'
     calls:
       - argument: to
       - argument: '*'
-        if:
-          has_argument: prefix
+  - name: delegate
+    unless:
+      has_argument:
+        - at: prefix
+          has_value: true
+        - at: prefix
+          has_value_type: [String, Symbol]
+    calls:
+      - argument: to
   - name:
       - resource
       - resources
@@ -274,28 +335,31 @@ rules:
       - argument: controller
         camelize: true
         add_suffix: Controller
+        split: '::'
   - name:
       - resources
       - controller
       - namespace
     calls:
-      - argument: 1
+      - argument: 0
         camelize: true
         add_suffix: Controller
+        split: '::'
   - name: accepts_nested_attributes_for
     defines:
       argument: '*'
-      linked_transforms:
+      transforms:
         - add_suffix: _attributes
         - add_suffix: _attributes=
     calls:
       argument: reject_if
   - name: resource
     calls:
-      - argument: 1
+      - argument: 0
         camelize: true
         pluralize: true
         add_suffix: Controller
+        split: '::'
   - name:
     - new
     - create
@@ -304,16 +368,17 @@ rules:
     - update!
     - assign_attributes
     calls:
-      keys: '*'
+      keyword: '**'
       add_suffix: '='
   - name: permit
     calls:
       arguments: ['*', '**']
-      keys: '*'
+      keywords: '**'
       add_suffix: "="
+      recursive: true
   - name: layout
     calls:
-      argument: 1
+      argument: 0
   - name:
       - includes
       - preload
@@ -323,7 +388,7 @@ rules:
       - left_outer_joins
     calls:
       arguments: ['*', '**']
-      keys: '*'
+      keywords: '**'
   - name:
       - string
       - text
@@ -339,7 +404,7 @@ rules:
       - boolean
     path: /db/schema.rb
     calls:
-      argument: 1
+      argument: 0
       transforms:
         - original
         - add_suffix: '='
@@ -349,9 +414,8 @@ rules:
       - mattr_accessor
     defines:
       - argument: '*'
-        transforms:
-          - original
-          - add_suffix: '='
+      - argument: '*'
+        add_suffix: '='
     calls:
       - argument: '*'
         add_prefix: '@'
@@ -374,10 +438,9 @@ rules:
     - thread_cattr_accessor
     - thread_mattr_accessor
     defines:
-      argument: '*'
-      transforms:
-        - original
-        - add_suffix: '='
+      - argument: '*'
+      - argument: '*'
+        add_suffix: '='
   - name:
     - thread_cattr_reader
     - thread_mattr_reader
@@ -391,4 +454,4 @@ rules:
       add_suffix: '='
   - name: delegate_missing_to
     calls:
-      argument: 1
+      argument: 0