leftovers 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e6117fe1e8a7c5be09e50512f8bc17287f5dd99352d58645d53846130eeb4e9
-  data.tar.gz: a7907abb8c07b4f5026f78203bd1b216df655ad2853f199da381a53366edabb4
+  metadata.gz: 52698685d049f76cfbe3034d85b9de65aec3c06b44434119a6581b399778a648
+  data.tar.gz: daa5a40d80c7a180eb81a4dd59bc841788da04db541cfc93f2ae02577b1fd251
 SHA512:
-  metadata.gz: 8c9ddf1a721a8bbe56fafde72e65aad91450a64cbfb63667584f87ca7d63d580372724cfc7677f978f6e981bd269addbe4b1395e95c40a6dd6dd8752d1627927
-  data.tar.gz: 290a53782aa235c4fad3ce22257146e42b7268882fa34b3ffdf809b1023308e5266a621004a8e1d14e3217b6a9a60c4574cfd204669bd385a11f2a69e575fdf7
+  metadata.gz: 98ab99b3d471cdf3d42cf2c2e4940fc985313d68ce6a1ffe7b2f2909b0bcd95c1019a5fccdb306177a8283c0837baf068942a9f390fc38ccdeed9f5ecf8019f7
+  data.tar.gz: 1dcea67041a8afec49b80ff6b168d18fa28fcba7c6bbd546d0f004f76152f12116d9538cc0920e32721228a8a41233ad8788678d77fd55279f79b000e744ac55

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v0.2.3
+- restore ability to handle syntax errors. I really need to add coverage to this project
+- Fix bug with delete_after on an empty string
+- Support more of rails
+- Support parts of sidekiq
+
 # v0.2.2
 - update fast_ignore dependency
 

data/exe/leftovers

@@ -3,4 +3,4 @@
 
 require_relative '../lib/leftovers/cli'
 
-Leftovers::CLI.new(argv: ARGV, stdout: $stdout, stderr: $stderr)
+Leftovers::CLI.new(argv: ARGV)

data/leftovers.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'haml'
   spec.add_development_dependency 'pry', '~> 0.1'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '>= 13'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.74'
   spec.add_development_dependency 'rubocop-performance', '~> 1.4'

data/lib/config/rails.yml

@@ -20,6 +20,7 @@ rules:
       - ssl_configured? # ApplicationController
       - APP_PATH
       - APP_ROOT
+      - default_url_options # called by url_for
   - skip: true
     names:
       has_suffix: Helper
@@ -190,38 +191,81 @@ rules:
     - has_many
     - has_and_belongs_to_many
     calls:
-      argument: 1
-      camelize: true
-      singularize: true
-      unless:
-        has_argument: class_name
+      - argument: 1
+        camelize: true
+        singularize: true
+        unless:
+          has_argument: class_name
+    defines:
+      - argument: 1
+        linked_transforms:
+          - original
+          - add_suffix: '='
+          - singularize: true
+            add_suffix: _ids
+          - singularize: true
+            add_suffix: _ids=
   - name:
     - has_many
     - has_one
     - has_and_belongs_to_many
     calls:
-      argument: as
+      argument:
+        - as
+  - name:
+    - has_one
+    - has_many
+    calls:
+      - argument:
+          - source_type
+          - source
+          - through
   - name:
       - has_one
-      - has_many
       - belongs_to
-      - has_and_belongs_to_many
     defines:
       - argument: 1
         linked_transforms:
           - original
           - add_suffix: '='
+          - add_prefix: build_
+          - add_prefix: create_
+          - add_prefix: create_
+            add_suffix: '!'
+          - add_prefix: reload
+  - name: belongs_to
+    calls:
+      argument: 1
+      unless:
+        has_argument:
+          keyword: optional
+          value: true
+
+  - name:
+     - has_one
+     - has_many
+     - belongs_to
+     - has_and_belongs_to_many
     calls:
       - argument:
-          - through
           - class_name
           - inverse_of
+      - argument: touch
+        add_suffix: '='
       - argument: 1
         if:
           has_argument: dependent
       - argument: 1
         if:
           has_argument: inverse_of
+      - argument: 1
+        if:
+          has_argument: touch
+      - argument: 1
+        if:
+          has_argument:
+            keyword: validate
+            value: true
   - name:
       - rescue_from
     calls:

data/lib/config/sidekiq.yml

@@ -0,0 +1,13 @@
+rules:
+  - skip: true
+    names:
+      - on_complete
+  - names:
+      - perform_async
+    calls:
+      itself: true
+      delete_suffix: _async
+  - name: register
+    calls:
+      argument: 2
+

data/lib/leftovers.rb

@@ -21,11 +21,11 @@ module Leftovers # rubocop:disable Metrics/ModuleLength
   end
 
   def stdout
-    @stdout ||= StringIO.new
+    @stdout ||= $stdout
   end
 
   def stderr
-    @stderr ||= StringIO.new
+    @stderr ||= $stderr
   end
 
   def config

data/lib/leftovers/cli.rb

@@ -8,7 +8,7 @@ module Leftovers
   class CLI
     attr_reader :argv, :stdout, :stderr
 
-    def initialize(argv: [], stdout: StringIO.new, stderr: StringIO.new)
+    def initialize(argv: [], stdout: $stdout, stderr: $stderr)
       @argv = argv
       @stdout = stdout
       @stderr = stderr

data/lib/leftovers/file_collector.rb

@@ -35,8 +35,8 @@ module Leftovers
       ast, comments = Leftovers::Parser.parse_with_comments(@ruby, @file)
       process_comments(comments)
       process(ast)
-    rescue Parser::SyntaxError => e
-      Leftovers.warn "#{e.class}: #{e.message} #{filename}:#{e.diagnostic.location.line}:#{e.diagnostic.location.column}" # rubocop:disable Layout/LineLength
+    rescue ::Parser::SyntaxError => e
+      Leftovers.warn "\e[31m#{filename}:#{e.diagnostic.location.line}:#{e.diagnostic.location.column} SyntaxError: #{e.message}\e[0m" # rubocop:disable Layout/LineLength
     end
 
     METHOD_NAME_RE = /[[:alpha:]_][[:alnum:]_]*\b[\?!=]?/.freeze
@@ -212,6 +212,8 @@ module Leftovers
         node.test = test?(node.loc)
         definitions.concat(rule.definitions(node))
       end
+    rescue StandardError => e
+      raise e.class, "#{e.message}\nwhen processing #{node} at #{filename}:#{node.loc.line}:#{node.loc.column}", e.backtrace # rubocop:disable Layout/LineLength
     end
   end
 end

data/lib/leftovers/parser.rb

@@ -29,7 +29,7 @@ module Leftovers
         p.diagnostics.ignore_warnings = true
 
         p.diagnostics.consumer = lambda do |diagnostic|
-          warn(diagnostic.render)
+          diagnostic
         end
 
         p

data/lib/leftovers/rake_task.rb

@@ -49,7 +49,7 @@ module Leftovers
     end
 
     def run(argv)
-      Leftovers::CLI.new(argv: argv, stdout: $stdout, stderr: $stderr)
+      Leftovers::CLI.new(argv: argv)
     rescue SystemExit => e
       raise unless e.status == 0
     end

data/lib/leftovers/transform_rule.rb

@@ -127,7 +127,7 @@ module Leftovers
     end
 
     def delete_after(string, _method_node)
-      string.split(@delete_after, 2).first
+      string.split(@delete_after, 2).first || string
     end
 
     def replace_with(_string, _method_node)

data/lib/leftovers/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leftovers
-  VERSION = '0.2.2'
+  VERSION = '0.2.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: leftovers
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Dana Sherson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-21 00:00:00.000000000 Z
+date: 2020-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -70,16 +70,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -227,6 +227,7 @@ files:
 - lib/config/rspec.yml
 - lib/config/ruby.yml
 - lib/config/selenium.yml
+- lib/config/sidekiq.yml
 - lib/config/simplecov.yml
 - lib/config/will_paginate.yml
 - lib/leftovers.rb