leftovers 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2cb691dc74d8b0d43765f899ea718a4d06c1ba8fa36ea3a68c44ece27531920
-  data.tar.gz: e24ade3f01a888de2e9438736d71b0e4f2d159a6783b3278e8ec7e58e7c8c626
+  metadata.gz: 16d46e25de2c0e4f243f396b910e3eb61e6342dd626fcceb9f30bd3734196d7b
+  data.tar.gz: e8c6c55c70e25167126fa2fa5ac3037f41a37b9ae8415f10b86cfea183436be1
 SHA512:
-  metadata.gz: a734ec1916762c5bc51fc212bfc254eb3d4083c968e6bcd128aa0c10ee9085762c6edbd86eb8afd3dd17ac5fa8b883d343bf34df3a3caaea1b84db5bc720bfaa
-  data.tar.gz: 7b80b90518a6a3e45aa3739394c18f4c7884ea07d75021dc919c62d23d6d110714c9969ab78b8078d6c219bfd9289a821bb4b828bc4e248a82a63f235cb7758f
+  metadata.gz: 609975369757068764cc179848f973aa6579dcf422a36ad54a7e7697cb257b1ec1043c3da8b106741869d1a0f113e4aa95bf824c7dca1c9766b05db90cddb7a8
+  data.tar.gz: c74f1643e44ad2f87490f8f2745c35286f746881bcac839c43bc0400863c0733a5246c5cf4d4b5be88d1501512aa6fb35debc637404262ee0902766e28a87b86

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# v0.11.0
+- Fixed an issue with active_record's `before_save` with multiple callbacks #18, #17 - thanks @palexvs for raising the issue and creating a pr
+- Due to this pr, i reviewed everything else that i think calls `ActiveSupport::Callbacks.set_callback`, and ensured they all:
+  - can have multiple args if relevant
+  - accept single values and array values for the if/unless args
+  - don't eval strings, that's not been a rails feature for a while
+- Fix active_model & active_record validation methods to more comprehensively handle all the keys that could be given symbols of method names, instead of only the documented ones
+
 # v0.10.0
 - Fixed an issue with t.belongs_to (within the migration generated by rails active_storage:install - thanks @veganstraightedge)
   - this was two issues:

data/lib/config/actionmailbox.yml

@@ -15,7 +15,10 @@ keep:
 dynamic:
   # https://api.rubyonrails.org/v7.0.2.2/classes/ActionMailbox/Base.html
   - names: [before_processing, after_processing, around_processing]
-    calls: ['*', if, unless]
+    calls:
+      - arguments: '*'
+      - arguments: [if, unless]
+        nested: '*'
 
   # https://guides.rubyonrails.org/action_mailbox_basics.html#examples
   # i'm guessing a lot about how this is supposed to work

data/lib/config/actionmailer.yml

@@ -26,7 +26,10 @@ dynamic:
       - before_action
       - after_action
       - around_action
-    calls: ['*', if, unless]
+    calls:
+      - arguments: '*'
+      - arguments: [if, unless]
+        nested: '*'
 
   # https://guides.rubyonrails.org/action_mailer_basics.html#intercepting-emails
   - names: interceptors=

data/lib/config/actionpack.yml

@@ -37,21 +37,29 @@ dynamic:
       - prepend_around_action
       - prepend_before_action
     calls:
-      - arguments: ['*', if, unless]
+      - arguments: '*'
+      - arguments: [if, unless]
+        nested: '*'
 
   - names:
     - skip_after_action
     - skip_around_action
     - skip_before_action
-    calls: [if, unless]
+    calls:
+      arguments: [if, unless]
+      nested: '*'
 
   - names: protect_from_forgery
-    calls: [if, unless]
+    calls:
+      arguments: [if, unless]
+      nested: '*'
 
 
   # https://edgeapi.rubyonrails.org/classes/ActionController/Logging/ClassMethods.html#method-i-log_at
   - names: log_at
-    calls: [if, unless]
+    calls:
+      arguments: [if, unless]
+      nested: '*'
 
 
   - name: helper

data/lib/config/activejob.yml

@@ -23,10 +23,9 @@ dynamic:
       - around_perform
       - after_perform
     calls:
-      - arguments: 0
+      - arguments: '*'
       - arguments: [if, unless]
-        nested:
-          arguments: '*'
+        nested: '*'
 
   # https://api.rubyonrails.org/v7.0.2.2/classes/ActiveJob/Exceptions/ClassMethods.html#method-i-discard_on
   # https://api.rubyonrails.org/v7.0.2.2/classes/ActiveJob/Exceptions/ClassMethods.html#method-i-retry_on

data/lib/config/activemodel.yml

@@ -82,25 +82,26 @@ dynamic:
       - before_validation
       - after_validation
     calls:
-      - arguments: 0
+      - arguments: '*'
       - arguments: [if, unless]
-        nested:
-          arguments: '*'
+        nested: '*'
   - name:
       - validates_associated
     calls:
-      - arguments: ['*', if, unless]
+      - arguments: '*'
+      - arguments: [if, unless]
+        nested: '*'
+
   # https://api.rubyonrails.org/classes/ActiveModel/Validations/ClassMethods.html#method-i-validates
   - name: [validates, validates!]
     calls:
       - arguments:
           - '*'
+          - 'in'
           - within
-          - inclusion
-          - exclusion
           - scope
-          - if
-          - unless
+          - with
+          - without
       - arguments: [if, unless]
         nested: '*'
       - arguments: [inclusion, exclusion]
@@ -108,6 +109,17 @@ dynamic:
           arguments:
             - 'in'
             - within
+      - arguments: format
+        nested:
+          arguments:
+            - with
+            - without
+      - arguments: length
+        nested:
+          arguments:
+            - is
+            - minimum
+            - maximum
       - arguments: [comparison, numericality]
         nested:
           arguments:
@@ -118,14 +130,10 @@ dynamic:
             - less_than_or_equal_to
             - other_than
       - keywords:
-          unless: [if, unless]
+          unless: [if, unless, 'on', allow_blank, allow_nil, strict]
         camelize: true
         add_suffix: Validator
         split: '::'
-    eval:
-      - arguments: [if, unless]
-      - arguments: [if, unless]
-        nested: '*'
 
   - name: validates_confirmation_of
     calls:
@@ -139,10 +147,9 @@ dynamic:
       argument: '*'
       add_suffix: _confirmation
 
-  - name: validates_comparison_of
+  - name: [validates_comparison_of, validates_numericality_of]
     calls:
       argument:
-        - '*'
         - greater_than
         - greater_than_or_equal_to
         - equal_to
@@ -150,13 +157,24 @@ dynamic:
         - less_than_or_equal_to
         - other_than
 
+  # why!?
+  - name: validates_numericality_of
+    calls:
+      argument:
+        - only_integer
+
   - name: [validates_exclusion_of, validates_inclusion_of]
     calls:
       argument:
-        - '*'
         - 'in'
         - within
 
+  - name: validates_length_of
+    calls: [is, minimum, maximum]
+
+  - name: validates_format_of
+    calls: [with, without]
+
   - name:
       - validates_absence_of
       - validates_acceptance_of
@@ -170,9 +188,7 @@ dynamic:
       - validates_presence_of
       - validates_size_of
     calls:
-      - arguments: ['*', if, unless]
-    eval:
-      - arguments: [if, unless]
+      - arguments: '*'
       - arguments: [if, unless]
         nested: '*'
 
@@ -183,9 +199,7 @@ dynamic:
       - validate_associated
       - validates_each
     calls:
-      - arguments: ['*', if, unless]
-    eval:
-      - arguments: [if, unless]
+      - arguments: '*'
       - arguments: [if, unless]
         nested: '*'
 
@@ -193,10 +207,7 @@ dynamic:
   - name: validates_with
     calls:
       arguments: [if, unless]
-    eval:
-      - arguments: [if, unless]
-      - arguments: [if, unless]
-        nested: '*'
+      nested: '*'
 
   # https://api.rubyonrails.org/classes/ActiveModel/AttributeMethods/ClassMethods.html#method-i-alias_attribute
   # https://api.rubyonrails.org/classes/ActiveModel/Dirty.html

data/lib/config/activerecord.yml

@@ -22,7 +22,23 @@ dynamic:
       - validates_numericality_of
       - validates_presence_of
       - validates_uniqueness_of
-    calls: ['*', if, unless]
+    calls:
+      - arguments: '*'
+      - arguments: [if, unless]
+        nested: '*'
+
+  - name: validates_uniqueness_of
+    calls:
+      arguments: scope
+      nested: '*'
+
+  - name: [validates, validates!]
+    calls:
+      - arguments: scope
+      - arguments: uniqueness
+        nested:
+          arguments: scope
+          nested: '*'
 
   # https://edgeapi.rubyonrails.org/classes/ActiveRecord/Aggregations/ClassMethods.html
   # i had to read the code for this
@@ -367,10 +383,9 @@ dynamic:
       - before_save
       - before_update
     calls:
-      - arguments: 0
+      - arguments: '*'
       - arguments: [if, unless]
-        nested:
-          arguments: '*'
+        nested: '*'
 
   - name:
       - includes

data/lib/config/activesupport.yml

@@ -146,8 +146,12 @@ dynamic:
 
   # https://api.rubyonrails.org/classes/ActiveSupport/Callbacks/ClassMethods.html#method-i-set_callback
   - name: set_callback
-    calls: [2, if, unless]
+    calls:
+      - arguments: '2+'
+      - arguments: [if, unless]
+        nested: '*'
 
+  # The second argument indicates whether the callback is to be run :before, :after, or :around the event. If omitted, :before is assumed.
   - name: set_callback
     calls: 1
     unless:
@@ -156,7 +160,9 @@ dynamic:
 
   # https://api.rubyonrails.org/classes/ActiveSupport/Callbacks/ClassMethods.html#method-i-skip_callback
   - name: skip_callback
-    calls: [if, unless]
+    calls:
+      arguments: [if, unless]
+      nested: '*'
 
   # https://api.rubyonrails.org/classes/ActiveSupport/Configurable/ClassMethods.html#method-i-config_accessor
   - name: config_accessor
@@ -203,7 +209,11 @@ dynamic:
   # https://api.rubyonrails.org/classes/ActiveSupport/Reloader.html#method-c-to_prepare
   # this is not well documented but uses set_callback internally so we can just guess
   - name: [before_class_unload, after_class_unload, to_prepare]
-    calls: [0, if, unless]
+    calls:
+      - arguments: '*'
+      - arguments: [if, unless]
+        nested:
+          arguments: '*'
 
   # https://api.rubyonrails.org/classes/Module/Concerning.html#method-i-concern
   - name: concern

data/lib/leftovers/reporter.rb

@@ -35,8 +35,8 @@ module Leftovers
     end
 
     def print_definition(definition)
-      puts "#{aqua definition.location_s} "\
-        "#{definition} "\
+      puts "#{aqua definition.location_s} " \
+        "#{definition} " \
         "#{grey definition.highlighted_source("\e[33m", "\e[0;2m")}"
     end
 

data/lib/leftovers/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leftovers
-  VERSION = '0.10.0'
+  VERSION = '0.11.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: leftovers
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Dana Sherson
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-05-02 00:00:00.000000000 Z
+date: 2022-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -588,8 +588,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.7.6
+rubygems_version: 3.2.15
 signing_key:
 specification_version: 4
 summary: Find unused methods and classes/modules