ledgerjournal 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b5770e988a14b6a2a45ada7b393d3a7ef857a822e17a5c4da2caebb50393257
-  data.tar.gz: 5fa7b153ddbddc3a175566086b6ebb8277f75428ad34ea065e13a524ec53b2a8
+  metadata.gz: 0bb59ca2d7f64a129c519354a4d9cdfb5d3eb4b7f97cb58d2232a4558315cfb2
+  data.tar.gz: 2ee806a9ab9755e980581d1b96910d8f692c7ff03cdd9700fbd0d673f6e592e4
 SHA512:
-  metadata.gz: d3ce3d96d0e7b9cf22378d8b802b24077be2bcc56f5bffe0005c1b134d1d0621def7f74874ae1f260d5467ce02d7aa06092df30753414b4e59af225f5327fa37
-  data.tar.gz: c70b31078daf4176609859c4751d45d0c153dcee4cea59c22774a317aecd74163024b8b56d5f7f419b32460a7a4f7167f221c8cfd9cf5471fdf07ba8e51dc7ef
+  metadata.gz: a5ecd9601da9786418765ebc5d5c7488ba225fce0c332a70919e13809387278d633905eb211eef170c3a87c50daa5f6c6a53d019b4c200819279cb53bc1d21d7
+  data.tar.gz: bc1f7e4b702408d90ec302617ffa37514530e2542d85d92033b72e8d42ecce0834935a084a44c9fb526a2fbd0cd2c45b83cae50818f31c6207b7ce29ea4e9df5

data/.rubocop.yml

@@ -4,6 +4,9 @@ Layout/LineLength:
 Metrics/MethodLength:
   Max: 30
 
+Metrics/ClassLength:
+  Max: 300
+  
 Style/RedundantReturn:
   Enabled: false
 

data/Gemfile.lock

@@ -8,12 +8,17 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
+    docile (1.3.2)
     mini_portile2 (2.4.0)
     minitest (5.14.0)
     nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
     open4 (1.3.4)
     rake (12.3.3)
+    simplecov (0.18.5)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.2)
 
 PLATFORMS
   ruby
@@ -22,6 +27,7 @@ DEPENDENCIES
   ledgerjournal!
   minitest (~> 5.0)
   rake (~> 12.0)
+  simplecov
 
 BUNDLED WITH
    2.1.4

data/README.md

@@ -10,16 +10,16 @@ The ledger binary needs to be installed to parse and pretty-print.
 
 ## Usage
 
-Parsing a leger file: 
+Parsing a ledger journal file: 
 
 ```ruby
-journal = Ledger::Journal.new(path: "example_journal.txt")
+journal = Ledger::Journal.new(path: "example_journal.dat")
 journal.transactions.each do |tx|
   puts tx.date, tx.payee
 end
 ```
 
-Creating a ledger:
+Creating a ledger file from scratch:
 
 ```ruby
 journal = Ledger::Journal.new()
@@ -37,9 +37,30 @@ journal.transactions << Ledger::Transaction.new(
 puts(journal.to_s)
 ```
 
+Appending to a ledger journal: 
+
+```ruby
+journal = Ledger::Journal.new(path: "example_journal.dat")
+journal.transactions << Ledger::Transaction.new(
+  date: Date.new(2020, 1, 2),
+  payee: 'Example Payee',
+  postings: [
+    Ledger::Posting.new(account: "Expenses:Unknown", currency: "EUR", amount: BigDecimal('1234.56')),
+    Ledger::Posting.new(account: "Assets:Checking", currency: "EUR", amount: BigDecimal('-1234.56'))
+  ]
+)
+journal.save!
+```
+
+Running ledger commands:
+
+```ruby
+puts Ledger.defaults.run('--version')
+```
+
 ### Locale-specific settings
 
-By default ledgerjournal expectes the ledger default date format '%Y/%m/%d' and amounts with decimal point (1234.56). This is configurable:
+By default ledgerjournal expects the date format '%Y/%m/%d' and amounts with decimal point (1234.56). This is configurable:
 
 ```ruby
 Ledger.defaults = Options.new(date_format: '%d.%m.%Y', decimal_comma: true)

data/ledgerjournal.gemspec

@@ -17,10 +17,9 @@ The ledger binary needs to be installed to parse and pretty-print.'
   spec.required_ruby_version = Gem::Requirement.new('>= 2.5.0')
 
   spec.metadata = {
-    'homepage_uri' => spec.homepage,
     'source_code_uri' => 'https://github.com/ralfebert/ledgerjournal.git',
     'bug_tracker_uri' => 'https://github.com/ralfebert/ledgerjournal/issues',
-    'documentation_uri' => "https://www.rubydoc.info/gems/ledgerjournal/#{Ledger::VERSION}"
+    'documentation_uri' => 'https://www.rubydoc.info/gems/ledgerjournal/'
   }
 
   # Specify which files should be added to the gem when it is released.
@@ -32,4 +31,5 @@ The ledger binary needs to be installed to parse and pretty-print.'
 
   spec.add_dependency 'nokogiri', '~> 1.10'
   spec.add_dependency 'open4', '~> 1.3'
+  spec.add_development_dependency 'simplecov'
 end

data/lib/ledgerjournal/journal.rb

@@ -23,8 +23,7 @@ module Ledger
         @path = path
         raise Error, "#{@path} not found" unless File.exist?(@path)
 
-        args = ["-f #{@path.shellescape}", ledger_args].compact.join(' ')
-        read_ledger(ledger_args: args)
+        read_ledger(ledger_args: ["-f #{@path.shellescape}", ledger_args].compact.join(' '))
       end
     end
 
@@ -38,6 +37,8 @@ module Ledger
     # @param [Boolean] pretty_print calls ledger to format the journal if true
     def to_s(pretty_print: true)
       str = transactions.map(&:to_s).join("\n\n")
+      # add a newline at the end of the file - see https://github.com/ledger/ledger/issues/516
+      str += "\n"
       if pretty_print
         begin
           str = Ledger.defaults.run('-f - print', stdin: str)
@@ -69,7 +70,7 @@ module Ledger
     def read_ledger(ledger_args: '')
       xml_result = Ledger.defaults.run(ledger_args + ' xml')
       xml = Nokogiri::XML(xml_result)
-      @transactions = xml.css('transaction').map { |tx_xml| Transaction.parse_xml(tx_xml) }
+      @transactions = xml.xpath('ledger/transactions/transaction').map { |tx_xml| Transaction.parse_xml(tx_xml) }
     end
   end
 end

data/lib/ledgerjournal/options.rb

@@ -3,6 +3,9 @@
 module Ledger
   # Options for interaction with ledger-cli
   class Options
+    attr_reader :date_format
+    attr_reader :decimal_comma
+
     # @param [String] date_format like '%Y/%m/%d' to pass to ledger-cli
     # @param [Boolean] decimal_comma pass true to use a comma as decimal separator, otherwise a dot is used
     def initialize(date_format:, decimal_comma:)

data/lib/ledgerjournal/posting.rb

@@ -43,10 +43,11 @@ module Ledger
     end
 
     def to_s
-      posting_line = "#{account}      #{currency} #{Ledger.defaults.format(amount)}"
+      posting_line = "#{account}   "
+      posting_line += "#{currency} #{Ledger.defaults.format(amount)}".rjust(48 - posting_line.length, ' ')
       posting_line += " = #{currency} #{Ledger.defaults.format(balance_assignment)}" if balance_assignment
       lines = [posting_line]
-      lines += metadata.to_a.sort { |a, b| a[0].casecmp(b[0]) }.collect { |m| "; #{m[0]}: #{m[1]}" } unless metadata.empty?
+      lines += metadata.to_a.collect { |m| "; #{m[0]}: #{m[1]}" } unless metadata.empty?
       return lines.join("\n")
     end
 

data/lib/ledgerjournal/transaction.rb

@@ -21,7 +21,7 @@ module Ledger
 
     def self.parse_xml(xml)
       Transaction.new(
-        date: Date.strptime(xml.xpath('date').text, '%Y/%m/%d'),
+        date: Date.strptime(xml.xpath('date').text, Ledger.defaults.date_format),
         payee: xml.xpath('payee').text,
         state: xml['state'].to_sym,
         metadata: Hash[xml.xpath('metadata/value').collect { |m| [m['key'], m.xpath('string').text] }],
@@ -38,11 +38,11 @@ module Ledger
       states = { pending: '!', cleared: '*' }
       lines = ["#{date_str} #{states[state]} #{payee}"]
 
-      lines += metadata.to_a.sort { |a, b| a[0].casecmp(b[0]) }.collect { |m| "    ; #{m[0]}: #{m[1]}" } unless metadata.empty?
+      lines += metadata.to_a.collect { |m| "    ; #{m[0]}: #{m[1]}" } unless metadata.empty?
 
       lines += postings.map { |posting| posting.to_s.lines.map { |line| '    ' + line }.join }
 
-      return lines.join("\n") + "\n"
+      return lines.join("\n")
     end
 
     # @param [String, Array<String>] accounts name(s)

data/lib/ledgerjournal/version.rb

@@ -2,5 +2,5 @@
 
 module Ledger
   # ledgerjournal version
-  VERSION = '0.5.1'
+  VERSION = '0.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ledgerjournal
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Ralf Ebert
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-26 00:00:00.000000000 Z
+date: 2020-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |-
   ledgerjournal is a Ruby gem to read and write ledger accounting files.
   For parsing, it uses the xml output from ledger. For outputting, it formats the ledger data to String in custom Ruby code.
@@ -69,11 +83,10 @@ homepage: https://github.com/ralfebert/ledgerjournal
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/ralfebert/ledgerjournal
   source_code_uri: https://github.com/ralfebert/ledgerjournal.git
   bug_tracker_uri: https://github.com/ralfebert/ledgerjournal/issues
-  documentation_uri: https://www.rubydoc.info/gems/ledgerjournal/0.5.1
-post_install_message: 
+  documentation_uri: https://www.rubydoc.info/gems/ledgerjournal/
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -88,8 +101,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: Library to read and write ledger accounting files.
 test_files: []